Re: [PATCH 02/14] rtlwifi_new: Remove RT_TRACE messages that use DBG_EMERG

On 12/11/2016 04:50 AM, Joe Perches wrote: On Sat, 2016-12-10 at 23:44 -0600, Larry Finger wrote: These messages are always logged and reprresent error conditions, thus we can use pr_err(). Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@re

Re: [PATCH] staging: rtl: fix possible NULL pointer dereference

with a similar name or produce this warning. Aced-by: Larry Finger <larry.fin...@lwfinger.net> Arnd, Please let me now if gcc-7 shows any warnings for the code in drivers/net/wireless/realtek/rtlwifi/. My distro supplies gcc-4.8, and it wouod be a lot of work to implement gcc-7. Larry C

[PATCH 7/7] rtlwifi: btcoexist control to enter/leave LPS

From: Ping-Ke Shih <pks...@realtek.com> Bluetooth coexistence needs to be able to control the power-save state. This patch turns the building of btcoexist back on. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- dr

[PATCH 0/7] rtlwifi: btcoexist: Rewrite BT coexistence routines

This set of patches implement a major rewrite of the BT coexistence routines. These patches must follow [PATCH 14/14] rtlwifi: Add work queue for c2h cmd. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Ping-Ke Shih (

[PATCH 6/7] rtlwifi: Add btcoex record_pwr_mode

From: Ping-Ke Shih <pks...@realtek.com> Add code to set the power mode bits in the descriptor. These bits are valid in RTL8723BE, RTL8821AE, RTL8812AE, and RTL8192EE. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net>

[PATCH 12/14] rtlwifi: btcoexist: Add vendor definition for new btcoexist

From: Ping-Ke Shih <pks...@realtek.com> Routine halbtc_get() will need to be able to get the vendor ID. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c |

[PATCH 14/14] rtlwifi: Add work queue for c2h cmd.

From: Ping-Ke Shih <pks...@realtek.com> btcoex needs to sleep, thus it must run in thread context. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/net/wireless/realtek/rtlwifi/base.c| 92 +

[PATCH 05/14] rtlwifi: Add TX report and disable key will wait until report acked.

ey. We use TX report to ensure it is sent. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/net/wireless/realtek/rtlwifi/base.c| 117 ++--- drivers/net/wireless/realtek/rtlwifi/base.h|

[PATCH 11/14] rtlwifi: Add a new enumeration value to btc_set_type

From: Ping-Ke Shih <pks...@realtek.com> The new value is needed for future capability. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 1 + 1 file ch

[PATCH 08/14] rtlwifi: rtl8723be: btcoex: add package_type function to btcoex

From: Ping-Ke Shih <pks...@realtek.com> The new code handles the package-type of the chip. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 7 + .../wirele

[PATCH 13/14] rtlwifi: rtl8723be: fix ant_sel code

From: Ping-Ke Shih <pks...@realtek.com> When ant_sel is set, we need to fill single_ant_path to select correct antenna path. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/net/wireless/realtek/rtlwifi/

[PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

From: Ping-Ke Shih <pks...@realtek.com> Add a new debugging function. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 23 ++ drivers/net/wirele

[PATCH 09/14] rtlwifi: ibtcoex: move bt_type declaration

From: Ping-Ke Shih <pks...@realtek.com> Routine rtl_get_hwpg_bt_type() is better in halbtcoutsrc.c than in rtl_btc.c. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/net/wireless/realtek/rtlwifi/btcoexist/

[PATCH 03/14] rtlwifi: Set retry limit depends on vif type.

From: Ping-Ke Shih <pks...@realtek.com> We assign different retry limit according to vif type, because it can boost performance in field. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: shaofu <sha...@realtek.com> Signed-off-by: Larry Finger <larr

[PATCH 02/14] rtlwifi: Fix programing CAM content sequence.

From: Ping-Ke Shih <pks...@realtek.com> There is a potential race condition when the control byte of a CAM entry is written first. Write in reverse order to correct the condition. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: shaofu <sha...@realtek.com> Si

[PATCH 01/14] rtlwifi: Correct power save capability while init mac80211

Set IEEE80211_HW_SUPPORTS_PS when driver is fwlps Because mac80211 control SW-LPS only, we add constraints to avoid errors. Signed-off-by: Vincent Fann <vincent_f...@realtek.com> Signed-off-by: shaofu <sha...@realtek.com> Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Si

[PATCH 06/14] rtlwifi: rtl8723be: btcoexist: Add single_ant_path

s them for BT. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 5 + drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.h | 1 + drivers/net/wirele

[PATCH 07/14] rtlwifi: move btcoex's ant_num declaration

From: Ping-Ke Shih <pks...@realtek.com> File halbtcoutsrc.c is a better place for routine rtl_get_hwpg_ant_num() than file rtl_btc.c. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- .../net/wireless/realtek

[PATCH 00/14] rtlwifi: Various updates

to stable; however they help in the stability of the drivers, and in the robustness of authentication/ association. This material should be sent to the 4.11 stream. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Vincent Fann (1) rtlwifi: Correct power save capability while init ma

[PATCH 03/14] rtlwifi: extend debug_comp to u64

The number of debugging conditions will exceed the capabilities of a 32-bit word. Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/net/wireless/realtek/rtlwifi/debug.c | 2 +- drivers/net/wireless/realtek/rtlwifi

Re: [PATCH 1/7] rtlwifi: btcoexist: Update routines for RTL8192EE

On 12/05/2016 05:38 AM, Dan Carpenter wrote: On Sat, Dec 03, 2016 at 11:32:01AM -0600, Larry Finger wrote: From: Ping-Ke Shih <pks...@realtek.com> The btcoexist routines for the RTL8192EE have been extensively rewritten. This patch does a million things and is totally unrevi

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

On 12/05/2016 03:34 PM, Dan Carpenter wrote: On Thu, Dec 01, 2016 at 07:48:29PM -0600, Larry Finger wrote: --- wireless-drivers-next.orig/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h +++ wireless-drivers-next/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h

[PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359

irq() does not, and a test is needed to prevent kernel panics. Fixes: commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb") Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Stable <sta...@vger.kernel.org> (4.9+) Cc: Wei Yongjun <weiyongj...@huawei.

[PATCH] rtlwifi: rtl_usb: Fix missing entry in USB driver's private data

9f93f82aba ("rtlwifi: Fix enter/exit power_save"). Fixes: ba9f93f82aba ("rtlwifi: Fix enter/exit power_save") Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- Kalle, This patch needs to be included in 4.10. Larry --- drivers/net/wireless/realtek/rtlwifi/usb.c | 1 +

Re: [PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359

On 12/20/2016 05:21 AM, Kalle Valo wrote: Larry Finger <larry.fin...@lwfinger.net> writes: With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb"), the method used to free an skb was changed because the kfree_skb() was inside a spinlock. Wh

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

On 12/07/2016 07:32 AM, Dan Carpenter wrote: On Wed, Dec 07, 2016 at 02:16:06PM +0200, Kalle Valo wrote: We have disccused this before, but for wireless it's not really that simple. AFAIK with dyndbg you can only control the messages per line (painful to enable group of messages) or per file

Re: [PATCH] staging: rtl8723bs: remove null test before kfree

On 04/10/2017 08:43 AM, Aishwarya Pant wrote: kfree(..) on a NULL pointer is a no-op; the null test here is redundant. Detected by coccicheck. Signed-off-by: Aishwarya Pant <aishp...@gmail.com> Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, Larry --- drivers/stagi

Re: [PATCH 06/22] staging: rtl8723bs: Fix various errors in os_dep/ioctl_cfg80211.c

On 04/09/2017 10:28 AM, Bastien Nocera wrote: On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote: Smatch lists the following: CHECK drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:470 rtw_cfg80211_ibss_indicate_connect() error: we

[PATCH 04/22] staging: rtl8723bs: Fix indenting warning in os_dep/os_intfs.c

Smatch logs the following warning: CHECK drivers/staging/rtl8723bs/os_dep/os_intfs.c drivers/staging/rtl8723bs/os_dep/os_intfs.c:1082 ips_netdrv_open() warn: inconsistent indenting A simple change in the white space handles this warning. Signed-off-by: Larry Finger <larry.

[PATCH 05/22] staging: rtl8723bs: Fix indenting mistake in os_dep/mlme_linux.c

Smatch reports the following warning: CHECK drivers/staging/rtl8723bs/os_dep/mlme_linux.c drivers/staging/rtl8723bs/os_dep/mlme_linux.c:149 rtw_os_indicate_disconnect() warn: inconsistent indenting Again, a simple change in the white space fixes this problem. Signed-off-by: Larry Finger

[PATCH 08/22] staging: rtl8723bs: Fix indenting problems in hal/HalHWImg8723B_BB.c

ODM_ReadAndConfig_MP_8723B_PHY_REG() warn: for statement not indented drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c:586 ODM_ReadAndConfig_MP_8723B_PHY_REG() warn: inconsistent indenting These were all fixed with white-space changes. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723

[PATCH 06/22] staging: rtl8723bs: Fix various errors in os_dep/ioctl_cfg80211.c

ould be null required an immediate exit from the routine at that point. A similar fix was required where 'skb' could be null. The two buffer overflow errors were caused by off-by-one errors. While locating these problems, another one was found in os_dep/ioctl_linux.c. Signed-off-by: Larry Finge

[PATCH 07/22] staging: rtl8723bs: Fix potential usage while NULL error in hal/rtl8723b_hal_init.c

from this routine. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723

[PATCH 01/22] staging: rtl8723bs: Fix indenting warning in os_dep/xmit_linux.c

Smatch issues the warning CHECK drivers/staging/rtl8723bs/os_dep/xmit_linux.c drivers/staging/rtl8723bs/os_dep/xmit_linux.c:42 _rtw_pktfile_read() warn: inconsistent indenting A simple indent changes fixes this. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/s

[PATCH 02/22] staging: rtl8723bs: Fix indenting warning in os_dep/rtw_proc.c

Smatch lists the following warning: CHECK drivers/staging/rtl8723bs/os_dep/rtw_proc.c drivers/staging/rtl8723bs/os_dep/rtw_proc.c:102 rtw_drv_proc_open() warn: inconsistent indenting This warning is fixed with a simple change in the white space. Signed-off-by: Larry Finger <larry.

[PATCH 00/22] staging: rtl87232bs: Fix errors and warnings detected by Smatch

A number of routines have indenting, off by one, and possible usage while null warnings or errors listed by Smatch. This set of patches fix all but one of these, and it is in code that will be removed in a subsequent patch. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Larry

[PATCH 03/22] staging: rtl8723bs: Fix dereference before check warning in os_dep/recv_linux.c

. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c index c677a5

Re: [PATCH] staging: rtl8723bs: core: drop unneeded null tests

ego...@redhat.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Thank you for these patches. Larry Finger has just posted a large cleanup series for the rtl8723bs driver, which will likely conflict with these. Can you rebase and re

[PATCH 18/22] staging: rtl8723bs: Fix some white-space errors in core/rtw_security.c

:1809 aes_decipher() warn: inconsistent indenting All of the above are fixed with white-space changes. A few unneeded blank lines are deleted. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/core/rtw_security.c | 469 +-

[PATCH 17/22] staging: rtl8723bs: Fix indenting problem in core/rtw_sta_mgt.c

Sparse reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_sta_mgt.c drivers/staging/rtl8723bs/core/rtw_sta_mgt.c:25 _rtw_init_stainfo() warn: inconsistent indenting This problem is fixed with a white-spcae change. Signed-off-by: Larry Finger <larry.fin...@lwfinger.

[PATCH 11/22] staging: rtl8723bs: Fix indenting problems in core/rtw_xmit.c

/rtl8723bs/core/rtw_xmit.c:295 _rtw_free_xmit_priv() warn: inconsistent indenting drivers/staging/rtl8723bs/core/rtw_xmit.c:946 xmitframe_addmic() warn: inconsistent indenting These are fixed with white-space changes. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/s

[PATCH 12/22] staging: rtl8723bs: Fix possible usage of NULL pointer in core/rtw_debug.c

: variable dereferenced before check 'phead' (see line 454) In the code, there are two successive calls to get_head(). The second is removed. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/core/rtw_debug.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH 13/22] staging: rtl8723bs: Fix indenting mistake in core/rtw_ap.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_ap.c drivers/staging/rtl8723bs/core/rtw_ap.c:382 expire_timeout_chk() warn: inconsistent indenting Fixing this requires changing the indentatikon of a long for loop. Signed-off-by: Larry Finger <larry.

[PATCH 10/22] staging: rtl8723bs: Fix indenting problem for hal/hal_com.c

Smatch lists the following: CHECK drivers/staging/rtl8723bs/hal/hal_com_phycfg.c drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2090 Hal_ChannelPlanToRegulation() warn: inconsistent indenting Fixed by changing the white space. Signed-off-by: Larry Finger <larry.fin...@lwfinger.

[PATCH 14/22] staging: rtl8723bs: Fix indenting mistakes in core/rtw_ieee80211.c

not indented These warnings are fixed with white-space changes. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723b

[PATCH 16/22] staging: rtl8723bs: Fix some indenting problems and a potential data overrun

drivers/staging/rtl8723bs/core/rtw_wlan_util.c:815 rtw_camid_alloc() warn: should '1 << (cam_id)' be a 64 bit type? The first two are fixed with white-space changes. The third is fixed by restricting cam_id to be less than 32. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net>

[PATCH 20/22] staging rtl8723bs: Fix indenting errors and an off-by-one mistake in core/rtw_mlme_ext.c

hanges. The error at line 1595 was the result of an off-by-one error in a for loop. The error at line 4969 was not fixed as that code lies inside a block of code that only is needed for 5G channels. This chip only works at 2.4 GHz. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- dri

[PATCH 22/22] staging: rtl8723bs: Fix indenting error in core/rtw_pwrctrl.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_pwrctrl.c drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:641 LeaveAllPowerSaveModeDirect() warn: inconsistent indenting Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723b

[PATCH 15/22] staging: rtl8723bs: Fix indenting mistakes in core/rtw_mlme.c

All of there are simple white-space errors. A typo is also fixed. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 37 +++ 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723b

[PATCH 21/22] staging: rtl8723bs: Fix indenting problems in core/rtw_odm.c

-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/core/rtw_odm.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_odm.c b/drivers/staging/rtl8723bs/core/rtw_odm.c index 5bc573386ad1..3144e8ec2fa2

[PATCH 19/22] staging: rtl8723bs: Fix white-space errors in core/rtw_recv.c

/rtw_recv.c:1547 validate_recv_frame() warn: inconsistent indenting Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8723bs/core/rtw_recv.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8723b

[PATCH 09/22] staging: rtl8723bs: Fix indening problem in hal/hal_com_phycfg.c

Smatch reports the following: CHECK drivers/staging/rtl8723bs/hal/hal_com_phycfg.c drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2090 Hal_ChannelPlanToRegulation() warn: inconsistent indenting This warning is fixed with a white-space change. Signed-off-by: Larry Finger <larry.

Re: [PATCH v2 4/4] Staging: rtl8712 : ieee80211.c: fixed camelcase coding style issue

On 06/29/2017 01:43 AM, Jaya Durga wrote: The following variables and struct name are renamed to avoid camelcase issue Configuration to configuration BeaconPeriod to beacon_period DSConfig to ds_config ATIMWindowto atim_window pnic_Config to pnic_config FHConfig to fh_config

Re: [PATCH 4/7] staging: rtl8723bs: Move braces to same line as conditional

On 04/27/2017 07:09 PM, Justin Vreeland wrote: Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 15 +-- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 9 +++-- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6

Re: [PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses

On 04/27/2017 07:09 PM, Justin Vreeland wrote: Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/odm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h index

Re: [PATCH 2/7] staging: rtl8723bs: Wrap multi-line macros in do-while loop

On 04/27/2017 07:09 PM, Justin Vreeland wrote: Signed-off-by: Justin Vreeland --- The patch is OK, but most maintainers require a non-blank commit message. Larry drivers/staging/rtl8723bs/hal/odm_debug.h | 80 +-- 1 file changed, 44

Re: Thoughts on staging and on fixing up drivers?

On 08/17/2017 04:07 PM, tedheadster wrote: Larry, you've migrated a bunch of staging code, and tried various approaches. Do you have any lessons on what has worked and what hasn't and if there is anything we can do to make the process better? I am also quite interested in such work. We asked

[PATCH 8/8] staging: rtlwifi: Reviewers fixes

This commit adds the TODO file and implements some reviewers comments made against some patches to the wireless tree. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@realtek.com> Cc: Yan-Hsuan Chuang <yhchu...@realtek.com> Cc: Birming Chiu <bi

[PATCH 7/8] staging: r8822be: Add Makefiles and Kconfig for new driver

into a single module r8822be. When this driver is moved to the wireless tree, halmac, phydm, and rtl8822be will become new modules. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@realtek.com> Cc: Yan-Hsuan Chuang <yhchu...@realtek.com> Cc:

[PATCH] staging: rtl8822be: Keep array subscript no lower than zero

vel]); This condition is caused when a loop falls through. The fix is to pin max_level to be >= 0. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> c: kbuild test robot <fengguang...@intel.com> Fixes: 9ce99b04b5b82fdf11e4c76b60a5f82c1e541297 staging: r8822be: Add

[PATCH] rtlwifi: Fix typo in if ... else if ... else construct

The kbuild test robot reports two conditions with no effect (if == else). These are the result of copy and paste typographical errors. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@realtek.com> Cc: Yan-Hsuan Chuang <yhchu...@realtek.com> Cc:

Re: [PATCH] staging: r8822be: Fix typo for CONFIG_RTLWIFI_DEBUG

On 08/30/2017 02:58 AM, Andreas Ziegler wrote: Indeed, sorry I missed that as well. So what should we make of that #ifdef? The code inside it doesn't compile (anymore? I didn't find any development history for that patch except the original mail), as there is no definition of struct submit_ctx

[PATCH 0/2] staging: r8822be: Remove some left-over debug code

Some useless debugging code from the initial writing of the driver was not removed before it was submitted. That oversight is now fixed and the remaining code in routine deinit_priv() is simplified. Larry Larry Finger (2): staging: r8822be: Remove some dead code staging: r8822be: Simplify

[PATCH 1/2] staging: r8822be: Remove some dead code

The code found inside an #ifdef CONFIG_RTL_DEBUG ... #endif section is left over from debugging of the original driver, and should be deleted. Reported by: Andreas Ziegler <andreas.zieg...@fau.de> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@

[PATCH 2/2] staging: r8822be: Simplify deinit_priv()

Now that the extraneous debugging code is removed, routine deinit_priv() clearly contains code that serves no useful purpose. A null test before a call to kfree() and a spurious cast are also removed. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@re

Re: [PATCH 2/3] staging: rtlwifi: use kcalloc instead of multiply

On 09/05/2017 01:53 AM, Tobin C. Harding wrote: checkpatch emits multiple warnings of type WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply Replace two calls to kzalloc() with calls to kcalloc(). I have previously discussed this kind of change. This recommendation by

Re: [PATCH 3/3] staging: rtlwifi: remove unused functions

On 09/05/2017 01:53 AM, Tobin C. Harding wrote: Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the driver. Both functions call rtl_addr_delay(), this function is unused outside of these call sites.The driver (and kernel) code base is cleaner if unused functions are removed.

Re: [PATCH 1/2] staging: rtlwifi: silence underflow warning

On 09/29/2017 02:51 AM, Dan Carpenter wrote: I'm not totally certain that it's necessary to put an upper limit here. I think it happens at lower levels. But if we are going to do that then we should have a lower bound as well. Signed-off-by: Dan Carpenter diff --git

Re: Two rtlwifi drivers?

On 08/24/2017 07:14 AM, Kalle Valo wrote: Dan Carpenter writes: Smatch is distrustful of the "capab" value and marks it as user controlled. I think it actually comes from the firmware? Anyway, I looked at other drivers and they added a bounds check and it seems

Re: [PATCH] staging: r8822be: fix null pointer dereference with a null driver_adapter

er before the tracing call so that a non-null driver_adapter is passed instead. Detected by CoverityScan, CID#1454613 ("Explicit null dereferenced") Fixes: 938a0447f094 ("staging: r8822be: Add code for halmac sub-driver") Signed-off-by: Colin Ian King <colin.k...@canonic

Re: [PATCH 3/3] staging: rtlwifi: simplify logical operation

ch more readable. In a followup, I will fix the spelling of polarity, but yours is fine. Acked-by: Larry Finger <larry.fin...@lwfinger.net> Larry --- drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/sta

Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency

On 08/23/2017 08:22 AM, Arnd Bergmann wrote: Like the version in drivers/net/wireless, this driver requires the MAC80211 framework, otherwise we run into a link error: ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined! ERROR: "cfg80211_unlink_bss"

Re: [PATCH] staging: rtlwifi: check for array overflow

have added it here as well. Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, Larry diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c index f7f207cbaee3..a30b928d5ee1 100644 --- a/drivers/stagin

[PATCH] staging: rtlwifi: Improve debugging by using debugfs

common status. 2. remove obsolete field bt_exist Signed-off-by: Ping-Ke Shih <pks...@realtek.com> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Yan-Hsuan Chuang <yhchu...@realtek.com> Cc: Birming Chiu <birm...@realtek.com> Cc: Shaofu <sha...@realtek.co

Re: [PATCH] Staging rtlwifi efuse fix up a warning kzalloc

On 08/26/2017 08:01 AM, Yurii Pavlenko wrote: Hello, I have attached a small patch to fix a warning "Prefer kcalloc over kzalloc with multiply" for efuse.c as part of challenge 10 of Eudyptula. Best regards, Yurii Pavlenko Signed-off-by: Yurii Pavlenko Before you waste

Re: [PATCH] staging: rtl8723bs: remove null check before kfree

On 08/26/2017 03:47 PM, Himanshu Jha wrote: Kfree on NULL pointer is a no-op and therefore checking is redundant. Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com> --- Acked-by: Larry Finger <larry.fin...@lwfinger.net> For some reason not fully explained, gmail is placin

Re: [PATCH] staging: rtlwifi: Improve debugging by using debugfs

On 08/24/2017 08:54 PM, Andrew Lunn wrote: netdev frowns upon debugfs. You should try to keep this altogether, making it easy to throw away before the driver is moved out of staging. You might want to look at ethtool -d. That will be accepted. Andrew, What is the problem with debugfs?

Re: [PATCH] staging: r8822be: remove some dead code

On 08/25/2017 03:42 AM, Dan Carpenter wrote: "hdr" can't be NULL. We take skb->data which is non-NULL and add an offset to get "hdr". Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Thanks. Looks good. Acked-by: Larry Finger <l

[PATCH 2/8] staging: r8822be: Copy existing btcoexist code into staging

. There are no changes other than removing all EXPORT statements, and the fixing of checkpatch messages. The latter will be backported to the wireless tree. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Cc: Ping-Ke Shih <pks...@realtek.com> Cc: Yan-Hsuan Chuang <yhchu...@realtek.c

[PATCH 0/8] staging: Add new driver for RTL8822BE

the code into the main wireless tree in small pieces. To minimize interference between the rtlwifi drivers in the wireless tree and this new driver, the new one can only be built as a module. In addition, all code is built into a single module. Larry Finger Signed-off-by: Larry Finger <larry.

Re: [PATCH] staging: r8822be: Fix typo for CONFIG_RTLWIFI_DEBUG

On 08/29/2017 06:30 AM, Andreas Ziegler wrote: The debugging output in deinit_priv is guarded by an #ifdef using CONFIG_RTL_DEBUG. This symbol does not exist and should be CONFIG_RTLWIFI_DEBUG instead. Signed-off-by: Andreas Ziegler NACK. Yes, there is a problem;

Re: Two rtlwifi drivers?

On 10/11/2017 08:13 AM, Greg Kroah-Hartman wrote: On Wed, Oct 11, 2017 at 12:06:00PM +0300, Kalle Valo wrote: (Sorry for taking so long with the reply, I wanted first to check what the rtlwifi in staging contains.) Larry Finger <larry.fin...@lwfinger.net> writes: On 08/24/2017 07

[PATCH] staging: rtl8188eu:

is not a wireless interface and therefore it fails to work correctly with it thereafter. This problem was reported and tested at https://github.com/lwfinger/rtl8188eu/issues/234. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.

[PATCH V2] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID

is not a wireless interface and therefore it fails to work correctly with it thereafter. This problem was reported and tested at https://github.com/lwfinger/rtl8188eu/issues/234. Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> --- v2 - completed missing subject drivers/staging/rtl

Re: [PATCH] staging: rtl8822be: fix missing null check on dev_alloc_skb return

On 11/17/2017 08:50 AM, Colin King wrote: From: Colin Ian King <colin.k...@canonical.com> dev_alloc_skb can potentially return NULL, so add a null check to avoid a null pointer dereference on skb Acked-by: Larry Finger <larry.fin...@lwfinger.net> Larry Detected by Cover

Re: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue WARNING:LONG_LINE

On 12/09/2017 05:11 AM, Neil Singh wrote: Cleanup below checkpatch issue: WARNING:LONG_LINE: line over 80 characters 1000: FILE: rtl871x_security.c:1000: +static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists, Signed-off-by: Neil Singh ---

Re: Searching help for Linux support for RTL8812AU

On 10/24/2017 08:24 AM, txt.file wrote: Hey Linux wireless list, A while ago I bought an ALFA Network AWUS036AC[0] which does not yet seem to be supported in Linux mainline. I would like to get it supported. The problem is that I have not that much experience doing software development. kind

Re: [PATCH] staging: rtl8822be: fix wrong dma unmap len

] Signed-off-by: Stanislaw Gruszka <sgrus...@redhat.com> Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks Stanislaw. It is amazing how long I can stare at a piece of code without seeing the problem. Larry --- drivers/staging/rtlwifi/rtl8822be/fw.c |2 +- 1 file

Re: [PATCH] staging: rtlwifi: add identifier names to function definition arguments

On 01/28/2018 08:05 AM, Erik Liodden wrote: Add identifier names to function definition arguments to comply with the kernel coding style and the naming convention in the rest of the file. Issues found by checkpatch. Signed-off-by: Erik Liodden --- As far as I am

Re: [PATCH-next] staging: rtl8188eu: Remove unneeded cast

. Signed-off-by: Christopher Diaz Riveros <chris...@gentoo.org> Acked-by: Larry Finger <larry.fin...@lwfinger.net> --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/dri

Re: [PATCH 1/2] staging: fix possible_condition_with_no_effect warnings

On 08/05/2018 02:35 PM, Umang Parmar wrote: Remove unnecessary conditions where if and else block had same code. Signed-off-by: Umang Parmar The subject should be "staging: rtlwifi: ...". If someone wants to search for fixes to the modules in drivers/staging/rtlwifi/, your subject would not

Re: [PATCH 2/2] staging: fix unneeded_variables warnings

On 08/05/2018 02:35 PM, Umang Parmar wrote: Directly return value and remove unneeded variables. Signed-off-by: Umang Parmar This patch also has the same problem with the subject. Otherwise it is OK. Larry ___ devel mailing list

Re: [PATCH] Staging:rtl8712: Style - Removed inline block comment to fix "Statements should start on a tapstop"

On 08/08/2018 04:22 AM, Greg KH wrote: On Sun, Aug 05, 2018 at 09:41:06PM +0200, Frank Werner-Krippendorf wrote: Removed 5 inline comments "/*volatile*/" rtl87x_event.h, to fix a coding style issue "Statements should start on a tabstop" detected by checkpatch.pl script. Signed-off-by: Frank

[PATCH 2/2] staging: rtl8712u: Fix compiler warning about strncpy

When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger --- drivers/staging/rtl8712

[PATCH 1/2] staging: rtl8192e: Fix compiler warning about strncpy

When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger --- drivers/staging/rtl8192e/rtllib_softmac.c

[PATCH 0/2] staging: Fix some warnings from strncpy()

When the size argument in a call to strncpy() is the size of the destimation, gcc8 issues a warning. These patches fix the potential problem by replacing the strncpy() with strlcpy(). Signed-off-by: Larry Finger Larry Finger (2): staging: rtl8192e: Fix compiler warning about strncpy

[PATCH v2 2/2] staging: rtl8712u: Fix compiler warning about strncpy

When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger --- v2 - No changes. --- drivers/staging/rtl8712

[PATCH v2 0/2] staging: Fix some warnings from strncpy()

When the size argument in a call to strncpy() is the size of the destimation, gcc8 issues a warning. These patches fix the potential problem. Signed-off-by: Larry Finger v2 - The code is changed to implement the comments of David Laight. Larry Finger (2): staging: rtl8192e: Fix compiler

Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style

On 08/29/2018 04:14 PM, Joe Perches wrote: On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote: Rename the bit field element AdvCoding, as it causes a checkpatch issue with CamelCase naming. As the element is not actually used in code it has been renamed to 'not_used_adv_coding'. The single

Re: [BUG] staging: r8822be: RTL8822be can't find any wireless AP

On 07/05/2018 02:36 AM, Pkshih wrote: On Wed, 2018-07-04 at 10:33 -0500, Daniel Drake wrote: On Wed, Jul 4, 2018 at 10:13 AM, Larry Finger wrote: We will have to agree to disagree. I have no idea what the vendors are doing that cause some motherboards to need a different aspm value. What I

<    1   2   3   4   5   6   >