Re: [PATCH] bus: fsl-mc: explicitly define the fsl_mc_command endianness

2018-10-02 Thread Laurentiu Tudor
On 02.10.2018 15:16, Ioana Ciornei wrote: > Both the header and the command parameters of the fsl_mc_command are > 64-bit little-endian words. Use the appropriate type to explicitly > specify their endianness. > > Signed-off-by: Ioana Ciornei Reviewed-By: Laurentiu Tudor -

Re: [PATCH 1/2] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-07-09 Thread Laurentiu Tudor
Hi Roy, Couple of comments inline. On 05.07.2018 22:41, Roy Pledge wrote: > Move the NXP DPIO (Datapath I/O Driver) out of the > drivers/staging directory and into the drivers/soc/fsl directory. > > The DPIO driver enables access to Queue and Buffer Manager (QBMAN) > hardware on NXP DPAA2

Re: [PATCH v6 0/6] staging: Introduce DPAA2 Ethernet Switch driver

2018-03-16 Thread Laurentiu Tudor
Hi Dan, On 03/15/2018 12:56 PM, Dan Carpenter wrote: > On Thu, Mar 15, 2018 at 12:44:37AM +0100, Andrew Lunn wrote: >> On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote: >>> This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs >>> with DPAA2 (DataPath

Re: [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging

2018-03-02 Thread Laurentiu Tudor
bp.c > @@ -5,9 +5,9 @@ >*/ > #include > #include > -#include "../include/dpbp.h" > +#include "linux/fsl/mc.h" I think we can use <> here, same comment for patch 3/3. Other than that, the series looks ok to me so for all the patches: Reviewed-by: La

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

2017-12-20 Thread Laurentiu Tudor
On 12/20/2017 01:06 PM, Greg KH wrote: > On Wed, Dec 20, 2017 at 10:52:52AM +0000, Laurentiu Tudor wrote: >> >> >> On 12/20/2017 12:42 PM, Greg KH wrote: >>> On Wed, Dec 20, 2017 at 10:26:49AM +, Laurentiu Tudor wrote: >>>> On 12/19/2017 06:10 PM,

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

2017-12-20 Thread Laurentiu Tudor
On 12/20/2017 12:42 PM, Greg KH wrote: > On Wed, Dec 20, 2017 at 10:26:49AM +0000, Laurentiu Tudor wrote: >> On 12/19/2017 06:10 PM, Greg KH wrote: >>>>> But all of these .h files are only used by the code in this specific >>>>> directory, no where el

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

2017-12-20 Thread Laurentiu Tudor
On 12/19/2017 06:10 PM, Greg KH wrote: > On Tue, Dec 19, 2017 at 03:39:44PM +0000, Laurentiu Tudor wrote: >> On 12/19/2017 05:29 PM, Greg KH wrote: >>> On Tue, Dec 19, 2017 at 03:21:19PM +0000, Laurentiu Tudor wrote: >>>> >>>> >>>> On 12

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

2017-12-19 Thread Laurentiu Tudor
On 12/19/2017 05:29 PM, Greg KH wrote: > On Tue, Dec 19, 2017 at 03:21:19PM +0000, Laurentiu Tudor wrote: >> >> >> On 12/19/2017 04:48 PM, Greg KH wrote: >>> On Wed, Nov 29, 2017 at 12:08:44PM +0200, laurentiu.tu...@nxp.com wrote: >>>> From: Stuart Y

Re: [PATCH v4] staging: fsl-mc: move bus driver out of staging

2017-12-19 Thread Laurentiu Tudor
.txt >> >> Update or delete other remaining staging files-- Makefile, Kconfig, TODO. >> Update dpaa2_eth and dpio staging drivers. >> >> Signed-off-by: Stuart Yoder <stuyo...@gmail.com> >> Signed-off-by: Laurentiu Tudor <laurentiu.tu...@nxp.com> >>

Re: [PATCH 1/2] staging: fsl-mc: Allocate IRQ's before scanning DPRC objects

2017-12-07 Thread Laurentiu Tudor
On 12/07/2017 03:18 PM, Nipun Gupta wrote: > > >> -Original Message----- >> From: Laurentiu Tudor >> Sent: Wednesday, December 06, 2017 19:00 >> To: Nipun Gupta <nipun.gu...@nxp.com>; stuyo...@gmail.com; Bharat >> Bhushan <bharat.bhus...@

Re: [PATCH 1/2] staging: fsl-mc: Allocate IRQ's before scanning DPRC objects

2017-12-06 Thread Laurentiu Tudor
Hi Bharat, On 12/06/2017 04:03 PM, Bharat Bhushan wrote: > Hi Laurentiu, > >> -Original Message----- >> From: Laurentiu Tudor >> Sent: Wednesday, December 06, 2017 7:00 PM >> To: Nipun Gupta <nipun.gu...@nxp.com>; stuyo...@gmail.com; Bharat >

Re: [PATCH 1/2] staging: fsl-mc: Allocate IRQ's before scanning DPRC objects

2017-12-06 Thread Laurentiu Tudor
Hi Nipun, Can you polish a bit this commit message? It doesn't seem to explain why this is needed. On 12/06/2017 06:18 PM, Nipun Gupta wrote: > When DPRC probing is deferred (such as where IOMMU is not probed > before the fsl-mc bus), all the devices in the DPRC containers gets > initialized

Re: [PATCH v3] staging: fsl-mc: move bus driver out of staging

2017-11-29 Thread Laurentiu Tudor
Hi Andrew, On 11/28/2017 06:04 PM, Andrew Lunn wrote: > On Tue, Nov 28, 2017 at 05:27:57PM +0200, laurentiu.tu...@nxp.com wrote: >> diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/bus/fsl-mc/dpmcp.h >> similarity index 100% >> rename from drivers/staging/fsl-mc/bus/dpmcp.h >> rename to

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-11-28 Thread Laurentiu Tudor
On 11/28/2017 02:59 PM, Greg KH wrote: > On Mon, Nov 27, 2017 at 03:32:28PM +0000, Laurentiu Tudor wrote: >> >> >> On 11/03/2017 05:17 PM, Greg KH wrote: >>> On Thu, Aug 31, 2017 at 06:04:30PM +0200, Greg KH wrote: >>>> On Mon, Aug 28, 2017 at 01:54

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-11-27 Thread Laurentiu Tudor
README.txt, providing and overview of DPAA goes to >>> Documentation/dpaa2/overview.txt >>> >>> Update or delete other remaining staging files-- Makefile, Kconfig, TODO. >>> Update dpaa2_eth and dpio staging drivers. >>> >>> Signed-off-by: S

Re: [PATCH] staging: fsl-mc: fix uninitialized variable use

2017-11-27 Thread Laurentiu Tudor
On 11/27/2017 11:08 AM, Greg KH wrote: > On Mon, Nov 27, 2017 at 11:01:34AM +0200, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Fix this warning triggering on a powerpc build: >> warning: 'error' may be used uninitiali

Re: [staging:staging-testing 104/105] drivers/staging//fsl-mc/bus/fsl-mc-bus.c:663:9: warning: 'error' may be used uninitialized in this function

2017-11-27 Thread Laurentiu Tudor
Hi Greg, On 11/27/2017 10:28 AM, Greg Kroah-Hartman wrote: > On Fri, Nov 24, 2017 at 06:02:08PM +0100, Greg Kroah-Hartman wrote: >> On Sat, Nov 25, 2017 at 01:01:18AM +0800, kbuild test robot wrote: >>> tree: >>>

Re: [PATCH v3] staging: fsl-mc: use 32bits to support 64K size mc-portals

2017-11-22 Thread Laurentiu Tudor
com> > --- Ok, so just to clarify this fixes the case where size is equal (or maybe larger in the future) to 0x10000. Acked-By: Laurentiu Tudor <laurentiu.tu...@nxp.com> --- Best Regards, Laurentiu ___ devel mailing list de.

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-11-06 Thread Laurentiu Tudor
README.txt, providing and overview of DPAA goes to >>> Documentation/dpaa2/overview.txt >>> >>> Update or delete other remaining staging files-- Makefile, Kconfig, TODO. >>> Update dpaa2_eth and dpio staging drivers. >>> >>> Signed-off-by: S

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-11-03 Thread Laurentiu Tudor
;-README.txt, providing and overview of DPAA goes to >>> Documentation/dpaa2/overview.txt >>> >>> Update or delete other remaining staging files-- Makefile, Kconfig, TODO. >>> Update dpaa2_eth and dpio staging drivers. >>> >>> Signed

Re: [RESEND PATCH 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

2017-10-02 Thread Laurentiu Tudor
rginean >>> <alexandru.margin...@nxp.com>; Ruxandra Ioana Radulescu >>> <ruxandra.radule...@nxp.com>; Laurentiu Tudor >> <laurentiu.tu...@nxp.com>; >>> stuyo...@gmail.com >>> Subject: RE: [RESEND PATCH 2/6] staging: fsl-dpaa2/ethsw: Add >

RE: [PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-09-11 Thread Laurentiu Tudor
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, September 11, 2017 4:03 PM > > On Mon, Sep 11, 2017 at 11:55:22AM +0000, Laurentiu Tudor wrote: > > Hi, > > > > > -Original Message- > > > Fro

RE: [PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-09-11 Thread Laurentiu Tudor
mc > > -README.txt, providing and overview of DPAA goes to > >Documentation/dpaa2/overview.txt > > > > Update or delete other remaining staging files-- Makefile, Kconfig, TODO. > > Update dpaa2_eth and dpio staging drivers. > > > > Signed-off-by: Stuart Yod

Re: [PATCH] staging: fsl-mc: move bus driver out of staging

2017-08-23 Thread Laurentiu Tudor
.txt >> >> Update or delete other remaining staging files-- Makefile, Kconfig, TODO. >> Update dpaa2_eth and dpio staging drivers. >> >> Signed-off-by: Stuart Yoder <stuyo...@gmail.com> >> Signed-off-by: Laurentiu Tudor <laurentiu.tu...@nxp.com> >>

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Laurentiu Tudor
On 08/16/2017 03:06 PM, Dan Carpenter wrote: > On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The previous fix removed the equal to zero comparisons by the strcmps and >> now the function always returns true. Fix this by adding

Re: [PATCH 7/7] staging: fsl-mc: allow the driver compile multi-arch

2017-07-20 Thread Laurentiu Tudor
Hi, Sparc seems to be broken in multiple places, including generic code. Is this a known issue? Is there something I could/should do? --- Thanks & Best Regards, Laurentiu On 07/19/2017 08:31 PM, kbuild test robot wrote: > Hi Laurentiu, > > [auto build test ERROR on staging/staging-testing] >

Re: [PATCH v2 0/7] staging: fsl-mc: make the driver compile on other architectures

2017-07-18 Thread Laurentiu Tudor
Hi Arnd, On 07/18/2017 05:26 PM, Arnd Bergmann wrote: > On Tue, Jul 18, 2017 at 3:37 PM, <laurentiu.tu...@nxp.com> wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Apart from a small change (first patch) which adds a missing comment, >>

Re: [PATCH v2 8/8] staging: fsl-mc: allow the driver compile multi-arch

2017-07-18 Thread Laurentiu Tudor
Hi Arnd, On 07/18/2017 05:25 PM, Arnd Bergmann wrote: > On Tue, Jul 18, 2017 at 3:37 PM, wrote: > >> --- a/drivers/staging/fsl-dpaa2/Kconfig >> +++ b/drivers/staging/fsl-dpaa2/Kconfig >> @@ -4,7 +4,7 @@ >> >> config FSL_DPAA2 >> bool "Freescale DPAA2 devices"

Re: [PATCH v2 6/8] staging: fsl-mc: don't use raw device io functions

2017-07-18 Thread Laurentiu Tudor
Hi Arnd, On 07/18/2017 05:18 PM, Arnd Bergmann wrote: > On Tue, Jul 18, 2017 at 3:37 PM, <laurentiu.tu...@nxp.com> wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> As raw device io functions are not portable and don't handle byte-order >>

Re: [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

2017-07-18 Thread Laurentiu Tudor
On 07/17/2017 06:00 PM, Arnd Bergmann wrote: > On Mon, Jul 17, 2017 at 4:27 PM, Laurentiu Tudor > <laurentiu.tu...@nxp.com> wrote: >> Hi Arnd, >> >> On 07/17/2017 04:45 PM, Arnd Bergmann wrote: >>> On Mon, Jul 17, 2017 at 3:26 PM, <laurentiu.tu...@

Re: [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

2017-07-17 Thread Laurentiu Tudor
Hi Robin, On 07/17/2017 04:43 PM, Robin Murphy wrote: > On 17/07/17 14:26, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Split the 64-bit accesses in 32-bit accesses because there's no real >> constrain in MC to do onl

Re: [PATCH 6/7] staging: fsl-mc: rewrite mc command send/receive to work on 32-bits

2017-07-17 Thread Laurentiu Tudor
Hi Arnd, On 07/17/2017 04:45 PM, Arnd Bergmann wrote: > On Mon, Jul 17, 2017 at 3:26 PM, <laurentiu.tu...@nxp.com> wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Split the 64-bit accesses in 32-bit accesses because there's no real >> c

Re: [PATCH 2/7] staging: fsl-mc: use generic memory barriers

2017-07-17 Thread Laurentiu Tudor
On 07/17/2017 04:38 PM, Robin Murphy wrote: > On 17/07/17 14:26, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> No need to use arch-specific memory barriers; switch to using generic >> ones. The rmb()s were usele

RE: [staging:staging-testing 357/367] make[5]: *** No rule to make target 'drivers/staging/fsl-mc/bus/dpmng.o', needed by 'drivers/staging/fsl-mc/bus/mc-bus-driver.o'.

2017-06-26 Thread Laurentiu Tudor
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Monday, June 26, 2017 2:55 PM > To: Laurentiu Tudor <laurentiu.tu...@nxp.com> > > On Mon, Jun 26, 2017 at 01:48:01PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Ju

RE: [staging:staging-testing 357/367] make[5]: *** No rule to make target 'drivers/staging/fsl-mc/bus/dpmng.o', needed by 'drivers/staging/fsl-mc/bus/mc-bus-driver.o'.

2017-06-26 Thread Laurentiu Tudor
Hi Greg, > -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Monday, June 26, 2017 11:50 AM > To: Laurentiu Tudor <laurentiu.tu...@nxp.com> > > On Mon, Jun 26, 2017 at 08:39:20AM +, Laurentiu Tudor wrote: > > Hi

RE: [staging:staging-testing 357/367] make[5]: *** No rule to make target 'drivers/staging/fsl-mc/bus/dpmng.o', needed by 'drivers/staging/fsl-mc/bus/mc-bus-driver.o'.

2017-06-26 Thread Laurentiu Tudor
Hi Greg, > -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > > On Sat, Jun 24, 2017 at 08:17:59PM +0800, kbuild test robot wrote: > > tree: > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ker >

Re: [PATCH 01/14] staging: fsl-mc: drop macros with possible side effects

2017-06-23 Thread Laurentiu Tudor
Hi Joe, On 06/22/2017 07:07 PM, Joe Perches wrote: > On Thu, 2017-06-22 at 16:35 +0300, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Several macros were triggering this checkpatch.pl warning: >>"Macro argumen

Re: [PATCH v7 10/10] staging: fsl-mc: move bus driver out of staging

2017-06-14 Thread Laurentiu Tudor
Hi Greg, On 06/13/2017 01:22 PM, Greg KH wrote: > On Thu, Jun 08, 2017 at 05:28:55PM +0300, laurentiu.tu...@nxp.com wrote: >> From: Stuart Yoder >> >> Move the source files out of staging into their final locations: >>-include files in drivers/staging/fsl-mc/include go

Re: [PATCH v7 02/10] staging: fsl-mc: fix macros with possible side effects

2017-06-14 Thread Laurentiu Tudor
On 06/13/2017 01:12 PM, Greg KH wrote: > On Thu, Jun 08, 2017 at 05:28:47PM +0300, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Several macros were triggering this checkpatch.pl warning: >>"Macro argumen

RE: [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging

2017-06-06 Thread Laurentiu Tudor
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, June 06, 2017 5:20 PM > To: Laurentiu Tudor <laurentiu.tu...@nxp.com> > > On Tue, Jun 06, 2017 at 02:03:44PM +, Laurentiu Tudor wrote: > > Hi Greg, &

RE: [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging

2017-06-06 Thread Laurentiu Tudor
Hi Greg, > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, June 03, 2017 11:40 AM > > On Wed, May 31, 2017 at 01:58:52PM +0300, laurentiu.tu...@nxp.com wrote: > > From: Stuart Yoder > > Your subject says 'v4' yet the other

RE: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

2017-06-06 Thread Laurentiu Tudor
Hi Greg, > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, June 03, 2017 11:41 AM > > On Wed, May 31, 2017 at 01:58:43PM +0300, laurentiu.tu...@nxp.com wrote: > > From: Laurentiu Tudor <laurentiu.tu...@nxp.com> > &

Re: [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging

2017-05-31 Thread Laurentiu Tudor
t; >> Update or delete other remaining staging files-- Makefile, Kconfig, TODO. >> Update dpaa2_eth and dpio staging drivers. >> >> Signed-off-by: Stuart Yoder <stuyo...@gmail.com> >> Signed-off-by: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> [Laurentiu: re

Re: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix address translations

2017-05-29 Thread Laurentiu Tudor
On 05/25/2017 03:31 PM, Ruxandra Ioana Radulescu wrote: >> -Original Message- >> From: Laurentiu Tudor >> Sent: Wednesday, May 24, 2017 3:34 PM >> To: Ruxandra Ioana Radulescu <ruxandra.radule...@nxp.com>; >> gre...@linuxfoundation.org >>

Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings

2017-05-26 Thread Laurentiu Tudor
Hi Greg, On 05/25/2017 07:58 PM, Greg KH wrote: > On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> > > Your subject line is very odd, please use the 'v2' marking properly... > >> >&g

Re: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix address translations

2017-05-24 Thread Laurentiu Tudor
Hi Ioana, Debatable nit inline. On 05/24/2017 03:13 PM, Ioana Radulescu wrote: > Use the correct mechanisms for translating a DMA-mapped IOVA > address into a virtual one. Without this fix, once SMMU is > enabled on Layerscape platforms, the Ethernet driver throws > IOMMU translation faults. > >

RE: [PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging

2017-05-22 Thread Laurentiu Tudor
> -Original Message- > From: Marc Zyngier [mailto:marc.zyng...@arm.com] > Sent: Monday, May 22, 2017 12:06 PM > To: Laurentiu Tudor <laurentiu.tu...@nxp.com> > > On 22/05/17 09:42, Laurentiu Tudor wrote: > > Hi Marc, > > > >> -

RE: [PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging

2017-05-22 Thread Laurentiu Tudor
Hi Marc, > -Original Message- > From: Marc Zyngier [mailto:marc.zyng...@arm.com] > Sent: Monday, May 22, 2017 10:41 AM > > On Mon, May 22 2017 at 7:12:39 am GMT, Laurentiu Tudor > <laurentiu.tu...@nxp.com> wrote: > > Hi Laurentiu, > > >

RE: [PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging

2017-05-22 Thread Laurentiu Tudor
Hi Marc, > -Original Message- > From: Marc Zyngier [mailto:marc.zyng...@arm.com] > Sent: Saturday, May 20, 2017 9:43 AM > To: Matthias Brugger <matthias@gmail.com> > Cc: Laurentiu Tudor <laurentiu.tu...@nxp.com>; gre...@linuxfoundation.or

Re: [PATCH] powerpc: booke: fix boot crash due to null hugepd

2017-05-17 Thread Laurentiu Tudor
Hi Greg, On 05/17/2017 12:15 PM, Greg KH wrote: > On Tue, May 16, 2017 at 09:47:52AM -0500, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> On 32-bit book-e machines, hugepd_ok() does not take >> into account null hugepd v

Re: [PATCH] staging: fsl-mc: fix warning in DT ranges parser

2017-02-28 Thread Laurentiu Tudor
unction return code > rather than passing it by reference. With this change, gcc can see that > we don't evaluate the cell numbers for an missing ranges property. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Looks good to me, i've tested it and did not see any issues, so here's

Re: [PATCH] staging: fsl-mc: Add missing header

2017-02-15 Thread Laurentiu Tudor
ex 0e2c1b5..87e4471 100644 > --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > @@ -17,6 +17,7 @@ > #include > #include > #include "../include/mc-bus.h" > +#include "fsl-mc-private.

Re: [PATCH 3/9] staging: fsl-mc: add device release callback

2017-02-03 Thread Laurentiu Tudor
> <catalin.horghi...@nxp.com>; Leo Li <leoyang...@nxp.com>; Stuart Yoder >> <stuart.yo...@nxp.com>; >> Laurentiu Tudor <laurentiu.tu...@nxp.com> >> Subject: [upstream-release] [PATCH 3/9] staging: fsl-mc: add device release >> callback >> &

Re: [PATCH 4/9] staging: fsl-mc: don't use devres api for refcounted objects

2017-02-03 Thread Laurentiu Tudor
talin >> Horghidan >> <catalin.horghi...@nxp.com>; Leo Li <leoyang...@nxp.com>; Roy Pledge >> <roy.ple...@nxp.com>; Laurentiu >> Tudor <laurentiu.tu...@nxp.com> >> Subject: [PATCH 4/9] staging: fsl-mc: don't use devres api for refcounted >> o

Re: [PATCH 2/9] staging: fsl-mc: fix device ref counting

2017-02-03 Thread Laurentiu Tudor
Hi Greg, Thanks for having a look. Comment below. On 02/03/2017 11:56 AM, Greg KH wrote: > On Wed, Feb 01, 2017 at 05:43:22AM -0600, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor <laurentiu.tu...@nxp.com> >> >> Drop unneeded get_device() call at dev

Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-12-06 Thread Laurentiu Tudor
On 12/05/2016 10:52 PM, Dan Carpenter wrote: > On Fri, Dec 02, 2016 at 12:12:14PM +0000, Laurentiu Tudor wrote: >>> +static inline bool dpaa2_sg_is_final(const struct dpaa2_sg_entry *sg) >>> +{ >>> + return !!(le16_to_cpu(sg->format_offset) >> SG_F

Re: [PATCH v3 3/9] bus: fsl-mc: dpio: add APIs for DPIO objects

2016-12-02 Thread Laurentiu Tudor
Couple of nits inline. --- Best Regards, Laurentiu On 12/02/2016 12:41 AM, Stuart Yoder wrote: > From: Ioana Radulescu > > Add the command build/parse APIs for operating on DPIO objects through > the DPAA2 Management Complex. > > Signed-off-by: Ioana Radulescu

Re: [PATCH v3 7/9] bus: fsl-mc: dpio: add the DPAA2 DPIO service interface

2016-12-02 Thread Laurentiu Tudor
On 12/02/2016 12:41 AM, Stuart Yoder wrote: > From: Roy Pledge > > The DPIO service interface handles initialization of DPIO objects > and exports APIs to be used by other DPAA2 object drivers to perform > queuing and buffer management related operations. The service allows

Re: [PATCH v3 6/9] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2

2016-12-02 Thread Laurentiu Tudor
On 12/02/2016 12:41 AM, Stuart Yoder wrote: > From: Roy Pledge > > Add QBman APIs for frame queue and buffer pool operations. > > Signed-off-by: Roy Pledge > Signed-off-by: Haiying Wang > Signed-off-by: Stuart Yoder

Re: [PATCH v3 5/9] bus: fsl-mc: dpio: add global dpaa2 definitions

2016-12-02 Thread Laurentiu Tudor
On 12/02/2016 12:41 AM, Stuart Yoder wrote: > From: Roy Pledge > > Create header for global dpaa2 definitions. Add definitions > for dequeue results. > > Signed-off-by: Roy Pledge > Signed-off-by: Stuart Yoder > --- >

Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-12-02 Thread Laurentiu Tudor
Some more bits and pieces inside. --- Best Regards, Laurentiu On 12/02/2016 12:41 AM, Stuart Yoder wrote: > From: Roy Pledge > > Add global definitions for DPAA2 frame descriptors and scatter > gather entries. > > Signed-off-by: Roy Pledge >