Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

2014-11-26 Thread Loïc Pefferkorn
On Wed, Nov 26, 2014 at 12:54:43PM -0800, Greg KH wrote: Ugh, how horrid, please just delete these functions and push down the spin_lock/unlock calls down into the places these are called. Same for these. Same thing here. Hello Greg, Thanks for your comments, I will write a v2. --

Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

2014-12-07 Thread Loïc Pefferkorn
On Tue, Dec 02, 2014 at 02:11:33PM -0700, Andreas Dilger wrote: On Nov 28, 2014, at 11:50 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Nov 27, 2014 at 07:34:10PM +0100, Loïc Pefferkorn wrote: Hello Greg, After some investigation, I think that removing these wrappers

Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

2014-12-13 Thread Loïc Pefferkorn
Don't hide implementation of locks in functions like this, it only causes problems. This code has layers of layers of layers of abstractions due to it wanting to be originally ported to other operating systems and lots of different kernel versions of Linux itself. Unwinding and removing

Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

2015-01-21 Thread Loïc Pefferkorn
On Sat, Jan 17, 2015 at 03:29:01PM -0800, Greg KH wrote: On Sat, Dec 13, 2014 at 03:58:46PM +0100, Loïc Pefferkorn wrote: Don't hide implementation of locks in functions like this, it only causes problems. This code has layers of layers of layers of abstractions due to it wanting