[PATCH v2] Staging iio: adc: Match parenthesis alignment

2018-10-17 Thread Marcelo Schmitt
Change close parenthesis alignment to match respective open parenthesis at iio/drivers/staging/iio/adc/ad7606.c line 379. This makes the file more compliant with the preferred coding style for the linux kernel. Signed-of-by: Marcelo Schmitt --- drivers/staging/iio/adc/ad7606.c | 2 +- 1 file

[PATCH] Staging iio/adc: fixes parenthesis alignment

2018-10-16 Thread Marcelo Schmitt
Fixes close parenthesis alignment to match open parenthesis at iio/drivers/staging/iio/adc/ad7606.c line 379. Signed-of-by: Marcelo Schmitt --- drivers/staging/iio/adc/ad7606.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/adc/ad7606.c b/drivers/staging

[PATCH] staging: iio: ad5933: add binding doc for ad5933

2018-12-02 Thread Marcelo Schmitt
Add a devicetree documentation for the ad5933 and ad5934 impedance converter, network analyzer. Co-Developed-by: Gabriel Capella Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella --- .../iio/impedance-analyzer/ad5933.txt | 23 +++ 1 file changed, 23

Re: [PATCH] staging: iio: ad5933: replaced kfifo by triggered_buffer

2018-12-02 Thread Marcelo Schmitt
On 11/25, Jonathan Cameron wrote: > On Thu, 22 Nov 2018 10:53:47 -0200 > Marcelo Schmitt wrote: > > > Previously, there was an implicit creation of a kfifo which was replaced > > by a call to triggered_buffer_setup, which is already implemented in iio > > infrastr

[PATCH 1/3] staging: iio: ad5933: change regulator binging for vref

2018-12-08 Thread Marcelo Schmitt
Set a single voltage regulator for all voltage references. Remove voltage reference value from default platafrom data struct. Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella Co-Developed-by: Gabriel Capella --- drivers/staging/iio/impedance-analyzer/ad5933.c | 14

[PATCH 2/3] staging: iio: ad5933: use clock framework for clock reference

2018-12-08 Thread Marcelo Schmitt
Add the option to specify the external clock (MCLK) using the clock framework. Also remove the old platform data structure. Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella Co-Developed-by: Gabriel Capella --- .../staging/iio/impedance-analyzer/ad5933.c | 43

[PATCH 0/3] Add devicetree support for ad5933

2018-12-08 Thread Marcelo Schmitt
This series of patches change voltage regulator error handling for the ad5933. It also add an option to specify external clock reference using a clock framework and remove the old platform data structure. Finally it adds binding documentation for devicetree. Marcelo Schmitt (3): staging: iio

[PATCH 3/3] staging: iio: ad5933: add binding doc for ad5933

2018-12-08 Thread Marcelo Schmitt
Add a devicetree documentation for the ad5933 and ad5934 impedance converter, network analyzer. Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella Co-Developed-by: Gabriel Capella --- .../iio/impedance-analyzer/ad5933.txt | 26 +++ 1 file changed, 26

Re: [PATCH 0/3] Add devicetree support for ad5933

2018-12-08 Thread Marcelo Schmitt
the pieces of advice needed for this work. Thanks, Marcelo Em sáb, 8 de dez de 2018 às 16:18, Marcelo Schmitt escreveu: > > This series of patches change voltage regulator error handling for the > ad5933. > It also add an option to specify external clock reference using a clock

[PATCH] staging: iio: ad5933: finalized device-tree support

2018-11-23 Thread Marcelo Schmitt
Added a of_device_id struct variable and subsequent call to MODULE_DEVICE_TABLE macro to complete device-tree support for this driver. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/ad5933.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging

[PATCH v2] staging: iio: ad5933: add device tree support

2018-11-24 Thread Marcelo Schmitt
Add a of_device_id struct variable and subsequent call to MODULE_DEVICE_TABLE macro to complete device tree support. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/ad5933.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/iio/impedance

[PATCH] staging: iio: ad5933: replaced kfifo by triggered_buffer

2018-11-22 Thread Marcelo Schmitt
Previously, there was an implicit creation of a kfifo which was replaced by a call to triggered_buffer_setup, which is already implemented in iio infrastructure. Signed-off-by: Marcelo Schmitt --- .../staging/iio/impedance-analyzer/Kconfig| 2 +- .../staging/iio/impedance-analyzer/ad5933.c

Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier

2019-04-02 Thread Marcelo Schmitt
On 04/01, Greg KH wrote: > On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote: > > > > On 4/1/2019 8:07 PM, Marcelo Schmitt wrote: > > > Add SPDX identifier of GPL-2.0 for the ad9832 driver. > > > > > > Signed-off-by: Marcelo Schmitt >

Re: Work on iio: stating: frequency: ad9832

2019-04-02 Thread Marcelo Schmitt
On 04/02, Alexandru Ardelean wrote: > On Mon, Apr 1, 2019 at 7:13 PM Jonathan Cameron > wrote: > > > > On Mon, 1 Apr 2019 11:25:29 -0300 > > Marcelo Schmitt wrote: > > > > > Hello, > > > > > > I was looking for some work on staging: i

Re: [PATCH 4/4] staging: iio: ad9832: add devicetree documentation

2019-04-02 Thread Marcelo Schmitt
On 04/02, Alexandru Ardelean wrote: > On Mon, Apr 1, 2019 at 5:38 PM Marcelo Schmitt > wrote: > > > > Add a devicetree documentation for the ad9832 direct digital > > synthesizer, waveform generator. > > > > Signed-off-by: Marcelo Schmitt > > ---

[PATCH 0/4] staging: iio: ad9832: use clock framework

2019-04-01 Thread Marcelo Schmitt
This series of patches do minor codestyle ajusts, set SPDX licence identifier, set use of linux's clock framework to handle external clock, and add a devicetree documentation. Marcelo Schmitt (4): staging: iio: ad9832: organize includes staging: iio: ad9832: add SPDX identifier staging: iio

[PATCH 1/4] staging: iio: ad9832: organize includes

2019-04-01 Thread Marcelo Schmitt
Organize includes to list them in lexicographic order. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/frequency/ad9832.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c

[PATCH 2/4] staging: iio: ad9832: add SPDX identifier

2019-04-01 Thread Marcelo Schmitt
Add SPDX identifier of GPL-2.0 for the ad9832 driver. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/frequency/ad9832.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c index

[PATCH 4/4] staging: iio: ad9832: add devicetree documentation

2019-04-01 Thread Marcelo Schmitt
Add a devicetree documentation for the ad9832 direct digital synthesizer, waveform generator. Signed-off-by: Marcelo Schmitt --- .../bindings/iio/frequency/ad9832.txt | 26 +++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio

[PATCH 3/4] staging: iio: ad9832: use clock framework for clock reference

2019-04-01 Thread Marcelo Schmitt
Previously external clock were set through platform_data struct. Now device uses clk struct defined in include/linux/clk.h to handle external clock source. It also removes mclk from platform_data struct. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/frequency/ad9832.c | 37

Work on iio: stating: frequency: ad9832

2019-04-01 Thread Marcelo Schmitt
Hello, I was looking for some work on staging: iio: ad9832 and made some observations while reading the driver. Apparently it had no devicetree documentation so I tried to elaborate one. It uses a platform_data variable to load external clock frequency (I tried to make it use linux's clock

Help on testing ad5933 driver

2019-03-21 Thread Marcelo Schmitt
Hello, would anyone mind helping me test ad5933 driver on actual hardware? I went through this (https://oslongjourney.github.io/linux-kernel/experiment-one-iio-dummy/) tutorial so I was able to load iio_simple_dummy driver, create and inspect some dummy devices. Now, as Jonathan has asked me, I

[PATCH v5 2/2] staging: iio: ad5933: move out of staging

2019-03-21 Thread Marcelo Schmitt
. Signed-off-by: Marcelo Schmitt --- drivers/iio/Kconfig | 1 + drivers/iio/Makefile | 1 + drivers/iio/impedance-analyzer/Kconfig| 18 + drivers/iio/impedance-analyzer/Makefile | 5 + drivers/iio/impedance-analyzer/ad5933.c

[PATCH v5 1/2] staging: iio: ad5933: change attributes to match ABI

2019-03-21 Thread Marcelo Schmitt
Change device attributes' names to match ABI documentation. Names were chosen such that they tend to be similar to existing ABI so it should be easier to standardize them when necessary. Signed-off-by: Marcelo Schmitt --- .../staging/iio/impedance-analyzer/ad5933.c | 24 +-- 1

[PATCH v5 0/2] staging: iio: ad5933: move out of staging

2019-03-21 Thread Marcelo Schmitt
. Marcelo Schmitt (2): staging: iio: ad5933: change attributes to match ABI staging: iio: ad5933: move out of staging drivers/iio/Kconfig | 1 + drivers/iio/Makefile | 1 + drivers/iio/impedance-analyzer/Kconfig| 18 + drivers/iio

Re: [PATCH] staging: iio: adis16240: add of_match_table entry

2019-05-24 Thread Marcelo Schmitt
Hi Alexandru, On 05/24, Alexandru Ardelean wrote: > On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro wrote: > > > > This patch adds of_match_table entry in device driver in order to > > enable spi fallback probing. > > > > Signed-off-by: Rodrigo Ribeiro

Re: [PATCH v2] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-09-22 Thread Marcelo Schmitt
Hi, Could anyone with some experience in devicetree give us a hint on what to do here? I have built a binding doc using the same spi-cpha property. https://github.com/analogdevicesinc/linux/commit/bb2945e489dfdf2faa0255dd2cf09ae4ee77d826 On 09/13, Ardelean, Alexandru wrote: > On Thu, 2019-09-12

Re: [PATCH] staging: iio: cdc: ad7746: Fix unnecessary check and assignment in ad7746_probe()

2021-05-17 Thread Marcelo Schmitt
Hi Tang, The patch looks overall good, though I think it could be split into two pieces: one for simplifying ret declaration and another for removing the check after device register. Despite that, I guess Lucas might already be working on similar changes.