Folowing patches are cleaning some warnings and checkups from checkpatch.pl
Matej Dujava (9):
staging: sm750fb: fix length of lines
staging: sm750fb: unifying macro definitions
staging: sm750fb: reordering of macro definitions
staging: sm750fb: removing unnecessary binary operations
This patch removes typedefs from enum and renames it from "typedef enum
_sii164_hot_plug_mode_t" to "enum sii164_hot_plug_mode" as per kernel
coding standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_sii164.c | 2 +
This patch reorder definition of macros so all macros are in same order.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_display.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_display.h
b/drivers/s
This patch breaks lines that are longer than 80 characters and joins
together those, that are too short and can be placed at one.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_chip.c | 7 +++--
drivers/staging/sm750fb/ddk750_dvi.c
This patch adds tabs into macro definitions so all rhs are on same column.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_display.h | 74
drivers/staging/sm750fb/ddk750_hwi2c.c | 4 +-
drivers/staging/sm750fb/s
This patch removes typedefs from enum and renames it from "typedef enum
_disp_output_t" to "enum disp_output" as per kernel coding standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_display.c | 2 +-
drivers/staging/sm
This patch remove unnecessary operation (eg. ``X | (0x0 << Y)`` to ``X``).
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_display.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/dri
This patch removes typedefs from enum and renames it from
"typedef enum _DPMS_t" to "enum DPMS" as per kernel coding standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_power.c | 2 +-
drivers/staging/sm750fb/ddk750_po
This patch removes typedefs from enum and renames it from "typedef enum
_logical_chip_type_t" to "enum logical_chip_type" as per kernel coding
standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
drivers/sta
This patch removes typedefs from enum and renames it from "typedef enum
_clock_type_t" to "enum clock_type" as per kernel coding standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_chip.h | 8
drivers/staging
This patch removes typedefs from enum and renames it from
"typedef enum _DPMS_t" to "enum DPMS" as per kernel coding standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_power.c | 2 +-
drivers/staging/sm750fb/ddk750_po
This patch removes typedefs from enum and renames it from "typedef enum
_logical_chip_type_t" to "enum logical_chip_type" as per kernel coding
standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_chip.c | 2 +-
drivers/staging
This patch removes typedefs from enum and renames it from "typedef enum
_sii164_hot_plug_mode_t" to "enum sii164_hot_plug_mode" as per kernel
coding standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_sii164.c | 2 +
: unifying macro definitions
staging: sm750fb: reordering of macro definitions
staging: sm750fb: removing unnecessary binary operations
* delete duplicit macro for MHZ
[1] https://lkml.org/lkml/2017/5/15/284
Matej Dujava (7):
staging: sm750fb: fix length of lines, function
This patch adds tabs into macro definitions so all rhs are on same column.
Removing MHz macro from ddk_chip.c file and reuse MHZ from sm750.h.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_chip.c| 18
drivers/staging/sm750fb/ddk750_dis
This patch removes typedefs from enum and renames it from "typedef enum
_disp_output_t" to "enum disp_output" as per kernel coding standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_display.c | 2 +-
drivers/staging/sm
This patch breaks lines that are longer than 80 characters and joins
together those, that are too short and can be placed at one.
Function calls and declarations are updated to fit kernel code style.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_
This patch removes typedefs from enum and renames it from "typedef enum
_disp_output_t" to "enum disp_output" as per kernel coding standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_display.c | 2 +-
drivers/staging/sm
This patch removes typedefs from enum and renames it from "typedef enum
_logical_chip_type_t" to "enum logical_chip_type" as per kernel coding
standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
drivers/sta
This patch adds tabs into macro definitions so all rhs are on same column.
Move MHz macro from ddk_chip.c to ddk_chip.h.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_chip.c| 18
drivers/staging/sm750fb/ddk750_chip.h| 5 +-
d
This patch removes typedefs from enum and renames it from "typedef enum
_clock_type_t" to "enum clock_type" as per kernel coding standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_chip.h | 8
drivers/staging
This patch breaks lines that are longer than 80 characters and joins
together those, that are too short and can be placed at one.
Function calls and declarations are updated to fit kernel code style.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_
/15/875
Matej Dujava (7):
staging: sm750fb: fix length of lines, function calls and declaration
staging: sm750fb: unifying macro usage and definitions
staging: sm750fb: Remove typedef from "typedef enum
_logical_chip_type_t"
staging: sm750fb: Remove typedef from &qu
This patch removes typedefs from enum and renames it from "typedef enum
_sii164_hot_plug_mode_t" to "enum sii164_hot_plug_mode" as per kernel
coding standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_sii164.c | 2 +
This patch removes typedefs from enum and renames it from
"typedef enum _DPMS_t" to "enum DPMS" as per kernel coding standards.
Signed-off-by: Matej Dujava <mduj...@kocurkovo.cz>
---
drivers/staging/sm750fb/ddk750_power.c | 2 +-
drivers/staging/sm750fb/ddk750_po
On Thu, May 18, 2017 at 03:56:26PM +0200, Greg KH wrote:
> On Tue, May 16, 2017 at 11:20:18AM +0200, Matej Dujava wrote:
> > This patch adds tabs into macro definitions so all rhs are on same column.
> > Move MHz macro from ddk_chip.c to ddk_chip.h.
> >
> > Signed
This patch will update error message, so it is same as error message in
another function.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index
Switch statement does not contain all cases: 8, 16, 24, 32.
This patch will add missing one (24)
Fixes: 81dee67e215b ("staging: sm750fb: add sm750 to staging")
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/sm750.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drive
This patch will unify code for updating color offsets and frame buffer
visual mode.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/sm750.c | 149 ++--
1 file changed, 67 insertions(+), 82 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers
This patch set will unify reused switch statement updating fb_info by
creating inline functions.
Tested only by compilation.
Matej Dujava (3):
staging: sm750fb: add missing case while setting FB_VISUAL
staging: sm750fb: add common function to set color offsets and visual
mode
staging
This patch set will fix checkpatch LONG_LINE warnings and will save us
one call of bb_get_frame_time in case od !bNeedAck.
Change history:
v2: Implemented advice of ternary operator from Joe Perches
Matej Dujava (2):
staging: vt6655: return early if not bNeedAck
staging: vt6655: fix
This patch will check for bNeedAck before making bb_get_frame_time call, so
in case we dont need uAckTime, we can return early.
Signed-off-by: Matej Dujava
---
drivers/staging/vt6655/rxtx.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655
This patch will fix LONG_LINE error from checkpatch, by using ternary
operator.
Signed-off-by: Matej Dujava
---
drivers/staging/vt6655/rxtx.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index
in vt6656/Makefile.
Signed-off-by: Matej Dujava
---
v1: Initial patch
v2: This patch was split from original bigger patch
v3: Added more info about what and why it's removed
drivers/staging/vt6655/Makefile | 24
drivers/staging/vt6656/Makefile | 4 ++--
2 files changed
vt665x/Makefile and vt6655/device_main.c.
Signed-off-by: Matej Dujava
---
v1: Initial patch
v2: This patch was split from original bigger patch
v3: Added more info about what and why it's removed
drivers/staging/vt6655/Makefile | 3 ---
drivers/staging/vt6655/device_main.c | 1 -
drivers
in vt6656/Makefile.
---
v1: Initial patch
v2: This patch was split from original bigger patch
v3: Added more info about what and why it's removed
Matej Dujava (2):
staging: vt6656: vt6655: removing unused macros definition Makefiles
staging: vt6655: vt6656: change order of makefile variable
This patch will add indentation to multiline variable and put obj-$(CONFIG_X)
at the begining of the file.
Signed-off-by: Matej Dujava
---
drivers/staging/vt6655/Makefile | 24
drivers/staging/vt6656/Makefile | 4 ++--
2 files changed, 14 insertions(+), 14 deletions
This patchset will remove unused definitions of C Macros, reorder variable
definition and increase indentation to match visual block.
---
v2: spliting original patch to 2 separate patches
Matej Dujava (2):
staging: vt6656: vt6655: clean Makefiles
staging: vt6655: vt6656: change order
This patch is removing CFLAGS that are defining flags that are not used.
Signed-off-by: Matej Dujava
---
drivers/staging/vt6655/Makefile | 3 ---
drivers/staging/vt6655/device_main.c | 1 -
drivers/staging/vt6656/Makefile | 3 ---
3 files changed, 7 deletions(-)
diff --git a/drivers
On Fri, May 15, 2020 at 03:48:59PM +0200, Greg Kroah-Hartman wrote:
I still fail to understand the need for this patch at all. It doesn't
clean anything up, nor change anything. There is no rule that this has
to be in one order or the other, and in fact, I like the order that the
files
On Sat, May 09, 2020 at 07:07:14PM +0200, Greg Kroah-Hartman wrote:
On Sat, May 09, 2020 at 11:07:27AM +0200, Matej Dujava wrote:
This patch is removing CFLAGS that are defining flags that are not used.
You are also modifying the indentation and moving lines around for no
reason :(
Please
This patch is removing CFLAGS that are defining flags that are not used.
Signed-off-by: Matej Dujava
---
drivers/staging/vt6655/Makefile | 27 ---
drivers/staging/vt6655/device_main.c | 1 -
drivers/staging/vt6656/Makefile | 7 ++-
3 files changed, 14
This patch will check for bNeedAck before making bb_get_frame_time call, so
in case we dont need uAckTime, we can return early.
Signed-off-by: Matej Dujava
---
drivers/staging/vt6655/rxtx.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655
This patch will fix LONG_LINE error from checkpatch, by createing temporary
variable so call to the function is not in if/else block.
Signed-off-by: Matej Dujava
---
drivers/staging/vt6655/rxtx.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers
On Sat, May 02, 2020 at 10:11:43PM -0700, Joe Perches wrote:
On Sun, 2020-05-03 at 00:16 +0200, Matej Dujava wrote:
This patch will fix LONG_LINE error from checkpatch, by createing temporary
variable so call to the function is not in if/else block.
[]
diff --git a/drivers/staging/vt6655
This patch will unify exit point for s_uGetDataDuration function.
Signed-off-by: Matej Dujava
---
drivers/staging/vt6655/rxtx.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index
This patch will reuse code for two cases.
Signed-off-by: Matej Dujava
---
drivers/staging/vt6655/rxtx.c | 34 --
1 file changed, 34 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index 2f9c2ead3cb8..28f0cda36dec 100644
This patch will prepare us to make return at the end of case body
Signed-off-by: Matej Dujava
---
drivers/staging/vt6655/rxtx.c | 36 +--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
This patch will remove if/else by selecting proper argument before
function call, also index is updated before function call.
Signed-off-by: Matej Dujava
---
drivers/staging/vt6655/rxtx.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/drivers
This patch is extracting calculation of uAckTime in one place, at the
start of case body.
Signed-off-by: Matej Dujava
---
drivers/staging/vt6655/rxtx.c | 33 +++--
1 file changed, 15 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers
This patch set will eliminate few checkpatch LONG_LINE errors.
Simplify code paths by:
- returning at the end of case body
- removing unnecessary else branches
Matej Dujava (5):
staging: vt6655: merge two switch cases in s_uGetDataDuration
staging: vt6655: do calculation of uAckTime first
51 matches
Mail list logo
