[PATCH v2] staging: iio: ad2s1210: fix 'assignment operator' style checks

This patch fixes all "Assignment operator '=' should be on the previous line" checks found in ad2s1210.c with checkpatch.pl. Signed-off-by: Matheus Tavares --- Changes in v2: In v1, tabs were accidentally converted to whitespaces. Now, tabs were preserved. drivers/staging/iio/resolve

[PATCH v2 6/6] staging:iio:ad2s90: Check channel type at read_raw

This patch adds a channel type check at the beginning of the ad2s90_read_raw function. Since ad2s90 has only one channel, it just checks if the given channel is the expected one and if not, return -EINVAL. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 3 +++ 1 file

[PATCH v2 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure

the execution of the rest of the function. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 11fac9f90148..d6a42e3f1bd8

[PATCH v2 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code

Previously, when spi_read returned an error code inside ad2s90_read_raw, the code was ignored and IIO_VAL_INT was returned. This patch makes the function return the error code returned by spi_read when it fails. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 9

[PATCH v2 4/6] staging:iio:ad2s90: Move device registration to the end of probe

registration to the end of ad2s90_probe. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index c20d37dc065a..b4a6a89c11b0

[PATCH v2 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and implements the relative read behavior at ad2s90_read_raw. Signed-off-by: Victor Colombo Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 32 ++- 1 file changed, 22 insertions

[PATCH v2 3/6] staging:iio:ad2s90: Remove always overwritten assignment

This patch removes an initial assignment to the variable ret at probe, that was always overwritten. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers

[PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling

my S-o-B in patch 5. Matheus Tavares (5): staging:iio:ad2s90: Make read_raw return spi_read's error code staging:iio:ad2s90: Make probe handle spi_setup failure staging:iio:ad2s90: Remove always overwritten assignment staging:iio:ad2s90: Move device registration to the end of probe

[PATCH v3 0/6] staging:iio:ad2s90: Add scale info and improve error handling

. Matheus Tavares (5): staging:iio:ad2s90: Make read_raw return spi_read's error code staging:iio:ad2s90: Make probe handle spi_setup failure staging:iio:ad2s90: Remove always overwritten assignment staging:iio:ad2s90: Move device registration to the end of probe staging:iio:ad2s90: Check channel

[PATCH v3 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure

: The 'return ret' statement could be out of the 'if' block, but this whole block will be moved up in the function in the patch: 'staging:iio:ad2s90: Move device registration to the end of probe'. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 7 ++- 1 file changed, 6

[PATCH v3 4/6] staging:iio:ad2s90: Move device registration to the end of probe

registration to the end of ad2s90_probe. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 54ad85bd9dc6..8f79cccf4814

[PATCH v3 3/6] staging:iio:ad2s90: Remove always overwritten assignment

This patch removes an initial assignment to the variable ret at probe, that was always overwritten. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers

[PATCH v3 6/6] staging:iio:ad2s90: Check channel type at read_raw

This patch adds a channel type check at the beginning of the ad2s90_read_raw function. Since ad2s90 has only one channel, it just checks if the given channel is the expected one and if not, return -EINVAL. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 3 +++ 1 file

[PATCH v3 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and implements the relative read behavior at ad2s90_read_raw. Signed-off-by: Victor Colombo Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 30 +++ 1 file changed, 21 insertions(+), 9

[PATCH v3 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code

Previously, when spi_read returned an error code inside ad2s90_read_raw, the code was ignored and IIO_VAL_INT was returned. This patch makes the function return the error code returned by spi_read when it fails. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 7

Re: [PATCH v2 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code

On 10/28/18 1:40 PM, Jonathan Cameron wrote: On Fri, 26 Oct 2018 23:00:00 -0300 Matheus Tavares wrote: Previously, when spi_read returned an error code inside ad2s90_read_raw, the code was ignored and IIO_VAL_INT was returned. This patch makes the function return the error code returned

Re: [PATCH v2 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure

On 10/28/18 1:43 PM, Jonathan Cameron wrote: On Fri, 26 Oct 2018 23:00:01 -0300 Matheus Tavares wrote: Previously, ad2s90_probe ignored the return code from spi_setup, not handling its possible failure. This patch makes ad2s90_probe check if the code is an error code and, if so, do

[PATCH 3/6] staging:iio:ad2s90: Remove always overwritten assignment

This patch removes an initial assignment to the variable ret at probe, that was always overwritten. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers

[PATCH 0/6] staging:iio:ad2s90: Add scale info and improve error handling

This patch set adds scale info to ad2s90's single channel, improve error handling in it's functions and fix a possible race condition issue. The goal with this patch set is to address the points discussed in the mailing list in an effort to move ad2s90.c out of staging. Matheus Tavares (5

[PATCH 6/6] staging:iio:ad2s90: Check channel type at read_raw

This patch adds a channel type check at the beginning of the ad2s90_read_raw function. Since ad2s90 has only one channel, it just checks if the given channel is the expected one and if not, return -EINVAL. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 3 +++ 1 file

[PATCH 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code

Previously, when spi_read returned an error code inside ad2s90_read_raw, the code was ignored and IIO_VAL_INT was returned. This patch makes the function return the error code returned by spi_read when it fails. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 9

[PATCH 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure

the execution of the rest of the function. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 11fac9f90148..d6a42e3f1bd8

[PATCH 4/6] staging:iio:ad2s90: Move device registration to the end of probe

registration to the end of ad2s90_probe. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index c20d37dc065a..b4a6a89c11b0

[PATCH 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

From: Victor Colombo This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and implements the relative read behavior at ad2s90_read_raw. Signed-off-by: Victor Colombo --- drivers/staging/iio/resolver/ad2s90.c | 32 ++- 1 file changed, 22 insertions(+), 10

[PATCH 0/6] staging:iio:ad2s90: Add dt support and move out of staging

l be happy to send a patch to tackle it. Matheus Tavares (6): staging:iio:ad2s90: Add device tree support staging:iio:ad2s90: Remove spi setup that should be done via dt staging:iio:ad2s90: Add max frequency check at probe dt-bindings:iio:resolver: Add docs for ad2s90 staging:iio:ad2s90

[PATCH 2/6] staging:iio:ad2s90: Remove spi setup that should be done via dt

node of a device tree will be documented in the future patch "dt-bindings:iio:resolver: Add docs for ad2s90". Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c

[PATCH 3/6] staging:iio:ad2s90: Add max frequency check at probe

/ (2 * 6e-7), which gives roughly 83Hz. Signed-off-by: Matheus Tavares Signed-off-by: Alexandru Ardelean --- Alex's S-o-B was added because he gave the code suggestion for this patch. drivers/staging/iio/resolver/ad2s90.c | 12 1 file changed, 12 insertions(+) diff --git

[PATCH 6/6] staging:iio:ad2s90: Move out of staging

Move ad2s90 resolver driver out of staging to the main tree. Signed-off-by: Matheus Tavares Signed-off-by: Victor Colombo --- drivers/iio/resolver/Kconfig| 10 ++ drivers/iio/resolver/Makefile | 1 + drivers/{staging => }/iio/resolver/ad2s90.c |

[PATCH 1/6] staging:iio:ad2s90: Add device tree support

This patch adds device tree support to ad2s90 with standard device tree id table. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c

[PATCH 4/6] dt-bindings:iio:resolver: Add docs for ad2s90

This patch adds the device tree binding documentation for the ad2s90 resolver-to-digital converter. Signed-off-by: Matheus Tavares --- .../bindings/iio/resolver/ad2s90.txt | 26 +++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, which solves the checkpatch.pl warning: "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 1 + 1 file changed, 1

[PATCH v2 4/7] dt-bindings:iio:resolver: Add docs for ad2s90

This patch adds the device tree binding documentation for the ad2s90 resolver-to-digital converter. Signed-off-by: Matheus Tavares --- Changes in v2: - Rewritten 'spi-cpol and spi-cpha' item to say that the device can work in either mode (0,0) or (1,1) and explain how they should be specified

[PATCH v2 7/7] staging:iio:ad2s90: Move out of staging

Move ad2s90 resolver driver out of staging to the main tree. Signed-off-by: Matheus Tavares Signed-off-by: Victor Colombo --- Changes in v2: - Disabled git move detection, to see the whole code, as Jonathan suggested drivers/iio/resolver/Kconfig | 10 ++ drivers/iio/resolver

[PATCH v2 0/7] staging:iio:ad2s90: Add dt support and move out of staging

frequency check at probe Matheus Tavares (5): staging:iio:ad2s90: Add device tree support staging:iio:ad2s90: Remove spi setup that should be done via dt dt-bindings:iio:resolver: Add docs for ad2s90 staging:iio:ad2s90: Replace license text w/ SPDX identifier staging:iio:ad2s90: Move out

[PATCH v2 1/7] staging:iio:ad2s90: Add device tree support

This patch adds device tree support to ad2s90 with standard device tree id table. Signed-off-by: Matheus Tavares --- Changes in v2: - none drivers/staging/iio/resolver/ad2s90.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging

[PATCH v2 6/7] staging:iio:ad2s90: Add comment to device state mutex

From: Victor Colombo Fix the checkpatch.pl issue: "CHECK: struct mutex definition without comment". Signed-off-by: Victor Colombo Signed-off-by: Matheus Tavares --- Changes in v2: - Patch added in v2 drivers/staging/iio/resolver/ad2s90.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v2 5/7] staging:iio:ad2s90: Replace license text w/ SPDX identifier

This patch removes the license boilerplate text at the top of ad2s90.c and, instead, adds the SPDX GPL-2.0 license identifier, which solves the checkpatch.pl warning: "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". Signed-off-by: Matheus Tavares --- Cha

[PATCH v2 3/7] staging:iio:ad2s90: Add max frequency check at probe

the max frequency should be 1 / (2 * 6e-7), which gives roughly 83Hz. Signed-off-by: Alexandru Ardelean Signed-off-by: Matheus Tavares --- Changes in v2: - Correctly credit Alexandru as the patch's author drivers/staging/iio/resolver/ad2s90.c | 12 1 file changed, 12 insertions

[PATCH v2 2/7] staging:iio:ad2s90: Remove spi setup that should be done via dt

, not in the driver's code. This patch removes them from the probe function. Note: The way in which the mentioned spi settings need to be specified on the ad2s90's node of a device tree will be documented in the future patch "dt-bindings:iio:resolver: Add docs for ad2s90". Signed-off-b

[PATCH v3 1/7] staging:iio:ad2s90: Add device tree support

This patch adds device tree support to ad2s90 with standard device tree id table. Signed-off-by: Matheus Tavares --- Changes in v3: - Removed of_patch_ptr from of_match_table assignment Changes in v2: - none drivers/staging/iio/resolver/ad2s90.c | 7 +++ 1 file changed, 7 insertions

[PATCH v3 0/7] staging:iio:ad2s90: Add dt support and move out of staging

in this mail thread: https://marc.info/?l=linux-iio=154028966111330=2. Alexandru Ardelean (1): staging:iio:ad2s90: Add max frequency check at probe Matheus Tavares (5): staging:iio:ad2s90: Add device tree support staging:iio:ad2s90: Remove spi setup that should be done via dt dt

[PATCH v3 5/7] staging:iio:ad2s90: Replace license text w/ SPDX identifier

This patch removes the license boilerplate text at the top of ad2s90.c and, instead, adds the SPDX GPL-2.0 license identifier, which solves the checkpatch.pl warning: "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". Signed-off-by: Matheus Tavares --- Changes in v

[PATCH v3 2/7] staging:iio:ad2s90: Remove spi setup that should be done via dt

, not in the driver's code. This patch removes them from the probe function. Note: The way in which the mentioned spi settings need to be specified on the ad2s90's node of a device tree will be documented in the future patch "dt-bindings:iio:resolver: Add docs for ad2s90". Signed-off-b

[PATCH v3 6/7] staging:iio:ad2s90: Add comment to device state mutex

From: Victor Colombo Fix the checkpatch.pl issue: "CHECK: struct mutex definition without comment". Signed-off-by: Victor Colombo Signed-off-by: Matheus Tavares --- Changes in v3: - none Changes in v2: - Patch added in v2 drivers/staging/iio/resolver/ad2s90.c | 2 +- 1 file

[PATCH v3 4/7] dt-bindings:iio:resolver: Add docs for ad2s90

This patch adds the device tree binding documentation for the ad2s90 resolver-to-digital converter. Signed-off-by: Matheus Tavares --- Changes in v3: - Added reference to spi-bus documentation after spi properties, as suggested by Alexandru Ardelean. Changes in v2: - Rewritten 'spi-cpol

[PATCH v3 3/7] staging:iio:ad2s90: Add max frequency check at probe

the max frequency should be 1 / (2 * 6e-7), which gives roughly 83Hz. Signed-off-by: Alexandru Ardelean Signed-off-by: Matheus Tavares --- Changes in v3: - none Changes in v2: - Correctly credit Alexandru as the patch's author drivers/staging/iio/resolver/ad2s90.c | 12 1 file

[PATCH v3 7/7] staging:iio:ad2s90: Move out of staging

Move ad2s90 resolver driver out of staging to the main tree. Signed-off-by: Matheus Tavares Signed-off-by: Victor Colombo --- Changes in v3: - none Changes in v2: - Disabled git move detection, to see the whole code, as Jonathan suggested drivers/iio/resolver/Kconfig | 10

Re: [PATCH 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

On Fri, Oct 26, 2018 at 7:04 AM Dan Carpenter wrote: > > On Thu, Oct 25, 2018 at 09:45:11PM -0300, Matheus Tavares wrote: > > From: Victor Colombo > > > > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and > > implements the relative read behavior at a

Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling

On Sun, Oct 28, 2018 at 1:52 PM Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 22:59:59 -0300 > Matheus Tavares wrote: > > > This patch set adds scale info to ad2s90's single channel, improve > > error handling in it's functions and fix a possible race condition >

Re: [PATCH v2 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

On Sun, Oct 28, 2018 at 1:50 PM Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 23:00:04 -0300 > Matheus Tavares wrote: > > > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and > > implements the relative read behavior at ad2s90_read_raw. > > >

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

On Fri, Nov 9, 2018 at 8:13 PM Fabio Estevam wrote: > > Hi Matheus, > Hi, Fabio > On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares > wrote: > > > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > > which solves the checkpatch.pl warning: &

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

On Fri, Nov 9, 2018 at 10:20 PM Greg Kroah-Hartman wrote: > > On Fri, Nov 09, 2018 at 09:19:52PM -0200, Matheus Tavares Bernardino wrote: > > On Fri, Nov 9, 2018 at 8:13 PM Fabio Estevam wrote: > > > > > > Hi Matheus, > > > > > > > Hi, Fab

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

On Sat, Nov 10, 2018 at 11:23 AM Fabio Estevam wrote:> > Hi Matheus, > > On Fri, Nov 9, 2018 at 10:27 PM Matheus Tavares Bernardino > wrote: > > > Got it, thanks for the explanation! I'll correct this in v2. > > One more suggestion: in v2 you could also consi

Re: [PATCH 2/6] staging:iio:ad2s90: Remove spi setup that should be done via dt

On Sun, Nov 11, 2018 at 9:42 AM Jonathan Cameron wrote: > > On Fri, 9 Nov 2018 20:00:40 -0200 > Matheus Tavares wrote: > > > The ad2s90 driver currently sets some spi settings (max_speed_hz and > > mode) at ad2s90_probe. This should, instead, be handled via device tree

[PATCH] staging: iio: ad2s1210: fix 'assignment operator' style checks

This patch fixes all "Assignment operator '=' should be on the previous line" checks found in ad2s1210.c by checkpatch.pl. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s1210.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/s

Re: [PATCH v2 4/7] dt-bindings:iio:resolver: Add docs for ad2s90

On Mon, Nov 19, 2018 at 6:22 AM Ardelean, Alexandru wrote: > > On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote: > > This patch adds the device tree binding documentation for the ad2s90 > > resolver-to-digital converter. > > > > One minor comment inline

Re: [PATCH v2 1/7] staging:iio:ad2s90: Add device tree support

On Mon, Nov 19, 2018 at 6:09 AM Ardelean, Alexandru wrote: > > On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote: > > This patch adds device tree support to ad2s90 with standard > > device tree id table. > > > > Hey, > > Comment inline

Re: [PATCH 4/6] dt-bindings:iio:resolver: Add docs for ad2s90

On Sun, Nov 11, 2018 at 9:48 AM Jonathan Cameron wrote: > > On Fri, 9 Nov 2018 20:00:42 -0200 > Matheus Tavares wrote: > > > This patch adds the device tree binding documentation for the ad2s90 > > resolver-to-digital converter. > > > > Signed-off-by: Matheu

Re: [PATCH] staging:iio:adc:ad7280a: add of_match_table entry

end the two patches separately? Thanks, Matheus > Reviewed-by: Alexandru Ardelean > > > > Signed-off-by: Kartik Kulkarni > > Reviewed-by: Matheus Tavares > > --- > > drivers/staging/iio/adc/ad7280a.c | 9 - > > 1 file changed, 8 insertions(+