Re: [PATCH v5 1/6] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-11-03 Thread Mauro Carvalho Chehab
parameter (that is, soc_camera and imx-drm) are changed to not decrement the passed prev argument's refcount themselves. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Feel free to merge it via Grant's tree. Acked-by: Mauro Carvalho Chehab mche...@osg.samsung.com --- Changes since v4

Re: [PATCH] staging: media: lirc: replace dev_err by pr_err

2014-11-05 Thread Mauro Carvalho Chehab
Em Tue, 4 Nov 2014 02:13:19 +0200 Aya Mahfouz mahfouz.saif.elya...@gmail.com escreveu: This patch replaces dev_err by pr_err since the value of ir is NULL when the message is displayed. This one doesn't apply at the media tree: diff --git a/drivers/staging/media/lirc/lirc_zilog.c

Re: [PATCH] staging: media: lirc: modify print calls

2014-11-05 Thread Mauro Carvalho Chehab
Em Tue, 4 Nov 2014 23:43:07 +0200 Aya Mahfouz mahfouz.saif.elya...@gmail.com escreveu: This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls. Also doesn't apply. Probably made to apply on Greg's tree. Regards, Mauro Signed-off-by: Aya

Re: [PATCH v2 01/10] [media] Move mediabus format definition to a more standard place

2014-11-07 Thread Mauro Carvalho Chehab
Em Fri, 07 Nov 2014 13:43:59 +0200 Sakari Ailus sakari.ai...@iki.fi escreveu: +enum media_bus_format { There's no really a need to keep the definitions inside the enum. It looks a little bit confusing to me. That made me realise something I missed yesterday. There's a difference: the

Re: [PATCH] staging: media: bcm2048: fix coding style error

2014-11-16 Thread Mauro Carvalho Chehab
Em Sat, 15 Nov 2014 13:25:03 -0800 Greg KH gre...@linuxfoundation.org escreveu: On Sat, Nov 15, 2014 at 09:59:34PM +0100, Pavel Machek wrote: On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote: On 11/15, Christian Resell wrote: Simple style fix (checkpatch.pl: space prohibited before

Re: [PATCH] Staging: media: lirc: lirc_serial: replaced printk with pr_debug

2014-11-25 Thread Mauro Carvalho Chehab
Em Fri, 21 Nov 2014 14:21:40 +0100 Abel Moyo abelmoyo...@gmail.com escreveu: Replaced printk with pr_debug in dprintk Signed-off-by: Abel Moyo abelmoyo...@gmail.com --- drivers/staging/media/lirc/lirc_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-12-04 Thread Mauro Carvalho Chehab
Hi Luis, Em Tue, 25 Nov 2014 20:36:29 + Luis de Bethencourt l...@debethencourt.com escreveu: checkpatch makes an exception to the 80-colum rule for quotes strings, and Documentation/CodingStyle recommends not splitting quotes strings across lines because it breaks the ability to grep for

Re: [PATCH v3 2/2] staging: media: lirc: lirc_zilog.c: keep consistency in dev functions

2014-12-05 Thread Mauro Carvalho Chehab
Em Fri, 05 Dec 2014 12:35:25 + Luis de Bethencourt l...@debethencourt.com escreveu: On 5 December 2014 at 12:28, Dan Carpenter dan.carpen...@oracle.com wrote: On Thu, Dec 04, 2014 at 10:35:24PM +, Luis de Bethencourt wrote: The previous patch switched some dev functions to move

Fw: staging: media: Use dev_err() instead of pr_err()

2013-11-14 Thread Mauro Carvalho Chehab
/staging/media/go7007/go7007-usb.c Hans Verkuil hans.verk...@cisco.com (maintainer:STAGING - GO7007...) Mauro Carvalho Chehab m.che...@samsung.com (maintainer:MEDIA INPUT INFRA...) Greg Kroah-Hartman gre...@linuxfoundation.org (supporter:STAGING SUBSYSTEM) linux-me

Re: staging: media: Use dev_err() instead of pr_err()

2013-11-17 Thread Mauro Carvalho Chehab
Em Fri, 15 Nov 2013 15:29:39 +0900 Greg Kroah-Hartman gre...@linuxfoundation.org escreveu: On Thu, Nov 14, 2013 at 11:08:14AM -0200, Mauro Carvalho Chehab wrote: Hi, I'm not sure how this patch got applied upstream: commit b6ea5ef80aa7fd6f4b18ff2e4174930e8772e812 Author

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

2014-03-05 Thread Mauro Carvalho Chehab
Em Tue, 11 Feb 2014 13:38:51 +0100 Laurent Pinchart laurent.pinch...@ideasonboard.com escreveu: Hi Paul, Thank you for the patch. On Tuesday 11 February 2014 12:17:01 Paul Bolle wrote: Commit d632dfefd36f ([media] v4l: omap4iss: Add support for OMAP4 camera interface - Build system)

Re: [PATCH V3] i2c: move of helpers into the core

2013-08-24 Thread Mauro Carvalho Chehab
Nawrocki s.nawro...@samsung.com Signed-off-by: Wolfram Sang w...@the-dreams.de Acked-by: Mauro Carvalho Chehab m.che...@samsung.com --- V2-V3: Was trying to be too smart by only fixing includes needed. Took a more general approach this time, converting of_i2c.h to i2c.h in case i2c.h

Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-10-31 Thread Mauro Carvalho Chehab
, right? If so: Acked-by: Mauro Carvalho Chehab m.che...@samsung.com Regards, Hans --- drivers/staging/media/dt3155v4l/dt3155v4l.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c b/drivers/staging

Re: [Patch v2][ 04/37] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format.

2013-10-31 Thread Mauro Carvalho Chehab
...@lists.freedesktop.org Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: linux-me...@vger.kernel.org Cc: Sascha Hauer ker...@pengutronix.de Cc: linux-arm-ker...@lists.infradead.org Cc: Eric Bénard e...@eukrea.com Signed-off-by: Denis Carikli de

Re: [kconfig] update: results of some syntactical checks

2013-11-02 Thread Mauro Carvalho Chehab
Em Sat, 02 Nov 2013 20:20:54 +0100 Paul Bolle pebo...@tiscali.nl escreveu: On Sun, 2013-10-20 at 00:03 +0200, Martin Walch wrote: drivers/media/common/siano/Kconfig:21-26 config SMS_SIANO_DEBUGFS bool Enable debugfs for smsdvb depends on SMS_SIANO_MDTV depends on DEBUG_FS

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

2014-03-06 Thread Mauro Carvalho Chehab
Em Thu, 06 Mar 2014 12:00:30 +0100 Laurent Pinchart laurent.pinch...@ideasonboard.com escreveu: Hi Greg, On Wednesday 05 March 2014 20:45:29 Greg Kroah-Hartman wrote: On Thu, Mar 06, 2014 at 01:48:29AM +0100, Laurent Pinchart wrote: On Wednesday 05 March 2014 16:28:03 Joe Perches wrote:

Re: [PATCH] media: tlg2300: disable building the driver

2014-12-23 Thread Mauro Carvalho Chehab
Em Mon, 22 Dec 2014 13:25:45 -0700 Jim Davis jim.ep...@gmail.com escreveu: This driver doesn't build with the current kernel, as reported in linux-next (https://lkml.org/lkml/2014/12/18/483) and by the 0-day build system

[PATCH 1/2] vino: Fix media dependencies

2014-12-23 Thread Mauro Carvalho Chehab
Changeset c1d9e03d4ef4 moved the driver to staging, but it forgot to preserve the existing dependency. fixes: c1d9e03d4ef4 ([media] vino/saa7191: move to staging in preparation for removal) Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff

[PATCH 2/2] tlg2300: Fix media dependencies

2014-12-23 Thread Mauro Carvalho Chehab
Changeset ea2e813e8cc3 moved the driver to staging, but it forgot to preserve the existing dependency. Fixes: ea2e813e8cc3 ([media] tlg2300: move to staging in preparation for removal) Cc: Hans Verkuil hverk...@xs4all.nl Cc: Jim Davis jim.ep...@gmail.com Signed-off-by: Mauro Carvalho Chehab mche

[PATCH] radio-bcm2048: remove unused var

2015-04-28 Thread Mauro Carvalho Chehab
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_i2c_driver_probe': drivers/staging/media/bcm2048/radio-bcm2048.c:2596:11: warning: variable 'skip_release' set but not used [-Wunused-but-set-variable] int err, skip_release = 0; ^ Signed-off-by: Mauro Carvalho

[PATCH 15/18] omap4iss: stop MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-05-07 Thread Mauro Carvalho Chehab
This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, as it uses a hack to check if the remote entity is a subdev. Get rid of it. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/drivers/staging/media/omap4iss/iss_ipipe.c b/drivers/staging/media/omap4iss/iss_ipipe.c index

[PATCH 10/18] media controller: use macros to check for V4L2 subdev entities

2015-05-07 Thread Mauro Carvalho Chehab
and FB/DRM too. Ok, on the current pipelines supported by those drivers, just V4L stuff are there, but, assuming that some day a pipeline that also works with other subsystems will ever added, it is better to add explicit checks for the AV_DMA stuff. Signed-off-by: Mauro Carvalho Chehab mche

[PATCH 11/18] omap3/omap4/davinci: get rid of MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-05-07 Thread Mauro Carvalho Chehab
it by 2 16 where it occurs, and add a note saying that the code there is actually a hack. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c index a6a61cce43dd..6721ef2533a0 100644

[PATCH 14/18] davinci_vbpe: stop MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-05-07 Thread Mauro Carvalho Chehab
This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV: - it uses a hack to check if the remote entity is a subdev; - it still uses the legacy entity subtype check macro, that will be removed soon. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/drivers/staging/media

Re: [PATCH 10/18] media controller: use macros to check for V4L2 subdev entities

2015-05-08 Thread Mauro Carvalho Chehab
Em Fri, 08 May 2015 14:46:19 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On 05/08/2015 03:12 AM, Mauro Carvalho Chehab wrote: Instead of relying on media subtype, use the new macros to detect if an entity is a subdev or an A/V DMA entity. Please note that most drivers assume

Re: [PATCH] media: cxd2099: move pre-init values out of init()

2015-04-08 Thread Mauro Carvalho Chehab
Em Sun, 8 Feb 2015 20:55:36 + luisbg l...@debethencourt.com escreveu: Improve code readability by moving out all pre-init values from the init function. Signed-off-by: Luis de Bethencourt luis...@samsung.com --- drivers/staging/media/cxd2099/cxd2099.c | 4 ++-- 1 file changed, 2

[PATCH 11/11] [media] lirc_imon: simplify error handling code

2015-06-05 Thread Mauro Carvalho Chehab
/lirc/lirc_imon.c:933 imon_probe() warn: possible memory leak of 'driver' And make the error handling code more standard. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c index 335b98a54237

Re: [PATCH 18/26] [media] dvb: Get rid of typedev usage for enums

2015-06-09 Thread Mauro Carvalho Chehab
Em Mon, 08 Jun 2015 13:03:03 -0700 Joe Perches j...@perches.com escreveu: On Mon, 2015-06-08 at 16:54 -0300, Mauro Carvalho Chehab wrote: The DVB API was originally defined using typedefs. This is against Kernel CodingStyle, and there's no good usage here. While we can't remove its usage

[PATCH RFC v3 07/16] media: get rid of unused extra_links param on media_entity_init()

2015-08-12 Thread Mauro Carvalho Chehab
to change the implementation of the links. So, before doing that, let's first remove that extra unused parameter, in order to cleanup the interface first. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/Documentation/media-framework.txt b/Documentation/media-framework.txt index

[PATCH RFC v3 10/16] media: rename link source/sink to pad0_source/pad1_sink

2015-08-12 Thread Mauro Carvalho Chehab
f) ; do sed s,link-sink,link-pad1_sink,g; s,link-source,link-pad0_source,g; $i a mv a $i; done Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c index 3c97ebdf9f2a..e673f6f7c398 100644

[PATCH RFC v3 11/16] media: rename the function that create pad links

2015-08-12 Thread Mauro Carvalho Chehab
in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g $i a mv a $i; done Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git

Re: [PATCH 0/4] [media] Media entity cleanups and build fixes

2015-08-19 Thread Mauro Carvalho Chehab
Hi Javier, Em Wed, 19 Aug 2015 17:35:18 +0200 Javier Martinez Canillas jav...@osg.samsung.com escreveu: Hello, This series contains a couple of build fixes and cleanups for the Media Controller framework. The goal of the series is to get rid of the struct media_entity .parent member since

[PATCH RFC v5 8/8] [media] media: rename the function that create pad links

2015-08-18 Thread Mauro Carvalho Chehab
in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g $i a mv a $i; done Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git

[PATCH v6 8/8] [media] media: rename the function that create pad links

2015-08-19 Thread Mauro Carvalho Chehab
in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g $i a mv a $i; done Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Hans

[PATCH v7 10/44] [media] media: rename the function that create pad links

2015-08-23 Thread Mauro Carvalho Chehab
in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g $i a mv a $i; done Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Hans

[PATCH v7 28/44] [media] media: use macros to check for V4L2 subdev entities

2015-08-23 Thread Mauro Carvalho Chehab
and FB/DRM too. Ok, on the current pipelines supported by those drivers, just V4L stuff are there, but, assuming that some day a pipeline that also works with other subsystems will ever added, it is better to add explicit checks for the AV_DMA stuff. Signed-off-by: Mauro Carvalho Chehab mche

[PATCH v7 29/44] [media] omap3/omap4/davinci: get rid of MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-08-23 Thread Mauro Carvalho Chehab
it by 2 16 where it occurs, and add a note saying that the code there is actually a hack. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c index 27555e4f4aa8..6b5c52b7f755 100644

[PATCH v7 11/44] [media] media: use entity.graph_obj.mdev instead of .parent

2015-08-23 Thread Mauro Carvalho Chehab
: @@ struct media_entity *me; @@ - me-parent + me-graph_obj.mdev @@ struct media_entity *link; @@ - link-source-entity-parent + link-source-entity-graph_obj.mdev @@ struct exynos_video_entity *ve; @@ - ve-vdev.entity.parent + ve-vdev.entity.graph_obj.mdev Suggested-by: Mauro Carvalho Chehab mche

[PATCH v7 02/44] [media] staging: omap4iss: get entity ID using media_entity_id()

2015-08-23 Thread Mauro Carvalho Chehab
. Signed-off-by: Javier Martinez Canillas jav...@osg.samsung.com Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index 9bfb725b9986..e54a7afd31de 100644 --- a/drivers/staging/media/omap4iss/iss.c

[PATCH v7 33/44] [media] omap4iss: stop MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-08-23 Thread Mauro Carvalho Chehab
This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, as it uses a hack to check if the remote entity is a subdev. Get rid of it. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/drivers/staging/media/omap4iss/iss_ipipe.c b/drivers/staging/media/omap4iss/iss_ipipe.c index

[PATCH RFC v2 10/16] media: rename the function that create pad links

2015-08-11 Thread Mauro Carvalho Chehab
in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g $i a mv a $i; done Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git

[PATCH RFC v2 09/16] media: use media_graph_obj for link endpoints

2015-08-11 Thread Mauro Carvalho Chehab
introduce links between entities and interfaces, we may need to change some existing code to work with links that aren't pad to pad. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c index

Re: [PATCH RFC v2 09/16] media: use media_graph_obj for link endpoints

2015-08-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Aug 2015 14:25:18 +0200 Hans Verkuil hansv...@cisco.com escreveu: Hi Mauro, Thanks for posting the missing patches. Thanks for reviewing this patch series! On 08/11/15 14:09, Mauro Carvalho Chehab wrote: As we'll need to create links between entities and interfaces, we

[PATCH RFC v2 07/16] media: get rid of unused extra_links param on media_entity_init()

2015-08-07 Thread Mauro Carvalho Chehab
to change the implementation of the links. So, before doing that, let's first remove that extra unused parameter, in order to cleanup the interface first. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/Documentation/media-framework.txt b/Documentation/media-framework.txt index

Re: [PATCH RFC v3 07/16] media: get rid of unused extra_links param on media_entity_init()

2015-08-14 Thread Mauro Carvalho Chehab
Em Fri, 14 Aug 2015 13:33:48 +0300 Sakari Ailus sakari.ai...@iki.fi escreveu: Hi Mauro, On Wed, Aug 12, 2015 at 05:14:51PM -0300, Mauro Carvalho Chehab wrote: Currently, media_entity_init() creates an array with the links, allocated at init time. It provides a parameter (extra_links

[PATCH v4 1/6] media: get rid of unused extra_links param on media_entity_init()

2015-08-14 Thread Mauro Carvalho Chehab
to change the implementation of the links. So, before doing that, let's first remove that extra unused parameter, in order to cleanup the interface first. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Sakari Ailus sakari.ai...@linux.intel.com diff --git a/Documentation/media

[PATCH 2/2] [media] include/media: move platform driver headers to a separate dir

2015-11-11 Thread Mauro Carvalho Chehab
in $(ls $j); do echo "perl -ne 's,(include [\\\"\\<]media/)($i)([\\\"\\>]),\1$j\2\3,; print \$_' |\\"; done; done; echo "cat > a && mv a \$i; done") >script && . ./script Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> ren

Re: [PATCH 2/2] [media] include/media: move platform driver headers to a separate dir

2015-11-13 Thread Mauro Carvalho Chehab
Em Wed, 11 Nov 2015 21:26:31 +0100 Arnd Bergmann <a...@arndb.de> escreveu: > On Wednesday 11 November 2015 15:14:48 Mauro Carvalho Chehab wrote: > > rename include/media/{ => platform}/exynos-fimc.h (100%) > > rename include/media/{ => platform}/mmp-camera.h (100%

Re: [PATCH 2/2] [media] include/media: move platform driver headers to a separate dir

2015-11-13 Thread Mauro Carvalho Chehab
Em Fri, 13 Nov 2015 22:31:15 +0100 Arnd Bergmann <a...@arndb.de> escreveu: > On Friday 13 November 2015 17:13:41 Mauro Carvalho Chehab wrote: > > Em Wed, 11 Nov 2015 21:26:31 +0100 > > Arnd Bergmann <a...@arndb.de> escreveu: > > > > &g

[PATCH v2 3/3] [media] include/media: move platform_data to linux/platform_data/media

2015-11-16 Thread Mauro Carvalho Chehab
cd include/$MAIN_DIR; for j in $DIRS; do for i in $(ls $j); do echo " perl -ne 's,include/$PREV_DIR($i)\b,include/$MAIN_DIR$j\1,; print \$_' |\\"; done; done;

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-10-11 Thread Mauro Carvalho Chehab
Em Mon, 12 Oct 2015 00:07:52 +0300 Sakari Ailus <sakari.ai...@iki.fi> escreveu: > Hi Mauro, > > On Sun, Aug 30, 2015 at 12:06:43AM -0300, Mauro Carvalho Chehab wrote: > > Instead of relying on media subtype, use the new macros to detect > > if an entity is a

Re: [PATCH 1/1] media: Correctly determine whether an entity is a sub-device

2015-10-12 Thread Mauro Carvalho Chehab
7 @@ static inline bool is_media_entity_v4l2_subdev(struct > media_entity *entity) > case MEDIA_ENT_F_LENS: > case MEDIA_ENT_F_ATV_DECODER: > case MEDIA_ENT_F_TUNER: > + case MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN: > return true; OK. Reviewed-by:

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-10-12 Thread Mauro Carvalho Chehab
Em Mon, 12 Oct 2015 18:35:05 +0300 Sakari Ailus <sakari.ai...@iki.fi> escreveu: > Hi Mauro, > > On Sun, Oct 11, 2015 at 09:56:25PM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 12 Oct 2015 00:07:52 +0300 > > Sakari Ailus <sakari.ai...@iki.fi> escreveu: > &g

Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c

2015-11-18 Thread Mauro Carvalho Chehab
Em Wed, 18 Nov 2015 23:05:27 +0530 Jitendra escreveu: > > > On Wednesday 18 November 2015 10:42 PM, Greg KH wrote: > > On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote: > >> This is a patch to the radio-bcm2048.c file that fixes up a brace warning > >>

Re: [PATCH v2 3/3] [media] include/media: move platform_data to linux/platform_data/media

2015-11-17 Thread Mauro Carvalho Chehab
Em Mon, 16 Nov 2015 13:28:10 +0100 Arnd Bergmann escreveu: > I think we can also move some of the existing platform data headers to the > same > place, but that could be a separate patch: > > $ git grep linux/platform_data drivers/media/ >

Re: [PATCH v7 10/44] [media] media: rename the function that create pad links

2015-08-28 Thread Mauro Carvalho Chehab
Em Wed, 26 Aug 2015 11:54:03 -0300 Mauro Carvalho Chehab mche...@osg.samsung.com escreveu: Em Tue, 25 Aug 2015 12:55:41 -0600 Shuah Khan shua...@osg.samsung.com escreveu: On 08/23/2015 02:17 PM, Mauro Carvalho Chehab wrote: Now that a link can be either between two different graph

[PATCH v8 33/55] [media] omap3/omap4/davinci: get rid of MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-08-29 Thread Mauro Carvalho Chehab
it by 2 16 where it occurs, and add a note saying that the code there is actually a hack. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c index 9a811f5741fa..f0e530c98188 100644

[PATCH v8 11/55] [media] media: use entity.graph_obj.mdev instead of .parent

2015-08-29 Thread Mauro Carvalho Chehab
: @@ struct media_entity *me; @@ - me-parent + me-graph_obj.mdev @@ struct media_entity *link; @@ - link-source-entity-parent + link-source-entity-graph_obj.mdev @@ struct exynos_video_entity *ve; @@ - ve-vdev.entity.parent + ve-vdev.entity.graph_obj.mdev Suggested-by: Mauro Carvalho Chehab mche

[PATCH v8 00/55] MC next generation patches

2015-08-29 Thread Mauro Carvalho Chehab
[media] omap3isp: separate links creation from entities init [media] omap3isp: create links after all subdevs have been bound Mauro Carvalho Chehab (49): [media] media: create a macro to get entity ID [media] media: add a common struct to be embed on media graph objects [media] media: use

[PATCH v8 36/55] [media] davinci_vbpe: stop MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-08-29 Thread Mauro Carvalho Chehab
This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV: - it uses a hack to check if the remote entity is a subdev; - it still uses the legacy entity subtype check macro, that will be removed soon. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/drivers/staging/media

[PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-08-29 Thread Mauro Carvalho Chehab
and FB/DRM too. Ok, on the current pipelines supported by those drivers, just V4L stuff are there, but, assuming that some day a pipeline that also works with other subsystems will ever added, it is better to add explicit checks for the AV_DMA stuff. Signed-off-by: Mauro Carvalho Chehab mche

[PATCH v8 10/55] [media] media: rename the function that create pad links

2015-08-29 Thread Mauro Carvalho Chehab
this shell script: for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g $i a mv a $i; done Signed-off-by: Mauro Carvalho Chehab mche

Re: [PATCH v8 00/55] MC next generation patches

2015-08-30 Thread Mauro Carvalho Chehab
Em Sun, 30 Aug 2015 00:06:11 -0300 Mauro Carvalho Chehab mche...@osg.samsung.com escreveu: That's the 8th version of the MC next generation patches. Differences from version 7: - Patches reworked to make the reviewers happy; - Bug fixes; - ALSA changes got their own separate patches

Re: [PATCH v7 11/44] [media] media: use entity.graph_obj.mdev instead of .parent

2015-08-26 Thread Mauro Carvalho Chehab
Em Tue, 25 Aug 2015 13:25:15 -0600 Shuah Khan shuahk...@gmail.com escreveu: On Tue, Aug 25, 2015 at 12:36 AM, Hans Verkuil hverk...@xs4all.nl wrote: On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: From: Javier Martinez Canillas jav...@osg.samsung.com The struct media_entity has

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 04:16:15 +0200 Laurent Pinchart <laurent.pinch...@ideasonboard.com> escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 30 August 2015 00:06:43 Mauro Carvalho Chehab wrote: > > Instead of relying on media subtype, use the new macros

Re: [PATCH v8 33/55] [media] omap3/omap4/davinci: get rid of MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 04:08:17 +0200 Laurent Pinchart <laurent.pinch...@ideasonboard.com> escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 30 August 2015 00:06:44 Mauro Carvalho Chehab wrote: > > On omap3/omap4/davinci drivers, MEDIA_ENT_T_V4L2_SUBDEV m

Re: [PATCH v8 37/55] [media] omap4iss: stop MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 03:46:28 +0200 Laurent Pinchart <laurent.pinch...@ideasonboard.com> escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 30 August 2015 00:06:48 Mauro Carvalho Chehab wrote: > > This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, as

Re: [PATCH v8 36/55] [media] davinci_vbpe: stop MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 03:52:01 +0200 Laurent Pinchart <laurent.pinch...@ideasonboard.com> escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 30 August 2015 00:06:47 Mauro Carvalho Chehab wrote: > > This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV: > &g

[PATCH 03/10] media framework: rename pads init function to media_entity_pads_init()

2015-12-11 Thread Mauro Carvalho Chehab
Carvalho Chehab <mche...@osg.samsung.com> --- Documentation/media-framework.txt | 18 +++--- Documentation/video4linux/v4l2-framework.txt | 8 Documentation/zh_CN/video4linux/v4l2-framework.txt | 8 drivers/media/dvb-core/dv

[PATCH] media: use unsigned for pad index

2015-12-11 Thread Mauro Carvalho Chehab
The pad index is unsigned. Replace the occurences of it where pertinent. Suggested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> --- drivers/media/platform/omap3isp/ispccdc.c | 2 +- drivers/me

Re: On Lindent shortcomings and massive style fixing

2015-12-28 Thread Mauro Carvalho Chehab
Em Mon, 28 Dec 2015 07:33:32 -0800 Greg KH escreveu: > On Mon, Dec 28, 2015 at 04:33:27PM +0200, Andrey Utkin wrote: > > After some iterations of checkpatch.pl, on a new developed driver > > (tw5864), now I have the following: > > > > $ grep 'WARNING\|ERROR'

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

2016-01-25 Thread Mauro Carvalho Chehab
Em Fri, 18 Dec 2015 18:35:29 +0530 Sudip Mukherjee escreveu: > Modify lirc_parallel driver to use the new parallel port device model. Did you or someone else tested this patch? Regards, Mauro > > Signed-off-by: Sudip Mukherjee > --- >

Re: [PATCH 4/5] staging: media: lirc: place operator on previous line

2016-01-25 Thread Mauro Carvalho Chehab
Em Fri, 18 Dec 2015 18:35:28 +0530 Sudip Mukherjee escreveu: > checkpatch complains about the logical operator, which should be on the > previous line. IMHO, this is a matter of personal taste. I prefer to keep the operator on the next line, as it makes clearer to

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

2016-01-25 Thread Mauro Carvalho Chehab
Em Mon, 25 Jan 2016 22:32:31 +0530 Sudip Mukherjee <sudipm.mukher...@gmail.com> escreveu: > On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote: > > Em Fri, 18 Dec 2015 18:35:29 +0530 > > Sudip Mukherjee <sudipm.mukher...@gmail.com> escreveu: > &

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

2016-01-25 Thread Mauro Carvalho Chehab
Em Mon, 25 Jan 2016 23:03:43 +0530 Sudip Mukherjee <sudipm.mukher...@gmail.com> escreveu: > On Monday 25 January 2016 10:42 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 25 Jan 2016 22:32:31 +0530 > > Sudip Mukherjee <sudipm.mukher...@gmail.com> escreveu: > > &

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Mar 2016 12:52:54 +0200 Sakari Ailus <sakari.ai...@iki.fi> escreveu: > Hi Mauro, > > On Mon, Mar 14, 2016 at 07:13:58AM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 14 Mar 2016 09:22:37 +0200 > > Sakari Ailus <sakari.ai...@iki.fi>

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-14 Thread Mauro Carvalho Chehab
(), > > media_create_intf_link() and media_devnode_create(). > > > > Signed-off-by: Shuah Khan <shua...@osg.samsung.com> > > Suggested-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> > > What's the use case for calling the above functions in an atomic

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-15 Thread Mauro Carvalho Chehab
Em Mon, 14 Mar 2016 14:09:09 +0200 Sakari Ailus <sakari.ai...@iki.fi> escreveu: > Hi Mauro, > > On Mon, Mar 14, 2016 at 08:46:33AM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 14 Mar 2016 12:52:54 +0200 > > Sakari Ailus <sakari.ai...@iki.fi>

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-13 Thread Mauro Carvalho Chehab
gs for > memory allocation. > > tree-wide driver changes for media_*() GFP flags change: > Change drivers to add gfpflags to interffaces, media_create_pad_link(), > media_create_intf_link() and media_devnode_create(). > > Signed-off-by: Shuah Khan <shua...@osg.samsung.com

[PATCH] [media] media: rename media unregister function

2016-03-19 Thread Mauro Carvalho Chehab
Now that media_device_unregister() also does a cleanup, rename it to media_device_unregister_cleanup(). Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> --- drivers/media/common/siano/smsdvb-main.c | 2 +- drivers/media/media-device.c

Re: [PATCH] [media] media: rename media unregister function

2016-03-19 Thread Mauro Carvalho Chehab
Em Fri, 18 Mar 2016 16:20:19 +0200 Sakari Ailus <sakari.ai...@linux.intel.com> escreveu: > Shuah Khan wrote: > > On 03/18/2016 08:12 AM, Javier Martinez Canillas wrote: > >> Hello Shuah, > >> > >> On 03/18/2016 11:01 AM, Shuah Khan wrote: > >

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-19 Thread Mauro Carvalho Chehab
Em Wed, 16 Mar 2016 10:28:35 +0200 Sakari Ailus <sakari.ai...@iki.fi> escreveu: > Hi Mauro, > > On Tue, Mar 15, 2016 at 12:55:35PM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 14 Mar 2016 14:09:09 +0200 > > Sakari Ailus <sakari.ai...@iki.fi>

[PATCH] [media] tw686x-kh: use the cached value

2016-04-20 Thread Mauro Carvalho Chehab
; ^ Use the cache instead, as it seems reading it needs to be done with spin lock taken. Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> --- drivers/staging/media/tw686x-kh/tw686x-kh-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Mauro Carvalho Chehab
Em Tue, 2 Aug 2016 20:01:34 +0800 Baole Ni escreveu: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the >

[PATCH 1/2] [media] move s5p-cec to staging

2016-06-28 Thread Mauro Carvalho Chehab
As the CEC core is currently at staging, it doesn't make any sense to put a dependent driver outside staging. So, move it also to staging. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- MAINTAINERS| 2 +- drivers

[PATCH 2/2] [media] s5p_cec: get rid of an unused var

2016-06-28 Thread Mauro Carvalho Chehab
drivers/staging/media/s5p-cec/s5p_cec.c: In function 's5p_cec_adap_enable': drivers/staging/media/s5p-cec/s5p_cec.c:42:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] int ret; ^~~ Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/s

Re: [PATCH 3/6] staging: bcm2835-v4l2: Add a build system for the module.

2017-02-03 Thread Mauro Carvalho Chehab
Em Fri, 27 Jan 2017 13:55:00 -0800 Eric Anholt escreveu: > This is derived from the downstream tree's build system, but with just > a single Kconfig option. > > For now the driver only builds on 32-bit arm -- the aarch64 build > breaks due to the driver using arm-specific cache

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Mauro Carvalho Chehab
RPi customers to use, as you're providing a driver that is limited. > > Thanks >Dave > > > On 03/02/17 18:59, Mauro Carvalho Chehab wrote: > > HI Eric, > > > > Em Fri, 27 Jan 2017 13:54:58 -0800 > > Eric Anholt <e...@anholt.net> escreveu: >

Re: [PATCH] staging:bcm2048 : Add parentheses around variable x

2017-02-03 Thread Mauro Carvalho Chehab
Em Sat, 3 Dec 2016 15:14:26 +0530 Tabrez khan escreveu: > Add parentheses around variable x for the readability purpose. > > This warning was found using checkpatch.pl. > > Signed-off-by: Tabrez khan > --- >

Re: [PATCH] [media] v4l: omap4iss: Fix using BIT macro

2016-10-03 Thread Mauro Carvalho Chehab
Em Sat, 1 Oct 2016 16:37:46 -0700 Wayne Porter escreveu: > Checks found by checkpatch > > Signed-off-by: Wayne Porter > --- > drivers/staging/media/omap4iss/iss_regs.h | 76 > +++ > 1 file changed, 38 insertions(+), 38

Re: [PATCH -next] staging: media: stih-cec: remove unused including

2016-10-24 Thread Mauro Carvalho Chehab
Em Sun, 2 Oct 2016 16:55:05 +0200 Greg Kroah-Hartman escreveu: > On Wed, Sep 28, 2016 at 03:13:13PM +, Wei Yongjun wrote: > > From: Wei Yongjun > > > > Remove including that don't need it. > > > > Signed-off-by: Wei Yongjun

[PATCH 10/25] [media] radio-bcm2048: don't ignore errors

2016-10-14 Thread Mauro Carvalho Chehab
-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/staging/media/bcm2048/radio-bcm2048.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c index ea15cc638097..4d9bd02ede47

Re: [PATCH 29/39] Annotate hardware config module parameters in drivers/staging/media/

2016-12-01 Thread Mauro Carvalho Chehab
Em Thu, 01 Dec 2016 14:59:56 + David Howells <dhowe...@redhat.com> escreveu: > Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > > > drivers/staging/media/lirc/lirc_parallel.c:728:19: error: Expected ) in > > function declarator > > Did yo

Re: [PATCH 29/39] Annotate hardware config module parameters in drivers/staging/media/

2016-12-01 Thread Mauro Carvalho Chehab
tates drivers in drivers/staging/media/. > > Suggested-by: One Thousand Gnomes <gno...@lxorguk.ukuu.org.uk> > Signed-off-by: David Howells <dhowe...@redhat.com> > cc: Mauro Carvalho Chehab <mche...@kernel.org> > cc: Greg Kroah-Hartman <gre...@linuxfoundation.or

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-22 Thread Mauro Carvalho Chehab
Hi Michael, Em Mon, 20 Mar 2017 08:40:11 -0700 Michael Zoran escreveu: > > > Are you using Eric Anholt's HDMI Audio driver that's included in > > > VC4?  > > > That could well be incompatible with the firmware driver. Or are > > > you > > > using a half mode of VC4 for

Re: [PATCH v2] staging: media: omap4iss: Replace a bit shift by a use of BIT.

2017-03-26 Thread Mauro Carvalho Chehab
Em Sun, 26 Mar 2017 20:57:02 +0300 Laurent Pinchart escreveu: > Hi Arushi, > > Thank you for the patch. > > On Friday 24 Mar 2017 21:31:45 Arushi Singhal wrote: > > This patch replaces bit shifting on 1 with the BIT(x) macro. > > This was done with

[PATCH v2 21/22] docs-rst: fix usb cross-references

2017-03-30 Thread Mauro Carvalho Chehab
As some USB documentation files got moved, adjust their cross-references to their new place. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- Documentation/ABI/stable/sysfs-bus-usb| 2 +- Documentation/driver-api/usb/URB.rst | 2 ++ Documen

[PATCH 21/22] docs-rst: fix usb cross-references

2017-03-29 Thread Mauro Carvalho Chehab
As some USB documentation files got moved, adjust their cross-references to their new place. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- Documentation/ABI/stable/sysfs-bus-usb| 2 +- Documentation/driver-api/usb/URB.rst | 2 ++ Documen

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-19 Thread Mauro Carvalho Chehab
Em Fri, 17 Mar 2017 17:34:36 -0700 Eric Anholt <e...@anholt.net> escreveu: > Mauro Carvalho Chehab <mche...@s-opensource.com> writes: > > > Em Wed, 15 Mar 2017 18:46:24 -0700 > > Michael Zoran <mzo...@crowfest.net> escreveu: > > > >> On Wed, 201

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-17 Thread Mauro Carvalho Chehab
Em Fri, 17 Mar 2017 12:16:08 + Russell King - ARM Linux escreveu: > On Fri, Mar 17, 2017 at 01:02:07PM +0100, Philipp Zabel wrote: > > I think most of the simple, fixed pipeline use cases could be handled by > > libv4l2, by allowing to pass a v4l2 subdevice path to

  1   2   3   4   5   6   7   8   9   10   >