using it for error reporting.
Signed-off-by: Paul Kocialkowski
---
.../sun8i_a83t_mipi_csi2.c| 40 ---
1 file changed, 40 deletions(-)
diff --git
a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c
b/drivers/media/platform/sunxi/sun8i
it there.
Fixes: 5cc7522d8965 ("media: sun6i: Add support for Allwinner CSI V3s")
Co-developed-by: Kévin L'hôpital
Signed-off-by: Kévin L'hôpital
Signed-off-by: Paul Kocialkowski
---
.../platform/sunxi/sun6i-csi/sun6i_csi.h | 20 +--
1 file changed, 10 insertions(+), 10
The V3s has a CSI0 camera controller which seems to be exclusively
dedicated to MIPI CSI-2, as it does not seem to have access to a
set of parallel input pins.
Signed-off-by: Paul Kocialkowski
---
arch/arm/boot/dts/sun8i-v3s.dtsi | 12
1 file changed, 12 insertions(+)
diff --git
L'hôpital
Signed-off-by: Paul Kocialkowski
---
.../platform/sunxi/sun6i-csi/sun6i_csi.c | 42 +++
1 file changed, 25 insertions(+), 17 deletions(-)
diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
index
the Allwinner BSP.
This version integrates MIPI CSI-2 support as a standalone V4L2 subdev
instead of merging it in the sun6i-csi driver.
It was tested on a Banana Pi M3 board with an OV8865 sensor in a 4-lane
configuration.
Signed-off-by: Paul Kocialkowski
---
drivers/media/platform/sunxi/Kconfig
the fwnode graph and
media controller API.
Signed-off-by: Paul Kocialkowski
---
drivers/media/platform/sunxi/Kconfig | 1 +
drivers/media/platform/sunxi/Makefile | 1 +
.../platform/sunxi/sun6i-mipi-csi2/Kconfig| 11 +
.../platform/sunxi/sun6i-mipi-csi2/Makefile | 4
controller doesn't have much to do itself except for selecting
the MIPI CSI-2 input.
Co-developed-by: Kévin L'hôpital
Signed-off-by: Kévin L'hôpital
Signed-off-by: Paul Kocialkowski
---
drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers
This introduces YAML bindings documentation for the A83T MIPI CSI-2
controller.
Signed-off-by: Paul Kocialkowski
---
.../media/allwinner,sun8i-a83t-mipi-csi2.yaml | 158 ++
1 file changed, 158 insertions(+)
create mode 100644
Documentation/devicetree/bindings/media/allwinner
is the same that already drives DSI, but used in Rx mode.
Signed-off-by: Paul Kocialkowski
---
arch/arm/boot/dts/sun8i-v3s.dtsi | 50
1 file changed, 50 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
index 07722bc5df11
one colorspace:raw
xfer:none ycbcr:601 quantization:full-range]
-> "sun6i-mipi-csi2":0 [ENABLED,IMMUTABLE]
Happy reviewing!
Paul Kocialkowski (14):
phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes
phy: allwinner: phy-sun6i-mipi-dphy: Support D-PHY Rx mode for MI
MIPI CSI-2 is supported on the A83T with a dedicated controller that
covers both the protocol and D-PHY. It can be connected to the CSI
interface as a V4L2 subdev through the fwnode graph.
Signed-off-by: Paul Kocialkowski
---
arch/arm/boot/dts/sun8i-a83t.dtsi | 26 ++
1
The Allwinner A31 D-PHY supports both Rx and Tx modes. While the latter
is already supported and used for MIPI DSI this adds support for the
former, to be used with MIPI CSI-2.
This implementation is inspired by the Allwinner BSP implementation.
Signed-off-by: Paul Kocialkowski
---
drivers/phy
This allows selecting a dedicated CMA memory pool (specified via
device-tree) instead of the default one.
Signed-off-by: Paul Kocialkowski
---
drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/media/platform/sunxi/sun6i-csi
(zero value) is kept to Tx so only the rkisp1 driver, which
uses D-PHY in Rx mode, needs to be adapted.
Signed-off-by: Paul Kocialkowski
---
drivers/staging/media/rkisp1/rkisp1-isp.c | 3 ++-
include/linux/phy/phy-mipi-dphy.h | 13 +
2 files changed, 15 insertions(+), 1
electing a CAPTURE resolution that is
> > too small, avoiding unwanted page faults.
> >
> > Signed-off-by: Nicolas Dufresne
>
> This looks correct.
Looks like there's no issue with alignment (that will get applied as well),
which was a possible concern.
Thanks for reviewing!
2][64];
> __u8scaling_list_dc_coef_16x16[6];
> __u8scaling_list_dc_coef_32x32[2];
> };
> };
>
> And let the core use a default for each scaling matrix, if userspace doesn't
> set it.
>
>
>
> Cheers,
> Mauro
--
Pa
Hi,
On Fri 13 Dec 19, 17:15, Jernej Skrabec wrote:
> Signed-off-by: Jernej Skrabec
Good catch, thanks!
Acked-by: Paul Kocialkowski
Cheers,
Paul
> ---
> drivers/staging/media/sunxi/cedrus/cedrus_h265.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/s
; Only complete HW reset helps.
>
> This fix is similar to that for H264.
Thanks for the fix, interesting that the same issue shows up on HEVC!
I suspect that Allwinner folks never really tested the engine without
using it for bitstream parsing.
Acked-by: Paul Kocialkowski
Cheers,
P
Hi Jenrej,
On Wed 06 Nov 19, 22:05, Jernej Skrabec wrote:
> H264 decoder needs additional or bigger buffers in order to decode 4k
> videos.
Thanks for the changes, looks good to me!
Acked-by: Paul Kocialkowski
Cheers,
Paul
> Signed-off-by: Jernej Skrabec
> ---
> driver
Hi,
On Mon 04 Nov 19, 17:33, Jernej Škrabec wrote:
> Dne ponedeljek, 04. november 2019 ob 11:02:28 CET je Paul Kocialkowski
> napisal(a):
> > Hi Jernej,
> >
> > On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote:
> > > Mode register also holds information i
Hi Jernej,
On Mon 04 Nov 19, 17:53, Jernej Škrabec wrote:
> Dne ponedeljek, 04. november 2019 ob 11:13:19 CET je Paul Kocialkowski
> napisal(a):
> > Hi,
> >
> > On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote:
> > > H264 decoder needs additional or big
-off-by: Jernej Skrabec
Acked-by: Paul Kocialkowski
As I said on the other email, it would be nice to eventually reflect the actual
per-platform maximum dimensions instead of hardcoding the maximum for all
platforms confounded.
Cheers,
Paul
> ---
> drivers/staging/media/sunxi/cedrus/cedrus_
Hi,
On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote:
> H264 decoder needs additional or bigger buffers in order to decode 4k
> videos.
Thanks for the fixup, we hadn't looked into those bits at all during initial
bringup of H.264!
See a few minor comments below.
> Signed-off-by: Jernej Skrabec
>
Hi Jernej,
On Sat 26 Oct 19, 09:49, Jernej Skrabec wrote:
> Mode register also holds information if video width is bigger than 2048
> and if it is equal to 4096.
>
> Rework cedrus_engine_enable() to properly signal this properties.
Thanks for the patch, looks good to me!
Ac
delayed this for far too long already so I think we should get it
in without further delay.
The patch apparently no longer applies on top of media/master, but feel free
to send out a rebased series with:
Acked-by: Paul Kocialkowski
Let's leave out 2/3 though, I think I will submit a s
Hi,
On Wed 16 Oct 19, 16:56, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
This is still:
Acked-by: Paul Kocialkowski
Please collect the tag in your next version, if there's a need for one.
Cheers,
Paul
> S
od, thanks!
Acked-by: Paul Kocialkowski
Cheers,
Paul
> Signed-off-by: Hariprasad Kelam
> ---
> drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
&g
On Thu 03 Oct 19, 23:19, Jernej Škrabec wrote:
> Dne četrtek, 03. oktober 2019 ob 22:58:57 CEST je Paul Kocialkowski
> napisal(a):
> > Hi,
> >
> > On Thu 03 Oct 19, 22:44, Jernej Škrabec wrote:
> > > Dne četrtek, 03. oktober 2019 ob 22:28:46 CEST je Paul
Hi,
On Thu 03 Oct 19, 22:44, Jernej Škrabec wrote:
> Dne četrtek, 03. oktober 2019 ob 22:28:46 CEST je Paul Kocialkowski
> napisal(a):
> > Hi,
> >
> > On Thu 03 Oct 19, 07:16, Jernej Škrabec wrote:
> > > Dne četrtek, 03. oktober 2019 ob 00:06:50 CEST je Paul
Hi,
On Thu 03 Oct 19, 07:16, Jernej Škrabec wrote:
> Dne četrtek, 03. oktober 2019 ob 00:06:50 CEST je Paul Kocialkowski
> napisal(a):
> > Hi,
> >
> > On Wed 02 Oct 19, 21:35, Jernej Skrabec wrote:
> > > Reference index count in VE_H264_PPS should com
Hi,
On Wed 02 Oct 19, 21:35, Jernej Skrabec wrote:
> This is continuation of https://lkml.org/lkml/2019/5/30/1459 with several
> patches removed (2 merged, others needs redesign) and one added.
Thanks for the continued effort on this, these fixes are greatly appreciated
(and more generally, all
Hi,
On Wed 02 Oct 19, 21:35, Jernej Skrabec wrote:
> Accessing capture queue structue directly is not safe. Use helpers for
> that.
Looks good to me, thanks!
Acked-by: Paul Kocialkowski
Cheers,
Paul
> Signed-off-by: Jernej Skrabec
> ---
> drivers/staging/media/sunxi/
userspace and v4l2-request testing tool currently don't provide this,
but I have a pending merge request adding it for the hantro so it's good to go.
Acked-by: Paul Kocialkowski
Cheers,
Paul
> Signed-off-by: Jernej Skrabec
> ---
> drivers/staging/media/sunxi/cedrus/cedrus_h264.c | 8
Hi,
On Wed 02 Oct 19, 21:35, Jernej Skrabec wrote:
> It seems that for some H264 videos at least one bitstream parsing
> trigger must be called in order to be decoded correctly. There is no
> explanation why this helps, but it was observed that two sample videos
> with this fix are now decoded
Hi,
On Tue 30 Jul 19, 09:27, Hans Verkuil wrote:
> On 7/27/19 11:57 AM, Paul Kocialkowski wrote:
> > Hi Hans,
> >
> > On Fri 26 Jul 19, 10:33, Hans Verkuil wrote:
> >> On 7/25/19 8:55 PM, Paul Kocialkowski wrote:
> >>> HEVC/H.265 stateless support for
Hi Hans,
On Fri 26 Jul 19, 10:33, Hans Verkuil wrote:
> On 7/25/19 8:55 PM, Paul Kocialkowski wrote:
> > HEVC/H.265 stateless support for V4L2 and Cedrus
> >
> > This is early support for HEVC/H.265 stateless decoding in V4L2,
> > including both definitions and driver
This introduces support for HEVC/H.265 to the Cedrus VPU driver, with
both uni-directional and bi-directional prediction modes supported.
Field-coded (interlaced) pictures, custom quantization matrices and
10-bit output are not supported at this point.
Signed-off-by: Paul Kocialkowski
support;
* No support for SPS extensions: range, multilayer, 3d, scc, 4 bits;
* No support for PPS extensions: range, multilayer, 3d, scc, 4 bits.
Signed-off-by: Paul Kocialkowski
---
Documentation/media/uapi/v4l/biblio.rst | 9 +
.../media/uapi/v4l/ext-ctrls-codec.rst| 486
Document the current state of the HEVC slice pixel format.
The format will need to evolve in the future, which is why it is
not part of the public API.
Signed-off-by: Paul Kocialkowski
---
.../media/uapi/v4l/pixfmt-compressed.rst | 21 +++
1 file changed, 21 insertions
Since it's not necessarily very explicit why we need to zero some fields
in std_validate_compound, add a comment before the function to explain
why, which should help as a reminder.
Signed-off-by: Paul Kocialkowski
---
drivers/media/v4l2-core/v4l2-ctrls.c | 4
1 file changed, 4 insertions
instead of buffer indices in the DPB
* Declared variable in their reduced scope as suggested;
* Added the H.265/HEVC spec to the biblio;
* Used in-doc references to the spec and the required APIs;
* Removed debugging leftovers.
Cheers!
Paul Kocialkowski (4):
media: v4l2-ctrl: Add a comment on why
Hi Hans and thanks for the review!
On Mon 22 Jul 19, 16:40, Hans Verkuil wrote:
> On 6/14/19 4:38 PM, Paul Kocialkowski wrote:
> > This introduces the required definitions for HEVC decoding support with
> > stateless VPUs. The controls associated to the HEVC slice format provide
&
Hi,
On Mon 22 Jul 19, 18:58, Sakari Ailus wrote:
> On Mon, Jul 22, 2019 at 07:14:08PM +0530, Nishka Dasgupta wrote:
> > On 22/07/19 5:54 PM, Paul Kocialkowski wrote:
> > > Hi,
> > >
> > > On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote:
> > > > O
Hi,
On Mon 22 Jul 19, 19:14, Nishka Dasgupta wrote:
> On 22/07/19 5:54 PM, Paul Kocialkowski wrote:
> > Hi,
> >
> > On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote:
> > > On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote:
> > > > Typecast as b
Hi,
Any feedback on this series? I think it was pretty much ready for merge
regarding the comments received so far.
I could craft a rebased v7, with or without additional changes, if needed.
What do you think?
Cheers,
Paul
On Fri 14 Jun 19, 16:38, Paul Kocialkowski wrote:
> This is ea
However, I'm not sure I really see what cocinelle was unhappy about. You
mentionned single-line functions, but I don't see how that can be a problem.
So in the end, I think we should keep the !! and drop the (bool) cast if there's
no particular warning about it.
What do you think?
Cheer
s, capabilities);
> + return (bool)cedrus_find_format(pixelformat, directions, capabilities);
> }
>
> static void cedrus_prepare_format(struct v4l2_pix_format *pix_fmt)
> --
> 2.19.1
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://boo
Hi,
On Fri 05 Jul 19, 17:43, Nishka Dasgupta wrote:
> On 05/07/19 3:56 PM, Paul Kocialkowski wrote:
> > Hi,
> >
> > On Wed 03 Jul 19, 13:43, Nishka Dasgupta wrote:
> > > Remove function cedrus_check_format as all it does is call
> > > cedrus_find_
Hi,
On Tue 09 Jul 19, 22:04, Joe Perches wrote:
> Arguments are supposed to be ordered high then low.
>
> Signed-off-by: Joe Perches
Good catch, thanks!
Acked-by: Paul Kocialkowski
Cheers,
Paul
> ---
> drivers/staging/media/sunxi/cedrus/cedrus_regs.h | 2 +-
> 1 file ch
return false;
> }
>
> -static bool cedrus_check_format(u32 pixelformat, u32 directions,
> - unsigned int capabilities)
> -{
> - return cedrus_find_format(pixelformat, directions, capabilities);
> -}
> -
> static void cedrus_prepare_format(struct v4l2_pix_format *pix
; - return _formats[i];
> + return false;
> }
>
> static bool cedrus_check_format(u32 pixelformat, u32 directions,
> --
> 2.19.1
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
.265/HEVC spec to the biblio;
* Used in-doc references to the spec and the required APIs;
* Removed debugging leftovers.
Cheers!
Paul Kocialkowski (5):
media: v4l2-ctrls: Split off MPEG-2 controls validation
media: v4l2-ctrls: Split off MPEG-2 controls initialization
media: v4l: Add
Just like codec-specific controls validation, controls initialization
for codecs is quite specific so move it to a specific helper for
MPEG-2 for increased clarity.
Signed-off-by: Paul Kocialkowski
---
drivers/media/v4l2-core/v4l2-ctrls.c | 33 ++--
1 file changed, 22
This introduces support for HEVC/H.265 to the Cedrus VPU driver, with
both uni-directional and bi-directional prediction modes supported.
Field-coded (interlaced) pictures, custom quantization matrices and
10-bit output are not supported at this point.
Signed-off-by: Paul Kocialkowski
support;
* No support for SPS extensions: range, multilayer, 3d, scc, 4 bits;
* No support for PPS extensions: range, multilayer, 3d, scc, 4 bits.
Signed-off-by: Paul Kocialkowski
---
Documentation/media/uapi/v4l/biblio.rst | 9 +
.../media/uapi/v4l/ext-ctrls-codec.rst| 474
Document the current state of the HEVC slice pixel format.
The format will need to evolve in the future, which is why it is
not part of the public API.
Signed-off-by: Paul Kocialkowski
---
.../media/uapi/v4l/pixfmt-compressed.rst | 21 +++
1 file changed, 21 insertions
Since codec controls validation comes with its own logic, split off
std_validate for MPEG-2 for better clarity.
Use a shorter name for the validated structure and use the
type-specific pointer to grab it while at it.
Signed-off-by: Paul Kocialkowski
---
drivers/media/v4l2-core/v4l2-ctrls.c
Hi,
Le lundi 03 juin 2019 à 18:37 +0200, Jernej Škrabec a écrit :
> Dne ponedeljek, 03. junij 2019 ob 14:23:28 CEST je Maxime Ripard napisal(a):
> > On Thu, May 30, 2019 at 11:15:16PM +0200, Jernej Skrabec wrote:
> > > H264 decoder driver preallocated pretty big worst case mv col buffer
> > >
Hi,
Le lundi 03 juin 2019 à 17:48 +0200, Jernej Škrabec a écrit :
> Dne ponedeljek, 03. junij 2019 ob 14:18:59 CEST je Maxime Ripard napisal(a):
> > Hi,
> >
> > On Thu, May 30, 2019 at 11:15:15PM +0200, Jernej Skrabec wrote:
> > > H264 and HEVC engines need additional buffers for each capture
Hi,
Le jeudi 30 mai 2019 à 23:15 +0200, Jernej Skrabec a écrit :
> Scale and rotation are currently not implemented, so it makes no sense to
> set chroma size for it.
>
> Signed-off-by: Jernej Skrabec
Acked-by: Paul Kocialkowski
Cheers,
Paul
> ---
> drivers/staging/
Hi,
Le jeudi 30 mai 2019 à 23:15 +0200, Jernej Skrabec a écrit :
> This array is just duplicated capture buffer queue. Remove it and adjust
> code to look into capture buffer queue instead.
>
> Signed-off-by: Jernej Skrabec
Acked-by: Paul Kocialkowski
Cheers and t
Hi Hans,
On Sat, 2019-05-25 at 13:08 +0200, Hans Verkuil wrote:
> Hi Paul,
>
> This patch is missing your Signed-of-by line! Can you reply with your SoB?
Ouch, sorry about that. This is definitely:
Signed-off-by: Paul Kocialkowski
Cheers,
Paul
> Regards,
>
> Hans
This introduces the required definitions for HEVC decoding support with
stateless VPUs. The controls associated to the HEVC slice format provide
the required meta-data for decoding slices extracted from the bitstream.
They are not exported to the public V4L2 API since reworking this API
will be
This introduces support for HEVC/H.265 to the Cedrus VPU driver, with
both uni-directional and bi-directional prediction modes supported.
Field-coded (interlaced) pictures, custom quantization matrices and
10-bit output are not supported at this point.
Signed-off-by: Paul Kocialkowski
relevant platforms;
* Switched over to tags instead of buffer indices in the DPB
* Declared variable in their reduced scope as suggested;
* Added the H.265/HEVC spec to the biblio;
* Used in-doc references to the spec and the required APIs;
* Removed debugging leftovers.
Cheers!
Paul Kocialkowski (4
format (with raw slice header), with slice
controls attached.
Signed-off-by: Paul Kocialkowski
---
include/media/hevc-ctrls.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/media/hevc-ctrls.h b/include/media/hevc-ctrls.h
index 9ea013c88afc..2de83d9f6d47 100644
--- a/include/media
Document the current state of the HEVC slice pixel format.
The format will need to evolve in the future, which is why it is
not part of the public API.
Signed-off-by: Paul Kocialkowski
---
.../media/uapi/v4l/pixfmt-compressed.rst | 21 +++
1 file changed, 21 insertions
From: Maxime Ripard
Introduce some basic H264 decoding support in cedrus. So far, only the
baseline profile videos have been tested, and some more advanced features
used in higher profiles are not even implemented.
Reviewed-by: Jernej Skrabec
Reviewed-by: Paul Kocialkowski
Signed-off
From: Maxime Ripard
The H264_SLICE_RAW format introduced before is meant for stateless
decoders that will need the H264 parsed slice data without the start code.
Let's document it.
Signed-off-by: Maxime Ripard
Signed-off-by: Hans Verkuil
---
.../media/uapi/v4l/pixfmt-compressed.rst |
From: Maxime Ripard
The H264_SLICE_RAW format is meant to hold the parsed slice data without
the start code. This will be needed by stateless decoders.
Signed-off-by: Maxime Ripard
Signed-off-by: Hans Verkuil
---
drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
include/media/h264-ctrls.h
From: Pawel Osciak
Stateless video codecs will require both the H264 metadata and slices in
order to be able to decode frames.
This introduces the definitions for the structures used to pass the
metadata from the userspace to the kernel.
Reviewed-by: Paul Kocialkowski
Reviewed-by: Tomasz Figa
Hi,
Here is a new version of the H264 decoding support in the cedrus
driver.
As you might already know, the cedrus driver relies on the Request
API, and is a reverse engineered driver for the video decoding engine
found on the Allwinner SoCs.
This work has been possible thanks to the work done
Document the current state of the HEVC slice pixel format.
The format will need to evolve in the future, which is why it is
not part of the public API.
Signed-off-by: Paul Kocialkowski
---
.../media/uapi/v4l/pixfmt-compressed.rst | 21 +++
1 file changed, 21 insertions
This introduces support for HEVC/H.265 to the Cedrus VPU driver, with
both uni-directional and bi-directional prediction modes supported.
Field-coded (interlaced) pictures, custom quantization matrices and
10-bit output are not supported at this point.
Signed-off-by: Paul Kocialkowski
format (with raw slice header), with slice
controls attached.
Signed-off-by: Paul Kocialkowski
---
include/media/hevc-ctrls.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/media/hevc-ctrls.h b/include/media/hevc-ctrls.h
index 9ea013c88afc..2de83d9f6d47 100644
--- a/include/media
of buffer indices in the DPB
* Declared variable in their reduced scope as suggested;
* Added the H.265/HEVC spec to the biblio;
* Used in-doc references to the spec and the required APIs;
* Removed debugging leftovers.
Cheers!
Paul Kocialkowski (4):
media: v4l: Add definitions for the HEVC slice
This introduces the required definitions for HEVC decoding support with
stateless VPUs. The controls associated to the HEVC slice format provide
the required meta-data for decoding slices extracted from the bitstream.
They are not exported to the public V4L2 API since reworking this API
will be
Hi,
On Mon, 2019-04-08 at 10:18 +0200, Paul Kocialkowski wrote:
> Hi,
>
> Le dimanche 07 avril 2019 à 20:47 +0200, Jernej Skrabec a écrit :
> > Currently, MEDIA_IOC_G_TOPOLOGY ioctl on cedrus fails due to incorrect
> > initialization order. Fix that by moving video_reg
Hi,
On Tue, 2019-04-02 at 13:51 +0200, Hans Verkuil wrote:
> On 2/14/19 10:53 AM, Paul Kocialkowski wrote:
[...]
> > +.. c:type:: v4l2_hevc_dpb_entry
> > +
> > +.. cssclass:: longtable
> > +
> > +.. flat-table:: struct v4l2_hevc_dpb_entry
> > +:he
rror path.
>
> Reported-by: Jonas Karlman
> Signed-off-by: Jernej Skrabec
Thanks for the fix, good catch!
Acked-by: Paul Kocialkowski
Cheers,
Paul
> ---
> drivers/staging/media/sunxi/cedrus/cedrus.c | 24 ++---
> 1 file changed, 12 insertions(+), 12 deletions(-
This introduces support for HEVC/H.265 to the Cedrus VPU driver, with
both uni-directional and bi-directional prediction modes supported.
Field-coded (interlaced) pictures, custom quantization matrices and
10-bit output are not supported at this point.
Signed-off-by: Paul Kocialkowski
indices in the DPB
* Declared variable in their reduced scope as suggested;
* Added the H.265/HEVC spec to the biblio;
* Used in-doc references to the spec and the required APIs;
* Removed debugging leftovers.
Cheers!
Paul Kocialkowski (2):
media: v4l: Add definitions for the HEVC slice format
, 4 bits.
Signed-off-by: Paul Kocialkowski
---
Documentation/media/uapi/v4l/biblio.rst | 9 +
.../media/uapi/v4l/ext-ctrls-codec.rst| 418 ++
.../media/uapi/v4l/pixfmt-compressed.rst | 15 +
.../media/uapi/v4l/vidioc-queryctrl.rst | 18 +
.../media
Hi,
On Thu, 2019-01-24 at 20:23 +0800, Ayaka wrote:
>
> Sent from my iPad
>
> > On Jan 24, 2019, at 6:27 PM, Paul Kocialkowski
> > wrote:
> >
> > Hi,
> >
> > > On Thu, 2019-01-10 at 21:32 +0800, ayaka wrote:
> > > I forget a impo
Hi,
On Tue, 2018-11-27 at 09:21 +0100, Maxime Ripard wrote:
> Hi!
>
> On Fri, Nov 23, 2018 at 02:02:09PM +0100, Paul Kocialkowski wrote:
> > This introduces support for HEVC/H.265 to the Cedrus VPU driver, with
> > both uni-directional and bi-directional predi
-by: Paul Kocialkowski
---
drivers/staging/media/sunxi/cedrus/cedrus_dec.c | 13 -
drivers/staging/media/sunxi/cedrus/cedrus_dec.h | 2 --
drivers/staging/media/sunxi/cedrus/cedrus_mpeg2.c | 10 --
3 files changed, 4 insertions(+), 21 deletions(-)
diff --git a/drivers/staging
Hi,
On Thu, 2019-01-24 at 11:32 +0100, Greg KH wrote:
> On Thu, Jan 24, 2019 at 10:55:42AM +0100, Paul Kocialkowski wrote:
> > This reverts commit cf20ae1535eb690a87c29b9cc7af51881384e967.
> >
> > The vb2_find_timestamp helper was modified to allow finding buffers
> >
Hi,
On Tue, 2019-01-08 at 18:00 +0800, Ayaka wrote:
>
> Sent from my iPad
>
> > On Jan 8, 2019, at 4:38 PM, Paul Kocialkowski
> > wrote:
> >
> > Hi,
> >
> > > On Tue, 2019-01-08 at 09:16 +0800, Ayaka wrote:
> > >
> > >
ess video decoder interface
Can you detail exactly what the rockchip decoder absolutely needs in
raw bitstream format?
Cheers,
Paul
> On 1/8/19 6:00 PM, Ayaka wrote:
> > Sent from my iPad
> >
> > > On Jan 8, 2019, at 4:38 PM, Paul Kocialkowski
> > > wrote:
>
This reverts commit cf20ae1535eb690a87c29b9cc7af51881384e967.
The vb2_find_timestamp helper was modified to allow finding buffers
regardless of their current state in the queue. This means that we
no longer have to take particular care of references to the current
capture buffer.
---
Access to reference frames that were imported from dma-buf was taken
care of and is no longer a pending item on the driver's TODO list.
Signed-off-by: Paul Kocialkowski
---
drivers/staging/media/sunxi/cedrus/TODO | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/media
once (when it
is first needed when queued) and keep it mapped until it is freed.
Signed-off-by: Pawel Osciak
Reviewed-on: https://chromium-review.googlesource.com/334103
Signed-off-by: Paul Kocialkowski
[Paul: Updated for mainline and changed commit message]
---
drivers/media/common/videobuf2
Because we need to request and release access to reference buffers
that are backed by a dma-buf import, keep track of the buffers used
as reference and add the appropriate calls in the device_run and
job_done m2m callbacks. The latter is introduced for this purpose.
Signed-off-by: Paul
can be passed to the operation.
Delaying the current context clearing should not be a problem since the
next call to v4l2_m2m_try_run happens right after that.
Signed-off-by: Paul Kocialkowski
---
drivers/media/v4l2-core/v4l2-mem2mem.c | 8 ++--
include/media/v4l2-mem2mem.h | 4
-by: Paul Kocialkowski
---
.../media/common/videobuf2/videobuf2-core.c | 46 +++
include/media/videobuf2-core.h| 15 ++
2 files changed, 61 insertions(+)
diff --git a/drivers/media/common/videobuf2/videobuf2-core.c
b/drivers/media/common/videobuf2/videobuf2
starting with:
media: cedrus: Cleanup duplicate declarations from cedrus_dec header
Paul Kocialkowski (4):
media: vb2: Add helpers to access unselected buffers
media: v4l2-mem2mem: Add an optional job_done operation
media: cedrus: Request access to reference buffers when decoding
media: cedrus
Access to reference frames that were imported from dma-buf was taken
care of and is no longer a pending item on the driver's TODO list.
Signed-off-by: Paul Kocialkowski
---
drivers/staging/media/sunxi/cedrus/TODO | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/media
Hi,
On Wed, 2019-01-09 at 15:29 +0100, Hans Verkuil wrote:
> On 01/09/19 15:19, Paul Kocialkowski wrote:
> > It was reported that some cases of interleaved video decoding require
> > using the current destination buffer as a reference. However, this is
> > no longer po
the current destination
buffer before resorting to vb2_find_timestamp and use it in MPEG-2.
Signed-off-by: Paul Kocialkowski
---
drivers/staging/media/sunxi/cedrus/cedrus_dec.c | 13 +
drivers/staging/media/sunxi/cedrus/cedrus_dec.h | 2 ++
drivers/staging/media/sunxi/cedrus
Some leftover declarations are still in the cedrus_dec header although
they were moved to cedrus_video already. Clean them up.
Signed-off-by: Paul Kocialkowski
---
drivers/staging/media/sunxi/cedrus/cedrus_dec.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/media
101 - 200 of 323 matches
Mail list logo
