Re: [PATCH 03/44] hibernate: Call have_kernel_poweroff instead of checking pm_power_off

2014-10-07 Thread Rafael J. Wysocki
On Monday, October 06, 2014 10:28:05 PM Guenter Roeck wrote: Poweroff handlers may now be installed with register_poweroff_handler. Use the new API function have_kernel_poweroff to determine if a poweroff handler has been installed. Cc: Rafael J. Wysocki r...@rjwysocki.net Cc: Pavel Machek

Re: [PATCH 44/44] kernel: Remove pm_power_off

2014-10-07 Thread Rafael J. Wysocki
On Monday, October 06, 2014 10:28:46 PM Guenter Roeck wrote: No users of pm_power_off are left, so it is safe to remove the function. Cc: Rafael J. Wysocki r...@rjwysocki.net Cc: Pavel Machek pa...@ucw.cz Cc: Len Brown len.br...@intel.com Signed-off-by: Guenter Roeck li...@roeck-us.net ACK

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-03 Thread Rafael J. Wysocki
On Friday, January 03, 2014 11:00:30 AM Russell King - ARM Linux wrote: On Thu, Jan 02, 2014 at 07:10:55PM -0800, Greg Kroah-Hartman wrote: On Thu, Jan 02, 2014 at 09:27:58PM +, Russell King wrote: Subsystems such as ALSA, DRM and others require a single card-level device structure to

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-03 Thread Rafael J. Wysocki
On Friday, January 03, 2014 12:18:13 PM Russell King - ARM Linux wrote: On Fri, Jan 03, 2014 at 12:58:16PM +0100, Rafael J. Wysocki wrote: On Friday, January 03, 2014 11:00:30 AM Russell King - ARM Linux wrote: On Thu, Jan 02, 2014 at 07:10:55PM -0800, Greg Kroah-Hartman wrote: On Thu

Re: [PATCH RESEND 0/3] memory_hotplug: hyperv: fix deadlock between memory adding and onlining

2015-02-12 Thread Rafael J. Wysocki
On Thursday, February 12, 2015 10:01:48 PM KY Srinivasan wrote: -Original Message- From: Rafael J. Wysocki [mailto:r...@rjwysocki.net] Sent: Thursday, February 12, 2015 2:13 PM To: KY Srinivasan Cc: Vitaly Kuznetsov; linux-ker...@vger.kernel.org; Greg Kroah-Hartman; Haiyang

Re: [PATCH RESEND 0/3] memory_hotplug: hyperv: fix deadlock between memory adding and onlining

2015-02-12 Thread Rafael J. Wysocki
On Thursday, February 12, 2015 10:10:30 PM KY Srinivasan wrote: [cut] This issue was first discovered by Andy Whitcroft: https://lkml.org/lkml/2014/3/14/451 I had sent patches based on Andy's analysis that did not affect the users of the kernel hot-add memory APIs:

Re: [PATCH RESEND 0/3] memory_hotplug: hyperv: fix deadlock between memory adding and onlining

2015-02-12 Thread Rafael J. Wysocki
; Yasuaki Ishimatsu; Tang Chen; Vlastimil Babka; David Rientjes; Fabian Frederick; Zhang Zhen; Vladimir Davydov; Wang Nan; Rafael J. Wysocki; de...@linuxdriverproject.org; linux...@kvack.org Subject: [PATCH RESEND 0/3] memory_hotplug: hyperv: fix deadlock between memory adding and onlining

Re: [PATCH 1/3] driver core: export lock_device_hotplug/unlock_device_hotplug

2015-02-11 Thread Rafael J. Wysocki
On Wednesday, February 11, 2015 12:39:47 PM Andrew Morton wrote: On Wed, 11 Feb 2015 16:44:20 +0100 Vitaly Kuznetsov vkuzn...@redhat.com wrote: add_memory() is supposed to be run with device_hotplug_lock grabbed, otherwise it can race with e.g. device_online(). Allow external modules

Re: [PATCH 1/3] drivers:pnp Add support for descendants claiming memory address space

2015-03-05 Thread Rafael J. Wysocki
On 2/17/2015 8:41 PM, Jake Oshins wrote: This patch adds some wrapper functions in the pnp layer. The intent is to allow memory address space claims by devices which are descendants (a child or grandchild of) a device which is already part of the pnp layer. This allows a device to make a

Re: [PATCH v6 13/22] power_supply: Change ownership from driver to core

2015-03-12 Thread Rafael J. Wysocki
/acpi/battery.c| 55 --- drivers/acpi/sbs.c| 68 + Assuming that it has got enough testing, Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com for the ACPI changes above. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source

Re: [PATCH v2] staging: board: Migrate away from __pm_genpd_name_add_device()

2015-09-08 Thread Rafael J. Wysocki
On Tuesday, September 08, 2015 12:06:53 PM Greg Kroah-Hartman wrote: > On Tue, Sep 08, 2015 at 07:06:03PM +0200, Geert Uytterhoeven wrote: > > The named genpd APIs are deprecated. Hence convert the board staging > > code from using genpd names to DT node paths. > > > > For now this supports PM

Re: [driver-core:driver-core-testing 2/6] drivers/built-in.o:undefined reference to `process_srcu'

2016-10-30 Thread Rafael J. Wysocki
On Friday, October 28, 2016 02:44:12 AM Greg Kroah-Hartman wrote: > On Fri, Oct 28, 2016 at 05:48:34AM +0800, kbuild test robot wrote: > > tree: > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > > driver-core-testing > > head:

Re: [PATCH v1 8/8] ACPI: Use recently introduced uuid_le_cmp_p{p}() helpers

2017-04-21 Thread Rafael J. Wysocki
On Friday, April 21, 2017 05:46:45 PM Andy Shevchenko wrote: > Recently introduced helpers take pointers to uuid_{be|le} instead of > reference. > > Using them makes code less ugly. > > Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> > Signed-of

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-26 Thread Rafael J. Wysocki
On Wednesday, July 26, 2017 01:03:03 PM Andy Shevchenko wrote: > On Wed, 2017-07-26 at 02:27 +0200, Rafael J. Wysocki wrote: > > On Wednesday, July 26, 2017 03:35:01 AM Andy Shevchenko wrote: > > > On Wed, Jul 26, 2017 at 3:21 AM, Rafael J. Wysocki <r...@rjwyso

Re: [PATCH 2/3] ACPI/DRM: rework ACPI_VIDEO Kconfig dependencies

2017-07-26 Thread Rafael J. Wysocki
; depends on INPUT > select THERMAL > + select BACKLIGHT_CLASS_DEVICE > + select BACKLIGHT_LCD_SUPPORT > + default y > help > This driver implements the ACPI Extensions For Display Adapters > for int

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-19 Thread Rafael J. Wysocki
On Wed, Jul 19, 2017 at 8:28 PM, Andy Shevchenko wrote: > There are new types and helpers that are supposed to be used in new code. > > As a preparation to get rid of legacy types and API functions do > the conversion here. Please talk to Mika about this one.

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-25 Thread Rafael J. Wysocki
do > > the conversion here. > > > > Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> > > Cc: Mika Westerberg <mika.westerb...@linux.intel.com> > > Acked-by: Mika Westerberg <mika.westerb...@linux.intel.com> OK Andy, do you want me to app

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-25 Thread Rafael J. Wysocki
On Wednesday, July 26, 2017 03:35:01 AM Andy Shevchenko wrote: > On Wed, Jul 26, 2017 at 3:21 AM, Rafael J. Wysocki <r...@rjwysocki.net> wrote: > > On Tuesday, July 25, 2017 05:12:35 PM Mika Westerberg wrote: > >> On Wed, Jul 19, 2017 at 09:28:57PM +030

Re: [PATCH] pci: Fix a possible sleep-in-atomic bug in pci_set_power_state

2017-10-09 Thread Rafael J. Wysocki
On Mon, Oct 9, 2017 at 7:18 PM, Bjorn Helgaas wrote: > On Mon, Oct 09, 2017 at 12:15:17PM -0500, Bjorn Helgaas wrote: >> [+cc Rafael, linux-pm] >> >> Hi Jia-Ju, >> >> On Mon, Oct 09, 2017 at 04:16:20PM +0800, Jia-Ju Bai wrote: >> > The drivers vt6655 and gma500 call

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-08-30 Thread Rafael J. Wysocki
On Wednesday, August 30, 2017 2:41:41 PM CEST Christoph Hellwig wrote: > On Wed, Jul 26, 2017 at 02:27:44AM +0200, Rafael J. Wysocki wrote: > > > >> > Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> > > > >> > Cc: Mika Westerberg <mika.we

Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2017-12-20 Thread Rafael J. Wysocki
} > > -static DEVICE_ATTR(power_state, 0444, power_state_show, NULL); > +static DEVICE_ATTR_RO(power_state); > > static ssize_t > acpi_eject_store(struct device *d, struct device_attribute *attr, > @@ -462,7 +462,7 @@ static ssize_t description_show(struct device *dev

Re: [PATCH RFC 1/2] drivers/base: export lock_device_hotplug/unlock_device_hotplug

2018-08-17 Thread Rafael J. Wysocki
On Fri, Aug 17, 2018 at 10:56 AM David Hildenbrand wrote: > > On 17.08.2018 10:41, Greg Kroah-Hartman wrote: > > On Fri, Aug 17, 2018 at 09:59:00AM +0200, David Hildenbrand wrote: > >> From: Vitaly Kuznetsov > >> > >> Well require to call add_memory()/add_memory_resource() with > >>

Re: [PATCH RFC 2/2] mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_lock

2018-08-17 Thread Rafael J. Wysocki
On Fri, Aug 17, 2018 at 9:59 AM David Hildenbrand wrote: > > There seem to be some problems as result of 30467e0b3be ("mm, hotplug: > fix concurrent memory hot-add deadlock"), which tried to fix a possible > lock inversion reported and discussed in [1] due to the two locks > a)

Re: [PATCH RFC 1/2] drivers/base: export lock_device_hotplug/unlock_device_hotplug

2018-08-17 Thread Rafael J. Wysocki
On Fri, Aug 17, 2018 at 10:41 AM Greg Kroah-Hartman wrote: > > On Fri, Aug 17, 2018 at 09:59:00AM +0200, David Hildenbrand wrote: > > From: Vitaly Kuznetsov > > > > Well require to call add_memory()/add_memory_resource() with > > device_hotplug_lock held, to avoid a lock inversion. Allow

Re: [PATCH v6 10/18] x86/power/64: Remove VLA usage

2018-08-06 Thread Rafael J. Wysocki
On Wednesday, July 25, 2018 8:01:47 PM CEST Kees Cook wrote: > On Wed, Jul 25, 2018 at 4:32 AM, Rafael J. Wysocki wrote: > > On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook wrote: > >> In the quest to remove all stack VLA usage from the kernel[1], this > >>

Re: [PATCH v6 10/18] x86/power/64: Remove VLA usage

2018-07-25 Thread Rafael J. Wysocki
On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to > shash directly and allocating the descriptor in heap memory (which should > be fine: the tfm has

Re: [PATCH 15/39] acpi/battery: simplify procfs code

2018-04-22 Thread Rafael J. Wysocki
Hellwig <h...@lst.de> It is OK AFAICS. Reviewed-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com> ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] sched/wait: introduce wait_event_freezable_hrtimeout

2019-01-21 Thread Rafael J. Wysocki
On Friday, January 18, 2019 5:04:50 PM CET Peter Zijlstra wrote: > On Fri, Jan 18, 2019 at 10:19:41AM -0500, Joel Fernandes wrote: > > You should document the variable names in the header comments. > > > > Also, this new API appears to conflict with definition of 'freezable' in > >

Re: [PATCH v1 8/8] PM / Hibernate: exclude all PageOffline() pages

2018-11-20 Thread Rafael J. Wysocki
On Monday, November 19, 2018 11:16:16 AM CET David Hildenbrand wrote: > The content of pages that are marked PG_offline is not of interest > (e.g. inflated by a balloon driver), let's skip these pages. > > Cc: "Rafael J. Wysocki" > Cc: Pavel Machek > Cc: Len Brow

Re: [PATCH v1 7/8] PM / Hibernate: use pfn_to_online_page()

2018-11-20 Thread Rafael J. Wysocki
On Monday, November 19, 2018 11:16:15 AM CET David Hildenbrand wrote: > Let's use pfn_to_online_page() instead of pfn_to_page() when checking > for saveable pages to not save/restore offline memory sections. > > Cc: "Rafael J. Wysocki" > Cc: Pavel Machek > Cc: Le

Re: [PATCH v1 1/6] mm/memory_hotplug: make remove_memory() take the device_hotplug_lock

2018-09-18 Thread Rafael J. Wysocki
t; Apart from that, there are not other users in the tree. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: Rashmica Gupta > Cc: Michael Neuling > Cc: Balbir Singh > Cc: Nathan Fontenot

Re: [PATCH v1 2/6] mm/memory_hotplug: make add_memory() take the device_hotplug_lock

2018-09-18 Thread Rafael J. Wysocki
_hotplug_lock is never > exported). > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: Greg Kroah-Hartman > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: Nathan Fontenot >

[PATCH] driver core: Add missing description of new struct device_link field

2019-02-21 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Commit 36003d4cf57c ("driver core: Fix PM-runtime for links added during consumer probe") forgot to add a kerneldoc decription for the new struct device_link member added by it, so do that now. Fixes: 36003d4cf57c ("driver core: Fix PM-runtime for lin

Re: [PATCH 10/10] docs: fix broken documentation links

2019-05-27 Thread Rafael J. Wysocki
On Mon, May 20, 2019 at 4:48 PM Mauro Carvalho Chehab wrote: > > Mostly due to x86 and acpi conversion, several documentation > links are still pointing to the old file. Fix them. > > Signed-off-by: Mauro Carvalho Chehab For the ACPI part: Acked-by: Ra

Re: [PATCH 1/7] PCI/PM: Always return devices to D0 when thawing

2019-10-15 Thread Rafael J. Wysocki
https://lore.kernel.org/r/ku1p153mb016637caead346f0aa8e3801bf...@ku1p153mb0166.apcp153.prod.outlook.com > Signed-off-by: Dexuan Cui > Signed-off-by: Bjorn Helgaas > Cc: sta...@vger.kernel.org# v4.13+ No issues found, so Reviewed-by: Rafael J. Wysocki > --- > drivers/pci/pci-d

Re: [PATCH 3/7] PCI/PM: Clear PCIe PME Status even for legacy power management

2019-10-15 Thread Rafael J. Wysocki
ments new power management, so > this change is just on principle, not to fix any actual defects. > > Fixes: a39bd851dccf ("PCI/PM: Clear PCIe PME Status bit in core, not PCIe > port driver") > Signed-off-by: Bjorn Helgaas This is a reasonable change in my view, so Reviewed-by: Ra

Re: [PATCH 4/7] PCI/PM: Run resume fixups before disabling wakeup events

2019-10-15 Thread Rafael J. Wysocki
> Signed-off-by: Bjorn Helgaas No concerns about this change, so Reviewed-by: Rafael J. Wysocki > --- > drivers/pci/pci-driver.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c > index 0c3086793e4e

Re: [PATCH 7/7] PCI/MSI: Move power state check out of pci_msi_supported()

2019-10-15 Thread Rafael J. Wysocki
power state check back into the callers for readability. No > functional change intended. > > Signed-off-by: Bjorn Helgaas No issues found, so Reviewed-by: Rafael J. Wysocki > --- > drivers/pci/msi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a

Re: [PATCH 2/7] PCI/PM: Correct pci_pm_thaw_noirq() documentation

2019-10-15 Thread Rafael J. Wysocki
e documentation to match the code. > > Signed-off-by: Bjorn Helgaas Right, the documentation is outdated, so Reviewed-by: Rafael J. Wysocki > --- > Documentation/power/pci.rst | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation

Re: [PATCH 6/7] PCI/PM: Wrap long lines in documentation

2019-10-15 Thread Rafael J. Wysocki
off-by: Bjorn Helgaas Well, looks better this way. :-) Reviewed-by: Rafael J. Wysocki > --- > Documentation/power/pci.rst | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/Documentation/power/pci.rst b/Documentatio

Re: [PATCH 5/7] PCI/PM: Make power management op coding style consistent

2019-10-15 Thread Rafael J. Wysocki
're all consistent. Remove > local "error" variables when unnecessary. No functional change intended. > > Signed-off-by: Bjorn Helgaas No issues found, so Reviewed-by: Rafael J. Wysocki > --- > drivers/pci/pci-driver.c | 76 +++- >

Re: [PATCH v2] PCI: PM: Move to D0 before calling pci_legacy_resume_early()

2019-10-10 Thread Rafael J. Wysocki
On 10/8/2019 9:56 PM, Bjorn Helgaas wrote: On Tue, Oct 08, 2019 at 07:32:27PM +0200, Rafael J. Wysocki wrote: On 10/7/2019 8:57 PM, Dexuan Cui wrote: -Original Message- From: Bjorn Helgaas Sent: Monday, October 7, 2019 6:24 AM To: Dexuan Cui Cc: lorenzo.pieral...@arm.com; linux

Re: [PATCH v2] PCI: PM: Move to D0 before calling pci_legacy_resume_early()

2019-10-08 Thread Rafael J. Wysocki
On 10/7/2019 8:57 PM, Dexuan Cui wrote: -Original Message- From: Bjorn Helgaas Sent: Monday, October 7, 2019 6:24 AM To: Dexuan Cui Cc: lorenzo.pieral...@arm.com; linux-...@vger.kernel.org; Michael Kelley ; linux-hyp...@vger.kernel.org; linux-ker...@vger.kernel.org;

Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-21 Thread Rafael J. Wysocki
On Wednesday, May 20, 2020 5:02:30 PM CEST Dan Carpenter wrote: > On Wed, May 20, 2020 at 01:15:44PM +0300, Dmitry Osipenko wrote: > > 20.05.2020 12:51, Dinghao Liu пишет: > > > pm_runtime_get_sync() increments the runtime PM usage counter even > > > it returns an error code. Thus a pairing

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-28 Thread Rafael J. Wysocki
gt; On Thu, May 21, 2020 at 08:39:02PM +0300, Dan Carpenter wrote: > > > > > On Thu, May 21, 2020 at 05:22:05PM +0200, Rafael J. Wysocki wrote: > > > > > > On Thu, May 21, 2020 at 11:15 AM Dan Carpenter > > > > > > wrote: > >

Re: Re: [PATCH] media: staging: tegra-vde: fix runtime pm imbalance on error

2020-05-21 Thread Rafael J. Wysocki
On Thu, May 21, 2020 at 11:15 AM Dan Carpenter wrote: > > On Thu, May 21, 2020 at 11:42:55AM +0800, dinghao@zju.edu.cn wrote: > > Hi, Dan, > > > > I agree the best solution is to fix __pm_runtime_resume(). But there are > > also > > many cases that assume pm_runtime_get_sync() will change PM

Re: [PATCH v3 3/7] drivers/acpi: convert seqno to use seqnum_ops

2021-02-04 Thread Rafael J. Wysocki
Hi Shuah, First off, please indicate the component in the subject, for example: "ACPI: extlog: convert seqno to use seqnum_ops" On Wed, Feb 3, 2021 at 7:12 PM Shuah Khan wrote: > > Sequence Number api provides interfaces for unsigned atomic up counters > leveraging atomic_t and atomic64_t ops

Re: [PATCH v1 0/9] x86/platform: Remove SFI framework and users

2021-02-11 Thread Rafael J. Wysocki
On Thu, Feb 11, 2021 at 2:50 PM Andy Shevchenko wrote: > > This is last part of Intel MID (SFI based) removal. We have no more users of > it > in the kernel and since SFI has been marked Obsolete for a few years already, > Remove all the stuff altogether. > > Note, the more recent platforms

Re: [PATCH v1 0/9] x86/platform: Remove SFI framework and users

2021-02-15 Thread Rafael J. Wysocki
On Thu, Feb 11, 2021 at 4:45 PM Hans de Goede wrote: > > Hi, > > On 2/11/21 4:24 PM, Rafael J. Wysocki wrote: > > On Thu, Feb 11, 2021 at 2:50 PM Andy Shevchenko > > wrote: > >> > >> This is last part of Intel MID (SFI based) removal. We have no