Re: [PATCH 01/15] [media] Move mediabus format definition to a more standard place

2014-11-05 Thread Sakari Ailus
or not. There is for enums, too, but it results in a compilation error... -- Regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev

Re: [PATCH 02/15] [media] v4l: Update subdev-formats doc with new MEDIA_BUS_FMT values

2014-11-05 Thread Sakari Ailus
? MEDIA_BUS_TO_V4L2_MBUS(Y8_1X8), MEDIA_BUS_TO_V4L2_MBUS(UV8_1X8), -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk ___ devel mailing list de...@linuxdriverproject.org http

Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode

2014-11-05 Thread Sakari Ailus
+++ include/uapi/linux/v4l2-mediabus.h | 26 -- I would keep the original file name, even if the compatibility definitions are there. I don't see any harm in having them around as well. -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

Re: [PATCH 03/15] [media] Make use of the new media_bus_format definitions

2014-11-05 Thread Sakari Ailus
On Tue, Nov 04, 2014 at 10:54:58AM +0100, Boris Brezillon wrote: Replace references to the v4l2_mbus_pixelcode enum with the new media_bus_format enum in all common headers. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Sakari Ailus sakari.ai...@linux.intel.com

Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode

2014-11-05 Thread Sakari Ailus
Hi Boris, On Wed, Nov 05, 2014 at 04:15:38PM +0100, Boris Brezillon wrote: On Wed, 5 Nov 2014 17:08:15 +0200 Sakari Ailus sakari.ai...@iki.fi wrote: I would keep the original file name, even if the compatibility definitions are there. I don't see any harm in having them around as well

Re: [PATCH v2 01/10] [media] Move mediabus format definition to a more standard place

2014-11-07 Thread Sakari Ailus
on the media bus -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 01/10] [media] Move mediabus format definition to a more standard place

2014-11-07 Thread Sakari Ailus
, + V4L2_MBUS_FROM_MEDIA_BUS_FMT(S5C_UYVY_JPEG_1X8), - /* HSV - next is 0x6002 */ - V4L2_MBUS_FMT_AHSV_1X32 = 0x6001, + V4L2_MBUS_FROM_MEDIA_BUS_FMT(AHSV_1X32), }; /** -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

Re: [PATCH v4 10/10] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel

2014-11-07 Thread Sakari Ailus
? I'd put this to beginning of the file, as Hans suggested. With this matter sorted out, for the set: Acked-by: Sakari Ailus sakari.ai...@linux.intel.com -- Kind regards, Sakari Ailus sakari.ai...@iki.fi ___ devel mailing list de

Re: [PATCH 1/6] v4l: omap4iss: Add support for OMAP4 camera interface - Core

2013-10-05 Thread Sakari Ailus
to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk ___ devel mailing list de...@linuxdriverproject.org http

Re: [PATCH RFC v3 07/16] media: get rid of unused extra_links param on media_entity_init()

2015-08-14 Thread Sakari Ailus
*source, u16 source_pad, How about putting this in front of the set? It has no dependencies to the other patches, does it? Acked-by: Sakari Ailus sakari.ai...@linux.intel.com -- Regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-10-11 Thread Sakari Ailus
V) > + if (!pad || !is_media_entity_v4l2_subdev(pad->entity)) > break; > > entity = pad->entity; > diff --git a/drivers/staging/media/omap4iss/iss_video.c > b/drivers/staging/media/omap4iss/iss_video.c > index 45a3f2d778fc

[PATCH 1/1] media: Correctly determine whether an entity is a sub-device

2015-10-12 Thread Sakari Ailus
If the function of an entity is not one of the pre-defined ones, it is not correctly recognised as a V4L2 sub-device. Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> --- include/media/media-entity.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/media/media-enti

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-10-12 Thread Sakari Ailus
Hi Mauro, On Sun, Oct 11, 2015 at 09:56:25PM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 12 Oct 2015 00:07:52 +0300 > Sakari Ailus <sakari.ai...@iki.fi> escreveu: > > > Hi Mauro, > > > > On Sun, Aug 30, 2015 at 12:06:43AM -0300, Mauro Carvalho Chehab wrote:

Re: [PATCH] [media] media: davinci_vpfe: fix missing unlock on error in vpfe_prepare_pipeline()

2016-02-07 Thread Sakari Ailus
mutex); Oh dear. I wonder how could this have happened... thanks for the fix! I've applied this to my tree. > return -ENOMEM; > } > media_entity_graph_walk_start(, entity); > -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sa

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-14 Thread Sakari Ailus
ggested-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> What's the use case for calling the above functions in an atomic context? -- Regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk ___ devel m

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-14 Thread Sakari Ailus
Hi Mauro, On Mon, Mar 14, 2016 at 07:13:58AM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 14 Mar 2016 09:22:37 +0200 > Sakari Ailus <sakari.ai...@iki.fi> escreveu: > > > Hi Shuah, > > > > On Sat, Mar 12, 2016 at 06:48:09PM -0700, Shuah Khan wrote: > > &

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-14 Thread Sakari Ailus
Hi Mauro, On Mon, Mar 14, 2016 at 08:46:33AM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 14 Mar 2016 12:52:54 +0200 > Sakari Ailus <sakari.ai...@iki.fi> escreveu: > > > Hi Mauro, > > > > On Mon, Mar 14, 2016 at 07:13:58AM -0300, Mauro Carvalho Chehab wrote: &

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-16 Thread Sakari Ailus
Hi Mauro, On Tue, Mar 15, 2016 at 12:55:35PM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 14 Mar 2016 14:09:09 +0200 > Sakari Ailus <sakari.ai...@iki.fi> escreveu: > > > Hi Mauro, > > > > On Mon, Mar 14, 2016 at 08:46:33AM -0300, Mauro Carvalho Chehab wrote: &

Re: [PATCH] [media] media: rename media unregister function

2016-03-18 Thread Sakari Ailus
make the change > to add _cleanup() at the end of media_device_unregister(). It can be handled > in API documentation that it does both. I think that's a bad idea. People will only read the documentation when something doesn't work. In this case it's easy to miss that. -- Sakari Ailus saka

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-07 Thread Sakari Ailus
port@0 { > + reg = <0>; > + > + mux_in0: endpoint { > + remote-endpoint = <_source0_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; >

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-07 Thread Sakari Ailus
> > > > of operation (such as the parallel bus case described above) we need to > > > > make that information discoverable at runtime. Maybe this should be > > > > considered as related to Sakari's efforts to support VC/DT for CSI-2, > > > > and >

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-18 Thread Sakari Ailus
Hi Philipp and Russell, On Fri, Feb 17, 2017 at 04:04:30PM +0100, Philipp Zabel wrote: > On Fri, 2017-02-17 at 14:22 +0200, Sakari Ailus wrote: > > Hi Philipp, Steve and Russell, > > > > On Fri, Feb 17, 2017 at 12:43:38PM +0100, Philipp Zabel wrote: > > > On Thu, 20

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-17 Thread Sakari Ailus
to transfer to LP-11 state? That appears to be the last step which is done in the csi2_s_stream() callback. What the sensor does next is to start streaming, and the first thing it does in that process is to switch to LP-11 state. Have you tried what happens if you simply dro

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-16 Thread Sakari Ailus
ilable, until FSL/NXP issues a new silicon rev. > > > > Can't the driver derive a clock from some irq and calculate for > >each frame if the timing was correct ? > > That's what is being done, essentially. > > > And if not m

Re: [PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

2017-03-16 Thread Sakari Ailus
On Sat, Mar 11, 2017 at 12:31:24PM -0800, Steve Longerbeam wrote: > > > On 03/11/2017 05:41 AM, Sakari Ailus wrote: > >Hi Steve, > > > >On Thu, Mar 09, 2017 at 08:52:58PM -0800, Steve Longerbeam wrote: > >>If the pads on both sides of a link specify a

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-17 Thread Sakari Ailus
rovide an excuse for not having libraries available to help the user to configure and control the device more or less automatically even in terms of best effort. It's something that does require attention, a lot more of it than it has received in recent few years. -- Kind regards, Sa

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

2017-04-04 Thread Sakari Ailus
(IS_ERR(vidsw->field)) { > + dev_err(>dev, "Failed to allocate regmap > field\n"); > + return PTR_ERR(vidsw->field); > + } > + > + regmap_field_read(vidsw->field, >active); > + } else { > +

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

2017-04-12 Thread Sakari Ailus
Hi Steve, On Tue, Apr 11, 2017 at 05:50:58PM -0700, Steve Longerbeam wrote: > > > On 04/04/2017 05:47 AM, Sakari Ailus wrote: > >Hi Steve, Philipp and Pavel, > > > >On Mon, Mar 27, 2017 at 05:40:34PM -0700, Steve Longerbeam wrote: > >>From: P

Re: [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

2017-03-03 Thread Sakari Ailus
e these patches based on? -- Regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-03 Thread Sakari Ailus
Hi Steve, On Thu, Mar 02, 2017 at 06:12:43PM -0800, Steve Longerbeam wrote: > > > On 03/02/2017 03:48 PM, Steve Longerbeam wrote: > > > > > >On 03/02/2017 08:02 AM, Sakari Ailus wrote: > >>Hi Steve, > >> > >>On Wed, Fe

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

2017-03-04 Thread Sakari Ailus
Hi Steve, On Fri, Mar 03, 2017 at 02:43:51PM -0800, Steve Longerbeam wrote: > > > On 03/03/2017 03:45 AM, Sakari Ailus wrote: > >On Thu, Mar 02, 2017 at 03:07:21PM -0800, Steve Longerbeam wrote: > >> > >> > >>On 03/02/2017 07:53 AM, Sakari Ailus wrote

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-04 Thread Sakari Ailus
Hi Russell, On Fri, Mar 03, 2017 at 11:06:45PM +, Russell King - ARM Linux wrote: > On Thu, Mar 02, 2017 at 06:02:57PM +0200, Sakari Ailus wrote: > > Hi Steve, > > > > On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote: > > > v4l2_pipeline_inheri

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-11 Thread Sakari Ailus
; > This way, if the subdev API is disabled, the driver will be > > > functional for V4L2-based applications that don't support neither > > > MC or subdev APIs. > > > > I'm not sure if it makes sense for the i.MX driver to behave differ

Re: [PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

2017-03-11 Thread Sakari Ailus
t sub-devices adds no value or is not the interface through which it the frame rate configured, I think it is overkill to change the link validation to expect otherwise. -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk __

Re: [PATCH v5 21/39] UAPI: Add media UAPI Kbuild file

2017-03-11 Thread Sakari Ailus
rectory instead? I actually wouldn't really object doing this but it should have been done in 2002 or so when the first V4L2 header was added. Now the benefit is questionable. -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk __

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-13 Thread Sakari Ailus
Hi Mauro, On Sat, Mar 11, 2017 at 08:25:49AM -0300, Mauro Carvalho Chehab wrote: > Em Sat, 11 Mar 2017 00:37:14 +0200 > Sakari Ailus <sakari.ai...@iki.fi> escreveu: > > > Hi Mauro (and others), > > > > On Fri, Mar 10, 2017 at 12:53:42PM -0300, Mauro Carvalho C

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-03-13 Thread Sakari Ailus
dation either: link validation should only include static properties of the link that are required for correct hardware operation. Frame rate is not such property: hardware that supports the MC interface generally does not recognise such concept (with the exce

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Sakari Ailus
or example, for the UVC driver. There, MC > is optional, as it should be. UVC is different. The device simply provides additional information through MC to the user but MC (or V4L2 sub-device interface) is not used for controlling the device. -- Kind regards, Sakari Ailus e-mail:

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-03-13 Thread Sakari Ailus
Hi Steve, On Mon, Mar 13, 2017 at 11:06:22AM -0700, Steve Longerbeam wrote: > > > On 03/13/2017 06:55 AM, Philipp Zabel wrote: > >On Mon, 2017-03-13 at 13:27 +, Russell King - ARM Linux wrote: > >>On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-03-13 Thread Sakari Ailus
Hi Russell, On Mon, Mar 13, 2017 at 01:27:02PM +, Russell King - ARM Linux wrote: > On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote: > > The vast majority of existing drivers do not implement them nor the user > > space expects having to set them. Making that

Re: [PATCH 12/29] drivers, media: convert s2255_dev.num_channels from atomic_t to refcount_t

2017-03-07 Thread Sakari Ailus
of four (4). I'd leave this driver using atomic_t. > v4l2_info(>v4l2_dev, "V4L2 device registered as %s\n", > video_device_node_name(>vdev)); > -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XM

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

2017-03-07 Thread Sakari Ailus
> situations. > > Signed-off-by: Elena Reshetova <elena.reshet...@intel.com> > Signed-off-by: Hans Liljestrand <ishkam...@gmail.com> > Signed-off-by: Kees Cook <keesc...@chromium.org> > Signed-off-by: David Windsor <dwind...@gmail.com> Acked-by: Sakari Ai

Re: [PATCH 13/29] drivers, media: convert vb2_vmarea_handler.refcount from atomic_t to refcount_t

2017-03-07 Thread Sakari Ailus
t of a memory type specific struct, the types that you change in the following three patches. I guess it would still compile and work as separate patches but you'd sure get warnings at least. How about merging this and the three following patches that change the memop refcount types? >

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

2017-03-05 Thread Sakari Ailus
On Sat, Mar 04, 2017 at 04:37:43PM -0800, Steve Longerbeam wrote: > > > On 03/04/2017 02:56 AM, Sakari Ailus wrote: > >Hi Steve, > > > >On Fri, Mar 03, 2017 at 02:43:51PM -0800, Steve Longerbeam wrote: > >> > >> > >>On 03/03/2017 03:45 AM,

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

2017-03-03 Thread Sakari Ailus
On Thu, Mar 02, 2017 at 03:07:21PM -0800, Steve Longerbeam wrote: > > > On 03/02/2017 07:53 AM, Sakari Ailus wrote: > >Hi Steve, > > > >On Wed, Feb 15, 2017 at 06:19:15PM -0800, Steve Longerbeam wrote: > >>Add a new FRAME_TIMEOUT event to signal that a vi

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

2017-03-02 Thread Sakari Ailus
gt; @@ -2132,6 +2132,7 @@ struct v4l2_streamparm { > #define V4L2_EVENT_FRAME_SYNC4 > #define V4L2_EVENT_SOURCE_CHANGE 5 > #define V4L2_EVENT_MOTION_DET6 > +#define V4L2_EVENT_FRAME_TIMEOUT 7 > #define

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-02 Thread Sakari Ailus
dia_source(struct > vb2_queue *q) > return 0; > } > > +static inline int __v4l2_pipeline_inherit_controls( > + struct video_device *vfd, > + struct media_entity *start_entity) > +{ > + return 0; > +} >

[PATCH v3.2 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators

2017-08-15 Thread Sakari Ailus
driver chip that drives a single flash LED and an indicator LED is no longer valid. Address the matter by registering one sub-device per LED. Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Reviewed-by: Jacek Anaszewski <jacek.anaszew...@gmail.com> Acked-by: Pavel Machek &

[PATCH v3.1 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators

2017-08-15 Thread Sakari Ailus
driver chip that drives a single flash LED and an indicator LED is no longer valid. Address the matter by registering one sub-device per LED. Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Reviewed-by: Jacek Anaszewski <jacek.anaszew...@gmail.com> Acked-by: Pavel Machek &

[PATCH v3 3/3] v4l2-flash-led-class: Document v4l2_flash_init() references

2017-08-10 Thread Sakari Ailus
The v4l2_flash_init() keeps a reference to the ops struct but not to the config struct (nor anything it contains). Document this. Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Acked-by: Pavel Machek <pa...@ucw.cz> Acked-by: Hans Verkuil <hans.verk...@cisco.com>

[PATCH v3 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators

2017-08-10 Thread Sakari Ailus
driver chip that drives a single flash LED and an indicator LED is no longer valid. Address the matter by registering one sub-device per LED. Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Reviewed-by: Jacek Anaszewski <jacek.anaszew...@gmail.com> Acked-by: Pavel Machek &

[PATCH v3 0/3] Create sub-device per LED

2017-08-10 Thread Sakari Ailus
tor" already in mediatree. - Add "v4l2-flash-led-class: Document v4l2_flash_init() references" to the set. Rui Miguel Silva (1): staging: greybus: light: fix memory leak in v4l2 register Sakari Ailus (2): v4l2-flash-led-class: Create separate sub-devices for indicators

[PATCH v3 1/3] staging: greybus: light: fix memory leak in v4l2 register

2017-08-10 Thread Sakari Ailus
e from v4l2_flash_init() for it never returns NULL. Fixes: 2870b52bae4c ("greybus: lights: add lights implementation") Reported-by: Sakari Ailus <sakari.ai...@linux.intel.com> Signed-off-by: Rui Miguel Silva <rmf...@gmail.com> Reviewed-by: Viresh Kumar <viresh.ku...@linaro.o

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

2017-08-09 Thread Sakari Ailus
Hi Rui, On Wed, Aug 09, 2017 at 02:20:02PM +0100, Rui Miguel Silva wrote: > Hi Sakari, > On Wed, Aug 09, 2017 at 02:15:53PM +0300, Sakari Ailus wrote: > > From: Rui Miguel Silva <rmf...@gmail.com> > > > > We are allocating memory for the v4l2 flash config

Re: [PATCH] Subject: drivers:staging:media:atomisp:12c:ab1302.c fix CHECK

2017-08-10 Thread Sakari Ailus
ady includes a copy of the GPL. Applied, with the subject line changed to "staging: media: atomisp: ap1302: Remove FSF postal address" and "CHECK: " removed. Please look e.g. git log on the atomisp driver for subject examples in the future. Thanks. -- Sakari Ailus e-mail: s

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

2017-08-10 Thread Sakari Ailus
_flash_ops, _cfg); > > + if (IS_ERR_OR_NULL(light->v4l2_flash)) > > Just IS_ERR since v4l2_flash_init() never returns NULL. Will fix. > > > + return PTR_ERR(light->v4l2_flash); > > > > - return ret; > >

Re: [PATCH] Subject:drivers:staging:media:atomisp:

2017-08-10 Thread Sakari Ailus
* The metadata contains exposure settings and face > + * detection results. > + */ /* * Multi-line comments * look like this. */ > static u16 ap1302_ss_list[] = { > 0xb01c, /* From 0x0186 with size 0x1C are exposure settings. */ > 0x0186, > -- >

Re: [PATCH] Subject:staging:media:atomisp:ap1302: fix comments style

2017-08-10 Thread Sakari Ailus
ver, please submit them as a single patch instead. And do continue paying attention to commit message subject and body. Thanks. -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk ___ devel mailing list de...@linuxdriv

Re: [PATCH v2 2/2] staging: atomisp2: hmm: Alignment code (rebased)

2017-07-13 Thread Sakari Ailus
lipp.guendi...@fau.de> > Signed-off-by: Chris Baller <chris.bal...@gmx.de> Hi Philipp, Neither of the patches still applies? Are you sure you rebased them on the atomisp branch? -- Regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk

Re: [PATCH v2] staging: atomisp: use kstrdup to replace kmalloc and memcpy

2017-07-09 Thread Sakari Ailus
On Sun, Jul 09, 2017 at 05:56:15PM +0530, hari prasath wrote: > On 8 July 2017 at 16:31, Sakari Ailus <sakari.ai...@iki.fi> wrote: > > Hi Hari, > > > > On Fri, Jul 07, 2017 at 08:15:21PM +0530, Hari Prasath wrote: > >> kstrdup kernel primitive can be used to rep

Re: [PATCH 1/2] staging: atomisp2: hmm: Fixed comment style

2017-07-11 Thread Sakari Ailus
p> Could you rebase yours on top of that, please? -- Regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2] staging: atomisp: use kstrdup to replace kmalloc and memcpy

2017-07-08 Thread Sakari Ailus
. I believe the caller(s) expect to get errors in the IA_CCS_ERR_* range. > bd->name = fw_minibuffer[index].name = namebuffer; > } else { > bd->name = name; -- Regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@r

Re: [PATCH] staging: atomisp: gc0310: constify acpi_device_id.

2017-07-08 Thread Sakari Ailus
t; > +static const struct acpi_device_id gc0310_acpi_match[] = { > >   {"XXGC0310"}, > >   {}, > >  }; > > (All four) > > Acked-by: Alan Cox <a...@linux.intel.com> There's four more... I've applied all to my atomisp bra

Re: [PATCH v2 2/2] staging: atomisp2: hmm: Alignment code (rebased)

2017-07-17 Thread Sakari Ailus
On Thu, Jul 13, 2017 at 09:26:50PM +0200, Philipp wrote: > > > On 13. Jul 2017, at 17:45, Sakari Ailus <sakari.ai...@iki.fi> wrote: > > > > On Thu, Jul 13, 2017 at 08:55:43AM +0200, Philipp Guendisch wrote: > >> This patch fixed code alignment to op

Re: [PATCH] staging: greybus: light: fix memory leak in v4l2 register

2017-08-09 Thread Sakari Ailus
: lights: add lights implementation") > Reported-by: Sakari Ailus <sakari.ai...@linux.intel.com> > Signed-off-by: Rui Miguel Silva <rmf...@gmail.com> My apologies for missing sending the original patch to the appropriate recipients the first time. Could I take t

[PATCH v2 0/3] Create sub-device per LED

2017-08-09 Thread Sakari Ailus
4l2-flash-led-class: Document v4l2_flash_init() references" to the set. Rui Miguel Silva (1): staging: greybus: light: fix memory leak in v4l2 register Sakari Ailus (2): v4l2-flash-led-class: Create separate sub-devices for indicators v4l2-flash-led-class: Document v4l2_fla

[PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

2017-08-09 Thread Sakari Ailus
") Reported-by: Sakari Ailus <sakari.ai...@linux.intel.com> Signed-off-by: Rui Miguel Silva <rmf...@gmail.com> Reviewed-by: Viresh Kumar <viresh.ku...@linaro.org> --- drivers/staging/greybus/light.c | 29 + 1 file changed, 9 insertions(+), 20 deletion

[PATCH v2 3/3] v4l2-flash-led-class: Document v4l2_flash_init() references

2017-08-09 Thread Sakari Ailus
The v4l2_flash_init() keeps a reference to the ops struct but not to the config struct (nor anything it contains). Document this. Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Acked-by: Pavel Machek <pa...@ucw.cz> --- include/media/v4l2-flash-led-class.h | 6 ++ 1

Re: [PATCH] media: staging: atomisp: sh_css_calloc shall return a pointer to the allocated space

2017-08-08 Thread Sakari Ailus
; > Bug added by commit da22013f7df4 ("atomisp: remove indirection from > sh_css_malloc") > > These wrappers should really be deleted. Applied, with the appropriate Fixes: header. Thanks! -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk ___

Re: [PATCH 2/5] [media] atomisp: constify videobuf_queue_ops structures

2017-08-08 Thread Sakari Ailus
e with the help of Coccinelle. Thanks. I'm picking this one up (for atomisp). -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/lis

Re: [PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver

2017-05-29 Thread Sakari Ailus
Hi Steve, A few comments below. On Wed, May 24, 2017 at 05:29:31PM -0700, Steve Longerbeam wrote: > This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta > branch, modified heavily to bring forward to latest interfaces and code > cleanup. > > Signed-off-by: Steve

Re: [PATCH v7 00/34] i.MX Media Driver

2017-05-29 Thread Sakari Ailus
ode in its media device link_setup callback, among other things. I don't think that this as such should prevent including the driver in staging, but at the same time my concern is what kind of guarantees can we give in terms of V4L2 framework support on things like this using the current API. I'd say &q

Re: [PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver

2017-05-30 Thread Sakari Ailus
UPPLIES, sensor->supplies); > >Should this still be here? > > > >>+ return ret; > >>+} > >>+ > >>+static int ov5640_remove(struct i2c_client *client) > >>+{ > >>+ struct v4l2_subdev *sd = i2c_get_clientdata(client); > >>+ struct ov564

Re: [PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver

2017-06-03 Thread Sakari Ailus
ng else? Pavel: we do need to make sure the user space will be able to know the unit, too. It's rather a case with a number of controls: the unit is known but there's no API to convey it to the user. The exposure is a bit special, too: granularity matters a lot on small values. On most other con

Re: [PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver

2017-06-07 Thread Sakari Ailus
On Sun, Jun 04, 2017 at 11:00:14AM -0700, Steve Longerbeam wrote: > > > On 06/03/2017 11:02 AM, Steve Longerbeam wrote: > >Hi Sakari, > > > > > >On 05/29/2017 11:56 PM, Sakari Ailus wrote: > >>Hi Steve, > >> > >>On M

Re: [PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver

2017-06-07 Thread Sakari Ailus
On Sat, Jun 03, 2017 at 09:46:36PM -0700, Steve Longerbeam wrote: > > > On 06/03/2017 02:57 PM, Sakari Ailus wrote: > >On Sat, Jun 03, 2017 at 09:51:39PM +0200, Pavel Machek wrote: > >>Hi! > >> > >>>>>>+ /* Auto/manual exposure */ &g

Re: [PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver

2017-06-01 Thread Sakari Ailus
>exposure = v4l2_ctrl_new_std(hdl, ops, > > + V4L2_CID_EXPOSURE_ABSOLUTE, > > + 0, 65535, 1, 0); > > Is exposure_absolute supposed to be in microseconds...? Yes. OTOH V4L2_CID_EXPOSURE has no defined unit, so it's a bett

Re: [PATCH v8 17/34] [media] add Omnivision OV5640 sensor driver

2017-06-10 Thread Sakari Ailus
al_channel, int, 0); > +MODULE_PARM_DESC(virtual_channel, > + "MIPI CSI-2 virtual channel (0..3), default 0"); If this works for you it's a good workaround. I hope we can address the matter properly soon --- it's related to data types, embedded data etc. For the patch:

Re: [PATCH] Staging: media: atomisp: Merge assignment with return

2017-09-18 Thread Sakari Ailus
ommit message (subject line) at least. This case is a bit special because the other driver is also specific to the atomisp staging driver. Thanks. -- Sakari Ailus e-mail: sakari.ai...@iki.fi ___ devel mailing list de...@linuxdriverproject.org http://d

Re: [PATCH v2] [media] staging: atomisp: use clock framework for camera clocks

2017-09-22 Thread Sakari Ailus
.intel.com> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> I've applied the patch with small changes, there were other patches changing the deleted files. The tree is here: <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=atomi

Re: [PATCH v4] staging: atomisp: add a driver for ov5648 camera sensor

2017-10-10 Thread Sakari Ailus
mework or sensor driver changes to support atomisp, which currently is a staging driver. -- Sakari Ailus sakari.ai...@linux.intel.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] stagin: atomisp: Fix oops by unbalanced clk enable/disable call

2017-10-17 Thread Sakari Ailus
> > + > > if (on) { > > ret = clk_set_rate(gs->pmc_clk, gs->clock_src); > > Which tree [and branch] are you working off please? In the staging-next > branch of Greg's staging > tree this function does not appear as it is in this patch. Media

Re: [PATCH] staging/atomisp: Convert timers to use timer_setup()

2017-10-17 Thread Sakari Ailus
ev.osuosl.org > Signed-off-by: Kees Cook <keesc...@chromium.org> This appears to be the same as the patch I've applied previously. -- Sakari Ailus e-mail: sakari.ai...@iki.fi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 0/2] staging: atomisp: memory allocation cleanups

2017-10-17 Thread Sakari Ailus
e branch. Could you rebase your patches on this branch, please? <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=atomisp-next> Normally it'll be "atomisp". -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi ___ deve

Re: [PATCH] staging/atomisp: Convert timers to use timer_setup()

2017-10-17 Thread Sakari Ailus
On Tue, Oct 17, 2017 at 08:16:03AM -0700, Kees Cook wrote: > On Tue, Oct 17, 2017 at 1:23 AM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > > On Mon, Oct 16, 2017 at 04:24:56PM -0700, Kees Cook wrote: > >> In preparation for unconditionally passing the struct timer_list p

Re: [PATCH 0/2] staginng: atomisp: memory allocation cleanups

2017-10-13 Thread Sakari Ailus
?h=atomisp> -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: atomisp: add a driver for ov5648 camera sensor

2017-09-11 Thread Sakari Ailus
Hi Devid, Please see my comments below. Andy: please look for "INT5648". On Sun, Sep 10, 2017 at 02:23:07PM +0200, Devid Antonio Floni wrote: > The ov5680 5-megapixel camera sensor from OmniVision supports up to 2592x1944 > resolution and MIPI CSI-2 interface. Output format is raw sRGB/Bayer

Re: [PATCH] Staging: atomisp: fix alloc_cast.cocci warnings

2017-09-11 Thread Sakari Ailus
GFP_KERNEL); > if (parambuf == NULL) > return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY; -- Sakari Ailus e-mail: sakari.ai...@iki.fi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-29 Thread Sakari Ailus
Hi Mauro, (Removing the non-list recipients.) On Fri, Sep 29, 2017 at 06:27:13AM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 28 Sep 2017 15:09:21 +0300 > Sakari Ailus <sakari.ai...@iki.fi> escreveu: > > > Hi Mauro, > > > > On Wed, Sep 27, 2017 at 06:46:56PM -

Re: [PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Sakari Ailus
roperty API is just an API. -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [RESEND PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Sakari Ailus
roperty API is just an API. -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [RESEND PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-09-28 Thread Sakari Ailus
roperty API is just an API. -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: atomisp: constify v4l2_subdev_sensor_ops

2017-08-27 Thread Sakari Ailus
;julia.law...@lip6.fr> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> -- Sakari Ailus e-mail: sakari.ai...@iki.fi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4] staging: atomisp: add a driver for ov5648 camera sensor

2017-10-06 Thread Sakari Ailus
g this patch at least until the other drivers are available. Andy, Alan; any opinion? -- Kind regards, Sakari Ailus sakari.ai...@linux.intel.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V3 22/29] [media] atomisp: deprecate pci_get_bus_and_slot()

2017-11-29 Thread Sakari Ailus
lying the rest of the patch. Please use the media tree as the base in the future. Thanks. -- Sakari Ailus e-mail: sakari.ai...@iki.fi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 0/3] Sparse fixes for the Atom ISP Staging Driver

2017-11-29 Thread Sakari Ailus
> .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 24 > +++--- > .../isp_param/interface/ia_css_isp_param_types.h | 2 +- > 2 files changed, 13 insertions(+), 13 deletions(-) Thanks, applied! -- Sakari Ailus e-mail: sakari.ai...@iki.fi

Re: [PATCH 3/3] media: staging: atomisp: prefer s16 to int16_t.

2017-11-29 Thread Sakari Ailus
On Mon, Nov 27, 2017 at 11:30:54AM +, Jeremy Sowden wrote: > Signed-off-by: Jeremy Sowden <jer...@azazel.net> I'd just leave it as-is, int16_t is a standard type. The commit message would be needed, too. -- Sakari Ailus e-mail: sakari.ai.

Re: [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.

2017-11-29 Thread Sakari Ailus
merged via the media tree. To avoid conflicts, I suggest to avoid merging them via the staging tree. Thanks. -- Kind regards, Sakari Ailus e-mail: sakari.ai...@iki.fi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.

2017-11-29 Thread Sakari Ailus
On Wed, Nov 29, 2017 at 10:15:06AM +0100, Greg KH wrote: > On Wed, Nov 29, 2017 at 11:08:17AM +0200, Sakari Ailus wrote: > > Hi Greg, > > > > On Mon, Nov 27, 2017 at 01:21:25PM +0100, Greg KH wrote: > > > On Mon, Nov 27, 2017 at 11:30:53AM +, Jeremy Sowden wrote:

Re: [PATCH 1/7] media: atomisp: stop producing hundreds of kernel-doc warnings

2017-11-29 Thread Sakari Ailus
moving lesser than-characaters. It'd be good to mention how it's been generated. -- Kind regards, Sakari Ailus sakari.ai...@linux.intel.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  1   2   >