[PATCH] staging: wlan-ng: fix SPDX comment style in headers

2018-05-04 Thread Tim Collier
Several of the wlan-ng header files had C++-style SPDX comments. Fixed checkpatch warnings by replacing with C-style comments, as per the kernel docs. Signed-off-by: Tim Collier <osde...@gmail.com> --- drivers/staging/wlan-ng/hfa384x.h | 2 +- drivers/staging/wlan-ng/p80211

[PATCH] staging: wlan-ng: fix coding style issues in p80211netdev.h

2018-05-15 Thread Tim Collier
Fix two issues with parameters not aligned to opening parenthesis, as reported by checkpatch. File is now clean for checkpatch. Signed-off-by: Tim Collier <osde...@gmail.com> --- drivers/staging/wlan-ng/p80211netdev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH] staging: wlan-ng: fix block comment alignment in p80211metastruct.h

2018-05-11 Thread Tim Collier
Fix checkpatch warning for misaligned * characters in the block comment at the start of p80211metastruct.h; with this change the file is checkpatch clean. Signed-off-by: Tim Collier <osde...@gmail.com> --- drivers/staging/wlan-ng/p80211metastruct.h | 88 +++---

[PATCH] staging: wlan-ng: fix coding style issues in p80211netdev.h

2018-05-16 Thread Tim Collier
Fix two issues with parameters not aligned to opening parenthesis, as reported by checkpatch. File is now clean for checkpatch. Signed-off-by: Tim Collier <osde...@gmail.com> --- drivers/staging/wlan-ng/p80211netdev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH] staging: wlan-ng: fix coding style issues in p80211netdev.c

2018-05-16 Thread Tim Collier
Fix 2 "Alignment should match open parenthesis" messages issued by checkpatch. Signed-off-by: Tim Collier <osde...@gmail.com> --- drivers/staging/wlan-ng/p80211netdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211net

Re: [PATCH] staging: wlan-ng: fix coding style issues in p80211netdev.h

2018-05-16 Thread Tim Collier
Sorry. This is a duplicate of the previous path for p80211netdev.h, sent in error. Please ignore. On Wed, May 16, 2018 at 08:48:54AM +0100, Tim Collier wrote: > Fix two issues with parameters not aligned to opening parenthesis, as > reported by checkpatch. File is now clean for chec

[PATCH 2/2] staging: wlan-ng: convert P80211SKB_RXMETA to inline function in p80211conv

2018-05-23 Thread Tim Collier
the new function. This change depends on the similar change for P80211SKB_FRMMETA having been applied. Signed-off-by: Tim Collier <osde...@gmail.com> --- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- drivers/staging/wlan-ng/p80211conv.c | 4 ++-- drivers/staging/wlan-ng/p80211conv.h

[PATCH 1/2] staging: wlan-ng: convert P80211SKB_FRMMETA to inline function in p80211conv

2018-05-23 Thread Tim Collier
the new function. Signed-off-by: Tim Collier <osde...@gmail.com> --- drivers/staging/wlan-ng/p80211conv.c | 4 ++-- drivers/staging/wlan-ng/p80211conv.h | 15 --- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/s

[PATCH 0/2] staging: wlan-ng: fix coding style issues in p80211conv.h

2018-05-23 Thread Tim Collier
Replace two macros defined in p80211conv.h with equivalent inline functions to avoid potential issues with repeated use of macro arguments as reported by checkpatch. With these changes, which must be applied in order, p80211conv.h is checkpatch clean. Tim Collier (2): staging: wlan-ng: convert

[PATCH] staging: wlan-ng: remove unused declarations from p80211types.h

2018-05-25 Thread Tim Collier
s change, checkpatch reports that p80211types.h has no obvious issues. Signed-off-by: Tim Collier <osde...@gmail.com> --- drivers/staging/wlan-ng/p80211types.h | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211types.h

[PATCH 0/4] staging: wlan-ng: coding style changes

2018-06-22 Thread Tim Collier
Changes to fix issues reported by checkpatch. Tim Collier (4): staging: wlan-ng: fix coding style (indentation) in prism2mib.c staging: wlan-ng: replace WLAN_CTL_FRAMELEN with inline function in p80211hdr.h staging: wlan-ng: replace macro with inline function in prism2mgmt.c staging

[PATCH 4/4] staging: wlan-ng: add parentheses to macro argument usage in prism2mgmt.c

2018-06-22 Thread Tim Collier
Fix two "CHECK: Macro argument 'N' may be better as '(N)' to avoid precedence issue" messages, reported by checkpatch, by adding parentheses around the offending macro argument references. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/prism2mgmt.c | 4 ++-- 1 file changed, 2

[PATCH 3/4] staging: wlan-ng: replace macro with inline function in prism2mgmt.c

2018-06-22 Thread Tim Collier
checkpatch gives the following message for the p80211rate_to_p2bit macro: CHECK: Macro argument reuse 'n' - possible side-effects? To fix the message, replace the macro with an equivalent inline function. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/prism2mgmt.c | 19

[PATCH 2/4] staging: wlan-ng: replace WLAN_CTL_FRAMELEN with inline function in p80211hdr.h

2018-06-22 Thread Tim Collier
so updated accordingly. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211hdr.h | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211hdr.h b/drivers/staging/wlan-ng/p80211hdr.h index 26b178721414..6564810fd

[PATCH 1/4] staging: wlan-ng: fix coding style (indentation) in prism2mib.c

2018-06-22 Thread Tim Collier
Fix "CHECK: Alignment should match open parenthesis" reported by checkpatch.pl. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/prism2mib.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/stagi

[PATCH 1/2] staging: wlan-ng: add missing parameter name to prototype

2018-05-02 Thread Tim Collier
Fix checkpatch warning for missing parameter name for function prototype. Signed-off-by: Tim Collier <osde...@gmail.com> --- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/w

[PATCH 2/2] staging: wlan-ng: fix line-break style issue

2018-05-02 Thread Tim Collier
Fix checkpatch warning due to line break after '(', leaving an over 80 character warning due to long macro name. Signed-off-by: Tim Collier <osde...@gmail.com> --- drivers/staging/wlan-ng/hfa384x_usb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/w

[PATCH 0/2] staging: wlan-ng: fix coding style issues in hfa384x_usb.c

2018-05-02 Thread Tim Collier
Fix two checkpatch issues in hfa384x_usb.c. One warning for a line over 80 characters remains (due to a long macro name). Tim Collier (2): staging: wlan-ng: add missing parameter name to prototype staging: wlan-ng: fix line-break style issue drivers/staging/wlan-ng/hfa384x_usb.c | 5

[PATCH] staging: wlan-ng: remove unused definitions from p80211types.h

2018-08-03 Thread Tim Collier
Remove the following unused definitions from p80211types.h: * struct p80211enum * struct p80211enumpair * struct catlistitem declaration and associated function pointer typedefs (along with preceding block comment) Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211types.h | 27

[PATCH 02/12] staging: wlan-ng: avoid use of camel case macro names in p80211metadef.h

2018-08-28 Thread Tim Collier
lower-case) to conform to the coding guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 48 ++--- drivers/staging/wlan-ng/p80211metadef.h | 118 drivers/staging/wlan-ng/p80211netdev.c | 8 +-- drivers/staging/wlan-ng/p

[PATCH 04/12] staging: wlan-ng: shorten names of "DIDMIB_DOT11MAC_" macros

2018-08-28 Thread Tim Collier
Shorten the names of the p80211metadef.h macros prefixed with "DIDMIB_DOT11MAC_" by removing repeat use of "DOT11" to reduce long lines and ease readabbility. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 4 ++-- drivers/staging/wlan-ng/

[PATCH 05/12] staging: wlan-ng: shorten names of "DIDMIB_DOT11PHY_" macros

2018-08-28 Thread Tim Collier
Shorten the names of the p80211metadef.h macros prefixed with "DIDMIB_DOT11PHY_" by removing repeat use of "DOT11PHY" and "DOT11" to reduce long lines and ease readabbility. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 6 +

[PATCH 03/12] staging: wlan-ng: shorten names of "DIDMIB_DOT11SMT_" macros

2018-08-28 Thread Tim Collier
Shorten the names of the p80211metadef.h macros prefixed with "DIDMIB_DOT11SMT_" (also in lower-case) by removing repeat use of "DOT11" to reduce long lines and ease readabbility. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 20 ++---

[PATCH 06/12] staging: wlan-ng: shorten names of "DIDMIB_LNX_" macros

2018-08-28 Thread Tim Collier
Shorten the names of the p80211metadef.h macros prefixed with "DIDMIB_LNX_" by removing repeat use of "LNX" to reduce long lines and ease readabbility. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 4 ++-- drivers/staging/wlan-ng/prism2mib.c

[PATCH 00/12] staging: wlan-ng: coding style changes/cleanups

2018-08-28 Thread Tim Collier
l multiple times. Patches should be applied in order as there are some dependencies. Tim Collier (12): staging: wlan-ng: remove redundant code in "#if 0" blocks staging: wlan-ng: avoid use of camel case macro names in p80211metadef.h staging: wlan-ng: shorten names of "

[PATCH 01/12] staging: wlan-ng: remove redundant code in "#if 0" blocks

2018-08-28 Thread Tim Collier
Remove two blocks of code that checkpatch identified as redundant because they were enclosed in "#if...#endif". In the case of prism2fw.c the associated "TODO" comment was retained. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211netdev.c | 4 dri

[PATCH 09/12] staging: wlan-ng: make switch case block format consistent

2018-08-28 Thread Tim Collier
For switch statements with case blocks make the format consistent by applying K formatting, a space before the opening brace, single indentation of contained code, break inside the block and closing brace aligned with case. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x_usb.c

[PATCH 12/12] staging: wlan-ng: remove "autogenerated code" comments

2018-08-28 Thread Tim Collier
p80211metadef.h and p80211metastruct.h both have comments stating they are autogenerated and should not be edited. However, neither is generated during build and both have had numerous manual edits since the driver has been in staging. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng

[PATCH 11/12] staging: wlan-ng: remove unnecessary braces from if

2018-08-28 Thread Tim Collier
Remove braces from an if statement with only a single line in the if block. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x_usb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c

[PATCH 07/12] staging: wlan-ng: shorten names of "DIDMIB_P2_" macros

2018-08-28 Thread Tim Collier
Shorten the names of the p80211metadef.h macros prefixed with "DIDMIB_P2_" by removing repeat use of "P2" to reduce long lines and ease readabbility. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 2 +- drivers/staging/wlan-ng/p80211metadef.h | 10

[PATCH 08/12] staging: wlan-ng: formatting cleanup in cfg80211.c

2018-08-28 Thread Tim Collier
Combine previously split lines for an assignment; now fits in 80 characters as the name of the macro being assigned was shortened. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng

[PATCH 10/12] staging: wlan-ng: rejoin split lines shortened by case changes

2018-08-28 Thread Tim Collier
The reformatting of case blocks has shortened some lines such that previously split lines can be rejoined without exceeding 80 characters. Rejoined those lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x_usb.c | 6 ++ drivers/staging/wlan-ng/prism2sta.c | 17

[PATCH 0/2] staging: wlan-ng: coding style change and comment update

2018-07-25 Thread Tim Collier
Apply a coding style change suggested by checkpatch and correct a comment. Tim Collier (2): staging: wlan-ng: remove volatile from reapable field in hfa384x_usbctlx staging: wlan-ng: correction to comment in hfa384x_usb drivers/staging/wlan-ng/hfa384x.h | 2 +- drivers/staging/wlan

[PATCH 2/2] staging: wlan-ng: correction to comment in hfa384x_usb

2018-07-25 Thread Tim Collier
The comment for hfa384x_docmd incorrectly states that usercb_data should be NULL for DOASYNC calls; in fact, it should be NULL for DOWAIT calls (this is consistent with the other similar functions and the rest of the comment text). Signed-off-by: Tim Collier --- drivers/staging/wlan-ng

[PATCH 1/2] staging: wlan-ng: remove volatile from reapable field in hfa384x_usbctlx

2018-07-25 Thread Tim Collier
cross threads are protected by the hw->ctlxq.lock spinlock, where hw is the device struct, so appears thread-safe. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers

Re: [PATCH 11/12] staging: wlan-ng: remove unnecessary braces from if

2018-08-30 Thread Tim Collier
On Wed, Aug 29, 2018 at 02:39:30PM +0300, Dan Carpenter wrote: > On Tue, Aug 28, 2018 at 08:26:22PM +0100, Tim Collier wrote: > > Remove braces from an if statement with only a single line in the if > > block. > > > > Signed-off-by: Tim Collier > > --- > >

Re: [PATCH 02/12] staging: wlan-ng: avoid use of camel case macro names in p80211metadef.h

2018-08-30 Thread Tim Collier
On Wed, Aug 29, 2018 at 02:37:36PM +0300, Dan Carpenter wrote: > On Tue, Aug 28, 2018 at 08:26:13PM +0100, Tim Collier wrote: > > checkpatch reported a number of "Avoid CamelCase" issues for macros > > defined in p80211metadef.h (and for files that used these macros). &g

[PATCH 2/3] staging: wlan-ng: fix expression continuation in prism2mgmt.c

2018-07-06 Thread Tim Collier
checkpatch reports "CHECK: Logical continuations should be on the previous line" when a continuation line begins with an operator. Reformat the code so that the operator appears at the end of the line being continued. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/prism2m

[PATCH 3/3] staging: wlan-ng: remove unneeded parentheses from prism2mgmt.c

2018-07-06 Thread Tim Collier
remove parentheses reported as unnecessary by checkpatch Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/prism2mgmt.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c index

[PATCH 0/3] staging: wlan-ng: fix coding style issues

2018-07-06 Thread Tim Collier
Fix issues reported by checkpatch regarding the correct point to split lines for coninuation and unnecessary parentheses. Tim Collier (3): staging: wlan-ng: fix expression continuation in prism2fw.c staging: wlan-ng: fix expression continuation in prism2mgmt.c staging: wlan-ng: remove

[PATCH 1/3] staging: wlan-ng: fix expression continuation in prism2fw.c

2018-07-06 Thread Tim Collier
checkpatch reports "CHECK: Logical continuations should be on the previous line" when a continuation line begins with an operator. Reformat the code so that the operator appears at the end of the line being continued. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/pris

[PATCH 0/3] staging: wlan-ng: formatting changes

2018-11-07 Thread Tim Collier
Formatting changes to resolve 80 character limit warnings reported by checkpatch. Tim Collier (3): staging: wlan-ng: formatting change in cfg80211.c staging: wlan-ng: reformatting in hfa384x.h to fit 80 character limit staging: wlan-ng: reformatting in prism2mib.c to fit 80 character

[PATCH 3/3] staging: wlan-ng: reformatting in prism2mib.c to fit 80 character limit

2018-11-07 Thread Tim Collier
Reformat lines over 80 characters in prism2mib.c to resolve "line over 80 characters" warnings reported by checkpatch. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/prism2mib.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git

[PATCH 1/3] staging: wlan-ng: formatting change in cfg80211.c

2018-11-07 Thread Tim Collier
Resolve "line over 80 characters" warning reported by checkpatch by splitting function header over 2 lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c

[PATCH 2/3] staging: wlan-ng: reformatting in hfa384x.h to fit 80 character limit

2018-11-07 Thread Tim Collier
Reformat lines over 80 characters in hfa384x.h to resolve "line over 80 characters" warnings reported by checkpatch. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x.h | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drive

[PATCH v2 13/62] staging: wlan-ng: rename DIDmsg_lnxreq_hostwep in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_lnxreq_hostwep in p80211metadef.h to DIDMSG_LNXREQ_HOSTWEP to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/p80211req

[PATCH v2 01/62] staging: wlan-ng: rename DIDmsg_dot11req_mibget in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_dot11req_mibget in p80211metadef.h to DIDMSG_DOT11REQ_MIBGET to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 2 +- drivers/staging/wlan-ng/p80211met

[PATCH v2 15/62] staging: wlan-ng: rename DIDmsg_lnxreq_autojoin in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_lnxreq_autojoin in p80211metadef.h to DIDMSG_LNXREQ_AUTOJOIN to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 4 ++-- drivers/staging/wlan-ng/p80211met

[PATCH v2 10/62] staging: wlan-ng: rename DIDmsg_dot11ind_authenticate in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_dot11ind_authenticate in p80211metadef.h to DIDMSG_DOT11IND_AUTHENTICATE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- 1 file changed, 1 inser

[PATCH v2 03/62] staging: wlan-ng: rename DIDmsg_dot11req_mibget_resultcode in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_dot11req_mibget_resultcode in p80211metadef.h to DIDMSG_DOT11REQ_MIBGET_RESULTCODE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/stagi

[PATCH v2 25/62] staging: wlan-ng: rename DIDmsg_p2req_ramdl_write_addr in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_p2req_ramdl_write_addr in p80211metadef.h to DIDMSG_P2REQ_RAMDL_WRITE_ADDR to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/

[PATCH v2 04/62] staging: wlan-ng: rename DIDmsg_dot11req_mibset in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_dot11req_mibset in p80211metadef.h to DIDMSG_DOT11REQ_MIBSET to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 4 ++-- drivers/staging/wlan-ng/p80211met

[PATCH v2 24/62] staging: wlan-ng: rename DIDmsg_p2req_ramdl_write in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_p2req_ramdl_write in p80211metadef.h to DIDMSG_P2REQ_RAMDL_WRITE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/prism2fw.

[PATCH v2 09/62] staging: wlan-ng: rename DIDmsg_dot11req_start in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_dot11req_start in p80211metadef.h to DIDMSG_DOT11REQ_START to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/prism2sta.c

[PATCH v2 08/62] staging: wlan-ng: rename DIDmsg_dot11req_scan_results in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_dot11req_scan_results in p80211metadef.h to DIDMSG_DOT11REQ_SCAN_RESULTS to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 2 +- drivers/stagi

[PATCH v2 07/62] staging: wlan-ng: rename DIDmsg_dot11req_scan in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_dot11req_scan in p80211metadef.h to DIDMSG_DOT11REQ_SCAN to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 2 +- drivers/staging/wlan-ng/p80211met

[PATCH v2 11/62] staging: wlan-ng: rename DIDmsg_lnxreq_ifstate in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_lnxreq_ifstate in p80211metadef.h to DIDMSG_LNXREQ_IFSTATE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/p80211req

[PATCH v2 14/62] staging: wlan-ng: rename DIDmsg_lnxreq_commsquality in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_lnxreq_commsquality in p80211metadef.h to DIDMSG_LNXREQ_COMMSQUALITY to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 2 +- drivers/staging/wlan-ng/p8021

[PATCH v2 06/62] staging: wlan-ng: rename DIDmsg_dot11req_mibset_resultcode in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_dot11req_mibset_resultcode in p80211metadef.h to DIDMSG_DOT11REQ_MIBSET_RESULTCODE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/stagi

[PATCH v2 17/62] staging: wlan-ng: rename DIDmsg_p2req_readpda_pda in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_p2req_readpda_pda in p80211metadef.h to DIDMSG_P2REQ_READPDA_PDA to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/prism2fw.

[PATCH v2 31/62] staging: wlan-ng: rename DIDmib_cat_dot11smt in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmib_cat_dot11smt in p80211metadef.h to DIDMIB_CAT_DOT11SMT to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v2 38/62] staging: wlan-ng: rename DIDmib_dot11mac_dot11OperationTable in p80211metadef.h

2018-09-26 Thread Tim Collier
g lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211metadef.h b/drivers/staging/wlan-ng/p80211metadef.h index a386b6cb15bc..79f6813cd9d6 100644 --- a/drivers/staging/wla

[PATCH v2 56/62] staging: wlan-ng: rename DIDmib_p2_p2NIC_p2PRISupRange in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmib_p2_p2NIC_p2PRISupRange in p80211metadef.h to DIDMIB_P2_NIC_PRISUPRANGE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Also shorten name by removing repeated use of "P2" to ease readability and reduce long lines.

[PATCH v2 52/62] staging: wlan-ng: rename DIDmib_lnx_lnxConfigTable_lnxRSNAIE in p80211metadef.h

2018-09-26 Thread Tim Collier
g lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/prism2mib.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211metadef.h b/drivers/staging/wlan-ng/p80211metadef.h index d04e78

[PATCH v2 50/62] staging: wlan-ng: rename DIDmib_cat_lnx in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmib_cat_lnx in p80211metadef.h to DIDMIB_CAT_LNX to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 30/62] staging: wlan-ng: rename DIDmsg_p2req_flashdl_write in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_p2req_flashdl_write in p80211metadef.h to DIDMSG_P2REQ_FLASHDL_WRITE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/p

[PATCH v2 45/62] staging: wlan-ng: rename DIDmib_cat_dot11phy in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmib_cat_dot11phy in p80211metadef.h to DIDMIB_CAT_DOT11PHY to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v2 58/62] staging: wlan-ng: rename DIDmib_p2_p2MAC_p2CurrentTxRate in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmib_p2_p2MAC_p2CurrentTxRate in p80211metadef.h to DIDMIB_P2_MAC_CURRENTTXRATE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Also shorten name by removing repeated use of "P2" to ease readability and reduce long lines.

[PATCH v2 22/62] staging: wlan-ng: rename DIDmsg_p2req_ramdl_state_exeaddr in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_p2req_ramdl_state_exeaddr in p80211metadef.h to DIDMSG_P2REQ_RAMDL_STATE_EXEADDR to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/stagi

[PATCH v2 18/62] staging: wlan-ng: rename DIDmsg_dot11ind_associate in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_dot11ind_associate in p80211metadef.h to DIDMSG_DOT11IND_ASSOCIATE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- 1 file changed, 1 insertion(+),

[PATCH v2 34/62] staging: wlan-ng: rename DIDmib_dot11smt_dot11PrivacyTable in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmib_dot11smt_dot11PrivacyTable to DIDMIB_DOT11SMT_PRIVACYTABLE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Also shorten name by removing repeated use of "DOT11" to ease readability and reduce long lines. Signed

[PATCH v2 23/62] staging: wlan-ng: rename DIDmsg_p2req_ramdl_state_resultcode in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_p2req_ramdl_state_resultcode in p80211metadef.h to DIDMSG_P2REQ_RAMDL_STATE_RESULTCODE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/st

[PATCH v2 21/62] staging: wlan-ng: rename DIDmsg_p2req_ramdl_state_enable in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_p2req_ramdl_state_enable in p80211metadef.h to DIDMSG_P2REQ_RAMDL_STATE_ENABLE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/stagi

[PATCH v2 27/62] staging: wlan-ng: rename DIDmsg_p2req_ramdl_write_data in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_p2req_ramdl_write_data in p80211metadef.h to DIDMSG_P2REQ_RAMDL_WRITE_DATA to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/

[PATCH v2 28/62] staging: wlan-ng: rename DIDmsg_p2req_ramdl_write_resultcode in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_p2req_ramdl_write_resultcode in p80211metadef.h to DIDMSG_P2REQ_RAMDL_WRITE_RESULTCODE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/st

[PATCH v2 33/62] staging: wlan-ng: rename DIDmib_dot11smt_dot11WEPDefaultKeysTable_key in p80211metadef.h

2018-09-26 Thread Tim Collier
lity and reduce long lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 6 +++--- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/p80211req.c | 8 drivers/staging/wlan-ng/prism2mib.c | 8 4 files changed, 12 inserti

[PATCH v2 26/62] staging: wlan-ng: rename DIDmsg_p2req_ramdl_write_len in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_p2req_ramdl_write_len to DIDMSG_P2REQ_RAMDL_WRITE_LEN to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/prism2fw.c | 2 +

[PATCH v2 32/62] staging: wlan-ng: rename DIDmib_dot11smt_dot11WEPDefaultKeysTable in p80211metadef.h

2018-09-26 Thread Tim Collier
nd reduce long lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211metadef.h b/drivers/staging/wlan-ng/p80211metadef.h index bcc44621664a..a74af59737ce 100644 --- a/dri

[PATCH v2 35/62] staging: wlan-ng: rename DIDmib_dot11smt_dot11PrivacyTable_dot11PrivacyInvoked in p80211metadef.h

2018-09-26 Thread Tim Collier
nd reduce long lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 4 ++-- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/p80211req.c | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-)

[PATCH v2 29/62] staging: wlan-ng: rename DIDmsg_p2req_flashdl_state in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmsg_p2req_flashdl_state in p80211metadef.h to DIDMSG_P2REQ_FLASHDL_STATE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/p

[PATCH v2 42/62] staging: wlan-ng: rename DIDmib_dot11mac_dot11OperationTable_dot11LongRetryLimit in p80211metadef.h

2018-09-26 Thread Tim Collier
to ease readability and reduce long lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211metadef.h b/drivers/staging/wla

[PATCH v2 41/62] staging: wlan-ng: rename DIDmib_dot11mac_dot11OperationTable_dot11ShortRetryLimit in p80211metadef.h

2018-09-26 Thread Tim Collier
;DOT11" to ease readability and reduce long lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211metadef.h b/drivers/staging/wla

[PATCH v2 55/62] staging: wlan-ng: rename DIDmib_p2_p2Static_p2CnfPortType in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmib_p2_p2Static_p2CnfPortType in p80211metadef.h to DIDMIB_P2_STATIC_CNFPORTTYPE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Also shorten name by removing repeated use of "P2" to ease readability and reduce long lines.

[PATCH v2 46/62] staging: wlan-ng: rename DIDmib_dot11phy_dot11PhyOperationTable in p80211metadef.h

2018-09-26 Thread Tim Collier
nd reduce long lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211metadef.h b/drivers/staging/wlan-ng/p80211metadef.h index 9e865f82cf98..53f380f2f66f 100644 --- a/dri

[PATCH v2 62/62] staging: wlan-ng: remove "autogenerated code" comments

2018-09-26 Thread Tim Collier
p80211metadef.h and p80211metastruct.h both have comments stating they are autogenerated and should not be edited. However, neither is generated during build and both have had numerous manual edits since the driver has been in staging. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng

[PATCH v2 48/62] staging: wlan-ng: rename DIDmib_dot11phy_dot11PhyDSSSTable in p80211metadef.h

2018-09-26 Thread Tim Collier
g lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211metadef.h b/drivers/staging/wlan-ng/p80211metadef.h index 5d06b342b980..dae733524342 100644 --- a/drivers/staging/wlan-ng/p

[PATCH v2 40/62] staging: wlan-ng: DIDmib_dot11mac_dot11OperationTable_dot11RTSThreshold in p80211metadef.h

2018-09-26 Thread Tim Collier
to ease readability and reduce long lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 2 +- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/w

[PATCH v2 53/62] staging: wlan-ng: rename DIDmib_cat_p2 in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmib_cat_p2 in p80211metadef.h to DIDMIB_CAT_P2 to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 51/62] staging: wlan-ng: rename DIDmib_lnx_lnxConfigTable in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmib_lnx_lnxConfigTable in p80211metadef.h to DIDMIB_LNX_CONFIGTABLE to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Also shorten name by removing repeated use of "LNX" to ease readability and reduce long lines. Signed

[PATCH v2 37/62] staging: wlan-ng: rename DIDmib_dot11smt_dot11PrivacyTable_dot11ExcludeUnencrypted in p80211metadef.h

2018-09-26 Thread Tim Collier
;DOT11" to ease readability and reduce long lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 4 ++-- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/p80211req.c | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 4 files changed, 5 insert

[PATCH v2 43/62] staging: wlan-ng: rename DIDmib_dot11mac_dot11OperationTable_dot11FragmentationThreshold in p80211metadef.h

2018-09-26 Thread Tim Collier
of "DOT11" to ease readability and reduce long lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 2 +- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/

[PATCH v2 49/62] staging: wlan-ng: rename DIDmib_dot11phy_dot11PhyDSSSTable_dot11CurrentChannel in p80211metadef.h

2018-09-26 Thread Tim Collier
d "DOT11PHY" to ease readability and reduce long lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 2 +- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff -

[PATCH v2 39/62] staging: wlan-ng: rename DIDmib_dot11mac_dot11OperationTable_dot11MACAddress in p80211metadef.h

2018-09-26 Thread Tim Collier
to ease readability and reduce long lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/p80211netdev.c | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-n

[PATCH v2 59/62] staging: wlan-ng: formatting cleanup in cfg80211.c

2018-09-26 Thread Tim Collier
Combine previously split lines for an assignment; now fits in 80 characters as the name of the macro being assigned was shortened. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng

[PATCH v2 47/62] staging: wlan-ng: rename DIDmib_dot11phy_dot11PhyTxPowerTable_dot11CurrentTxPowerLevel in p80211metadef.h

2018-09-26 Thread Tim Collier
of "DOT11" and "DOT11PHY" to ease readability and reduce long lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 4 ++-- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 3 files changed, 4 insertions(+), 4 dele

[PATCH v2 44/62] staging: wlan-ng: rename DIDmib_dot11mac_dot11OperationTable_dot11MaxTransmitMSDULifetime in p80211metadef.h

2018-09-26 Thread Tim Collier
of "DOT11" to ease readability and reduce long lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/p80211metadef.h | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211metadef.h b/dri

[PATCH v2 54/62] staging: wlan-ng: rename DIDmib_p2_p2Static in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmib_p2_p2Static in p80211metadef.h to DIDMIB_P2_STATIC to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Also shorten name by removing repeated use of "P2" to ease readability and reduce long lines. Signed-off-by: Tim C

[PATCH v2 57/62] staging: wlan-ng: rename DIDmib_p2_p2MAC in p80211metadef.h

2018-09-26 Thread Tim Collier
Rename DIDmib_p2_p2MAC in p80211metadef.h to DIDMIB_P2_MAC to fix "Avoid CamelCase" message from checkpatch and conform to the coding style guidelines. Also shorten name by removing repeated use of "P2" to ease readability and reduce long lines. Signed-off-by: Tim Collier

[PATCH v2 61/62] staging: wlan-ng: rejoin split lines shortened by case changes

2018-09-26 Thread Tim Collier
The reformatting of case blocks has shortened some lines such that previously split lines can be rejoined without exceeding 80 characters. Rejoined those lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x_usb.c | 6 ++ drivers/staging/wlan-ng/prism2sta.c | 17

[PATCH v2 60/62] staging: wlan-ng: make switch case block format consistent

2018-09-26 Thread Tim Collier
For switch statements with case blocks make the format consistent by applying K formatting, a space before the opening brace, single indentation of contained code, break inside the block and closing brace aligned with case. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x_usb.c

  1   2   >