[PATCH] staging: wilc1000: fix check of kthread_run() return value

The kthread_run() function returns either a valid task_struct or ERR_PTR() value, check for NULL is invalid. The change fixes potential oops, e.g. in OOM situation. Signed-off-by: Vladimir Zapolskiy <v...@mleia.com> --- drivers/staging/wilc1000/linux_wlan.c | 4 ++-- 1 file changed, 2 inse

Re: [PATCH] staging: wilc1000: fix check of kthread_run() return value

Hi Julian, On 10.03.2016 01:27, Julian Calaby wrote: > Hi Vladimir, > > On Thu, Mar 10, 2016 at 10:13 AM, Vladimir Zapolskiy <v...@mleia.com> wrote: >> The kthread_run() function returns either a valid task_struct or >> ERR_PTR() value, check for NULL is invalid.

Re: [PATCH] staging: wilc1000: fix check of kthread_run() return value

Hi Julian, On 10.03.2016 01:42, Julian Calaby wrote: > Hi Vladimir, > > On Thu, Mar 10, 2016 at 10:30 AM, Vladimir Zapolskiy <v...@mleia.com> wrote: >> Hi Julian, >> >> On 10.03.2016 01:27, Julian Calaby wrote: >>> Hi Vladimir, >>> >>

Re: [PATCH] staging: wilc1000: fix check of kthread_run() return value

Hi Julian, On 10.03.2016 02:24, Julian Calaby wrote: > Hi Vladimir, > > On Thu, Mar 10, 2016 at 11:02 AM, Vladimir Zapolskiy <v...@mleia.com> wrote: >> Hi Julian, >> >> On 10.03.2016 01:42, Julian Calaby wrote: >>> Hi Vladimir, >>> >>

[PATCH] staging: android: ion_test: fix check of platform_device_register_simple() error code

On error platform_device_register_simple() returns ERR_PTR() value, check for NULL always fails. The change corrects the check itself and propagates the returned error upwards. Fixes: 81fb0b901397 ("staging: android: ion_test: unregister the platform device") Signed-off-by: Vladimir Za

Re: [PATCH v2 04/19] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

Hi Steve, On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > Both hang off the same i2c2 bus, so they require different (and non- > default) i2c slave addresses. > > The OV5642 connects to the parallel-bus mux input port

Re: [PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > > The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. > > The OV5640 connects to the input port on the MIPI CSI-2 receiver on > mipi_csi. It is set

Re: [PATCH v2 09/19] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Enables the ADV7180 decoder sensor. The ADV7180 connects to the > parallel-bus mux input on ipu1_csi0_mux. > > On the sabreauto, two analog video inputs are routed to the ADV7180, > composite on Ain1, and composite on Ain3. Those inputs are

Re: [PATCH v2 12/19] media: imx: Add SMFC subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is a media entity subdevice driver for the i.MX Sensor Multi-FIFO > Controller module. Video frames are received from the CSI and can > be routed to various sinks including the i.MX Image Converter for > scaling, color-space conversion, motion

Re: [PATCH v2 11/19] media: imx: Add CSI subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is a media entity subdevice for the i.MX Camera > Serial Interface module. > > Signed-off-by: Steve Longerbeam > --- [snip] > diff --git a/drivers/staging/media/imx/imx-csi.c >

Re: [PATCH v2 13/19] media: imx: Add IC subdev drivers

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is a set of three media entity subdevice drivers for the i.MX > Image Converter. The i.MX IC module contains three independent > "tasks": > > - Pre-processing Encode task: video frames are routed directly from > the CSI and can be scaled,

Re: [PATCH v2 15/19] media: imx: Add MIPI CSI-2 Receiver subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > for sensors with a MIPI CSI2 interface. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Makefile| 1 + >

Re: [PATCH v2 10/19] media: Add i.MX media core driver

Hi Steve, On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam > --- > Documentation/devicetree/bindings/media/imx.txt | 205 + v2 was sent before getting Rob's review comments, but

Re: [PATCH v2 14/19] media: imx: Add Camera Interface subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is the camera interface driver that provides the v4l2 > user interface. Frames can be received from various sources: > > - directly from SMFC for capturing unconverted images directly from > camera sensors. > > - from the IC pre-process

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Steve, On 03/28/2017 03:40 AM, Steve Longerbeam wrote: > From: Philipp Zabel > > This driver can handle SoC internal and external video bus multiplexers, > controlled either by register bit fields or by a GPIO. The subdevice > passes through frame interval and mbus

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/19/2017 04:22 PM, Russell King - ARM Linux wrote: > On Sun, Mar 19, 2017 at 02:21:10PM +, Russell King - ARM Linux wrote: >> There's a good reason why I dumped a full debug log using GST_DEBUG=*:9, >> analysed it for the cause of the failure, and tried several different >> pipelines,

Re: [PATCH v5 00/39] i.MX Media Driver

Hi Russell, On 03/18/2017 10:43 PM, Russell King - ARM Linux wrote: > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: >> Can you share your gstreamer pipeline? For now, until >> VIDIOC_ENUM_FRAMESIZES is implemented, try a pipeline that >> does not attempt to specify a frame

Re: [PATCH] mtd: nand: Rename nand.h into rawnand.h

;ys...@users.sourceforge.jp> > Cc: Rich Felker <dal...@libc.org> > Cc: Wenyou Yang <wenyou.y...@atmel.com> > Cc: Josh Wu <rainyfeel...@outlook.com> > Cc: Kamal Dasu <kdasu.k...@gmail.com> > Cc: Masahiro Yamada <yamada.masah...@socionext.com> > Cc: Han X

Re: [PATCH v8 00/34] i.MX Media Driver

On 06/10/2017 02:26 AM, Hans Verkuil wrote: > On 10/06/17 01:16, Steve Longerbeam wrote: >> >> >> On 06/07/2017 12:02 PM, Hans Verkuil wrote: >>> We're still waiting for an Ack for patch 02/34, right? >>> >> >> Hi Hans, Rub has provided an Ack for patch 2. >> >>> Other than that everything is

Re: [PATCH v3 2/2] ARM: dts: tegra20: Add video decoder node

t may lead to conflicts for IRAM resource between users. My proposal is to add a valid device tree node to describe an IRAM region firstly, then reserve a subregion in it by using a new "iram" property. 8< From: Vladimir Zapolskiy <v...@mleia.com> Date: Thu, 12 Oct 2017

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

Hi Dmitry, I'll add just a couple of minor comments, in general the code looks very good. On 10/20/2017 12:34 AM, Dmitry Osipenko wrote: > NVIDIA Tegra20/30/114/124/132 SoC's have video decoder engine that > supports standard set of video formats like H.264 / MPEG-4 / WMV / VC1. > Currently

Re: [PATCH v4 1/5] ARM: tegra: Add device tree node to describe IRAM

Hi Dmitry, On 10/20/2017 12:34 AM, Dmitry Osipenko wrote: > From: Vladimir Zapolskiy <v...@mleia.com> > > All Tegra SoCs contain 256KiB IRAM, which is used to store CPU resume code > and by hardware engines like a video decoder. > > Signed-off-by: Vladimir Zapolskiy <

Re: [PATCH v4 2/5] media: dt: bindings: Add binding for NVIDIA Tegra Video Decoder Engine

Hi Dmitry, On 10/20/2017 12:34 AM, Dmitry Osipenko wrote: > Add binding documentation for the Video Decoder Engine which is found > on NVIDIA Tegra20/30/114/124/132 SoC's. > > Signed-off-by: Dmitry Osipenko > --- > .../devicetree/bindings/media/nvidia,tegra-vde.txt | 55 >