*m, void *v)
^
drivers/staging/rtl8192u/r8192U_core.c:627:12: warning: ‘proc_get_stats_rx’
defined but not used [-Wunused-function]
static int proc_get_stats_rx(struct seq_file *m, void *v)
^
fix this by adding #ifdef around them.
Signed-off-by: YueHaibing
---
drivers
Pls ignore this, there has a fix.
[PATCH] staging/rtl8192u: fix defined but not used build warnings
On 2018/7/13 16:01, YueHaibing wrote:
> When CONFIG_PROC_FS isn't set, gcc warning this:
>
> drivers/staging/rtl8192u/r8192U_core.c:508:12: warning: ‘proc_get_stats_ap’
> defined
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Signed-off-by: YueHaibing
---
drivers/staging/mt7621-pci/pci-mt7621.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c
b/drivers/staging/mt7621-pci/pci-mt7621.c
index
There is no need to have the 'resource_size_t res_len' variable static
since new value always be assigned before use it.
Signed-off-by: YueHaibing
---
drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media
There is no need to have the 'resource_size_t res_len' variable static
since new value always be assigned before use it.
Signed-off-by: YueHaibing
---
drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media
Remove duplicated include.
Signed-off-by: YueHaibing
---
drivers/staging/axis-fifo/axis-fifo.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/axis-fifo/axis-fifo.c
b/drivers/staging/axis-fifo/axis-fifo.c
index 63c8efd..48a9877 100644
--- a/drivers/staging/axis-fifo/axis
/halbtcoutsrc.c: In function
'halbtc_enter_lps':
drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c:307:21: warning:
variable 'ppsc' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing
---
drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c | 4
1 file changed, 4 deletions
On 2018/9/20 22:43, Stephen Hemminger wrote:
> On Thu, 20 Sep 2018 20:33:01 +0800
> YueHaibing wrote:
>
>> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
>> which is a typedef for an enum type, so make sure the implementation in
>> this driv
On 2018/9/20 23:50, David Miller wrote:
> From: YueHaibing
> Date: Thu, 20 Sep 2018 20:32:44 +0800
>
>> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
>> which is a typedef for an enum type, so make sure the implementation in
>> this driver has
On 2018/9/20 22:50, Haiyang Zhang wrote:
>
>
>> -Original Message-
>> From: Stephen Hemminger
>> Sent: Thursday, September 20, 2018 10:44 AM
>> To: YueHaibing
>> Cc: da...@davemloft.net; dmitry.tarnya...@lockless.no;
>> w...@grandegger.com; m.
, We are not sure if the error can go away after retrying, returning
NETDEV_TX_BUSY may cause infinite retry from the upper layer.
so just return NETDEV_TX_OK at there.
Found by coccinelle.
Signed-off-by: YueHaibing
---
drivers/net/hyperv/netvsc_drv.c | 9 ++---
1 file changed, 6 insertions
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.
Found by coccinelle.
Signed-off-by: YueHaibing
---
drivers/net/ethernet/faraday/ftgmac100.c | 4 ++--
drivers/net/ethernet/faraday
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
YueHaibing (22):
net: micrel: fix return type
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
---
net
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
---
net
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
Found by coccinelle.
Signed-off-by: YueHaibing
---
net
Remove including that don't need it.
Signed-off-by: YueHaibing
---
arch/x86/hyperv/hv_apic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c
index 2c43e30..8eb6fbee 100644
--- a/arch/x86/hyperv/hv_apic.c
+++ b/arch/x86/hyperv/hv_apic.c
From: Yue Haibing
Remove including that don't need it.
Signed-off-by: Yue Haibing
---
drivers/staging/gasket/gasket_interrupt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_interrupt.c
b/drivers/staging/gasket/gasket_interrupt.c
index 1cfbc12..176ac2a
There is no need to have the 'intrepeat_times' variable static since new
value always be assigned before use it.
Signed-off-by: YueHaibing
---
drivers/staging/rtl8712/rtl8712_efuse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c
b
sorry, Pls ignore this. The title need fix.
On 2018/12/18 21:09, YueHaibing wrote:
> strncmp() stops comparing when either the end of one of the first two
> arguments is reached or when 'n' characters have been compared, whichever
> comes first.That means that strncmp(s1, s2, n) is e
that the following warning is reported by smatch:
drivers/staging/fbtft/fbtft_device.c:1458
fbtft_device_init() error: strncmp() '"list"' too small (5 vs 32)
Signed-off-by: YueHaibing
---
v2: fix patch title
---
drivers/staging/fbtft/fbtft_device.c | 2 +-
1 file changed, 1 inser
that the following warning is reported by smatch:
drivers/staging/fbtft/fbtft_device.c:1458
fbtft_device_init() error: strncmp() '"list"' too small (5 vs 32)
Signed-off-by: YueHaibing
---
drivers/staging/fbtft/fbtft_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
that the following warning is reported by smatch:
drivers/staging/fbtft/fbtft_device.c:1458
fbtft_device_init() error: strncmp() '"list"' too small (5 vs 32)
Signed-off-by: YueHaibing
---
v2-v3: fix messed patch title
---
drivers/staging/fbtft/fbtft_device.c | 2 +-
1 file changed, 1 inser
On 2018/12/18 21:37, Dan Carpenter wrote:
> On Tue, Dec 18, 2018 at 09:25:08PM +0800, YueHaibing wrote:
>> strncmp() stops comparing when either the end of one of the first two
>> arguments is reached or when 'n' characters have been compared, whichever
>> comes first.That
' set but not used [-Wunused-but-set-variable]
It never used since introduction in
commit 775fec69008d ("media: add Rockchip VPU JPEG encoder driver")
Signed-off-by: YueHaibing
---
drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 5 -
drivers/staging/media/ro
'bindex' is unsigned, it never less than zero.
This patch bring int 'binary' back to handle the err condition.
Fixes: 51abe041c5ed ("media: staging/intel-ipu3: Add dual pipe support")
Signed-off-by: YueHaibing
---
drivers/staging/media/ipu3/ipu3-css.c | 8
1 file changed, 4
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/wilc1000/host_interface.c: In function
'wilc_parse_network_info':
drivers/staging/wilc1000/host_interface.c:748:16: warning:
variable 'msa' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing
---
drivers
On 2019/4/5 9:56, Caio Salvador Rohwedder wrote:
> Fix checkpatch coding style errors on rtl819x_TSProc.c
> - space required before the open parenthesis '('
> - spaces required around that '=='
>
> Signed-off-by: Caio Salvador Rohwedder
> ---
>
and can be removed.
Signed-off-by: YueHaibing
---
drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c
index bab41ab7c0a5..1d992d5c4e17 100644
--- a/drivers/staging
'ht_cap_len' set but not used [-Wunused-but-set-variable]
They are never used and can be removed.
Signed-off-by: YueHaibing
---
drivers/staging/rtlwifi/base.c | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi
.
Signed-off-by: YueHaibing
---
drivers/staging/rtlwifi/rtl8822be/hw.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtlwifi/rtl8822be/hw.c
b/drivers/staging/rtlwifi/rtl8822be/hw.c
index dac22c21f821..1de4e903a4de 100644
--- a/drivers/staging/rtlwifi
;
drivers/staging/comedi/drivers/dyna_pci10xx.c:109:15: warning:
variable 'chan' set but not used [-Wunused-but-set-variable]
unsigned int chan, range;
They are never used since introduction in commit 16a7373a8e14 ("Staging:
comedi: add dyna_pci10xx driver")
Signed-off-by: YueHaibing
--
'efuse_get_current_size':
drivers/staging/rtlwifi/efuse.c:1185:5: warning:
variable 'hoffset' set but not used [-Wunused-but-set-variable]
They're never used and can be removed.
Signed-off-by: YueHaibing
---
drivers/staging/rtlwifi/efuse.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
:1731:24: warning:
variable 'stype' set but not used [-Wunused-but-set-variable]
They're never used and can be removed.
Signed-off-by: YueHaibing
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e
Remove including that don't need it.
Signed-off-by: YueHaibing
---
drivers/staging/mt7621-mmc/dbg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers/staging/mt7621-mmc/dbg.c
index eabe0595978b..c7c091fa1da0 100644
--- a/drivers/staging/mt7621-mmc
On 2019/2/18 22:31, Dan Carpenter wrote:
> On Mon, Feb 18, 2019 at 12:33:59PM +0000, YueHaibing wrote:
>> @@ -1747,11 +1747,10 @@ static short _rtl92e_tx(struct net_device *dev,
>> struct sk_buff *skb)
>> header = (struct rtllib_hdr_1addr *)(((u8 *)skb->data) +
:1731:24: warning:
variable 'stype' set but not used [-Wunused-but-set-variable]
This remove unnessesary bool variable 'multi_addr, broad_addr, uni_addr'
Also 'stype' never used and can be removed.
Signed-off-by: YueHaibing
---
v2: remove unnessesary bool variable 'multi_addr,uni_addr
: In function
rtl8723bs_free_xmit_priv:
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c:640:23: warning: variable phal
set but not used [-Wunused-but-set-variable]
They are never used and can be removed.
Signed-off-by: YueHaibing
---
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 5 +
1
Sorry, this is broken, Pls igore this.
On 2019/5/28 22:29, YueHaibing wrote:
> Fix gcc build error while CONFIG_REGMAP_MMIO is not set
>
> drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function
> `controller_probe':
> arcx-anybus.c: undefined reference to `__devm_regma
("staging: fieldbus: arcx-anybus: change custom -> mmio
regmap")
Signed-off-by: YueHaibing
---
drivers/staging/fieldbus/anybuss/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fieldbus/anybuss/Kconfig
b/drivers/staging/fieldbus/anybuss/Kconfig
index 8bc
aging: fieldbus: arcx-anybus: change custom -> mmio
regmap")
Signed-off-by: YueHaibing
---
v2: fix patch style warning
---
drivers/staging/fieldbus/anybuss/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fieldbus/anybuss/Kconfig
b/drivers/staging/fieldbus/anybuss/
On 2019/5/28 21:41, Sven Van Asbroeck wrote:
> Hello YueHaibing,
>
> On Tue, May 28, 2019 at 9:33 AM YueHaibing wrote:
>>
>> Fix gcc build error while CONFIG_REGMAP_MMIO is not set
>>
>> drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function
>> `con
On 2019/5/28 22:35, Sven Van Asbroeck wrote:
> On Tue, May 28, 2019 at 10:31 AM YueHaibing wrote:
>>
>> Fix gcc build error while CONFIG_REGMAP_MMIO is not set
>>
>
> checkpatch.pl errors remain:
>
> $ ./scripts/checkpatch.pl < ~/Downloads/YueHaibing.eml
&
ype(irq_get_irq_data(chip->bus.irq));
Reported-by: Hulk Robot
Fixes: 7f6b6d553df7 ("Staging: iio: adt7316: Add all irq related code in
adt7316_irq_setup()")
Fixes: c63460c4298f ("Staging: iio: adt7316: Use device tree data to set
ldac_pin")
Signed-off-by: YueHaibing
---
Robot
Fixes: 3e7f51bd9607 ("media: meson: add v4l2 m2m video decoder driver")
Signed-off-by: YueHaibing
---
drivers/staging/media/meson/vdec/vdec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/meson/vdec/vdec.c
b/drivers/staging/media/meson/vdec/vdec.c
ind
On 2019/6/16 21:11, Jonathan Cameron wrote:
> On Fri, 14 Jun 2019 23:28:46 +0800
> YueHaibing wrote:
>
>> Fix build error:
>>
>> drivers/staging/iio/addac/adt7316.c: In function adt7316_store_update_DAC:
>> drivers/staging/iio/addac/adt7316.c:949:3: error: imp
-by: YueHaibing
---
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
index 9acf1ea..ca76073 100644
--- a/drivers/staging/kpc2000
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: YueHaibing
---
drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc_dma
this.
Reported-by: Hulk Robot
Fixes: 8b523f20417d ("staging: ks7010: removed custom Michael MIC
implementation.")
Signed-off-by: YueHaibing
---
drivers/staging/ks7010/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/ks7010/Kconfig b/drivers/staging/ks7010/Kco
to fix this.
Reported-by: Hulk Robot
Fixes: 8b523f20417d ("staging: ks7010: removed custom Michael MIC
implementation.")
Signed-off-by: YueHaibing
---
v2: use 'depends on' instead of 'select'
---
drivers/staging/ks7010/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drive
If most_register_configfs_subsys fails, call
most_deregister_component to clean up.
Fixes: 919c03ae11b9 ("staging: most: enable configfs support")
Signed-off-by: YueHaibing
---
drivers/staging/most/sound/sound.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
There is no callers in tree, so can be removed.
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
---
drivers/staging/kpc2000/kpc2000/fileops.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000/fileops.c
b/drivers/staging/kpc2000/kpc2000/fileops.c
y: Hulk Robot
Fixes: 7dc7967fc39a ("staging: kpc2000: add initial set of Daktronics drivers")
Signed-off-by: YueHaibing
---
drivers/staging/kpc2000/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig
index fb59229
A null check before a kfree is redundant, so remove it.
This is detected by coccinelle.
Signed-off-by: YueHaibing
---
drivers/staging/kpc2000/kpc2000_spi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000_spi.c
b/drivers/staging/kpc2000
Remove duplicated include.
Signed-off-by: YueHaibing
---
drivers/staging/kpc2000/kpc2000/kp2000_module.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc2000/kp2000_module.c
b/drivers/staging/kpc2000/kpc2000/kp2000_module.c
index 661b0b74ed66..fa3bd266ba54 100644
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: YueHaibing
---
drivers/staging/kpc2000/kpc_spi/spi_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc_spi
rtw_joinbss_cmd:
drivers/staging/rtl8723bs/core/rtw_cmd.c:771:6: warning: variable auth set but
not used [-Wunused-but-set-variable]
They are never used, so can be removed.
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 6 ++
1 file changed, 2
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/rtl8723bs/hal/odm.c: In function 'odm_RSSIMonitorCheckCE':
drivers/staging/rtl8723bs/hal/odm.c:1258:7: warning:
variable 'FirstConnect' set but not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
If most_register_configfs_subsys() fails, we should
call most_deregister_component() do cleanup.
Reported-by: Hulk Robot
Fixes: 919c03ae11b9 ("staging: most: enable configfs support")
Signed-off-by: YueHaibing
---
drivers/staging/most/sound/sound.c | 5 -
1 file changed, 4 insert
aging: tegra-vde: Fix build error")
Fixes: b301f8de1925 ("media: staging: media: tegra-vde: Add IOMMU support")
Signed-off-by: YueHaibing
---
drivers/staging/media/tegra-vde/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/tegra-vd
/staging/rtl8192e/rtl8192e/rtl_dm.c:1904:32:
warning: variable 'cck_rx_ver2_min_index' set but not used
[-Wunused-but-set-variable]
They are never used, so can be removed.
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 12 +++-
1 file
since commit eb0e7bf3ca94 ("staging:
rtl8192u: ieee80211: ieee80211_crypt_ccmp.c: Use crypto API ccm(aes)")
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
8192e: rtllib_crypt_ccmp.c: Use crypto API ccm(aes)")
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
---
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
b/drivers/staging/rtl8192e/rtllib_cr
Remove including that don't need it.
Signed-off-by: YueHaibing
---
drivers/staging/media/imx/imx-media-csc-scaler.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx-media-csc-scaler.c
b/drivers/staging/media/imx/imx-media-csc-scaler.c
index de599af59ffc
Remove duplicated include.
Signed-off-by: YueHaibing
---
drivers/staging/exfat/exfat_super.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/exfat/exfat_super.c
b/drivers/staging/exfat/exfat_super.c
index 5b5c2ca8c9aa..f202a6588dc3 100644
--- a/drivers/staging/exfat
Remove including that don't need it.
Signed-off-by: YueHaibing
---
drivers/staging/exfat/exfat_super.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/exfat/exfat_super.c
b/drivers/staging/exfat/exfat_super.c
index 5b5c2ca8c9aa..cb43a39864af 100644
--- a/drivers/staging
Use kmemdup rather than duplicating its implementation
Signed-off-by: YueHaibing
---
drivers/staging/exfat/exfat_super.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/exfat/exfat_super.c
b/drivers/staging/exfat/exfat_super.c
index 5b5c2ca8c9aa
rote:
>>>>> On 8/26/19 3:31 PM, YueHaibing wrote:
>>>>>> If COMPILE_TEST is y and IOMMU_SUPPORT is n, selecting TEGRA_VDE
>>>>>> to m will set IOMMU_IOVA to m, this fails the building of
>>>>>> TEGRA_HOST1X and DRM_TEGRA which is y like
[=n] || COMPILE_TEST [=y])
Reported-by: Hulk Robot
Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS")
Signed-off-by: YueHaibing
---
drivers/staging/octeon/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/octeon/Kconfig b/drivers/st
-off-by: YueHaibing
---
drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
index a733046..95edd14 100644
--- a/drivers/staging/rtl8723bs/hal
On 2019/7/26 23:57, Stefan Wahren wrote:
> Hi Yue,
>
> Am 26.07.19 um 11:26 schrieb YueHaibing:
>> Fix gcc used-but-set-variable warning:
>
> just a nit. It is call "unused-but-set-variable"
Oh, yes, thanks!
>
> Acked-by: Stefan Wahren
>
>&
/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:6: warning:
variable local_uc set but not used [-Wunused-but-set-variable]
Remove the unused variables 'local_entity_uc' and 'local_uc'
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
Acked-by: Stefan Wahren
---
v3: fix patch title
aging as it is obsolete")
Signed-off-by: YueHaibing
---
drivers/staging/wusbcore/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wusbcore/Kconfig b/drivers/staging/wusbcore/Kconfig
index 056c60b..a559d02 100644
--- a/drivers/staging/wusbcore/Kconfig
+++
be removed.
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
---
drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
index 49fa81406..71919a3 100644
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/rtl8192e/rtllib_rx.c: In function rtllib_rx_InfraAdhoc:
drivers/staging/rtl8192e/rtllib_rx.c:1303:6: warning:
variable payload set but not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
On 2019/7/24 21:49, Robin Murphy wrote:
> On 24/07/2019 11:30, Sakari Ailus wrote:
>> Hi Yue,
>>
>> On Mon, Jul 22, 2019 at 09:47:49PM +0800, YueHaibing wrote:
>>> If IOMMU_SUPPORT is not set, ipu3 driver may select IOMMU_IOVA to m.
>>> But for ma
logic/qlge/ to
drivers/staging/qlge/")
Signed-off-by: YueHaibing
---
drivers/staging/qlge/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/qlge/Kconfig b/drivers/staging/qlge/Kconfig
index ae9ed2c..a3cb25a3 100644
--- a/drivers/staging/qlge/Kconfig
+++
'
Select IOMMU_IOVA while COMPILE_TEST is set to fix this.
Reported-by: Hulk Robot
Suggested-by: Dmitry Osipenko
Fixes: b301f8de1925 ("media: staging: media: tegra-vde: Add IOMMU support")
Signed-off-by: YueHaibing
---
drivers/staging/media/tegra-vde/Kconfig | 2 +-
1 file changed, 1
On 2019/7/25 22:49, Greg KH wrote:
> On Thu, Jul 25, 2019 at 10:27:16PM +0800, YueHaibing wrote:
>> use variables 'local_entity_uc' and 'local_uc',
>> mute gcc used-but-set-variable warning:
>>
>> drivers/staging/vc04_services/interface/vchiq_a
/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:6: warning:
variable local_uc set but not used [-Wunused-but-set-variable]
Remove the unused variables 'local_entity_uc' and 'local_uc'
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
---
v2: remove the unused variable
---
drivers
but not used [-Wunused-but-set-variable]
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:6: warning:
variable local_uc set but not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
---
drivers/staging/vc04_services/interface/vchiq_arm
Signed-off-by: YueHaibing
---
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
index 8e4caee..dd349c5 100644
--- a/drivers/staging/rtl8723bs/hal
1 - 100 of 134 matches
Mail list logo
