[PATCH] staging: rtl8723bs: os_dep: Remove unused declarations

From: Hariprasad Kelam Remove unused Macro declarations Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 -- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c| 3 --- drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 5 - 3 files changed, 10

[PATCH] staging: rtl8723bs: core: Remove Macro "IS_MAC_ADDRESS_BROADCAST"

From: Hariprasad Kelam Remove unused macro IS_MAC_ADDRESS_BROADCAST. In future if one wants use it ,use generic API "is_broadcast_ether_addr" Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 7 --- 1 file changed, 7 deletions(-) diff --git

[PATCH] staging: exfat: make use of kmemdup

From: Hariprasad Kelam fix below issue reported by coccicheck drivers/staging//exfat/exfat_super.c:2709:26-33: WARNING opportunity for kmemdup Signed-off-by: Hariprasad Kelam --- drivers/staging/exfat/exfat_super.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

[PATCH] staging: nvec: make use of devm_platform_ioremap_resource

From: Hariprasad Kelam fix below issue reported by coccicheck drivers/staging//nvec/nvec.c:794:1-5: WARNING: Use devm_platform_ioremap_resource for base Signed-off-by: Hariprasad Kelam --- drivers/staging/nvec/nvec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a

[PATCH] rtl8723bs: core: Remove code valid only for 5GHZ

From: Hariprasad Kelam As per TODO ,remove code valid only for 5 GHz(channel > 14). Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/c

[PATCH] staging: vc04_services: make use of devm_platform_ioremap_resource

From: Hariprasad Kelam fix below issue reported by coccicheck drivers/staging//vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:139 WARNING: Use devm_platform_ioremap_resource for g_regs Signed-off-by: Hariprasad Kelam --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c

[PATCH] staging: clocking-wizard: make use of devm_platform_ioremap_resource

From: Hariprasad Kelam Fix below issue reported by coccicheck drivers/staging//clocking-wizard/clk-xlnx-clock-wizard.c:147:1-15: WARNING: Use devm_platform_ioremap_resource for clk_wzrd -> base Signed-off-by: Hariprasad Kelam --- drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c

[PATCH] staging: fieldbus: make use of devm_platform_ioremap_resource

From: Hariprasad Kelam fix below issues reported by coccicheck drivers/staging//fieldbus/anybuss/arcx-anybus.c:135:1-5: WARNING: Use devm_platform_ioremap_resource for base drivers/staging//fieldbus/anybuss/arcx-anybus.c:248:1-14: WARNING: Use devm_platform_ioremap_resource for cd -> cpld_b

[PATCH] staging: media: imx: make use devm_platform_ioremap_resource

From: Hariprasad Kelam fix below issue reported by coccicheck drivers/staging//media/imx/imx7-mipi-csis.c:973:1-12: WARNING: Use devm_platform_ioremap_resource for state -> regs Signed-off-by: Hariprasad Kelam --- drivers/staging/media/imx/imx7-mipi-csis.c | 4 +--- 1 file changed

[PATCH] staging: mt7621-dma: make use of devm_platform_ioremap_resource

From: Hariprasad Kelam fix below issue reported by coccicheck rivers/staging//mt7621-dma/mtk-hsdma.c:671:1-5: WARNING: Use devm_platform_ioremap_resource for base Signed-off-by: Hariprasad Kelam --- drivers/staging/mt7621-dma/mtk-hsdma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH] staging: netlogic: make use of devm_platform_ioremap_resource

From: Hariprasad Kelam fix below issue reported by coccicheck drivers/staging//netlogic/xlr_net.c:980:2-17: WARNING: Use devm_platform_ioremap_resource for priv -> base_addr Signed-off-by: Hariprasad Kelam --- drivers/staging/netlogic/xlr_net.c | 3 +-- 1 file changed, 1 insertion(+)

[PATCH] staging: ralink-gdma: make use of devm_platform_ioremap_resource

From: Hariprasad Kelam fix below issue reported by coccicheck drivers/staging//ralink-gdma/ralink-gdma.c:822:1-5: WARNING: Use devm_platform_ioremap_resource for base Signed-off-by: Hariprasad Kelam --- drivers/staging/ralink-gdma/ralink-gdma.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] staging: emxx_udc: make use of devm_platform_ioremap_resource

From: Hariprasad Kelam fix below issue reported by coccicheck drivers/staging//emxx_udc/emxx_udc.c:3092:1-10: WARNING: Use devm_platform_ioremap_resource for mmio_base Signed-off-by: Hariprasad Kelam --- drivers/staging/emxx_udc/emxx_udc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH] staging: media: make use of devm_platform_ioremap_resource

From: Hariprasad Kelam fix below issue reported by coccicheck drivers/staging//media/omap4iss/iss.c:915:1-15: WARNING: Use devm_platform_ioremap_resource for iss -> regs [ res ] Signed-off-by: Hariprasad Kelam --- drivers/staging/media/omap4iss/iss.c | 6 +- 1 file changed, 1 insert

[PATCH] staging: media: sunxi: make use of devm_platform_ioremap_resource

From: Hariprasad Kelam fix below issue reported by coccicheck drivers/staging//media/sunxi/cedrus/cedrus_hw.c:229:1-10: WARNING: Use devm_platform_ioremap_resource for dev -> base Signed-off-by: Hariprasad Kelam --- drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 4 +--- 1 file changed

[PATCH] staging: comedi: Fix spelling mistake

changes interupts --> interrupts to fix warning reported by checkpatch tool Signed-off-by: Hariprasad Kelam --- drivers/staging/comedi/drivers/dt2811.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/dt2811.c b/drivers/staging/comedi/driv

[Patch v2 01/10] staging: rtl8723bs: os_dep: Remove function _rtw_regdomain_select

This function simply returns &rtw_regdom_rd . So replace this function with actual code Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/staging/rtl87

[Patch v2 02/10] staging: rtl8723bs: os_dep: Move common code to func

Inthis file all functions has below common functionality 1.Check flag padapter->bSurpriseRemoved 2.Get sdio_func structure from intf_hdl. This patch introduces two new APIs rtw_isadapter_removed,rtw_sdio_get_func which helps to do above common functionality. Signed-off-by: Hariprasad Ke

[Patch v2 03/10] staging: rtl8723bs: os_dep: Remove unused function argument sdio_device_id

Remove passing pdid as function argument to rtw_sdio_if1_init as it is not being used Signed-off-by: Hariprasad Kelam --- v3 - Add patch number drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep

[Patch v2 04/10] staging: rtl8723bs: hal: Remove function argument padapter

Remove function argument "padapter" in rtl8723bs_init_recv_priv function as its not being used Signed-off-by: Hariprasad Kelam --- v4 - Add patch number drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 4 ++-- drivers/staging/rtl8723bs/include/recv_osdep.h | 2 +- drivers/staging

[Patch v2 05/10] staging: rtl8723bs: os_dep: Remove unused defines

Remove below unused defines RTW_CH_MAX_2G_CHANNEL rtw_a_rates RTW_A_RATES_NUM RTW_5G_CHANNELS_NUM Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep

[Patch v2 06/10] staging: rtl8723bs: os_dep: Remove unused defines related to combo scan

Remove below defines WEXT_CSCAN_AMOUNT WEXT_CSCAN_BUF_LEN WEXT_CSCAN_NPROBE_SECTION Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b

[Patch v2 07/10] staging: rtl8723bs: Remove unneeded function argument for init_addba_retry_timer

init_addba_retry_timer does not use padapter, so only keep psta Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- drivers/staging/rtl8723bs/os_dep/mlme_linux.c| 2 +- 3

[Patch v2 08/10] staging: rtl8723bs: core: Remove unneeded extern WFD_OUI

Remove unneeded extern variable "extern unsigned char WFD_OUI" Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_ap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/cor

[Patch v2 09/10] staging: rtl8723bs: core: Remove unneeded variables sgi_20m,sgi_40m and sgi_80m

htpriv.sgi_* variables are of type u8 ,instead of storing them in local variables ,its better to read value directly from structure. Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 --- 1 file changed, 4 insertions(+), 7

[Patch v2 10/10] staging: rtl8723bs: core: Remove Macro "IS_MAC_ADDRESS_BROADCAST"

Remove unused macro IS_MAC_ADDRESS_BROADCAST. In future if one wants use it ,use generic API "is_broadcast_ether_addr" Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 7 --- 1 file changed, 7 deletions(-) diff --git

[PATCH] staging: rtl8192e: Make use kmemdup

As kmemdup API does kmalloc + memcpy . We can make use of it instead of calling kmalloc and memcpy independetly. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8192e/rtllib_softmac.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/staging

Re: [PATCH] staging: rtl8192e: Make use kmemdup

On Sat, Aug 03, 2019 at 10:52:04AM -0700, Joe Perches wrote: > On Sat, 2019-08-03 at 23:10 +0530, Hariprasad Kelam wrote: > > As kmemdup API does kmalloc + memcpy . We can make use of it instead of > > calling kmalloc and memcpy independetly. > [] > > diff --git a/

[Patch v2] staging: rtl8192e: Make use kmemdup

As kmemdup API does kmalloc + memcpy . We can make use of it instead of calling kmalloc and memcpy independetly. Signed-off-by: Hariprasad Kelam --- v2 - remove the netdev_info() uses for allocation failures drivers/staging/rtl8192e/rtllib_softmac.c | 24 +++- 1 file

[PATCH] staging: rtl8192u: Add NULL check post kzalloc

Collect returns status of kzalloc. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8192u/r8192U_core.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index fe1f279..3240442

[PATCH] staging: rtl8723bs: core: Remove unneeded declaration WFD_OUI

Remove unneeded declaration "extern unsigned char WFD_OUI" Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_ap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c index 02f547

[PATCH V2] staging: comedi: dt2811: Fix spelling mistake

changes interupts --> interrupts to fix warning reported by checkpatch tool Signed-off-by: Hariprasad Kelam --- Changes in v2: - Make the Subject more clear by including changed file path. --- drivers/staging/comedi/drivers/dt2811.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH] staging: wlan-ng: collect return status without variable

err and result variables are declared to collect return status of prism2_domibset_uint32. Check return status in if loop and return directly. Rearragne code such that we can avoid declaring these variables. Signed-off-by: Hariprasad Kelam --- drivers/staging/wlan-ng/cfg80211.c | 17

Re: [PATCH] staging: wlan-ng: collect return status without variable

On Fri, May 10, 2019 at 01:57:54PM +0300, Dan Carpenter wrote: > On Fri, May 10, 2019 at 08:09:00AM +0530, Hariprasad Kelam wrote: > > diff --git a/drivers/staging/wlan-ng/cfg80211.c > > b/drivers/staging/wlan-ng/cfg80211.c > > index 8a862f7..5dad5ac 100644 > > --

Re: [PATCH] staging: wlan-ng: collect return status without variable

On Fri, May 10, 2019 at 09:40:11PM +0300, Dan Carpenter wrote: > On Fri, May 10, 2019 at 10:53:08PM +0530, Hariprasad Kelam wrote: > > On Fri, May 10, 2019 at 01:57:54PM +0300, Dan Carpenter wrote: > > > On Fri, May 10, 2019 at 08:09:00AM +0530, Hariprasad Kelam wrote: > >

[Patch v2] drivers: staging : wlan-ng : collect return status without variable

As caller rdev_set_default_key not particular about -EFAULT. We can preserve the return value of prism2_domibset_uint32. Signed-off-by: Hariprasad Kelam - Changes in v2: - remove masking of original return value with EFAULT --- drivers/staging/wlan-ng/cfg80211.c | 9 +++-- 1 file

[PATCH v3] drivers: staging : wlan-ng : collect return status without variable

As caller rdev_set_default_key not particular about -EFAULT. We can preserve the return value of prism2_domibset_uint32. Signed-off-by: Hariprasad Kelam Changes in v2: - remove masking of original return value with EFAULT Changes in v3: - merge patch v1 and v2 sothat it can be applied

[PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret

fix below issue reported by coccicheck drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2685:5-8: Unneeded variable: "ret". Return "0" on line 3266 Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 +-- 1 file changed, 1 insertion(+),

[PATCH] staging: rtl8723bs: core fix warning "Comparison to bool"

fix below issue reported by coccicheck drivers/staging/rtl8723bs/core/rtw_cmd.c:1741:7-17: WARNING: Comparison to bool Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core

[PATCH] staging: rtl8723bs: core fix warning Comparison to bool

fix below issue reported by coccicheck drivers/staging/rtl8723bs/core/rtw_mlme.c:1675:6-10: WARNING: Comparison to bool Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs

[PATCH] staging :rtl8723bs :core fix WARNING: Comparison to bool

fix below warning reported by coccicheck drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:181:5-40: WARNING: Comparison to bool Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[Patch v2] staging: rtl8723bs: os_dep: Remove Unneeded variable ret

fix below issue reported by coccicheck drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2685:5-8: Unneeded variable: "ret". Return "0" on line 3266 Signed-off-by: Hariprasad Kelam Changes in v2: - make subject line more clean --- drivers/staging/rtl8723bs/os_dep/ioct

[PATCH] staging: rtl8723bs: core: rtw_recv: fix warning Unneeded variable ret

fix below warning reported by coccicheck drivers/staging/rtl8723bs/core/rtw_recv.c:1903:5-8: Unneeded variable: "ret". Return "_SUCCESS" on line 1972 drivers/staging/rtl8723bs/core/rtw_recv.c:1618:6-9: Unneeded variable: "ret". Return "_SUCCESS" on li

[PATCH] staging: rtl8723bs: core: rtw_recv: fix warning Comparison to NULL

fix below warning reported by checkpatch CHECK: Comparison to NULL could be written "!precvpriv->pallocated_frame_buf" CHECK: Comparison to NULL could be written "padapter" Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_recv.c | 48 +++

Re: [PATCH] staging: rtl8723bs: core: rtw_recv: fix warning Comparison to NULL

On Thu, May 16, 2019 at 11:00:56AM +0300, Dan Carpenter wrote: > On Wed, May 15, 2019 at 11:15:36PM +0530, Hariprasad Kelam wrote: > > @@ -1042,7 +1042,7 @@ sint sta2ap_data_frame( > > } > > > > *psta = rtw_get_stainfo(pstapriv, pattrib->s

[PATCH] staging: erofs: fix Warning Use BUG_ON instead of if condition followed by BUG

fix below warning reported by coccicheck drivers/staging/erofs/unzip_pagevec.h:74:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Signed-off-by: Hariprasad Kelam --- drivers/staging/erofs/unzip_pagevec.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

[PATCH] staging: media: imx: fix Unneeded variable: "ret". Return "0"

fix below warning reported by coccichec drivers/staging/media/imx/imx-media-capture.c:617:5-8: Unneeded variable: "ret". Return "0" on line 630 Signed-off-by: Hariprasad Kelam --- drivers/staging/media/imx/imx-media-capture.c | 3 +-- 1 file changed, 1 insertion(+), 2 dele

[Patch v2] staging: erofs: fix Warning Use BUG_ON instead of if condition followed by BUG

fix below warning reported by coccicheck drivers/staging/erofs/unzip_pagevec.h:74:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Signed-off-by: Hariprasad Kelam - Changes in v2: - replace BUG_ON with DBG_BUGON - --- drivers/staging/erofs/unzip_pagevec.h | 3

Re: [Patch v2] staging: erofs: fix Warning Use BUG_ON instead of if condition followed by BUG

On Sun, May 19, 2019 at 05:50:40PM +0800, Gao Xiang wrote: > > > On 2019/5/19 下午5:34, Hariprasad Kelam wrote: > > fix below warning reported by coccicheck > > > > drivers/staging/erofs/unzip_pagevec.h:74:2-5: WARNING: Use BUG_ON > > instead of if condition fol

[PATCH] staging: rtl8723bs: core: rtw_ap: fix Unneeded variable: "ret". Return "0"

This patch fixes below warnings reported by coccicheck drivers/staging/rtl8723bs/core/rtw_ap.c:1400:5-8: Unneeded variable: "ret". Return "0" on line 1441 drivers/staging/rtl8723bs/core/rtw_ap.c:2195:5-8: Unneeded variable: "ret". Return "0" on li

[PATCH] staging: rtl8723bs: os_dep: os_intfs: fix warning Unneeded variable: "status". Return "_SUCCESS"

rtl8723bs/os_dep/os_intfs.c:1429:5-8: Unneeded variable: "ret". Return "_SUCCESS" on line 1451 drivers/staging/rtl8723bs/os_dep/os_intfs.c:1300:5-8: Unneeded variable: "ret". Return "_SUCCESS" on line 1368 Signed-off-by: Hariprasad Kelam --- drivers/sta

[PATCH] taging: rtl8723bs: hal: odm_HWConfig: odm_HWConfig: Unneeded variable: "result". Return "HAL_STATUS_SUCCESS"

This patch fixes below warnings reported by coccicheck drivers/staging/rtl8723bs/hal/odm_HWConfig.c:501:4-10: Unneeded variable: "result". Return "HAL_STATUS_SUCCESS" on line 526 Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 4 +--

[PATCH] staging: rtl8723bs: core: rtw_mlme_ext: fix warning Unneeded variable: "ret"

SUCCESS" on line 494 Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index d110d45..6a2eb6

[Patch v2] staging: rtl8723bs: hal: odm_HWConfig: odm_HWConfig: Unneeded variable: "result". Return "HAL_STATUS_SUCCESS"

This patch fixes below warnings reported by coccicheck drivers/staging/rtl8723bs/hal/odm_HWConfig.c:501:4-10: Unneeded variable: "result". Return "HAL_STATUS_SUCCESS" on line 526 Signed-off-by: Hariprasad Kelam - Changes in v2: - fixed typo in commit message ---

[Patch v2] staging: rtl8723bs: core: rtw_ap: fix Unneeded variable: "ret". Return "0

Function "rtw_sta_flush" always returns 0 value. So change return type of rtw_sta_flush from int to void. Same thing applies for rtw_hostapd_sta_flush Signed-off-by: Hariprasad Kelam -- Changes v2 - change return type of rtw_sta_flush - drivers/staging/rtl8723bs/cor

[Patch v3] staging: rtl8723bs: core: rtw_ap: fix Unneeded variable: "ret". Return "0

Function "rtw_sta_flush" always returns 0 value. So change return type of rtw_sta_flush from int to void. Same thing applies for rtw_hostapd_sta_flush Signed-off-by: Hariprasad Kelam -- Changes v2 - change return type of rtw_sta_flush -- Changes v3 - fix indent

[PATCH] staging: unisys: visornic: Replace GFP_ATOMIC with GFP_KERNEL

other situations where you cannot sleep And we can take advantage of GFP_KERNEL , as when system is in low memory chances of getting success is high compared to GFP_ATOMIC. As visornic_probe is in process context we can use GPF_KERNEL. Signed-off-by: Hariprasad Kelam --- drivers/staging/unisys

[PATCH v3] staging: rtl8723bs: core: rtw_ap: fix Unneeded variable: "ret". Return "0

Function "rtw_sta_flush" always returns 0 value. So change return type of rtw_sta_flush from int to void. Same thing applies for rtw_hostapd_sta_flush Signed-off-by: Hariprasad Kelam -- Changes v2 - change return type of rtw_sta_flush -- Changes v3 - fix indent

[PATCH v2] staging: rtl8723bs: core: rtw_mlme_ext: fix warning Unneeded variable: "ret"

SUCCESS" on line 494 Signed-off-by: Hariprasad Kelam changes in v2: change return type of init_mlme_ext_priv() from int to void We cant change return type of on_action_spct() it is a call back function from action_handler.

[Patch v2] staging: rtl8723bs: core: rtw_recv: fix warning Comparison to NULL

fix below warning reported by checkpatch CHECK: Comparison to NULL could be written "!precvpriv->pallocated_frame_buf" CHECK: Comparison to NULL could be written "padapter" Signed-off-by: Hariprasad Kelam - changes in v2: Corected few erorrs like (!*p

[Patch v3] staging: rtl8723bs: core: rtw_mlme_ext: fix warning Unneeded variable: "ret"

SUCCESS" on line 494 Signed-off-by: Hariprasad Kelam changes in v2: change return type of init_mlme_ext_priv() from int to void We cant change return type of on_action_spct() it is a call back function from action_handler.

[Patch v4] staging: rtl8723bs: core: rtw_ap: fix Unneeded variable: "ret". Return "0

Function "rtw_sta_flush" always returns 0 value. So change return type of rtw_sta_flush from int to void. Same thing applies for rtw_hostapd_sta_flush Signed-off-by: Hariprasad Kelam -- Changes v2 - change return type of rtw_sta_flush Changes v3 - fix indent

[PATCH] staging: mt7621-pci: pci-mt7621: Remove unneeded variable err

devm_request_pci_bus_resources function will return -EBUSY/-ENOMEM in fail case and returns 0 on success. So no need to store return value in err variable. Signed-off-by: Hariprasad Kelam --- drivers/staging/mt7621-pci/pci-mt7621.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions

[Patch v5] staging: rtl8723bs: core: rtw_ap: fix Unneeded variable: "ret". Return "0"

Function "rtw_sta_flush" always returns 0 value. So change return type of rtw_sta_flush from int to void. Same thing applies for rtw_hostapd_sta_flush Signed-off-by: Hariprasad Kelam - Changes v2 - change return type of rtw_sta_flush Changes v3 - fix indentaion iss

[PATCH] Staging: rtl8723bs: hal: fix warning possible condition with no effect (if == else)

this patch fixes below coccicheck warning ./drivers/staging/rtl8723bs/hal/odm_DIG.c:499:1-3: WARNING: possible condition with no effect (if == else) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/odm_DIG.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff

[PATCH] drivers: staging: speakup: serialio: fix warning linux/serial.h is included more than once

fix below warning reported by includecheck ./drivers/staging/speakup/serialio.h: linux/serial.h is included more than once. Signed-off-by: Hariprasad Kelam --- drivers/staging/speakup/serialio.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/speakup/serialio.h b

[PATCH] staging: rtl8723bs: core: fix warning Comparison to NULL

this patch fixes "Comparison to NULL" warnings reported by checkpatch Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 54 +++ 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw

[PATCH] staging: rtl8723bs: hal: fix error "do not initialise globals to 0"

this patch fixes below Errors reported by checkpatch ERROR: do not initialise globals to 0 +u8 g_fwdl_chksum_fail = 0; ERROR: do not initialise globals to 0 +u8 g_fwdl_wintint_rdy_fail = 0; Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ++-- 1 file

[PATCH] Staging: emxx_udc: fix warning "sum of probable bitmasks, consider |"

Knowing the fact that operator '|' is faster than '+'. Its better we replace + with | in this case. Issue reported by coccicheck drivers/staging/emxx_udc/emxx_udc.h:94:34-35: WARNING: sum of probable bitmasks, consider | Signed-off-by: Hariprasad Kelam --- drivers/staging

Re: [PATCH] Staging: emxx_udc: fix warning "sum of probable bitmasks, consider |"

On Mon, Jun 03, 2019 at 09:04:57PM +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 04, 2019 at 12:24:12AM +0530, Hariprasad Kelam wrote: > > Knowing the fact that operator '|' is faster than '+'. > > Its better we replace + with | in this case. > > >

[PATCH] staging: erofs: fix warning Comparison to bool

fix below warnings reported by coccicheck drivers/staging/erofs/unzip_vle.c:332:11-18: WARNING: Comparison to bool Signed-off-by: Hariprasad Kelam --- drivers/staging/erofs/unzip_vle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/erofs/unzip_vle.c b

[PATCH] staging: erofs: make use of DBG_BUGON

DBG_BUGON is introduced and it could only crash when EROFS_FS_DEBUG (EROFS developping feature) is on. replace BUG_ON with DBG_BUGON. Signed-off-by: Hariprasad Kelam --- drivers/staging/erofs/unzip_vle.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH] staging: rtl8723bs: fix indentation issues

und that '/' (ctx:VxV) WARNING: Missing a blank line after declarations WARNING: braces {} are not necessary for single statement blocks CHECK: spaces preferred around that '/' (ctx:VxV) CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/st

[PATCH] staging: rtl8723bs: hal: move common code to macro

CRO HAL_BTC8723B2ANT_DMA_DURATION_ADJUST Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 746 ++-- 1 file changed, 293 insertions(+), 453 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c index cb62

[Patch v2] staging: rtl8723bs: hal: move common code to macro

In halbtc8723b2ant_TdmaDurationAdjust function,below piece of code is repeated many times. halbtc8723b2ant_PsTdma(pBtCoexist, NORMAL_EXEC, true, val); pCoexDm->psTdmaDuAdjType = val; So replace the same with "HAL_BTC8723B2ANT_DMA_DURATION_ADJUST" MACRO. Signed-off-by: Har

[PATCH 1/3] staging: rtl8723bs: fix warning comparison to NULL

This patch fixes below issue reported by checkpatch CHECK: Comparison to NULL could be written "!pxmitbuf->pallocated_buf" + if (pxmitbuf->pallocated_buf == NULL) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 +- 1 file chan

[PATCH 2/3] staging: rtl8723bs: fix issue "Using comparison to true is error prone"

this patch fixes below issue reported by checkpatch CHECK: Using comparison to true is error prone + if (res == true) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 3/3] staging: rtl8723bs: provide spaces around unary operators

+ if (pxmitpriv->free_xmitframe_cnt > (NR_XMITFRAME/4)) { ^ Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/d

[PATCH] staging: rtl8723bs: fix spaces required around unary operator

this patch fixes below issues reported by checkpatch ERROR: spaces required around that '=' (ctx:WxV) ERROR: spaces required around that '=' (ctx:WxV) ERROR: spaces required around that '<' (ctx:VxV) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8

[PATCH 1/2] staging: rtl8723bs: fix issue Comparison to NULL

This patch fixes below issues reported by checkpatch CHECK: Comparison to NULL could be written "rtw_proc" CHECK: Comparison to NULL could be written "!rtw_proc" CHECK: Comparison to NULL could be written "!rtw_proc" Signed-off-by: Hariprasad Kelam --- dr

[PATCH 2/2] rtl8723bs: os_dep: fix spaces preferred around unary operator

CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 24

[PATCH 1/3] staging: rtl8723bs: hal: sdio_ops: fix Comparison to NULL

this patch fixes below warning reported by checkpatch CHECK: Comparison to NULL could be written "c2h_evt" Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/

[PATCH 2/3] staging: rtl8723bs: hal: sdio_ops: fix spaces preferred around unary operator

CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) Signed-off-by: Hariprasad Kelam --- drive

[PATCH 3/3] staging: rtl8723bs: hal: sdio_ops: fix braces {} are not necessary for single statement blocks

This patch fixes below issue reported by checkpatch WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH] staging: rtl8723bs: hal: Change return type to void from u8

The function HalQueryTxOQTBufferStatus8723BSdio always returns true and caller functions are not bother about return status. Change return type to void. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 3 +-- drivers/staging/rtl8723bs/include/sdio_ops.h | 2

[PATCH 2/2] staging: rtl8723bs: hal: sdio_halinit: fix spaces preferred around that unary operator

CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '<<' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 92

[PATCH 1/2] staging: rtl8723bs: hal: sdio_halinit: fix comparison to true/false is error prone

CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal

[Patch v2 1/3] staging: rtl8723bs: hal: sdio_halinit: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam changes in v2: send proper patch without corruption --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 18

[Patch v2 2/3] staging: rtl8723bs: hal: sdio_halinit: fix spaces preferred around that unary operator

This patch fixes below issues reported by checkpatch CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '<<' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by: Hariprasad Kelam -- changes in v2:

[Patch v2 3/3] staging: rtl8723bs: hal: sdio_halinit: fix Comparison to NULL

This patch fixes below issue reported by checkpatch CHECK: Comparison to NULL could be written "psta" CHECK: Comparison to NULL could be written "psta" Signed-off-by: Hariprasad Kelam - changes in v2: Send proper patch with out corruption --- drivers/s

[PATCH 2/2] staging: rtl8723bs: hal: spaces preferred around unary operator

This patch fixes below issues reported by checkpatch CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '/' (ctx:VxV) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 8 1 file changed, 4 insert

[PATCH 1/2] staging: rtl8723bs: hal: Using comparison to true is error prone

fix below issue reported by checkpatch CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 26 +- 1 file changed, 13 insertions(+), 13

[PATCH] staging: rtl8723bs: hal: Remove return type of initrecvbuf

change return of initrecvbuf from s32 to void. As this function always returns SUCCESS . fix checkpatch warning "Comparison to false is error prone" Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 10 +++--- 1 file changed, 3 insertions(+), 7

[Patch v2 1/2] staging: rtl8723bs: hal: Remove return type of initrecvbuf

change return of initrecvbuf from s32 to void. As this function always returns SUCCESS . Signed-off-by: Hariprasad Kelam --- changes in v2: break the patch for specific change --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions

[Patch v2 2/2] staging: rtl8723bs: hal: fix Using comparison to false is error prone

fix below issue reported by checkpatch CHECK: Using comparison to false is error prone Signed-off-by: Hariprasad Kelam --- changes in v2: break the patch for specific change --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] staging: rtl8723bs: hal: Add null check after memory allocation

Add NULL check post call to rtw_zmalloc. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c index ac79de8..9177c18 100644 --- a

[PATCH] staging/rtl8723bs/core: Remove redundant call to memset

rtw_zmalloc is doing memset . So there is no need to call memset again. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index

[PATCH] staging/rtl8723bs/core/rtw_ap: Remove redundant call to memset

rtw_zmalloc is internally doing memset . So there is no need to call memset again. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_ap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c

[PATCH] staging: rtl8723bs: os_dep: Make use rtw_zmalloc

rtw_malloc with memset can be replaced with rtw_zmalloc. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs

[PATCH] staging: rtl8723bs: os_dep: ioctl_linux: Make use rtw_zmalloc

rtw_malloc with memset can be replace with rtw_zmalloc. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs

  1   2   >