> > Either way, it's not clear to me and I think the code needs cleaning
> > up.
> > Any ideas?
>
> 10+ year old code, yeah!!!
>
> Just guess, who knows, no one seems to care :(
I'm at least interested in helping with cleaning the code and learning
about the driver, maybe fixing up logical err
is.
Does anybody know what this is there for? If not, does it make sense to
just go ahead and remove the code there?
Stephen
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
> staging: erofs: rename superblock flags (MS_xyz -> SB_xyz)
> staging: erofs: update .mount and .remount_sb
I noticed, thanks.
--
Cheers,
Stephen Rothwell
pgphPCaln6Mel.pgp
Description: OpenPGP digital signature
_
Avoid going from struct page to virt address (and back) by just
keeping pointer to the allocated pages instead of virt address.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 20 +---
drivers/uio/uio_hv_generic.c | 5 +++--
include/linux/hyperv.h | 2
Rather than passing relid and then looking up the channel.
Pass the channel directly, since caller already knows it.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 3 +--
drivers/hv/channel_mgmt.c | 17 +
drivers/hv/vmbus_drv.c| 3 +--
include/linux
The ring buffer is contiguous IOVA and is mapped via phys addr
for sysfs file. Use same method for the UIO mapping.
Signed-off-by: Stephen Hemminger
---
drivers/uio/uio_hv_generic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/uio/uio_hv_generic.c b/drivers
Introduce the concept of mapping physical memory locations that
are normal memory. The new type UIO_MEM_IOVA are similar to
existing UIO_MEM_PHYS but the backing memory is not marked as uncached.
Also, indent related switch to the currently used style.
Signed-off-by: Stephen Hemminger
because the vmbus channel was
persistent. Change the semantics so that the buffers are
allocated on probe, but not attached to host until
device is opened.
Signed-off-by: Stephen Hemminger
---
drivers/uio/uio_hv_generic.c | 102 ---
1 file changed, 72 insertions
backported as a fix, to 4.19 but that is not
an LTS so probably not worth it.
Stephen Hemminger (6):
vmbus: pass channel to hv_process_channel_removal
vmbus: keep pointer to ring buffer page
vmbus: split ring buffer allocation from open
uio: introduce UIO_MEM_IOVA
hv_uio_generic: map
application restarts.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 267 ++-
drivers/hv/ring_buffer.c | 1 +
include/linux/hyperv.h | 9 ++
3 files changed, 162 insertions(+), 115 deletions(-)
diff --git a/drivers/hv/channel.c b/drivers/hv
backported as a fix, to 4.19 but that is not
an LTS so probably not worth it.
v2 - add refcount unwind in hv_uio_generic open in case of error
Stephen Hemminger (6):
vmbus: pass channel to hv_process_channel_removal
vmbus: keep pointer to ring buffer page
vmbus: split ring buffer allocation
application restarts.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 267 ++-
drivers/hv/ring_buffer.c | 1 +
include/linux/hyperv.h | 9 ++
3 files changed, 162 insertions(+), 115 deletions(-)
diff --git a/drivers/hv/channel.c b/drivers/hv
The ring buffer is contiguous IOVA and is mapped via phys addr
for sysfs file. Use same method for the UIO mapping.
Signed-off-by: Stephen Hemminger
---
drivers/uio/uio_hv_generic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/uio/uio_hv_generic.c b/drivers
Avoid going from struct page to virt address (and back) by just
keeping pointer to the allocated pages instead of virt address.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 20 +---
drivers/uio/uio_hv_generic.c | 5 +++--
include/linux/hyperv.h | 2
Rather than passing relid and then looking up the channel.
Pass the channel directly, since caller already knows it.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 3 +--
drivers/hv/channel_mgmt.c | 17 +
drivers/hv/vmbus_drv.c| 3 +--
include/linux
because the vmbus channel was
persistent. Change the semantics so that the buffers are
allocated on probe, but not attached to host until
device is opened.
Signed-off-by: Stephen Hemminger
---
drivers/uio/uio_hv_generic.c | 104 +--
1 file changed, 74 insertions
Introduce the concept of mapping physical memory locations that
are normal memory. The new type UIO_MEM_IOVA are similar to
existing UIO_MEM_PHYS but the backing memory is not marked as uncached.
Also, indent related switch to the currently used style.
Signed-off-by: Stephen Hemminger
Introduce the concept of mapping physical memory locations that
are normal memory. The new type UIO_MEM_IOVA are similar to
existing UIO_MEM_PHYS but the backing memory is not marked as uncached.
Also, indent related switch to the currently used style.
Signed-off-by: Stephen Hemminger
The ring buffer is contiguous IOVA and is mapped via phys addr
for sysfs file. Use same method for the UIO mapping.
Signed-off-by: Stephen Hemminger
---
drivers/uio/uio_hv_generic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/uio/uio_hv_generic.c b/drivers
because the vmbus channel was
persistent. Change the semantics so that the buffers are
allocated on probe, but not attached to host until
device is opened.
Signed-off-by: Stephen Hemminger
---
drivers/uio/uio_hv_generic.c | 104 +--
1 file changed, 74 insertions
Avoid going from struct page to virt address (and back) by just
keeping pointer to the allocated pages instead of virt address.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 20 +---
drivers/uio/uio_hv_generic.c | 5 +++--
include/linux/hyperv.h | 2
Rather than passing relid and then looking up the channel.
Pass the channel directly, since caller already knows it.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 3 +--
drivers/hv/channel_mgmt.c | 17 +
drivers/hv/vmbus_drv.c| 3 +--
include/linux
backported as a fix, to 4.19 but that is not
an LTS so probably not worth it.
v3 - fix typo (sent wrong version for v2)
v2 - fix refcount when hv_uio_open fails
Stephen Hemminger (6):
vmbus: pass channel to hv_process_channel_removal
vmbus: keep pointer to ring buffer page
vmbus: split
application restarts.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 267 ++-
drivers/hv/ring_buffer.c | 1 +
include/linux/hyperv.h | 9 ++
3 files changed, 162 insertions(+), 115 deletions(-)
diff --git a/drivers/hv/channel.c b/drivers/hv
together here for better review. The PCI changes
were submitted previously, but the main review comment was "why do you
need this?". This is why.
v2 - slot name can be shorter.
remove locking when creating pci_slots; see comment for explaination
Stephen Hemminger (2):
PCI: h
Matching network device based on MAC address is problematic
since a non VF network device can be creted with a duplicate MAC
address causing confusion and problems. The VMBus API does provide
a serial number that is a better matching method.
Signed-off-by: Stephen Hemminger
---
drivers/net
sing GPU's. But the PCI slot infrastructure will handle
that.
This has a side effect which may also be useful. The common udev
network device naming policy uses the slot information (rather
than PCI address).
Signed-off-by: Stephen Hemminger
---
drivers/pci/controll
On Thu, 20 Sep 2018 20:33:01 +0800
YueHaibing wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_
On Thu, 20 Sep 2018 15:18:20 +0100
Lorenzo Pieralisi wrote:
> On Fri, Sep 14, 2018 at 12:54:55PM -0700, Stephen Hemminger wrote:
> > The Hyper-V implementation of PCI controller has concept of 32 bit serial
> > number
> > (not to be confused with PCI-E serial number). This
On Thu, 20 Sep 2018 17:06:59 +
Haiyang Zhang wrote:
> +static inline void rsc_add_data
> + (struct netvsc_channel *nvchan,
> + const struct ndis_pkt_8021q_info *vlan,
> + const struct ndis_tcp_ip_checksum_info *csum_info,
> + void *data, u32 len)
> +{
Could this be changed
On Thu, 20 Sep 2018 20:56:46 +
Haiyang Zhang wrote:
> > -Original Message-
> > From: Stephen Hemminger
> > Sent: Thursday, September 20, 2018 4:48 PM
> > To: Haiyang Zhang
> > Cc: Haiyang Zhang ; da...@davemloft.net;
> > net...@vger.k
On Fri, 21 Sep 2018 18:20:35 +
Haiyang Zhang wrote:
Overall, this looks good. Some minor suggestions.
> +struct nvsc_rsc {
> + const struct ndis_pkt_8021q_info *vlan;
> + const struct ndis_tcp_ip_checksum_info *csum_info;
> + u8 is_last; /* last RNDIS msg in a vmtransfer_page */
On Fri, 21 Sep 2018 18:51:54 +
Haiyang Zhang wrote:
> > -Original Message-
> > From: Stephen Hemminger
> > Sent: Friday, September 21, 2018 2:37 PM
> > To: Haiyang Zhang
> > Cc: Haiyang Zhang ; da...@davemloft.net;
> > net...@vger.k
On 09/25/2018 01:27 PM, Tong Zhang wrote:
Kernel Version: 4.18.5
Problem Description:
When setting nice value, it is checked by LSM function security_task_setnice().
see kernel/sched/core.c:3972 SYSCALL_DEFINE1(nice, int, increment)
We discovered a leaking path in android binder which allows u
On Wed, 26 Sep 2018 18:25:10 +0800
YueHaibing wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_
On Thu, 27 Sep 2018 10:57:05 +0200
Mohammed Gamal wrote:
> On Wed, 2018-09-26 at 17:13 +, Haiyang Zhang wrote:
> > > -Original Message-
> > > From: Mohammed Gamal
> > > Sent: Wednesday, September 26, 2018 12:34 PM
> > > To: Stephen Hemminger ;
On Fri, 12 Oct 2018 20:55:15 +
Haiyang Zhang wrote:
Thanks for fixing this.
> + if (kstrtou32(kobject_name(&pdev->slot->kobj), 10, &serial)) {
> + netdev_notice(vf_netdev, "Invalid vf serial:%s\n",
> + pdev->slot->kobj.name);
> + retur
paired with synthetic
> NIC.
>
> Fixes: 00d7ddba1143 ("hv_netvsc: pair VF based on serial number")
> Reported-by: Vitaly Kuznetsov
> Signed-off-by: Haiyang Zhang
Reviewed-by: Stephen Hemminger
___
devel mailing list
de...@linuxdriv
On Thu, 18 Oct 2018 17:19:53 +0200
Olaf Hering wrote:
> Am Sun, 17 Sep 2017 20:54:18 -0700
> schrieb k...@exchange.microsoft.com:
>
> > This extends existing vmbus related sysfs structure to provide per-channel
> > state information. This is useful when diagnosing issues with multiple
> > queues
On Thu, 18 Oct 2018 15:32:35 +
Michael Kelley wrote:
> From Olaf Hering Sent: Thursday, October 18, 2018 8:20 AM
> >
> > > This extends existing vmbus related sysfs structure to provide per-channel
> > > state information. This is useful when diagnosing issues with multiple
> > > queues in
lockdep_assert_held is better at checking for locking requirements
since it doesn't get confused if someone else is holding the mutex.
Inspired by changes in network drivers by Lance Roy.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel_mgmt.c | 2 +-
drivers/hv/connection.c | 2
nd is processed.
Fixes: ae6935ed7d42 ("vmbus: split ring buffer allocation from open")
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index fe00b12e441
eported-by: Mohammed Gamal
Signed-off-by: Stephen Hemminger
---
drivers/uio/uio_hv_generic.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c
index c2493d011225..3c5169eb23f5 100644
--- a/drivers/uio/uio_hv_gener
S 0 /* GPIO_P153 on KZM9D */
> #define INT_VBUS 0 /* IRQ for GPIO_P153 */
> -struct gpio_desc *vbus_gpio;
> -int vbus_irq;
> +extern struct gpio_desc *vbus_gpio;
> +extern int vbus_irq;
>
> /* Board dependence(Wait) */
>
> --
Quoting Mauro Carvalho Chehab (2021-01-29 11:51:57)
> The Hisilicon 6421v600 SPMI driver is ready for mainstream.
>
> So, move it from staging.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
Acked-by: Stephen Boyd
Rob had some comments on the binding that don't look to
Quoting Sergio Paracuellos (2021-01-17 06:19:36)
> Hi all,
>
> On Sun, Dec 20, 2020 at 10:37 AM Sergio Paracuellos
> wrote:
> >
> > - Hardcode "xtal" as parent in FIXED macro.
> > - Change 'else if' clause into 'if' clause since a return statement was
> >being used in 'mt7621_xtal_recalc_ra
Quoting Sergio Paracuellos (2021-03-08 21:22:23)
> diff --git a/drivers/clk/ralink/Kconfig b/drivers/clk/ralink/Kconfig
> new file mode 100644
> index ..3e3f5cb9ad88
> --- /dev/null
> +++ b/drivers/clk/ralink/Kconfig
> @@ -0,0 +1,15 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +
Quoting Sergio Paracuellos (2021-03-08 21:22:21)
> Adds dt binding header for 'mediatek,mt7621-clk' clocks.
>
> Acked-by: Rob Herring
> Signed-off-by: Sergio Paracuellos
> ---
Applied to clk-next
___
devel mailing list
de...@linuxdriverproject.org
htt
Quoting Sergio Paracuellos (2021-03-08 21:22:22)
> Adds device tree binding documentation for clocks in the
> MT7621 SOC.
>
> Reviewed-by: Rob Herring
> Signed-off-by: Sergio Paracuellos
> ---
Applied to clk-next
___
devel mailing list
de...@linuxdriv
Quoting Sergio Paracuellos (2021-03-23 01:13:22)
> On Tue, Mar 9, 2021 at 6:22 AM Sergio Paracuellos
> wrote:
> >
> > Changes in v11:
> > - Collect Rob's Reviewed-by in bindings documentation patch.
> > - Fix MAINTAINERS patch using file 'mediatek,mt7621-sysc.yaml'
> >for documentation bindi
Quoting Sergio Paracuellos (2021-04-09 11:34:35)
> On Fri, Apr 9, 2021 at 8:14 PM Stephen Boyd wrote:
> >
> > Quoting Sergio Paracuellos (2021-03-08 21:22:23)
> > > diff --git a/drivers/clk/ralink/Makefile b/drivers/clk/ralink/Makefile
> > > new file mod
Quoting Michal Simek (2021-04-08 03:40:29)
>
>
> On 4/8/21 12:26 PM, Shubhrajyoti Datta wrote:
> > On Sun, Mar 7, 2021 at 1:50 AM Rob Herring wrote:
> >>
> >> On Wed, Feb 24, 2021 at 06:40:40PM +0530, Shubhrajyoti Datta wrote:
> >>> Add the devicetree binding for the xilinx clocking wizard.
> >>
Quoting Sergio Paracuellos (2021-04-09 22:50:56)
> The documentation for this SOC only talks about two
> registers regarding to the clocks:
> * SYSC_REG_CPLL_CLKCFG0 - provides some information about
> boostrapped refclock. PLL and dividers used for CPU and some
> sort of BUS.
> * SYSC_REG_CPLL_CLK
Quoting Sergio Paracuellos (2021-04-09 22:50:57)
> Clocks for SoC mt7621 have been properly integrated so there is
> no need to declare fixed clocks at all in the device tree. Remove
> all of them, add new device tree nodes for mt7621-clk and update
> the rest of the nodes to use them.
>
> Acked-b
Quoting Sergio Paracuellos (2021-04-09 22:50:58)
> Vendor listed for mediatek in kernel vendor file 'vendor-prefixes.yaml'
> contains 'mediatek' as a valid vendor string. Some nodes in the device
> tree are using an invalid vendor string vfor 'mtk' instead. Fix all of
> them in dts file. Update als
Quoting Sergio Paracuellos (2021-04-09 22:50:59)
> Adding myself as maintainer for mt7621 clock driver.
>
> Signed-off-by: Sergio Paracuellos
> ---
Applied to clk-next
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproj
151.67fcf...@canb.auug.org.au/
(the scmi tree commit mentioned in the latter is now in the arm-soc tree)
Not issues as such, but worth mentioning the conflicts and resolutions.
--
Cheers,
Stephen Rothwell
pgpGUzVR9OafJ.pgp
Description: OpenPGP digital
On Mon, Oct 4, 2021 at 8:27 PM Jann Horn wrote:
>
> On Tue, Oct 5, 2021 at 1:38 AM Casey Schaufler wrote:
> > On 10/4/2021 3:28 PM, Jann Horn wrote:
> > > On Mon, Oct 4, 2021 at 6:19 PM Casey Schaufler
> > > wrote:
> > >> On 10/1/2021 3:58 PM, Jann Horn wrote:
> > >>> On Fri, Oct 1, 2021 at 10:
On Tue, Oct 5, 2021 at 12:49 PM Todd Kjos wrote:
>
> On Tue, Oct 5, 2021 at 8:21 AM Stephen Smalley
> wrote:
> >
> > On Mon, Oct 4, 2021 at 8:27 PM Jann Horn wrote:
> > >
> > > On Tue, Oct 5, 2021 at 1:38 AM Casey Schaufler
> > > wrot
's 'struct task'. This ensures
> > > > > the euid is associated with the security context that
> > > > > of the task that opened binder.
> > > > >
> > > > > Fixes: 457b9a6f09f0 ("Staging: android: add binder driver")
&
Quoting Shubhrajyoti Datta (2020-08-28 06:39:53)
> Currently the set rate granularity is to integral divisors.
> Add support for the fractional divisors.
> Only the first output0 is fractional in the hardware.
>
> Signed-off-by: Shubhrajyoti Datta
Getting closer.
> diff --git a/drivers/clk/clk-
Quoting Shubhrajyoti Datta (2020-08-28 06:39:50)
> Add clocking wizard driver to clk.
>
> Signed-off-by: Shubhrajyoti Datta
> ---
Can this be combined with patch #6? And then use git format-patch -C -M
when generating patches? I'm trying to see if anything changed from the
file in the staging tr
Quoting Stephen Boyd (2020-09-21 14:19:59)
> Quoting Shubhrajyoti Datta (2020-08-28 06:39:50)
> > Add clocking wizard driver to clk.
> >
> > Signed-off-by: Shubhrajyoti Datta
> > ---
>
> Can this be combined with p
Quoting Shubhrajyoti Datta (2020-08-28 06:39:52)
> The patch adds support for dynamic reconfiguration of clock output rate.
> Output clocks are registered as dividers and set rate callback function
> is used for dynamic reconfiguration.
>
> Based on the initial work from Chirag.
>
> Signed-off-by
Quoting Shubhrajyoti Datta (2020-09-23 23:23:11)
>
> > -Original Message-
> > From: Stephen Boyd
> > Sent: Tuesday, September 22, 2020 2:48 AM
> > > +}
> > > +
> > > +static long clk_wzrd_round_
Quoting Mauro Carvalho Chehab (2020-10-09 05:15:30)
> Several *.txt files got converted to yaml. Update their
> references at MAINTAINERS file accordingly.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
Acked-by: Stephen Boyd
___
dev
Quoting Krzysztof Kozlowski (2020-11-15 09:09:48)
> COMMON_CLK even though is a user-selectable symbol, is still selected by
> multiple other config options. COMMON_CLK should not be used when
> legacy clocks are provided by architecture, so it correctly depends on
> !HAVE_LEGACY_CLK.
>
> However
Quoting Krzysztof Kozlowski (2020-11-17 23:48:12)
> On Tue, Nov 17, 2020 at 11:41:57PM -0800, Stephen Boyd wrote:
> > Quoting Krzysztof Kozlowski (2020-11-15 09:09:48)
> > > COMMON_CLK even though is a user-selectable symbol, is still selected by
> > > multiple other
was enabled. Now that isn't necessary and any
user-selectable options should be moved to depends syntax.
Reviewed-by: Stephen Boyd
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Quoting Krzysztof Kozlowski (2020-11-25 06:15:05)
> On Tue, Nov 24, 2020 at 04:11:31PM -0800, Stephen Boyd wrote:
> >
> > Ok so this patch isn't necessary then?
>
> For this particular build failure - it is not necessary anymore.
>
> However there might more of s
Quoting Nicolas Saenz Julienne (2020-12-11 08:47:52)
> Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
> interface when unbinding the device.
>
> Signed-off-by: Nicolas Saenz Julienne
> Reviewed-by: Florian Fainelli
> ---
uce rpi_firmware_put()
> which will permit automatically decrease the reference count upon
> unbinding consumer drivers.
>
> Suggested-by: Uwe Kleine-König
> Signed-off-by: Nicolas Saenz Julienne
> Reviewed-by: Florian Fainelli
>
> ---
Reviewed-by: Stephen Boyd
_
Quoting Shubhrajyoti Datta (2020-11-04 07:06:40)
>
> Shubhrajyoti Datta (7):
> dt-bindings: add documentation of xilinx clocking wizard
Any chance to respond to Robs comments?
> clk: clock-wizard: Add the clockwizard to clk directory
Is it called 'wizard' anywhere in the documentation? I wo
--
Cheers,
Stephen Rothwell
pgp7wygbVYpNc.pgp
Description: OpenPGP digital signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Quoting Michal Simek (2020-12-15 01:13:46)
>
> Can you please take a look at this series?
>
I did, see
https://lore.kernel.org/r/16078386.1580929.1950826106627397...@swboyd.mtv.corp.google.com
___
devel mailing list
de...@linuxdriverproject.org
ht
Quoting Sergio Paracuellos (2020-11-22 01:55:52)
> Adds device tree binding documentation for clocks in the
> MT7621 SOC.
>
> Signed-off-by: Sergio Paracuellos
> ---
> .../bindings/clock/mediatek,mt7621-clk.yaml | 67 +++
> 1 file changed, 67 insertions(+)
> create mode 100644
Quoting Sergio Paracuellos (2020-11-22 01:55:53)
> The documentation for this SOC only talks about two
> registers regarding to the clocks:
> * SYSC_REG_CPLL_CLKCFG0 - provides some information about
> boostrapped refclock. PLL and dividers used for CPU and some
> sort of BUS.
> * SYSC_REG_CPLL_CLK
Quoting Sergio Paracuellos (2020-12-17 02:01:39)
>
> On Thu, Dec 17, 2020 at 9:58 AM Stephen Boyd wrote:
> >
> > Quoting Sergio Paracuellos (2020-11-22 01:55:52)
> >
> > > diff --git
> > > a/Documentation/devicetree/bindings/clock/mediatek,mt7621-
Quoting Sergio Paracuellos (2020-12-17 01:54:18)
>
> On Thu, Dec 17, 2020 at 10:09 AM Stephen Boyd wrote:
> >
> > Quoting Sergio Paracuellos (2020-11-22 01:55:53)
> > > diff --git a/drivers/clk/ralink/Makefile b/drivers/clk/ralink/Makefile
> > > new file
Quoting Jonathan Cameron (2018-12-08 07:29:54)
> On Thu, 6 Dec 2018 11:10:51 +0200
> Mircea Caprioru wrote:
>
> > This patch adds a clock to the state structure of ad7192 for getting the
> > external clock frequency. This modifications is in accordance with clock
> > framework dt bindings documen
ringbuffer bus attributes to dev_groups")
> Cc: sta...@vger.kernel.org
> Cc: K. Y. Srinivasan
> Cc: Haiyang Zhang
> Cc: Stephen Hemminger
> Signed-off-by: Dexuan Cui
The concept looks fine, but maybe it would be simpler to move it into
hv_ringbuffer_get_debuginfo and have it ret
On Mon, 17 Dec 2018 18:00:29 +
Dexuan Cui wrote:
> > From: Stephen Hemminger
> > On Thu, 13 Dec 2018 16:35:43 +
> > Dexuan Cui wrote:
> >
> > > Before 98f4c651762c, we returned zeros for unopened channels.
> > > With 98f4c651762c, w
On Mon, 17 Dec 2018 18:44:12 +
Dexuan Cui wrote:
> > From: devel On Behalf Of
> > Dexuan Cui
> > Sent: Monday, December 17, 2018 10:31 AM
> > > From: Stephen Hemminger
> > >
> > > The old code was risky because it would silently return
> +static ssize_t channel_intr_in_full_show(const struct vmbus_channel
> *channel,
> + char *buf)
> +{
> + return sprintf(buf, "%llu\n", channel->intr_in_full);
> +}
intr_in_full is u64, which is not the same as unsigned long long.
to be correct you nee
Fixed comparison on right side of test warnings.
Signed-off-by: Stephen Martin
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
b/drivers/staging/rtl8188eu/core
Quoting Jonathan Cameron (2018-12-16 02:07:41)
> Rob, Clk experts, questions for you below.
>
> Jonathan
>
>
> On Thu, 13 Dec 2018 17:39:22 -0800
> Stephen Boyd wrote:
>
> > Quoting Jonathan Cameron (2018-12-08 07:29:54)
> > > On Thu, 6 Dec 2018 11:1
("PCI: hv: support reporting serial number as slot
> information")
> Signed-off-by: Dexuan Cui
> Cc: sta...@vger.kernel.org
> Cc: Stephen Hemminger
Acked-by: Stephen Hemminger
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
vmbus_connection.monitor_pages[0]));
> }
> static DEVICE_ATTR_RO(server_monitor_pending);
Looks good.
I wonder if ever gets used though since it returned incorrect data...
Acked-by: Stephen Hemminger
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, 8 Feb 2019 05:01:12 -0500
Kimberly Brown wrote:
You are right, the current behavior is broken.
It would be good to add a description of under what conditions
monitor is not used. Is this some part of a project emulating
Hyper-V?
> +
> + if (!hv_dev->channel->offermsg.monitor_allocat
On Mon, 11 Feb 2019 02:01:18 -0500
Kimberly Brown wrote:
> On Fri, Feb 08, 2019 at 02:32:09PM -0800, Stephen Hemminger wrote:
> > On Fri, 8 Feb 2019 05:01:12 -0500
> > Kimberly Brown wrote:
> >
> > You are right, the current behavior is broken.
> > It woul
On Thu, 14 Feb 2019 01:11:03 -0500
Kimberly Brown wrote:
> On Mon, Feb 11, 2019 at 10:02:47AM -0800, Stephen Hemminger wrote:
> > On Mon, 11 Feb 2019 02:01:18 -0500
> > Kimberly Brown wrote:
> >
> > > On Fri, Feb 08, 2019 at 02:32:09PM -0800, Stephen Hemminger
Fixed else block indentation
Signed-off-by: Stephen Martin
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b/drivers/staging/rtl8188eu/core/rtw_xmit.c
index 3b1ccd138c3f..1723a47a96b4
int hyperv_fill_flush_guest_mapping_list(
struct hv_guest_mapping_flush_list *flush,
- u64 start_gfn, u64 pages)
+ int offset, u64 start_gfn, u64 pages)
{
u64 cur = start_gfn;
u64 additional_pages;
- int gpa_n = 0;
+ int gpa_n
/pci/controller/pci-hyperv.c | 23 +++
> 1 file changed, 23 insertions(+)
Thanks for fixing this.
Reviewed-by: Stephen Hemminger
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, 2 Aug 2019 19:56:02 +
Jose Carlos Cazarin Filho wrote:
> Fix checkpath error:
> CHECK: spaces preferred around that '*' (ctx:WxV)
> +extern hysdn_card *card_root;/* pointer to first card */
>
> Signed-off-by: Jose Carlos Cazarin Filho
Read the TODO, these drivers are sche
On Fri, 2 Aug 2019 19:50:17 +
Ricardo Bruno Lopes da Silva wrote:
> Fix error bellow from checkpatch.
>
> WARNING: Block comments use * on subsequent lines
> +/***
> +
>
> Signed-off-by: Ricardo Bruno Lopes da Silva
Read the TODO, t
Hi Gao,
One small suggestion: just remove the file names from the comments at
the top of the files rather than change them to reflect that they have
moved. We can usually tell the name of a file by its name :-)
--
Cheers,
Stephen Rothwell
pgpeto9QVOyjN.pgp
Description: OpenPGP digital
Hi Gao,
On Wed, 7 Aug 2019 01:02:58 +0800 Gao Xiang wrote:
>
> On Wed, Aug 07, 2019 at 01:34:23AM +1000, Stephen Rothwell wrote:
> >
> > One small suggestion: just remove the file names from the comments at
> > the top of the files rather than change them to reflect
Used checkpatch's --fix-inplace option for types SPACING, OPEN_BRACE,
ELSE_AFTER_BRACE. Manually edited the resulting changes to correct for
mistaken fixes and complete fixes that were only partially applied.
Signed-off-by: Stephen Brennan
---
To prevent this patch from getting even longe
Signed-off-by: Stephen Brennan
---
drivers/staging/rtl8192u/ieee80211/dot11d.c | 10 ++--
.../staging/rtl8192u/ieee80211/ieee80211.h| 4 +-
.../rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
.../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 22
.../rtl8192u/ieee80211
1 - 100 of 725 matches
Mail list logo
