[PATCH] staging: iio: Remove unnecessary cast on void pointer

2018-03-07 Thread Arushi Singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/iio/adc/ad7816.c | 2 +- 1 fil

[PATCH v3] staging: rtl8192u: Replace printk() with more standardize output format.

2018-03-07 Thread Arushi Singhal
quot;struct device object" is defined prefer pr_*macro() over printk(). This patch Replace printk having a log level with the appropriate output format according to the order of preference. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- Changes in v3 *In version2 n

[PATCH v2] staging: rtl8192u: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Arushi Singhal
Replace printk having a log level with the appropriate net_*macro_ratelimited. It's better to use actual device name as a prefix in error messages. Indentation is also changed, to fix the checkpatch issue if line is not exceding 80 characters. Signed-off-by: Arushi Singhal <arushisinghal19

[PATCH v2] staging: comedi: Replace "dont" with "don't

2018-03-04 Thread Arushi Singhal
Replace "dont" with "don't". "Dont" is not same as "Do not" or "Don't". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 *Commit log is rewrite in the imperative. drivers/staging/comedi/drivers/cb_p

[PATCH v3] staging: ipx: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Arushi Singhal
Replace printk having a log level with the appropriate net_*macro_ratelimited. It's better to use actual device name as a prefix in error messages. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 *In v1 printk was changed to pr_*macro(), which is used in

[PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Arushi Singhal
Replace printk having a log level with the appropriate net_*macro_ratelimited. It's better to use actual device name as a prefix in error messages. Indentation is also changed, to fix the checkpatch issue if line is not exceding 80 characters. Signed-off-by: Arushi Singhal <arushisinghal19

[PATCH v2] staging: Replace printk() with appropriate net_*macro_ratelimited()

2018-03-04 Thread Arushi Singhal
Replace printk having a log level with the appropriate net_*macro_ratelimited. It's better to use actual device name as a prefix in error messages. Indentation is also changed, to fix the checkpatch issue. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes

[PATCH 3/3] staging: media: Replace "dont" with "don't"

2018-03-04 Thread Arushi Singhal
Replace "dont" with "don't". "Dont" is not same as "Do not" or "Don't". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/media/atomisp/pci/atomisp2/mmu/isp_mmu.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/3] staging: media: Replace "cant" with "can't"

2018-03-04 Thread Arushi Singhal
Replace "cant" with "can't". "cant" is not same as "Can not" or "Can't". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH 1/3] staging: media: Replace "be be" with "be"

2018-03-04 Thread Arushi Singhal
This patch replace "be be" with "be". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_pipe_public.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/

[PATCH 0/3] staging: media: cleanup

2018-03-04 Thread Arushi Singhal
Spellcheck the comments. Remove the repeated, consecutive words with single word. Arushi Singhal (3): staging: media: Replace "be be" with "be" staging: media: Replace "cant" with "can't" staging: media: Replace "dont" with "don'

[PATCH 3/3] staging: lustre: Replace "dont" with "don't"

2018-03-04 Thread Arushi Singhal
Replace "dont" with "don't". "Dont" is not same as "Do not" or "Don't". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/lustre/lustre/fld/fld_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 2/3] staging: lustre: Replace "to to" with "to"

2018-03-04 Thread Arushi Singhal
This patch replace "to to" with "to". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/lustre/lustre/include/cl_object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/include/cl_o

[PATCH 0/3] staging: lustre: cleanup

2018-03-04 Thread Arushi Singhal
Spellcheck the comments. Remove the repeated, consecutive words with single word. Arushi Singhal (3): staging: lustre: Replace "be be" with "be" staging: lustre: Replace "to to" with "to" staging: lustre: Replace "dont" with &q

[PATCH 1/3] staging: lustre: Replace "be be" with "be"

2018-03-04 Thread Arushi Singhal
This patch replace "be be" with "be". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/lustre/lnet/libcfs/debug.c | 2 +- drivers/staging/lustre/lustre/include/lprocfs_status.h | 2 +- 2 files changed, 2 insertions(+),

[PATCH] staging: comedi: "dont" is changed to "don't"

2018-03-04 Thread Arushi Singhal
"dont" is changed to "don't" in messages, "dont" is not correct english. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +- drivers/staging/comedi/drivers/das16.c | 2 +- drivers/stag

[PATCH] staging: ipx: Replace printk() with appropriate pr_*() macro

2018-03-04 Thread Arushi Singhal
Using pr_() is more concise than printk(KERN_). Replace printks having a log level with the appropriate pr_*() macros. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/ipx/af_ipx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH] staging: rtl8723bs: Replace memset with eth_zero_addr

2018-03-03 Thread Arushi Singhal
this change is as follows: @header@ @@ #include @r1@ expression e; @@ -memset(e,0x00,ETH_ALEN); +eth_zero_addr(e); @includeheader depends on r1 && !header@ @@ + #include #include <...> Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl87

[PATCH] staging: rtl8723bs: Remove unnecessary semicolon.

2018-03-03 Thread Arushi Singhal
Remove unnecessary semicolon using semicolon.cocci Coccinelle script. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 2 +- 2 files changed, 2 insertions(+), 2 del

[PATCH] staging: rtlwifi: Remove nonessential semicolon

2018-03-03 Thread Arushi Singhal
Remove non-essential semicolon after 'else' and 'switch' statements. Issue found using semicolon.cocci Coccinelle script. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtlwifi/base.c | 6 +++--- drivers/staging/rtlwifi/phydm/phydm_rainfo

[PATCH v2 1/6] staging: rtl8712: Fixed 'tabstop' coding style warning

2018-03-02 Thread Arushi Singhal
Replace a mix of tabs and spaces indentation by tabs only. Fixed checkpatch warning "Statements should start on a tabstop". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl8712/drv_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v2 6/6] staging: rtl8712: remove unnecessary parentheses

2018-03-02 Thread Arushi Singhal
Remove unnecessary parentheses around variables to conform to the Linux kernel coding style. Issue found using checkpatch. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl8712/recv_linux.c | 4 +- drivers/staging/rtl8712/rtl8712_cmd.c | 8 ++-- d

[PATCH v2 2/6] staging: rtl8712: match alignment with open parenthesis

2018-03-02 Thread Arushi Singhal
Delete/Add tabs and spaces to align the code to fix the checkpatch issue: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl8712/mlme_linux.c | 2 +- drivers/staging/rtl8712/os_intfs.c

[PATCH v2 4/6] staging: rtl8712: Added spaces around '+'

2018-03-02 Thread Arushi Singhal
Add spaces around arithmetic operator '+', to conform to the Linux kernel coding style. Issue found using checkpatch. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl8712/rtl8712_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 3/6] staging: rtl8712: Remove multiple blank line(s)

2018-03-02 Thread Arushi Singhal
Remove extra blank line(s) to conform to the Linux kernel coding style. Issue found using checkpatch. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl8712/os_intfs.c | 1 - drivers/staging/rtl8712/rtl8712_bitdef.h | 1 - d

[PATCH v2 5/6] staging: rtl8712: Add spaces around '|'

2018-03-02 Thread Arushi Singhal
Add spaces around '|' to conform to the Linux kernel coding style. Issue found using checkpatch. CHECK: spaces preferred around that '|'. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl8712/rtl8712_cmdctrl_bitdef.h | 2 +- drivers/staging/r

[PATCH v2 0/6] staging: rtl8712: fix coding style issues

2018-03-02 Thread Arushi Singhal
Fix issues found with checkpatch.pl to conform to the Linux kernel coding style. Changes in v2: * From and Signed-off emails were not same in v1. * Added detailed commit message Arushi Singhal (6): staging: rtl8712: Fixed 'tabstop' coding style warning staging: rtl8712: match alignment

[PATCH 1/4] staging: rtl8712: Remove multiple blank line(s)

2018-03-02 Thread Arushi Singhal
From: Arushi Singhal <arushising...@gmail.com> Remove extra blank line(s) that were causing checkpatch issues. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl8712/os_intfs.c | 1 - drivers/staging/rtl8712/rtl8712_bitdef.h

[PATCH 4/4] staging: rtl8712: remove unnecessary parentheses

2018-03-02 Thread Arushi Singhal
Remove unnecessary parentheses around variables to conform to the Linux kernel coding style. Issue found using checkpatch. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl8712/recv_linux.c | 4 +- drivers/staging/rtl8712/rtl8712_cmd.c | 8 ++-- d

[PATCH 0/4] staging: rtl8712: fix coding style issues

2018-03-02 Thread Arushi Singhal
Fix issues found with checkpatch.pl for rtl8712 driver. Arushi Singhal (4): staging: rtl8712: Remove multiple blank line(s) staging: rtl8712: Added spaces around '+'. staging: rtl8712: Add spaces around '|' staging: rtl8712: remove unnecessary parentheses drivers/staging/rtl8712

[PATCH 2/4] staging: rtl8712: Added spaces around '+'.

2018-03-02 Thread Arushi Singhal
From: Arushi Singhal <arushising...@gmail.com> Add spaces around arithmetic operator '+', to fix the checkpatch issue. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl8712/rtl8712_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 3/4] staging: rtl8712: Add spaces around '|'

2018-03-02 Thread Arushi Singhal
From: Arushi Singhal <arushising...@gmail.com> Add spaces around '|' to fix the checkpatch issue. CHECK: spaces preferred around that '|'. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl8712/rtl8712_cmdctrl_bitdef.h | 2 +- drivers/sta

[PATCH] staging: rtl8712: match alignment with open parenthesis

2018-03-02 Thread Arushi Singhal
This patch fixes the checks reported by checkpatch.pl for alignment should match open parenthesis. Signed-off-by: Arushi Singhal <arushising...@gmail.com> --- drivers/staging/rtl8712/mlme_linux.c | 2 +- drivers/staging/rtl8712/os_intfs.c | 2 +- 2 files changed, 2 insertions(+), 2 del

[PATCH] staging: rtl8712: Fixed 'tabstop' coding style warning

2018-03-01 Thread Arushi Singhal
Replace a mix of tabs and spaces indentation by tabs only. Fixed checkpatch warning "Statements should start on a tabstop" in rtl8712 module. Signed-off-by: Arushi Singhal <arushising...@gmail.com> --- drivers/staging/rtl8712/drv_types.h | 2 +- 1 file changed, 1 insertio

[PATCH] staging: rtl8712: fix "Alignment match open parenthesis"

2017-07-06 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl8712/mlme_linux.c| 4 ++-- drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- drivers/staging/rtl8712/rtl8712_efuse.c

[PATCH] staging: iio: meter: Replace mlock with driver private buf_lock

2017-03-30 Thread Arushi Singhal
The driver needs to insure atomicity during frequency changes of bus and device. The iiodev->mlock as used was not doing that. Replace it with the drivers existing buffer lock and execute spi_write directly. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/st

[PATCH v2] staging: iio: Remove unneeded parentheses.

2017-03-29 Thread Arushi Singhal
Remove the extra parenthesis remove the checkpatch issue. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 -done the changes according to the current tree drivers/staging/iio/cdc/ad7746.c | 16 1 file changed, 8 insertions(+), 8 del

[RESEND PATCH] staging: iio: Remove extra Parenthesis

2017-03-29 Thread Arushi Singhal
Remove the extra parenthesis remove the checkpatch issue. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/iio/cdc/ad7746.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/s

[RESEND PATCH] staging: media: davinci_vpfe: Replace a bit shift

2017-03-29 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +- drivers/staging/media/

[RESEND PATCH] staging: media: omap4iss: Replace a bit shift by a use of BIT

2017-03-29 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/media/omap4iss/iss_csi2.c| 2 +- drivers/staging/media/omap4iss/iss_i

[PATCH] staging: iio: Use devm functions

2017-03-28 Thread Arushi Singhal
Use managed resource functions devm_request_irq instead of request_irq. Remove corresponding calls to free_irq in the probe. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 7 +++ 1 file changed, 3 insertions

[RFC] staging: iio: ad7759: Replace mlock with driver private buf_lock

2017-03-28 Thread Arushi Singhal
ock in the devices global data. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/iio/meter/ade7759.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/iio/meter/ade7759.c index 0b6

[PATCH v2] staging: media: atomisp: compress return logic

2017-03-28 Thread Arushi Singhal
Simplify function returns by merging assignment and return. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 *correct the error. drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 8 ++-- .../media/atomisp/pci/atomisp2/css2400/runtim

[PATCH] staging: media: atomisp: compress return logic

2017-03-25 Thread Arushi Singhal
Simplify function returns by merging assignment and return. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 8 ++-- .../media/atomisp/pci/atomisp2/css2400/runtime/bufq/src/bufq.c| 7 ++- 2

[PATCH] staging: greybus: compress return logic

2017-03-24 Thread Arushi Singhal
Simplify function returns by merging assignment and return. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/greybus/loopback.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/g

[PATCH v3] staging: media: davinci_vpfe: Replace a bit shift.

2017-03-24 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v3 - change the subject. - remove extra parenthesis. drivers/staging/media/

[PATCH v2] staging: media: davinci_vpfe:Replace a bit shift.

2017-03-24 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 -Remove unnecessary parenthesis. drivers/staging/media/davinci_vpfe/d

[PATCH v2] staging: media: omap4iss: Replace a bit shift by a use of BIT.

2017-03-24 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 -Remove unnecessary parenthesis drivers/staging/media/omap4iss/iss_c

[PATCH v2] staging: media: atomisp:Replace a bit shift.

2017-03-24 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 -remove the unnecessary parenthesis. drivers/staging/media/atomisp/

[PATCH] staging: iio: Remove extra Parenthesis.

2017-03-24 Thread Arushi Singhal
Remove the extra parenthesis remove the checkpatch issue. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/iio/cdc/ad7746.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/s

[PATCH] staging: lustre: Remove redundant code

2017-03-24 Thread Arushi Singhal
Remove the code which do not have any value. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/lustre/lnet/lnet/net_fault.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c b/drivers/staging/lustre/lne

[PATCH v2] staging: speakup: Remove the explicit NULL comparison

2017-03-24 Thread Arushi Singhal
Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 - change the commit s

[PATCH v3] staging: speakup: Align the code.

2017-03-24 Thread Arushi Singhal
Delete tabs and add spaces to align the code to fix the checkpatch issue: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v3 - make the commit message more clear. drivers/staging/speakup/spea

[PATCH v2] staging:speakup: Fix alignment with parenthesis.

2017-03-23 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 - change the commit message. drivers/staging/speakup/speakup_apollo.c | 2 +- drivers/staging/speakup/speakup_decext.c |

[PATCH] staging: tsl2x7x: Moved contents of the header to the source file.

2017-03-23 Thread Arushi Singhal
Moved the contents of the header(tsl2x7x.h) into the source file tsl2x7x_core.c with the exception of the platform data struct which is supposed to be used from somewhere else other than the driver. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/iio

[PATCH] staging: ad7746: Moved contents of the header to the source file.

2017-03-23 Thread Arushi Singhal
Moved the contents of the header(ad7746.h) into the source file ad7746.c with the exception of the platform data struct which is supposed to be used from somewhere else other than the driver. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/iio/cdc/ad7746

[PATCH v2] staging: fbtft: Replace a bit shift by a use of BIT.

2017-03-22 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 -improve the code. drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +- dri

[PATCH v2] staging: iio: Replace a bit shift by a use of BIT.

2017-03-22 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 -remove/correct the wrong code. drivers/staging/iio/cdc/ad7150.c | 2

[PATCH v2] staging: lustre: Replace a bit shift by a use of BIT.

2017-03-22 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 - remove the unnecessary parenthesis. - removethe wrong changes. dri

[PATCH v2] staging: rts5208: Replace a bit shift by a use of BIT.

2017-03-22 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 - remove the unnecessary parenthesis. drivers/staging/rts5208/rtsx_chip.c

[PATCH v2] staging: iio: Replace a bit shift by a use of BIT.

2017-03-22 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 -change the cc list drivers/staging/iio/adc/ad7816.c | 2 +- drivers/sta

[PATCH 1/3] staging: media: Replace a bit shift by a use of BIT.

2017-03-21 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- .../staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 12 ++-- .../media

[PATCH 3/3] staging: media: omap4iss: Replace a bit shift by a use of BIT.

2017-03-21 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/media/omap4iss/iss_csi2.c| 2 +- drivers/staging/media/omap4iss/iss_i

[PATCH 2/3] staging: media: davinci_vpfe: Replace a bit shift by a use of BIT.

2017-03-21 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +- drivers/staging/media/

[PATCH 0/3] staging: media: Replace a bit shift.

2017-03-21 Thread Arushi Singhal
Replace a bit shift by a use of BIT in media driver. Arushi Singhal (3): staging: media: Replace a bit shift by a use of BIT. staging: media: davinci_vpfe: Replace a bit shift by a use of BIT. staging: media: omap4iss: Replace a bit shift by a use of BIT. .../media/atomisp/pci/atomisp2

[PATCH] staging: media: Replace a bit shift by a use of BIT.

2017-03-21 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/octeon/ethernet-tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

staging: iio: Replace a bit shift by a use of BIT.

2017-03-21 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/iio/adc/ad7816.c | 2 +- drivers/staging/iio/cdc/ad7150.c | 2 +- dri

[PATCH] staging: rtl8712: Replace a bit shift by a use of BIT.

2017-03-21 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rtl8712/rtl8712_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] staging: sm750fb: Replace a bit shift by a use of BIT.

2017-03-21 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] staging: lustre: Replace a bit shift by a use of BIT.

2017-03-21 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +- drivers/staging

[PATCH] staging: fbtft: Replace a bit shift by a use of BIT.

2017-03-21 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/fbtft/fb_agm1264k-fl.c | 4 ++-- drivers/staging/fbtft/fb_ili91

[PATCH] staging: rts5208: Replace a bit shift by a use of BIT.

2017-03-21 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH v2 2/2] staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"

2017-03-21 Thread Arushi Singhal
This patch removes typedefs from enum and renames it from "typedef enum _spolarity_t" to "enum spolarity" as per kernel coding standards." Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 -change the subject and commit message of P

[PATCH v2 1/2] staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t"

2017-03-21 Thread Arushi Singhal
This patch removes typedefs from struct and renames it from "typedef struct _mode_parameter_t" to "struct mode_parameter" as per kernel coding standards." Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 -change the subject and com

[PATCH v2 0/2] Remove Typedefs.

2017-03-21 Thread Arushi Singhal
Typedefs are removed in sm750fb driver. Arushi Singhal (2): staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t" staging: sm750fb: Remove typedef from "typedef enum _spolarity_t" drivers/staging/sm750fb/ddk750_mode.c | 8 +--- drivers/staging/s

[PATCH 2/2] staging: iio: ade7759: Move header content to implementation file

2017-03-21 Thread Arushi Singhal
The contents of ade7759.h are only used in ade7759.c. Move the header contents to the implemtation file, and delete the header file. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/iio/meter/ade7759.c | 52 ++- drivers/s

[PATCH 1/2] staging: ad7759: Replace mlock with driver private lock

2017-03-21 Thread Arushi Singhal
ces global data. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/iio/meter/ade7759.c | 4 ++-- drivers/staging/iio/meter/ade7759.h | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/

[PATCH 0/2] IIO coding tasks

2017-03-21 Thread Arushi Singhal
Patchseries of IIO coding tasks Arushi Singhal (2): staging: ad7759: Replace mlock with driver private lock staging: iio: ade7759: Move header content to implementation file drivers/staging/iio/meter/ade7759.c | 56 +-- drivers/staging/iio/meter/ade7759.h

[PATCH 10/11] staging: speakup: Match alignment with open parenthesis.

2017-03-21 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/selection.c | 2 +- drivers/staging/speakup/serialio.c

[PATCH 08/11] staging: speakup: Removed Unnecessary parentheses.

2017-03-21 Thread Arushi Singhal
Unnecessary parentheses are removed to improve readability. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/s

[PATCH 06/11] staging: speakup: Moved OR operator to previous line.

2017-03-21 Thread Arushi Singhal
Moved logical OR operator to previous line to fix the following checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions

[PATCH 11/11] staging: speakup: Fix alignment with parenthesis.

2017-03-21 Thread Arushi Singhal
This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/speakup_apollo.c | 2 +- drivers/staging/speakup/speakup_decext

[PATCH 09/11] staging: speakup: Simplify the NULL comparisons

2017-03-21 Thread Arushi Singhal
Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/fakekey.c | 2 +- d

[PATCH 07/11] staging: speakup: spaces preferred around operator

2017-03-21 Thread Arushi Singhal
Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal <arushisingh

[PATCH 04/11] staging: speakup: fixes braces {} should be used on all arms of this statement

2017-03-21 Thread Arushi Singhal
This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 35 +++- drivers/staging/s

[PATCH 05/11] staging: speakup: Remove multiple assignments

2017-03-21 Thread Arushi Singhal
This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/

[PATCH 01/11] staging: speakup: Moved logical to previous line.

2017-03-21 Thread Arushi Singhal
Moved logical operator to previous line to fix the following checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 12 ++-- 1 file changed, 6 insertions

[PATCH 03/11] staging: speakup: Simplify "NULL" comparisons

2017-03-21 Thread Arushi Singhal
Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/selection.c

[PATCH 02/11] staging: speakup: Remove multiple assignments

2017-03-21 Thread Arushi Singhal
This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers

[RESEND PATCH 00/11] staging:speakup: Multiple Checkpatch issues.

2017-03-21 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (11): staging: speakup: Moved logical to previous line. staging: speakup: Remove multiple assignments staging: speakup: Simplify "NULL" comparisons staging: speakup: fixes braces

[PATCH 2/2] staging: sm750fb: Remove typedefs from enum

2017-03-21 Thread Arushi Singhal
This patch removes typedefs from enum and renames them as per kernel coding standards. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/sm750fb/ddk750_mode.h | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/s

[PATCH 1/2] staging: sm750fb: Remove typedefs from struct

2017-03-21 Thread Arushi Singhal
This patch removes typedefs from structure and renames them as per kernel coding standards. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/sm750fb/ddk750_mode.c | 8 +--- drivers/staging/sm750fb/ddk750_mode.h | 8 +++- drivers/staging/s

[PATCH 0/2] Remove Typrdefs

2017-03-21 Thread Arushi Singhal
Typedefs are removed in sm750fb driver. Arushi Singhal (2): staging: sm750fb: Remove typedefs from struct staging: sm750fb: Remove typedefs from enum drivers/staging/sm750fb/ddk750_mode.c | 8 +--- drivers/staging/sm750fb/ddk750_mode.h | 19 --- drivers/staging/sm750fb

[PATCH 4/4] staging: speakup: Fix alignment with parenthesis.

2017-03-21 Thread Arushi Singhal
This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/speakup_apollo.c | 2 +- drivers/staging/speakup/speakup_decext

[PATCH 3/4] staging: speakup: Match alignment with open parenthesis.

2017-03-21 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/selection.c | 2 +- drivers/staging/speakup/serialio.c

[PATCH 1/4] staging: speakup: Removed Unnecessary parentheses.

2017-03-21 Thread Arushi Singhal
Unnecessary parentheses are removed to improve readability. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/s

[PATCH 2/4] staging: speakup: Simplify the NULL comparisons

2017-03-21 Thread Arushi Singhal
Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/fakekey.c | 2 +- d

[PATCH 0/4] staging: speakup: Checkpatch issues.

2017-03-21 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (4): staging: speakup: Removed Unnecessary parentheses. staging: speakup: Simplify the NULL comparisons staging: speakup: Match alignment with open parenthesis. staging: speakup: Fix alignment

[PATCH 7/7] staging: speakup: spaces preferred around operator

2017-03-21 Thread Arushi Singhal
Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal <arushisingh

[PATCH 3/7] staging: speakup: Simplify "NULL" comparisons

2017-03-21 Thread Arushi Singhal
Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/selection.c

  1   2   3   >