Re: [Linux-kernel-mentees][PATCH v4] staging: kpc2000: Convert put_page to put_user_page*()

On Tue, Jul 30, 2019 at 11:36:06AM +0200, Greg KH wrote: > On Tue, Jul 30, 2019 at 02:58:44PM +0530, Bharath Vedartham wrote: > > put_page() to put_user_page*() > > What does this mean? That must have been a mistake! I just wanted to forward this patch to the Linux-kernel-mente

Re: [Linux-kernel-mentees][PATCH v4] staging: kpc2000: Convert put_page to put_user_page*()

put_page() to put_user_page*() Reply-To: In-Reply-To: <1564058658-3551-1-git-send-email-linux.b...@gmail.com> On Thu, Jul 25, 2019 at 06:14:18PM +0530, Bharath Vedartham wrote: [Forwarding patch to linux-kernel-mentees mailing list] > For pages that were retained via get_user_pages*()

[PATCH v4] staging: kpc2000: Convert put_page() to put_user_page*()

Cc: John Hubbard Cc: Jérôme Glisse Cc: Greg Kroah-Hartman Cc: Matt Sickler Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org Cc: linux...@kvack.org Reviewed-by: John Hubbard Signed-off-by: Bharath Vedartham --- Changes since v1 - Improved changelog by John's

Re: [PATCH v4] staging: kpc2000: Convert put_page to put_user_page*()

On Thu, Jul 25, 2019 at 09:46:34AM +0200, Greg KH wrote: > On Sat, Jul 20, 2019 at 11:02:14PM +0530, Bharath Vedartham wrote: > > For pages that were retained via get_user_pages*(), release those pages > > via the new put_user_page*() routines, instead of via put_page(). > &

Re: [PATCH v3] staging: kpc2000: Convert put_page to put_user_page*()

On Fri, Jul 19, 2019 at 08:59:02PM +, Matt Sickler wrote: > >From: Bharath Vedartham > >Changes since v2 > >- Added back PageResevered check as suggested by John Hubbard. > > > >The PageReserved check needs a closer look and is not worth messing >

[PATCH v4] staging: kpc2000: Convert put_page to put_user_page*()

Cc: John Hubbard Cc: Jérôme Glisse Cc: Greg Kroah-Hartman Cc: Matt Sickler Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org Cc: linux...@kvack.org Reviewed-by: John Hubbard Signed-off-by: Bharath Vedartham --- Changes since v1 - Improved changelog by John's

Re: [PATCH v3] staging: kpc2000: Convert put_page to put_user_page*()

On Fri, Jul 19, 2019 at 02:28:39PM -0700, John Hubbard wrote: > On 7/19/19 1:02 PM, Bharath Vedartham wrote: > > There have been issues with coordination of various subsystems using > > get_user_pages. These issues are better described in [1]. > > > > An implementation

[PATCH v3] staging: kpc2000: Convert put_page to put_user_page*()

tt Sickler Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org Cc: linux...@kvack.org Signed-off-by: Bharath Vedartham --- Changes since v1 - Improved changelog by John's suggestion. - Moved logic to dirty pages below sg_dma_unmap and removed PageReserved chec

Re: [PATCH] staging: kpc2000: Convert put_page() to put_user_page*()

On Mon, Jul 15, 2019 at 03:01:43PM -0700, John Hubbard wrote: > On 7/15/19 2:47 PM, Matt Sickler wrote: > > It looks like Outlook is going to absolutely trash this email. Hopefully > > it comes through okay. > > > ... > >> > >> Because this is a common pattern, and because the code here doesn't

[PATCH v2] staging: kpc2000: Convert put_page() to put_user_page*()

-by: John Hubbard Signed-off-by: Bharath Vedartham --- Changes since v1 - Added John's reviewed-by tag - Moved para talking about testing below the '---' - Moved logic of set_page_diry below dma_unmap_sg as per John's suggestion I currently do not have

Re: [PATCH] staging: kpc2000: Convert put_page() to put_user_page*()

On Mon, Jul 15, 2019 at 01:14:13PM -0700, John Hubbard wrote: > On 7/15/19 12:52 PM, Bharath Vedartham wrote: > > There have been issues with get_user_pages and filesystem writeback. > > The issues are better described in [1]. > > > > The solution being proposed wants

[PATCH] staging: kpc2000: Convert put_page() to put_user_page*()

...@driverdev.osuosl.org Signed-off-by: Bharath Vedartham --- drivers/staging/kpc2000/kpc_dma/fileops.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/kpc2000/kpc_dma/fileops.c index 6166587..82c70e6 100644 --- a/drivers

Re: [PATCH] mm/gup: Use put_user_page*() instead of put_page*()

On Mon, Jul 15, 2019 at 11:10:20AM -0700, John Hubbard wrote: > On 7/14/19 11:56 PM, Bharath Vedartham wrote: > > On Sun, Jul 14, 2019 at 04:33:42PM -0700, John Hubbard wrote: > >> On 7/14/19 12:08 PM, Bharath Vedartham wrote: > [...] > >> 1. Pull down https://github

Re: [PATCH] mm/gup: Use put_user_page*() instead of put_page*()

On Mon, Jul 15, 2019 at 09:29:53AM -0700, Ira Weiny wrote: > On Mon, Jul 15, 2019 at 12:26:54PM +0530, Bharath Vedartham wrote: > > On Sun, Jul 14, 2019 at 04:33:42PM -0700, John Hubbard wrote: > > > On 7/14/19 12:08 PM, Bharath Vedartham wrote: > > > > This

Re: [PATCH] mm/gup: Use put_user_page*() instead of put_page*()

On Sun, Jul 14, 2019 at 08:33:57PM -0600, Jens Axboe wrote: > On 7/14/19 1:08 PM, Bharath Vedartham wrote: > > diff --git a/fs/io_uring.c b/fs/io_uring.c > > index 4ef62a4..b4a4549 100644 > > --- a/fs/io_uring.c > > +++ b/fs/io_uring.c > > @@ -2694,10 +2694,9 @@

Re: [PATCH] mm/gup: Use put_user_page*() instead of put_page*()

On Sun, Jul 14, 2019 at 04:33:42PM -0700, John Hubbard wrote: > On 7/14/19 12:08 PM, Bharath Vedartham wrote: > > This patch converts all call sites of get_user_pages > > to use put_user_page*() instead of put_page*() functions to > > release reference to gup pinned pages. H

[PATCH] mm/gup: Use put_user_page*() instead of put_page*()

reference of gup pinned pages as I am not clear whether release_pages and put_page are interchangable. [1] https://lkml.org/lkml/2019/3/26/1396 [2] https://lwn.net/Articles/784574/ Signed-off-by: Bharath Vedartham --- drivers/media/v4l2-core/videobuf-dma-sg.c | 3 +-- drivers/misc/sgi-gru

[RFC/PATCH] staging: olpc_dcon: Use WARN_ON instead of BUG_ON

This is with respect to a checkpatch.pl CHECK: "Avoid crashing the kernel. Use WARN_ON instead of BUG_ON". But I maybe wrong here. Is a kernel crash desired if olpc_board_at_least(olpc_board(0xc2)) fails, will there be inconsistent results if execution continues? Signed-off-by: Bharath

[PATCH] staging: ralink-gdma: Remove space after cast

This fixes the checkpatch.pl check: "No space is necessary after the cast". Signed-off-by: Bharath Vedartham --- drivers/staging/ralink-gdma/ralink-gdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/r

Re: [PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

On Sun, Mar 24, 2019 at 09:58:42AM +0100, Greg KH wrote: > On Sat, Mar 23, 2019 at 05:04:44PM +0530, Bharath Vedartham wrote: > > Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned". > > > > Signed-off-by: Bharath Vedartham > > --- > >

[PATCH v2] staging: ralink-gdma: Change unsigned to unsigned int

This fixes the checkpatch.pl warning: "Prefer unsigned to unsigned int" Signed-off-by: Bharath Vedartham --- Changes since v1 - Based this patch of the staging branch and not linus's branch unlike the last patch. --- drivers/staging/ralink-gdma/ralink-gdma.c | 2

Re: [PATCH v4] staging: ralink-gdma: Use u32 over uint32_t

On Sun, Mar 24, 2019 at 09:58:33AM +0100, Greg KH wrote: > On Sat, Mar 23, 2019 at 09:16:48PM +0530, Bharath Vedartham wrote: > > Fixes the checkpatch.pl warning: "Prefer u32 over uint32_t" > > > > Signed-off-by: Bharath Vedartham > > --- > > Changes

Re: [PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

On Sun, Mar 24, 2019 at 09:58:42AM +0100, Greg KH wrote: > On Sat, Mar 23, 2019 at 05:04:44PM +0530, Bharath Vedartham wrote: > > Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned". > > > > Signed-off-by: Bharath Vedartham > > --- > >

[PATCH v4] staging: ralink-gdma: Use u32 over uint32_t

Fixes the checkpatch.pl warning: "Prefer u32 over uint32_t" Signed-off-by: Bharath Vedartham --- Changes since v3 - Fixed allignment issues. - Submitted a seperate patch to change unsigned to unsigned int. - One of the allignments crosses 80 characters

[PATCH] staging: ralink-gdma: Convert unsigned to unsigned int

Fix the checkpatch.pl warning: "Use unsigned int instead of unsigned". Signed-off-by: Bharath Vedartham --- drivers/staging/ralink-gdma/ralink-gdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/r

[PATCH v3] staging: ralink-gdma: Use u32 over uint32_t

This fixes the checkpatch.pl warning: "Prefer u32 over uint32_t" Signed-off-by: Bharath Vedartham --- Changes since v2 - Improved changelog - Thanks for the good feedback. I am a beginner. I will learn and grow. :) --- drivers/staging/ralink-gdma/ralink-g

[PATCH v2] staging: ralink-gdma: Change uint32_t to u32

Change occurences of uint32_t to u32 to fix checkpatch.pl warnings. Signed-off-by: Bharath Vedartham --- Changes since v1: - Improved changelog. --- --- drivers/staging/ralink-gdma/ralink-gdma.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH v2] staging: ralink-gdma: Change uint32_t to u32

Change occurences of uint32_t to u32 to fix checkpatch.pl warning Signed-off-by: Bharath Vedartham --- Changes since v1: -Improved the changelog. --- drivers/staging/ralink-gdma/ralink-gdma.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging

Re: [PATCH] staging: ralink-gdma: Change uint32_t to u32

On Fri, Mar 22, 2019 at 01:01:40PM +0300, Dan Carpenter wrote: > On Fri, Mar 22, 2019 at 12:55:02AM +0530, Bharath Vedartham wrote: > > This is a follow up on my previous patch. Change occurences of the > ^ I did not send a patch set. I should

[PATCH] staging: ralink-gdma: Change uint32_t to u32

This is a follow up on my previous patch. Change occurences of the stdint type uint32_t to its shortened type u32. This fixed the checkpatch.pl warning: "Prefer u32 over uint32_t". Signed-off-by: Bharath Vedartham --- drivers/staging/ralink-gdma/ralink-gdma.c | 10 +- 1 file

[PATCH v2] staging: ralink-gdma: Prefer u32 over uint32_t

Fix the checkpatch.pl warning: "Prefer u32 over uint32_t". Signed-off-by: Bharath Vedartham --- drivers/staging/ralink-gdma/ralink-gdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ral

Re: [PATCH] staging: ralink-gdma: Prefer u32 over uint32_t

On Thu, Mar 21, 2019 at 07:46:09PM +0100, Greg KH wrote: > On Fri, Mar 22, 2019 at 12:07:10AM +0530, Bharath Vedartham wrote: > > Change uint32_t to u32 > > That says _what_ you did, but _why_ are you doing this? That's the main > content a changelog text should have

[PATCH] staging: ralink-gdma: Prefer u32 over uint32_t

Change uint32_t to u32 Signed-off-by: Bharath Vedartham --- drivers/staging/ralink-gdma/ralink-gdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c index d78042e..2c19287 100644

Re: [PATCH v3] staging: erofs: Add whitespace after declaration

On Mon, Mar 18, 2019 at 11:40:35PM +0800, Gao Xiang wrote: > > > On 2019/3/18 23:38, Greg KH wrote: > > On Mon, Mar 18, 2019 at 09:02:24PM +0530, Bharath Vedartham wrote: > >> Add whitespace after declaration. Fixed the checkpatch.pl warning. > >>

[PATCH v3] staging: erofs: Add whitespace after declaration

Add whitespace after declaration. Fixed the checkpatch.pl warning. --- changes since v2 - mutt gave me a lot of problems. Hence 3 patches for a really small problem. - Fixed the extra missing line. Signed-off-by: Bharath Vedartham --- drivers/staging/erofs/inode.c | 2

[PATCH v2] staging: erofs: Add whitespace after declaration

Fix the checkpatch.pl warning to add a whitespace after declaration statements. Signed-off-by: Bharath Vedartham --- Changes since v2 - Mutt was giving me a few problems. I apologise for the previous poor patches. --- drivers/staging/erofs/inode.c | 3 +-- 1 file changed, 1

[PATCH] staging: erofs: Add whitespace after declaration

linux-ker...@vger.kernel.org Bcc: Subject: [PATCH] staging: erofs: Add whitespace after declaration Reply-To: Fix the checkpatch.pl warning to add a whitespace after declaration statements. Signed-off-by: Bharath Vedartham --- drivers/staging/erofs/inode.c | 3 +-- 1 file changed, 1

[no subject]

linux-ker...@vger.kernel.org Bcc: Subject: [PATCH] staging: erofs: Add whitespace after declaration Reply-To: Fix the checkpatch.pl warning to add a whitespace after declaration statements. Signed-off-by: Bharath Vedartham --- drivers/staging/erofs/inode.c | 3 +-- 1 file changed, 1

[PATCH v2] staging : speakup: Fix format issues in Kconfig

Fix the checkpatch.pl warning to replace ---help--- with help in Kconfig. Signed-off-by: Bharath Vedartham --- Changes since v1: - Allign help and removed redundant spaces. --- drivers/staging/speakup/Kconfig | 42 - 1 file changed, 16 insertions

[PATCH] staging : speakup: replace ---help--- with help in Kconfig

Fix the checkpatch.pl warning to replace ---help--- with help in Kconfig. Signed-off-by: Bharath Vedartham --- drivers/staging/speakup/Kconfig | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/speakup/Kconfig b/drivers/staging

Re: [PATCH] staging: speakup: Replace simple_strtoul with kstrtoul

On Sat, Feb 23, 2019 at 08:37:50PM +0100, Samuel Thibault wrote: > Bharath Vedartham, le dim. 24 févr. 2019 01:01:21 +0530, a ecrit: > > simple_strtoul is obsolete. Change it to kstrtoul. Kernel is building > > and booting successfully. > > Please recheck your patc

[PATCH] staging: speakup: Replace simple_strtoul with kstrtoul

simple_strtoul is obsolete. Change it to kstrtoul. Kernel is building and booting successfully. Signed-off-by: Bharath Vedartham --- drivers/staging/speakup/kobjects.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging

[PATCH] staging: wlan-ng: replace ---help--- with help in Kconfig

This patch fixes the checkpatch.pl warning: WARNING: prefer 'help' over '---help---' for new help texts Signed-off-by: Bharath Vedartham --- drivers/staging/wlan-ng/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/Kconfig b/drivers/staging

[PATCH] staging: netlogic: replace ---help--- with help in Kconfig

This patch fixes the checkpatch.pl warning: WARNING: prefer 'help' over '---help---' for new help texts Signed-off-by: Bharath Vedartham --- drivers/staging/netlogic/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/netlogic/Kconfig b/drivers/staging

[PATCH] staging: netlogic: replace ---help--- with help in Kconfig

This patch fixes the checkpatch.pl warning: WARNING: prefer 'help' over '---help---' for new help texts Signed-off-by: Bharath Vedartham --- drivers/staging/netlogic/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/netlogic/Kconfig b/drivers/staging