Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

On Fri, Feb 15, 2019 at 11:01:59AM -0800, John Stultz wrote: > On Fri, Feb 15, 2019 at 2:51 AM Brian Starkey wrote: > > > > Hi John, > > > > On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wrote: > > > > > [snip] > > > > > Some t

Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

Hi John, On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wrote: > [snip] > Some thoughts, as this ABI break has the potential to be pretty painful. > > 1) Unfortunately, this ABI is exposed *through* libion via > ion_alloc/ion_alloc_fd out to gralloc implementations. Which means it >

Re: [PATCH 2/4] staging: android: ion: Restrict cache maintenance to dma mapped memory

e buffer is not > > dma-mapped the CPU doesn't need to do any CMOs to access the buffer (and > > ION ensures not CMOs are applied) but if the CPU does want to access the > > buffer while it is dma mapped then ION ensures that the appropriate CMOs > > are applied. > > > >

Re: [PATCH] staging: android: ion: Allocate from heap ID directly without mask

On Thu, Jan 24, 2019 at 10:12:10AM -0600, Andrew F. Davis wrote: > On 1/24/19 9:24 AM, Brian Starkey wrote: [snip] > > > > What do you think about renaming ion_allocation_data.unused to heap_id > > and adding a flag instead? It's adding cruft to a staging API, bu

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

On Thu, Jan 24, 2019 at 10:04:46AM -0600, Andrew F. Davis wrote: > On 1/23/19 11:11 AM, Brian Starkey wrote: [snip] > > I'm very new to all this, so any pointers to history in this area are > appreciated. > [snip] > > > In case you didn't come across it already

Re: [PATCH] staging: android: ion: Allocate from heap ID directly without mask

Hi Andrew, On Wed, Jan 23, 2019 at 01:28:35PM -0600, Andrew F. Davis wrote: > Previously the heap to allocate from was selected by a mask of allowed > heap types. This may have been done as a primitive form of constraint > solving, the first heap type that matched any set bit of the heap mask >

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

e he has been one of the > > core guys who shaped up dma-buf as it is today. > > > > On Tue, 22 Jan 2019 at 02:51, Andrew F. Davis wrote: > >> > >> On 1/21/19 5:22 AM, Brian Starkey wrote: > > [snip] > > >>> > >>> Actually I

Re: [PATCH 4/4] staging: android: ion: Support for mapping with dma mapping attributes

Hi Liam, On Fri, Jan 18, 2019 at 10:37:47AM -0800, Liam Mark wrote: > Add support for configuring dma mapping attributes when mapping > and unmapping memory through dma_buf_map_attachment and > dma_buf_unmap_attachment. > > For example this will allow ION clients to skip cache maintenance, by >

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

16/19 4:54 PM, Liam Mark wrote: > >>> On Wed, 16 Jan 2019, Andrew F. Davis wrote: > >>> > >>>> On 1/16/19 9:19 AM, Brian Starkey wrote: > >>>>> Hi :-) > >>>>> > >>>>> On Tue, Jan 15, 2019 at 12:40:16PM -0600,

Re: [PATCH 11/14] staging: android: ion: Allow heap name to be null

Hi Andrew, On Fri, Jan 11, 2019 at 12:05:20PM -0600, Andrew F. Davis wrote: > The heap name can be used for debugging but otherwise does not seem > to be required and no other part of the code will fail if left NULL > except here. We can make it required and check for it at some point, > for now

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

Hi :-) On Tue, Jan 15, 2019 at 12:40:16PM -0600, Andrew F. Davis wrote: > On 1/15/19 12:38 PM, Andrew F. Davis wrote: > > On 1/15/19 11:45 AM, Liam Mark wrote: > >> On Tue, 15 Jan 2019, Andrew F. Davis wrote: > >> > >>> On 1/14/19 11:13 AM, Liam Mark wrote: > On Fri, 11 Jan 2019, Andrew F.

Re: [RFC PATCH v2] android: ion: How to properly clean caches for uncached allocations

On Wed, Nov 28, 2018 at 11:03:37PM -0800, Liam Mark wrote: > On Wed, 28 Nov 2018, Brian Starkey wrote: > > On Tue, Nov 27, 2018 at 10:46:07PM -0800, Liam Mark wrote: > > > On Tue, 27 Nov 2018, Brian Starkey wrote: > > > > On Mon, Nov 26, 2018 at 08:59:44PM -0800, Lia

Re: [RFC PATCH v2] android: ion: How to properly clean caches for uncached allocations

Hi Liam, On Tue, Nov 27, 2018 at 10:46:07PM -0800, Liam Mark wrote: > On Tue, 27 Nov 2018, Brian Starkey wrote: > > > Hi Liam, > > > > On Mon, Nov 26, 2018 at 08:59:44PM -0800, Liam Mark wrote: > > > On Tue, 20 Nov 2018, Brian Starkey wrote: > > > >

Re: [RFC PATCH v2] android: ion: How to properly clean caches for uncached allocations

Hi Liam, On Mon, Nov 26, 2018 at 08:59:44PM -0800, Liam Mark wrote: > On Tue, 20 Nov 2018, Brian Starkey wrote: > > > Hi Liam, > > > > I'm missing a bit of context here, but I did read the v1 thread. > > Please accept my apologies if I'm re-treading trodden gr

Re: [RFC PATCH v2] android: ion: How to properly clean caches for uncached allocations

Hi Liam, I'm missing a bit of context here, but I did read the v1 thread. Please accept my apologies if I'm re-treading trodden ground. I do know we're chasing nebulous ion "problems" on our end, which certainly seem to be related to what you're trying to fix here. On Thu, Nov 01, 2018 at

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

On Sun, Mar 12, 2017 at 02:34:14PM +0100, Benjamin Gaignard wrote: 2017-03-09 18:38 GMT+01:00 Laura Abbott : On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: 2017-03-06 17:04 GMT+01:00 Daniel Vetter : On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

On Fri, Mar 10, 2017 at 11:46:42AM +, Robin Murphy wrote: On 10/03/17 10:31, Brian Starkey wrote: Hi, On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: [snip] For me those patches are going in the right direction. I still

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

Hi, On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: [snip] For me those patches are going in the right direction. I still have few questions: - since alignment management has been remove from ion-core, should it be also

Re: [PATCHv2 1/4] staging: android: ion: Drop heap type masks

On Tue, Sep 06, 2016 at 03:16:52PM -0700, Laura Abbott wrote: On 09/05/2016 04:20 AM, Brian Starkey wrote: Hi, On Fri, Sep 02, 2016 at 12:36:25PM -0700, Laura Abbott wrote: On 09/02/2016 06:41 AM, Brian Starkey wrote: Hi Laura, On Thu, Sep 01, 2016 at 03:40:41PM -0700, Laura Abbott wrote

Re: [PATCHv2 1/4] staging: android: ion: Drop heap type masks

Hi, On Fri, Sep 02, 2016 at 12:36:25PM -0700, Laura Abbott wrote: On 09/02/2016 06:41 AM, Brian Starkey wrote: Hi Laura, On Thu, Sep 01, 2016 at 03:40:41PM -0700, Laura Abbott wrote: There is no advantage to having heap types be a mask. The ion client has long since dropped the mask. Drop

Re: [PATCHv2 1/4] staging: android: ion: Drop heap type masks

Hi Laura, On Thu, Sep 01, 2016 at 03:40:41PM -0700, Laura Abbott wrote: There is no advantage to having heap types be a mask. The ion client has long since dropped the mask. Drop the notion of heap type masks as well. I know this is the same patch you sent last time, so sorry for not

Re: [RFC][PATCH 6/6] staging: android: ion: Introduce new ioctls for dynamic heaps

Hi, I'm finding "usage_id" a bit confusing - there's not a very clear distinction between usage_id and heap ID. For instance, ION_IOC_USAGE_CNT claims to return the number of usage IDs, but seems to return the number of heaps (i.e. number heap IDs, some of which might be usage_ids). Similarly,

Re: [RFC][PATCH 0/6] ion: improved ABI

Hi Laura, On Mon, Jun 06, 2016 at 11:23:27AM -0700, Laura Abbott wrote: The ABI for Ion's ioctl interface are a pain to work with. The heap IDs are a 32-bit non-discoverable namespace that form part of the ABI. There's no way to determine what ABI version is in use which leads to problems if