[PATCH v3] drivers: most: add ALSA sound driver

2021-02-09 Thread Christian Gromm
This patch moves the ALSA sound driver out of the staging area and adds it to the stable part of the MOST driver. Modifications to the Makefiles and Kconfigs are done accordingly to not break the build. Signed-off-by: Christian Gromm --- v2: Reported-by: Greg Kroah-Hartman

[PATCH v2 1/2] staging: most: sound: add sanity check for function argument

2021-02-02 Thread Christian Gromm
This patch checks the function parameter 'bytes' before doing the subtraction to prevent memory corruption. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- v2: change if condition to avoid difference of subtraction becomes negative. drivers/staging/most/sound/sound.c | 2 ++ 1

[PATCH 1/2] staging: most: sound: add sanity check for function argument

2021-02-02 Thread Christian Gromm
This patch zero checks the function parameter 'bytes' before doing the subtraction to prevent memory corruption. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/sound/sound.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/most/sound

[PATCH 2/2] staging: most: sound: use non-safe list iteration

2021-02-02 Thread Christian Gromm
This patch replaces the safe list iteration function with the non-safe one, as no list element is being deleted. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/sound/sound.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 0/2] staging: most: sound: implement improvements reported in code review

2021-02-02 Thread Christian Gromm
This patch set fixes two problems found during code audit. Christian Gromm (2): staging: most: sound: add sanity check for function argument staging: most: sound: use non-safe list iteration drivers/staging/most/sound/sound.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions

[PATCH v2] drivers: most: add ALSA sound driver

2020-11-06 Thread Christian Gromm
This patch moves the ALSA sound driver out of the staging area and adds it to the stable part of the MOST driver. Modifications to the Makefiles and Kconfigs are done accordingly to not break the build. Signed-off-by: Christian Gromm --- v2: Reported-by: Greg Kroah-Hartman

[PATCH v2] drivers: staging: most: use swabXX functions of kernel

2020-11-04 Thread Christian Gromm
This patch makes use of the swab16() and swab32() functions available in the kernel instead of using own implementations. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: added 'Reported-by:' tag drivers/staging/most/sound/sound.c | 14 ++ 1 file changed, 2

[PATCH] drivers: staging: most: use swabXX functions of kernel

2020-11-04 Thread Christian Gromm
This patch makes use of the swab16() and swab32() functions available in the kernel instead of using own implementations. Signed-off-by: Christian Gromm --- drivers/staging/most/sound/sound.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging

[PATCH] drivers: most: add ALSA sound driver

2020-11-02 Thread Christian Gromm
This patch moves the ALSA sound driver out of the staging area and adds it to the stable part of the MOST driver. Modifications to the Makefiles and Kconfigs are done accordingly to not break the build. Signed-off-by: Christian Gromm --- drivers/most/Kconfig| 10 + drivers/most

[RESEND PATCH] drivers: most: add character device interface driver

2020-08-20 Thread Christian Gromm
This patch adds the character device (cdev) driver source file most_cdev.c and modifies the Makefiles and Kconfigs accordingly. Signed-off-by: Christian Gromm --- drivers/most/Kconfig | 9 + drivers/most/Makefile | 1 + drivers/most/most_cdev.c | 543

[PATCH] drivers: most: add character device interface driver

2020-08-03 Thread Christian Gromm
This patch adds the character device (cdev) driver source file most_cdev.c and modifies the Makefiles and Kconfigs accordingly. Signed-off-by: Christian Gromm --- drivers/most/Kconfig | 9 + drivers/most/Makefile | 1 + drivers/most/most_cdev.c | 543

[PATCH v7] drivers: most: add USB adapter driver

2020-07-31 Thread Christian Gromm
This patch adds the USB driver source file most_usb.c and modifies the Makefile and Kconfig accordingly. Signed-off-by: Christian Gromm --- v2: Reported-by: Greg Kroah-Hartman - don't remove usb driver from staging area - don't touch staging/most/Kconfig - remove

[PATCH v7] drivers: most: add USB adapter driver

2020-07-31 Thread Christian Gromm
This patch adds the USB driver source file most_usb.c and modifies the Makefile and Kconfig accordingly. Signed-off-by: Christian Gromm --- v2: Reported-by: Greg Kroah-Hartman - don't remove usb driver from staging area - don't touch staging/most/Kconfig - remove

[PATCH v6] drivers: most: add USB adapter driver

2020-07-30 Thread Christian Gromm
This patch adds the USB driver source file most_usb.c and modifies the Makefile and Kconfig accordingly. Signed-off-by: Christian Gromm --- v2: Reported-by: Greg Kroah-Hartman - don't remove usb driver from staging area - don't touch staging/most/Kconfig - remove

[PATCH] staging: most: usb: remove NET dependency

2020-07-28 Thread Christian Gromm
This patch removes the dependency to NET as it is no longer needed. Signed-off-by: Christian Gromm --- drivers/staging/most/usb/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/most/usb/Kconfig b/drivers/staging/most/usb/Kconfig index 75dc25c

[RESEND PATCH v5] drivers: most: add USB adapter driver

2020-07-27 Thread Christian Gromm
This patch adds the usb driver source file most_usb.c and modifies the Makefile and Kconfig accordingly. Signed-off-by: Christian Gromm --- v2: Reported-by: Greg Kroah-Hartman - don't remove usb driver from staging area - don't touch staging/most/Kconfig - remove

[RESEND PATCH v5] drivers: most: add USB adapter driver

2020-07-01 Thread Christian Gromm
This patch adds the usb driver source file most_usb.c and modifies the Makefile and Kconfig accordingly. Signed-off-by: Christian Gromm --- v2: Reported-by: Greg Kroah-Hartman - don't remove usb driver from staging area - don't touch staging/most/Kconfig - remove

[PATCH 5/5] staging: most: sound: remove overcautious argument checking

2020-06-23 Thread Christian Gromm
The interface pointer passed to a component API function cannot be NULL. This patch removes the unnecessary sanity check of this argument. Signed-off-by: Christian Gromm --- drivers/staging/most/sound/sound.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/most/sound

[PATCH 4/5] staging: most: sound: fix white spaces

2020-06-23 Thread Christian Gromm
This patch removes unnecessary empty lines. Signed-off-by: Christian Gromm --- drivers/staging/most/sound/sound.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c index 467faa1..7c56cdb 100644

[PATCH 3/5] staging: most: sound: fix return values

2020-06-23 Thread Christian Gromm
This patch returns the proper values when reporting an error to the caller. Signed-off-by: Christian Gromm --- drivers/staging/most/sound/sound.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound

[PATCH 0/5] staging: most: sound: clean up

2020-06-23 Thread Christian Gromm
Patch set to clean up code and fix issues. Christian Gromm (5): staging: most: sound: remove noisy log messages staging: most: sound: fix error path staging: most: sound: fix return values staging: most: sound: fix white spaces staging: most: sound: remove overcautious argument checking

[PATCH 1/5] staging: most: sound: remove noisy log messages

2020-06-23 Thread Christian Gromm
This patch removes unnecessary log messages to avoid noise in the kernel log. Signed-off-by: Christian Gromm --- drivers/staging/most/sound/sound.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging

[PATCH 2/5] staging: most: sound: fix error path

2020-06-23 Thread Christian Gromm
Return error and exit the function in case registering the component with the core is failing. Signed-off-by: Christian Gromm --- drivers/staging/most/sound/sound.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most

[PATCH 0/6] staging: most: cdev: clean-up and improvements

2020-06-22 Thread Christian Gromm
Patch set to fix minor issues and improve things a little. Christian Gromm (6): staging: most: cdev: remove noisy log messages staging: most: cdev: use dev_*() functions to print messages staging: most: cdev: remove overcautious parameter checking staging: most: cdev: fix up

[PATCH 5/6] staging: most: cdev: fix return values

2020-06-22 Thread Christian Gromm
This patch makes use of the proper return values when reporting an error to the caller. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/cdev/cdev.c b/drivers/staging/most/cdev

[PATCH 1/6] staging: most: cdev: remove noisy log messages

2020-06-22 Thread Christian Gromm
This patch removes unnecessary log messages to avoid noise in the kernel log. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/staging/most/cdev/cdev.c b/drivers/staging

[PATCH 2/6] staging: most: cdev: use dev_*() functions to print messages

2020-06-22 Thread Christian Gromm
This patch removes the pr_*() functions and uses dev_*() instead. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/most/cdev/cdev.c b/drivers/staging/most/cdev/cdev.c index

[PATCH 6/6] staging: most: cdev: simplify list iteration

2020-06-22 Thread Christian Gromm
This patch uses a less confusing list traversing structure to either return an item of the list that meets the prerequisites or NULL otherwise. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

[PATCH 4/6] staging: most: cdev: fix up parenthesizing

2020-06-22 Thread Christian Gromm
This patch removes unnecessary parnthesis. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/cdev/cdev.c b/drivers/staging/most/cdev/cdev.c index 9fc84fa..d374cc0 100644 --- a/drivers

[PATCH 3/6] staging: most: cdev: remove overcautious parameter checking

2020-06-22 Thread Christian Gromm
The interface pointer passed to a component API function cannot be NULL. This patch removes unnecessary sanity checks of the pointer. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging

[PATCH v5] drivers: most: add USB adapter driver

2020-06-02 Thread Christian Gromm
This patch adds the usb driver source file most_usb.c and modifies the Makefile and Kconfig accordingly. Signed-off-by: Christian Gromm --- v2: Reported-by: Greg Kroah-Hartman - don't remove usb driver from staging area - don't touch staging/most/Kconfig - remove

[PATCH] staging: most: usb: init return value in default path of switch/case expression

2020-05-28 Thread Christian Gromm
This patch avoids returning an uninitialized value in the default path of the switch expression. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging

[PATCH v4] drivers: most: add USB adapter driver

2020-05-27 Thread Christian Gromm
This patch adds the usb driver source file most_usb.c and modifies the Makefile and Kconfig accordingly. Signed-off-by: Christian Gromm --- v2: Reported-by: Greg Kroah-Hartman - don't remove usb driver from staging area - don't touch staging/most/Kconfig - remove

[PATCH 08/10] staging: most: usb: use correct error codes

2020-05-27 Thread Christian Gromm
This patch uses the -EINVAL return code where -EFAULT is wrongly being used. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging

[PATCH 06/10] staging: most: usb: don't use error path to exit function on success

2020-05-27 Thread Christian Gromm
This patch makes it transparent whether the function is exiting with an error or successful. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b

[PATCH 07/10] staging: most: usb: replace code to calculate array index

2020-05-27 Thread Christian Gromm
or 1. The replacement is more simple and less confusing when reading the code. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers

[PATCH 01/10] staging: most: usb: change order of function parameters

2020-05-27 Thread Christian Gromm
This patch swaps the arguments of function get_stream_frame_size to have the struct device as first parameter. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 03/10] staging: most: usb: change return value of function drci_rd_reg

2020-05-27 Thread Christian Gromm
This patch makes function drci_rd_reg return 0 in case of success and a negative number else. As no caller is evaluating the number of bytes transferred by function usb_control_msg this information is being omitted. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging

[PATCH 04/10] staging: most: usb: return 0 instead of variable

2020-05-27 Thread Christian Gromm
This patch returns 0 instead of variable in case of invalid parameter has been passed to function to increase readability. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 09/10] staging: most: usb: add missing put_device calls

2020-05-27 Thread Christian Gromm
This patch adds the missing put_device() function calls to properly free allocated resources and maintain reference counts. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/most

[PATCH 10/10] staging: most: usb: use function sysfs_streq

2020-05-27 Thread Christian Gromm
This patch replaces function strcmp() with sysfs_streq() to compare strings provided via sysfs. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/most/usb

[PATCH 00/10] staging: most: usb: fix code review findings

2020-05-27 Thread Christian Gromm
This series fixes the comments received from the mailing list. Christian Gromm (10): staging: most: usb: change order of function parameters staging: most: usb: don't use expressions that might fail in a declaration staging: most: usb: change return value of function drci_rd_reg

[PATCH 02/10] staging: most: usb: don't use expressions that might fail in a declaration

2020-05-27 Thread Christian Gromm
This patch moves function calls that can fail out of the declararion block of a function body. This is done to enhance readability. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff

[PATCH 05/10] staging: most: usb: move allocation of URB out of critical section

2020-05-27 Thread Christian Gromm
This patch puts the call to usb_alloc_urb() before the critical section starts that is protected with the io_mutex lock. This is to make the section as short as possible and to use the regular GFP_KERNEL flag. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most

[PATCH v3] drivers: most: add USB adapter driver

2020-05-18 Thread Christian Gromm
This patch adds the usb driver source file most_usb.c and modifies the Makefile and Kconfig accordingly. Signed-off-by: Christian Gromm --- v2: Reported-by: Greg Kroah-Hartman - don't remove usb driver from staging area - don't touch staging/most/Kconfig - remove

[PATCH v3 6/7] staging: most: usb: use macro ATTRIBUTE_GROUPS

2020-05-15 Thread Christian Gromm
This patch makes use of the macro ATTRIBUTE_GROUPS to create the groups instead of defining them manually. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: v3: drivers/staging/most/usb/usb.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git

[PATCH v3 2/7] staging: most: usb: remove reference to USB error codes

2020-05-15 Thread Christian Gromm
This patch removes the reference to the driver API file for USB error codes. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: removed copied USB error code section v3: drivers/staging/most/usb/usb.c | 97 -- 1 file changed

[PATCH v3 7/7] Documentation: ABI: correct sysfs attribute description of MOST driver

2020-05-15 Thread Christian Gromm
This patch fixes the ABI description file sysfs-bus-most. Signed-off-by: Christian Gromm --- v2: v3: Documentation/ABI/testing/sysfs-bus-most | 104 --- 1 file changed, 53 insertions(+), 51 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-bus-most b

[PATCH v3 1/7] staging: most: usb: use dev_*() functions to print messages

2020-05-15 Thread Christian Gromm
This patch removes the pr_*() functions and uses dev_*() instead. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: v3: drivers/staging/most/usb/usb.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b

[PATCH v3 3/7] staging: most: usb: check number of reported endpoints

2020-05-15 Thread Christian Gromm
This patch checks the number of endpoints reported by the USB interface descriptor and throws an error if the number exceeds MAX_NUM_ENDPOINTS. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: v3: - initialize return variable Reported-by: kbuild test robot

[PATCH v3 0/7] staging: most: usb: fix issues found in code audit

2020-05-15 Thread Christian Gromm
This series fixes the comments/findings on the previously submitted code of the USB adapter driver. The fixes should be applied in staging before moving the driver out as one patch. v2: modded patch 2/7 v3: modded patch 3/7 Christian Gromm (7): staging: most: usb: use dev_

[PATCH v3 4/7] staging: most: usb: use dev_dbg function

2020-05-15 Thread Christian Gromm
This patch replaces the functions dev_notice with dev_dbg to silence the driver during normal operation. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: v3: drivers/staging/most/usb/usb.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions

[PATCH v3 5/7] staging: most: fix typo in Kconfig

2020-05-15 Thread Christian Gromm
This patch corrects the typo in the Kconfig file where it says tranceiver instead of transceiver. Signed-off-by: Christian Gromm Reported-by: Randy Dunlap --- v2: v3: drivers/staging/most/usb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/usb

[PATCH v2 6/7] staging: most: usb: use macro ATTRIBUTE_GROUPS

2020-05-14 Thread Christian Gromm
This patch makes use of the macro ATTRIBUTE_GROUPS to create the groups instead of defining them manually. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: drivers/staging/most/usb/usb.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git

[PATCH v2 2/7] staging: most: usb: remove reference to USB error codes

2020-05-14 Thread Christian Gromm
This patch removes the reference to the driver API file for USB error codes. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: removed copied USB error code section drivers/staging/most/usb/usb.c | 97 -- 1 file changed, 97

[PATCH v2 7/7] Documentation: ABI: correct sysfs attribute description of MOST driver

2020-05-14 Thread Christian Gromm
This patch fixes the ABI description file sysfs-bus-most. Signed-off-by: Christian Gromm --- v2: Documentation/ABI/testing/sysfs-bus-most | 104 --- 1 file changed, 53 insertions(+), 51 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-bus-most b

[PATCH v2 1/7] staging: most: usb: use dev_*() functions to print messages

2020-05-14 Thread Christian Gromm
This patch removes the pr_*() functions and uses dev_*() instead. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: drivers/staging/most/usb/usb.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers

[PATCH v2 5/7] staging: most: fix typo in Kconfig

2020-05-14 Thread Christian Gromm
This patch corrects the typo in the Kconfig file where it says tranceiver instead of transceiver. Signed-off-by: Christian Gromm Reported-by: Randy Dunlap --- v2: drivers/staging/most/usb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/usb

[PATCH v2 4/7] staging: most: usb: use dev_dbg function

2020-05-14 Thread Christian Gromm
This patch replaces the functions dev_notice with dev_dbg to silence the driver during normal operation. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: drivers/staging/most/usb/usb.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff

[PATCH v2 0/7] staging: most: usb: fix issues found in code audit

2020-05-14 Thread Christian Gromm
This series fixes the comments/findings on the previously submitted code of the USB adapter driver. The fixes should be applied in staging before moving the driver out as one patch. v2: modded patch 2/7 Christian Gromm (7): staging: most: usb: use dev_*() functions to print messages

[PATCH v2 3/7] staging: most: usb: check number of reported endpoints

2020-05-14 Thread Christian Gromm
This patch checks the number of endpoints reported by the USB interface descriptor and throws an error if the number exceeds MAX_NUM_ENDPOINTS. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: drivers/staging/most/usb/usb.c | 13 ++--- 1 file changed, 6

[PATCH 1/7] staging: most: usb: use dev_*() functions to print messages

2020-05-14 Thread Christian Gromm
This patch removes the pr_*() functions and uses dev_*() instead. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- drivers/staging/most/usb/usb.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers

[PATCH 3/7] staging: most: usb: check number of reported endpoints

2020-05-14 Thread Christian Gromm
This patch checks the number of endpoints reported by the USB interface descriptor and throws an error if the number exceeds MAX_NUM_ENDPOINTS. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- drivers/staging/most/usb/usb.c | 13 ++--- 1 file changed, 6 insertions

[PATCH 7/7] Documentation: ABI: correct sysfs attribute description of MOST driver

2020-05-14 Thread Christian Gromm
This patch fixes the ABI description file sysfs-bus-most. Signed-off-by: Christian Gromm --- Documentation/ABI/testing/sysfs-bus-most | 104 --- 1 file changed, 53 insertions(+), 51 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-bus-most b/Documentation

[PATCH 4/7] staging: most: usb: use dev_dbg function

2020-05-14 Thread Christian Gromm
This patch replaces the functions dev_notice with dev_dbg to silence the driver during normal operation. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- drivers/staging/most/usb/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 5/7] staging: most: fix typo in Kconfig

2020-05-14 Thread Christian Gromm
This patch corrects the typo in the Kconfig file where it says tranceiver instead of transceiver. Signed-off-by: Christian Gromm Reported-by: Randy Dunlap --- drivers/staging/most/usb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/usb/Kconfig b

[PATCH 2/7] staging: most: usb: remove reference to USB error codes

2020-05-14 Thread Christian Gromm
This patch removes the reference to the driver API file for USB error codes. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- drivers/staging/most/usb/usb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c

[PATCH 0/7] staging: most: usb: fix issues found in code audit

2020-05-14 Thread Christian Gromm
This series fixes the comments/findings on the previously submitted code of the USB adapter driver. The fixes should be applied in staging before moving the driver out as one patch. Christian Gromm (7): staging: most: usb: use dev_*() functions to print messages staging: most: usb: remove

[PATCH 6/7] staging: most: usb: use macro ATTRIBUTE_GROUPS

2020-05-14 Thread Christian Gromm
This patch makes use of the macro ATTRIBUTE_GROUPS to create the groups instead of defining them manually. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- drivers/staging/most/usb/usb.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH v2 0/8] staging: most: move USB adapter driver to stable branch

2020-05-14 Thread Christian Gromm
This series moves the USB adapter driver to the stable branch and fixes the comments/findings on the submitted code. v2: - create a patch set to address the comments on submitted code Christian Gromm (8): drivers: most: add usb adapter driver drivers: most: usb: use dev_*() functions

[PATCH v2 1/8] drivers: most: add usb adapter driver

2020-05-14 Thread Christian Gromm
This patch adds the usb driver source file most_usb.c and modifies the Makefile and Kconfig accordingly. Signed-off-by: Christian Gromm --- v2: Reported-by: Greg Kroah-Hartman - don't remove usb driver from staging area - don't touch staging/most/Kconfig - remove

[PATCH v2 4/8] drivers: most: usb: check number of reported endpoints

2020-05-14 Thread Christian Gromm
This patch checks the number of endpoints reported by the USB interface descriptor and throws an error if the number exceeds MAX_NUM_ENDPOINTS. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: drivers/most/most_usb.c | 13 ++--- 1 file changed, 6 insertions(+), 7

[PATCH v2 8/8] Documentation: ABI: correct sysfs attribute description of MOST driver

2020-05-14 Thread Christian Gromm
This patch fixes the ABI description file sysfs-bus-most. Signed-off-by: Christian Gromm --- v2: Documentation/ABI/testing/sysfs-bus-most | 104 --- 1 file changed, 53 insertions(+), 51 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-bus-most b

[PATCH v2 3/8] drivers: most: usb: remove reference to USB error codes

2020-05-14 Thread Christian Gromm
This patch removes the reference to the driver API file for USB error codes. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: drivers/most/most_usb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/most/most_usb.c b/drivers/most/most_usb.c index 0846b38

[PATCH v2 7/8] drivers: most: usb: use macro ATTRIBUTE_GROUPS

2020-05-14 Thread Christian Gromm
This patch makes use of the macro ATTRIBUTE_GROUPS to create the groups instead of defining them manually. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: drivers/most/most_usb.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH v2 2/8] drivers: most: usb: use dev_*() functions to print messages

2020-05-14 Thread Christian Gromm
This patch removes the pr_*() functions and uses dev_*() instead. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: drivers/most/most_usb.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/most/most_usb.c b/drivers/most

[PATCH v2 6/8] drivers: most: fix typo in Kconfig

2020-05-14 Thread Christian Gromm
This patch corrects the typo in the Kconfig file where it says tranceiver instead of transceiver. Signed-off-by: Christian Gromm Reported-by: Randy Dunlap --- v2: drivers/most/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/most/Kconfig b/drivers/most

[PATCH v2 5/8] drivers: most: usb: use dev_dbg function

2020-05-14 Thread Christian Gromm
This patch replaces the functions dev_notice with dev_dbg to silence the driver during normal operation. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: drivers/most/most_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/most

[PATCH RFC] drivers: most: add USB adapter driver

2020-05-11 Thread Christian Gromm
This patch adds the MOST USB adapter driver to the stable branch. This is a follow-up to commit . Signed-off-by: Christian Gromm --- drivers/most/Kconfig |6 + drivers/most/Makefile |2 + drivers/most/usb/Kconfig | 14 + drivers/most/usb/Makefile |4

[PATCH] staging: most: usb: add PM functions

2020-05-05 Thread Christian Gromm
This patch adds the implementation of the PM functions resume and suspend. Signed-off-by: Christian Gromm --- drivers/staging/most/usb/usb.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index

[PATCH 3/4] staging: most: usb: drop unlikely macros

2020-05-05 Thread Christian Gromm
This patch removes the unlikely macros in the error patch of argument checking, as it has no measurable performance adavantage. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- drivers/staging/most/usb/usb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions

[PATCH 1/4] staging: most: usb: remove overcautious parameter checking

2020-05-05 Thread Christian Gromm
The interface pointer passed to a core API function cannot be NULL. This patch removes unnessecary the sanity check of the pointer. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- drivers/staging/most/usb/usb.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions

[PATCH 2/4] staging: most: usb: use EINVAL error code

2020-05-05 Thread Christian Gromm
This patch replaces the error code EIO with EINVAL, when there is no IO happening. Signed-off-by: Christian Gromm --- drivers/staging/most/usb/usb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c

[PATCH 0/4] staging: most: usb: cleanup code

2020-05-05 Thread Christian Gromm
This patch set consolidates the source code appearance by rearranging or removing unnecessary code and makes use of error codes that better signal the exception. Christian Gromm (4): staging: most: usb: remove overcautious parameter checking staging: most: usb: use EINVAL error code staging

[PATCH 4/4] staging: most: usb: consolidate code

2020-05-05 Thread Christian Gromm
This patch applies the same look and feel when assigning local variables. Signed-off-by: Christian Gromm --- drivers/staging/most/usb/usb.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 62d773c

[PATCH] staging: most: usb: fix exception handling

2020-05-04 Thread Christian Gromm
This patch fixes error handling on function parameters. Signed-off-by: Christian Gromm --- drivers/staging/most/usb/usb.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index

[PATCH RFC] staging: most: usb: move USB adapter driver to stable branch

2020-04-30 Thread Christian Gromm
This patch moves the MOST USB adapter driver to the stable branch. It is a follow-up to commit . Signed-off-by: Christian Gromm --- drivers/most/Kconfig| 6 ++ drivers/most/Makefile | 2 ++ drivers/{staging => }/most/usb/Kconfig | 0 drivers/{stag

[PATCH v2] most: core: use function subsys_initcall()

2020-04-24 Thread Christian Gromm
@@ static void __exit most_exit(void) ida_destroy(_id); } -module_init(most_init); +subsys_initcall(most_init); module_exit(most_exit); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Christian Gromm "); -- 2.7.4 ___ d

[PATCH] most: core: use function subsys_initcall()

2020-04-24 Thread Christian Gromm
) ida_destroy(_id); } -module_init(most_init); +subsys_initcall(most_init); module_exit(most_exit); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Christian Gromm "); -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.li

[RESEND PATCH v5 1/3] staging: most: move core files out of the staging area

2020-03-10 Thread Christian Gromm
This patch moves the core module to the /drivers/most directory and makes all necessary changes in order to not break the build. Signed-off-by: Christian Gromm --- v2: v3: v4: v5: rebased and adapted drivers/Kconfig| 1 + drivers/Makefile

[RESEND PATCH v5 2/3] staging: most: Documentation: update ABI description

2020-03-10 Thread Christian Gromm
This patch updates the ABI description files to be in sync with current implementation. Signed-off-by: Christian Gromm --- v2: v3: v4: v5: rebased and adapted .../most/Documentation/ABI/configfs-most.txt | 8 .../most/Documentation/ABI/sysfs-bus-most.txt | 24

[RESEND PATCH v5 3/3] staging: most: Documentation: move ABI description files out of staging area

2020-03-10 Thread Christian Gromm
This patch moves the ABI description fils sysfs-bus-most and configfs-most to the kernel's documentation folder. Signed-off-by: Christian Gromm --- v2: v3: v4: v5: rebased and adapted .../ABI/configfs-most.txt => Documentation/ABI/testing/configfs-most | 0 .../ABI/sysfs-bus-most.

[RESEND PATCH v5 0/3] staging: most: move core module out of staging

2020-03-10 Thread Christian Gromm
Christian Gromm (3): staging: most: move core files out of the staging area staging: most: Documentation: update ABI description staging: most: Documentation: move ABI description files out of staging area .../ABI/testing/configfs-most | 8 .../ABI

[PATCH v5 2/3] staging: most: Documentation: update ABI description

2020-02-19 Thread Christian Gromm
This patch updates the ABI description files to be in sync with current implementation. Signed-off-by: Christian Gromm --- v2: v3: v4: v5: rebased and adapted .../most/Documentation/ABI/configfs-most.txt | 8 .../most/Documentation/ABI/sysfs-bus-most.txt | 24

[PATCH v5 3/3] staging: most: Documentation: move ABI description files out of staging area

2020-02-19 Thread Christian Gromm
This patch moves the ABI description fils sysfs-bus-most and configfs-most to the kernel's documentation folder. Signed-off-by: Christian Gromm --- v2: v3: v4: v5: rebased and adapted .../ABI/configfs-most.txt => Documentation/ABI/testing/configfs-most | 0 .../ABI/sysfs-bus-most.

[PATCH v5 1/3] staging: most: move core files out of the staging area

2020-02-19 Thread Christian Gromm
This patch moves the core module to the /drivers/most directory and makes all necessary changes in order to not break the build. Signed-off-by: Christian Gromm --- v2: v3: v4: v5: rebased and adapted drivers/Kconfig| 1 + drivers/Makefile

[PATCH v5 0/3] staging: most: move core module out of staging

2020-02-19 Thread Christian Gromm
Christian Gromm (3): staging: most: move core files out of the staging area staging: most: Documentation: update ABI description staging: most: Documentation: move ABI description files out of staging area .../ABI/testing/configfs-most | 8 .../ABI

[PATCH v4 00/10] staging: most: move core module out of staging

2020-01-23 Thread Christian Gromm
race condition - fix logging behaviour - fix possible NULL pointer dereference Christian Gromm (10): staging: most: remove device from interface structure staging: most: core: drop device reference staging: most: remove struct device core driver staging: most: core: remove

[PATCH v4 01/10] staging: most: remove device from interface structure

2020-01-23 Thread Christian Gromm
This patch makes the adapter drivers use their own device structures when registering a most interface with the core module. With this the module that actually operates the physical device is the owner of the device. Signed-off-by: Christian Gromm --- v4: This patch has beed added

[PATCH v4 06/10] staging: next: configfs: fix release link

2020-01-23 Thread Christian Gromm
of a link that already has been destroyed. Signed-off-by: Christian Gromm --- v4: This patch has been added to the series drivers/staging/most/configfs.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/drivers/staging/most/configfs.c b/drivers

  1   2   3   4   5   6   7   8   >