On Mon, Jul 17, 2017 at 05:44:59PM +, Dilger, Andreas wrote:
> On Jul 12, 2017, at 03:03, Craig Inches <cr...@craiginches.com> wrote:
> >
> > This fixes a block statement which didnt end with */
> >
> > Signed-off-by: Craig Inches <cr...@craiginches.com
This fixes multiple block statements found not to match
style as per checkpatch
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
drivers/staging/lustre/include/linux/lnet/lnetst.h | 129 +
1 file changed, 81 insertions(+), 48 deletions(-)
diff --git a/drivers/s
This fixes a block statement which didnt end with */
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h
b/d
This patch fixes some multiline comment blocks which didnt conform
to the style guide, found by checkpatch.
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
.../staging/lustre/include/linux/lnet/lib-types.h | 46 ++
1 file changed, 30 insertions(+), 16 del
This patch fixes a warning generated by checkpatch for
a line over 80 characters.
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/i
This series fixes a few style issues in lustre. All where picked up
by checkpatch.
v2 Changes:
- Fixed typo in patch subject s/luster/lustre/
Craig
This fixes a block statement which didnt end with */
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h
b/d
This fixes multiple block statements found not to match
style as per checkpatch
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
drivers/staging/lustre/include/linux/lnet/lnetst.h | 129 +
1 file changed, 81 insertions(+), 48 deletions(-)
diff --git a/drivers/s
This patch fixes a warning generated by checkpatch for
a line over 80 characters.
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/i
This patch fixes some multiline comment blocks which didnt conform
to the style guide, found by checkpatch.
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
.../staging/lustre/include/linux/lnet/lib-types.h | 46 ++
1 file changed, 30 insertions(+), 16 del
This series fixes a few style issues in lustre. All where picked up
by checkpatch.
Craig Inches (4):
Staging: Luster: Clean up line over 80Char in lib-lnet.h
Staging: Lustre Fix up multiple Block Comments in lib-types.h
Staging: Lustre Fixing multiline block comments in lnetst.h
Staging
This resolves a checkpatch warning that "Single statement macros should
not use a do {} while (0) loop" by removing the loop and adjusting line
length accordingly.
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
Changes in v2:
- Kept statements together
- Kept oper
This resolves a checkpatch warning that "Single statement macros should
not use a do {} while (0) loop" by removing the loop and adjusting line
length accordingly.
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
Changes in v2:
- Kept statements together
- Kept oper
This resolves a checkpatch warning that "Single statement macros should
not use a do {} while (0) loop" by removing the loop and adjusting line
length accordingly.
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
.../lustre/include/linux/libcfs/libcfs_
On Mon, Mar 13, 2017 at 03:11:10PM +0300, Dan Carpenter wrote:
> On Sun, Mar 12, 2017 at 02:37:22PM +0100, Greg KH wrote:
> > On Sat, Mar 11, 2017 at 01:07:40PM +0000, Craig Inches wrote:
> > > This patch resolves the "Comparisons should place the constant on
> >
This patch adjusts lines so that they are less than 80 char.
Checkpatch.pl idenitified the issue.
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
drivers/staging/lustre/lustre/include/lu_object.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/d
This patch resolves the "Comparisons should place the constant on
the right side of the test" found with checkpatch tool.
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletio
I did build the kernel 1 for each change, then a final with all changes
applied.
Apologies if I missed something,
Craig
On Sat, Jun 18, 2016 at 07:02:35PM -0700, Greg Kroah-Hartman wrote:
> On Sat, Jun 18, 2016 at 10:25:55PM +0100, Craig Inches wrote:
> > Macros with complex valu
Line length greater than 80 char.
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
drivers/staging/lustre/lustre/include/cl_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/cl_object.h
b/drivers/staging/lustre/
Macros with complex values should be enclosed in parenthesis
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
drivers/staging/lustre/lustre/include/cl_object.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/cl_objec
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
drivers/staging/lustre/lustre/include/cl_object.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/cl_ob
Fix three different issues from checkpatch:
Line over 80 Chars
Unsigned int prefered over unsigned
Macros with complex values should be enclosed in parenthesis
Craig Inches (3):
checkpatch style issue: Line over 80 char
Checkpatch style issue:
Checkpatch error cleanup
drivers/staging
This patch changes 3 bracket alignment errors found by checkpatch.
Signed-off-by: Craig Inches <cr...@craiginches.com>
---
drivers/staging/android/sync.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/
On Thu, Jul 16, 2015 at 11:13:43PM +0300, Dan Carpenter wrote:
On Fri, Jul 17, 2015 at 03:03:24AM +, Craig Inches wrote:
Fixed multiple instances of:
CHECK: Alignment should match open parenthesis
CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Please don't use
Fixed up some checkpatch.pl style issues.
Line greater than 80 Chars in multiple locations.
Signed-off-by: Craig Inches craig.inc...@xayto.net
---
drivers/staging/dgnc/dgnc_tty.c | 168 ++--
1 file changed, 110 insertions(+), 58 deletions(-)
diff --git
Hi Joe,
On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote:
On Thu, 2015-07-16 at 23:11 +, Craig Inches wrote:
Fixed up some checkpatch.pl style issues.
Line greater than 80 Chars in multiple locations.
I think most all of these are not improvements.
Ok, can you
Fixed multiple instances of:
CHECK: Alignment should match open parenthesis
CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Please don't use multiple blank lines
CHECK: Blank lines aren't necessary after an open brace '{'
WARNING: line over 80 characters
Signed-off-by: Craig
On Fri, Jul 17, 2015 at 12:20:42AM +, Craig Inches wrote:
Hi Joe,
On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote:
On Thu, 2015-07-16 at 23:11 +, Craig Inches wrote:
Fixed up some checkpatch.pl style issues.
Line greater than 80 Chars in multiple locations.
I
On Mon, Jul 13, 2015 at 04:42:22AM -0700, Joe Perches wrote:
On Mon, 2015-07-13 at 17:29 +, Craig wrote:
Modified style issue in ion.c. Missing empty line after a definition
Signed-off-by: Craig craig.inc...@xayto.net
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed,
29 matches
Mail list logo
