Re: [PATCH 1/1] Staging: rdma: hfi1: rc.c: Fixed coding style issues

2016-05-25 Thread Dennis Dalessandro
On Mon, May 23, 2016 at 12:06:01PM +0530, Shyam Saini wrote: Fixed following checkpatch.pl warnings: Prefer 'unsigned int' to bare use of 'unsigned' Prefer READ_ONCE() over ACCESS_ONCE() In general please don't fix two types of issues in the same patch. Also, as to the unsinged -> unsigned

Re: [PATCH 1/1] Staging: rdma: hfi1: sdma.c: Fixed coding style issues

2016-05-23 Thread Dennis Dalessandro
On Mon, May 23, 2016 at 12:06:02PM +0530, Shyam Saini wrote: Fixed following checkpatch.pl warnings: Prefer 'unsigned int' to bare use of 'unsigned' Prefer READ_ONCE() over ACCESS_ONCE() Same response [1] as to your previous patch. If you do spin the READ_ONCE bit please squash the two.

Re: [PATCH] Staging: rdma: hfi1: verbs_mcast: fixed a brace coding style issue

2016-02-24 Thread Dennis Dalessandro
On Sun, Feb 21, 2016 at 04:30:39PM +0100, Jannik Becher wrote: Fixed a coding style issue. Signed-off-by: Jannik Becher --- drivers/staging/rdma/hfi1/verbs_mcast.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[RFC PATCH 02/15] IB/hfi1: Add basic rdmavt capability flags for hfi1

2015-12-14 Thread Dennis Dalessandro
Most functionality is still being done in the driver, set flags so that rdmavt will let hfi1 continue to handle mr, qp, and cq init. Reviewed-by: Mike Marciniszyn <mike.marcinis...@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessan...@intel.com> --- drivers/staging/rdma/

[RFC PATCH 11/15] IB/hfi1: Remove hfi1 MR and hfi1 specific qp type

2015-12-14 Thread Dennis Dalessandro
. Reviewed-by: Mike Marciniszyn <mike.marcinis...@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessan...@intel.com> Signed-off-by: Jubin John <jubin.j...@intel.com> --- drivers/staging/rdma/hfi1/Makefile |2 drivers/staging/rdma/hfi1/cq.c |2 drivers

[RFC PATCH 10/15] IB/hfi1: Implement hfi1 support for AH notification

2015-12-14 Thread Dennis Dalessandro
For OPA devices additional work is required to create an AH. This patch adds support to set the VL correctly. Reviewed-by: Mike Marciniszyn <mike.marcinis...@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessan...@intel.com> --- drivers/staging/rdma/hfi1/ve

[RFC PATCH 15/15] IB/hfi1: Use rdmavt pkey verbs function

2015-12-14 Thread Dennis Dalessandro
No need to keep providing the query pkey function. This is now being done in rdmavt. Remove support from hfi1. The allocation and maintenance of the list still resides in the driver. Reviewed-by: Mike Marciniszyn <mike.marcinis...@intel.com> Signed-off-by: Dennis Dalessandro <dennis

[RFC PATCH 06/15] IB/hfi1: Remove driver specific members from hfi1 qp type

2015-12-14 Thread Dennis Dalessandro
com> Signed-off-by: Dennis Dalessandro <dennis.dalessan...@intel.com> Signed-off-by: Jubin John <jubin.j...@intel.com> --- drivers/staging/rdma/hfi1/diag.c |3 + drivers/staging/rdma/hfi1/pio.c |6 ++- drivers/staging/rdma/hfi1/qp.c| 76

[RFC PATCH 12/15] IB/hfi1: Remove srq from hfi1

2015-12-14 Thread Dennis Dalessandro
SRQ data structure has been moved to rdmavt. Make use of it. Reviewed-by: Harish Chegondi <harish.chego...@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessan...@intel.com> --- drivers/staging/rdma/hfi1/qp.c|2 +- drivers/staging/rdma/hfi1/ruc.c |4 ++-- dri

[RFC PATCH 09/15] IB/hfi1: Use address handle in rdmavt and remove from hfi1

2015-12-14 Thread Dennis Dalessandro
Original patch from Kamal Heib <kam...@mellanox.com>, split apart from original and modified to accomodate recent changes in rdmavt. Remove AH from hfi1 and use rdmavt version. Signed-off-by: Kamal Heib <kam...@mellanox.com> Signed-off-by: Dennis Dalessandro <dennis.dalessan...@in

[RFC PATCH 04/15] IB/hfi1: Use rdmavt protection domain

2015-12-14 Thread Dennis Dalessandro
Remove protection domain from hfi1 and use rdmavt's version. Reviewed-by: Ira Weiny <ira.we...@intel.com> Reviewed-by: Mike Marciniszyn <mike.marcinis...@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessan...@intel.com> --- drivers/staging/rdma/hfi1/keys.c |4 +

[RFC PATCH 03/15] IB/hfi1: Consolidate dma ops for hfi1

2015-12-14 Thread Dennis Dalessandro
Remove the dma.c file from hfi1 in favor of using that which is present in rdmavt. Reviewed-by: Ira Weiny <ira.we...@intel.com> Reviewed-by: Mike Marciniszyn <mike.marcinis...@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessan...@intel.com> --- drivers/staging/

[RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

2015-12-14 Thread Dennis Dalessandro
-rdma%40vger.kernel.org/msg29360.html --- Dennis Dalessandro (15): IB/hfi1: Begin to use rdmavt for verbs IB/hfi1: Add basic rdmavt capability flags for hfi1 IB/hfi1: Consolidate dma ops for hfi1 IB/hfi1: Use rdmavt protection domain IB/hfi1: Remove MR data structures

[RFC PATCH 05/15] IB/hfi1: Remove MR data structures from hfi1

2015-12-14 Thread Dennis Dalessandro
Remove MR data structures from hfi1 and use the version in rdmavt Reviewed-by: Dean Luick <dean.lu...@intel.com> Reviewed-by: Mike Marciniszyn <mike.marcinis...@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessan...@intel.com> --- drivers/staging/rdma/h

[RFC PATCH 07/15] IB/hfi1: Add device specific info prints

2015-12-14 Thread Dennis Dalessandro
Implement get_card_name and get_pci_dev helper functions for rdmavt for hfi1. Reviewed-by: Mike Marciniszyn <mike.marcinis...@intel.com> Reviewed-by: Ira Weiny <ira.we...@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessa...@intel.com> --- drivers/staging/rdma/hf

[RFC PATCH 13/15] IB/hfi1: Remove ibport and use rdmavt version

2015-12-14 Thread Dennis Dalessandro
Remove most of the ibport members from hfi1 and use the rdmavt version. Also register the port with rdmavt. Reviewed-by: Mike Marciniszyn <mike.marcinis...@intel.com> Reviewed-by: Harish Chegondi <harish.chego...@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessan...@in

Re: HFI1 code duplication todo

2015-11-19 Thread Dennis Dalessandro
On Thu, Nov 12, 2015 at 04:13:18PM -0500, Dennis Dalessandro wrote: The major todo for the hfi1 driver in staging is getting rid of the verbs code duplication between ipath, qib, and now hfi1. The ipath driver has been deprecated and is going to be deleted soon. So that leaves qib and hfi

HFI1 code duplication todo

2015-11-12 Thread Dennis Dalessandro
The major todo for the hfi1 driver in staging is getting rid of the verbs code duplication between ipath, qib, and now hfi1. The ipath driver has been deprecated and is going to be deleted soon. So that leaves qib and hfi. To address this we have proposed rdmavt which will be a common kmod that

Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

2015-11-12 Thread Dennis Dalessandro
On Thu, Nov 12, 2015 at 08:04:01AM +0200, Or Gerlitz wrote: On Wed, Nov 11, 2015 at 3:39 PM, Dennis Dalessandro <dennis.dalessan...@intel.com> wrote: On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote: On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.we...@intel.com wrote:

Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

2015-11-11 Thread Dennis Dalessandro
On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote: On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.we...@intel.com wrote: From: Dennis Dalessandro <dennis.dalessan...@intel.com> +int snoop_send_dma_handler(struct hfi1_qp *qp, struct hfi1_pkt_sta

Re: [PATCH 4/8] staging/rdma/hfi1: remove unneeded goto done

2015-11-11 Thread Dennis Dalessandro
On Wed, Nov 11, 2015 at 12:03:36PM +0300, Dan Carpenter wrote: On Wed, Nov 11, 2015 at 12:43:05AM -0500, ira.we...@intel.com wrote: From: Ira Weiny <ira.we...@intel.com> This goto done is followed by an if (ret) break in the outer switch clause. It is unnecessary. Signed-off-by:

Re: [PATCH] staging/rdma/hfi1: Convert dd_dev_info() to hfi1_cdbg() in process startup

2015-11-05 Thread Dennis Dalessandro
On Thu, Nov 05, 2015 at 10:58:36AM +0300, Dan Carpenter wrote: On Wed, Nov 04, 2015 at 11:14:57PM -0500, jubin.j...@intel.com wrote: From: Sebastian Sanchez Replacing dd_dev_info() for hfi1_cdbg() to avoid generating syslog output for every context that is open by