(different address spaces)
kpc2000_i2c.c:516:expected void const volatile [noderef] *addr
kpc2000_i2c.c:516:got void *
Signed-off-by: Eduardo Barretto
---
drivers/staging/kpc2000/kpc2000_i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/kpc2000
Removed useless 'else' statement that followed an 'if' statement that
had a return 1 and moved all the content from the 'else' to outside of
the switch case, this way if any case is sufficient it returns '1',
otherwise it will return 0.
Signed-off-by: Edu
s else statement can be done outside the switch case statement
and then we return '0'.
This way we have a cleaner code and no checkpatch error complaints.
Signed-off-by: Eduardo Barretto
---
drivers/staging/wlan-ng/hfa384x_usb.c | 11 +--
1 file changed, 5 insertions(+), 6
:
> On Thu, Dec 18, 2014 at 12:17:54AM -0200, Eduardo Barretto wrote:
>> Fixed a coding style issue.
>
> What coding style issue?
>
> Be specific, you have lots of room here.
>
___
devel mailing list
de...@lin
Fixed a coding style issue.
Signed-off-by: Eduardo Barretto
---
drivers/staging/wlan-ng/hfa384x_usb.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 55d2f56..de33a07 100644
Thank you for the quick feedback.
It was my first patch to the kernel and I wanted to be sure it would get right
to the community.
I'll be making a version two with the consideration you brought me.
Thank you again,
Best regards,
Eduardo Barretto
On Sun, Dec 14, 2014 at 06:11:30PM -0800
Fixed a coding style issue
Signed-off-by: Eduardo Barretto
---
drivers/staging/wlan-ng/hfa384x_usb.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 55d2f56..d388f2c 100644
--- a