Re: [PATCH] greybus: audio: remove unused code

[Mark Greer]

On Thu, May 07, 2020 at 11:29:11PM +0200, Alexandre Belloni wrote:
> GREYBUS_AUDIO_MSM8994 is not an existing configuration option and as
> reported in September 2016, it depends on an "out-of-tree qualcomm audio
> driver". This driver never made it upstream.
> 
> https://lore.kernel.org/lkml/20160921073905.ga31...@kroah.com/
> 
> Moreover, there doesn't seem to be any interest in actually fixing the
> driver as it uses ASoC APIs that have been removed from the kernel in 2018
> as shown by its use of snd_soc_register_codec and
> snd_soc_codec_get_drvdata, removed in commit 999f7f5af8eb ("ASoC: remove
> Codec related code").
> 
> Signed-off-by: Alexandre Belloni 
> ---

Everything you say is true but it is still kinda sad to see this go.
But that is life...  If and when someone has the motivation to get this
working again they can take a look at the git history.

Thanks for this, Alexandre.

Acked-by: Mark Greer 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 7/9] staging: greybus: move core include files to include/linux/greybus/

[Mark Greer]

On Sun, Aug 25, 2019 at 07:54:27AM +0200, Greg Kroah-Hartman wrote:
> With the goal of moving the core of the greybus code out of staging, the
> include files need to be moved to include/linux/greybus.h and
> include/linux/greybus/
> 
> Cc: Vaibhav Hiremath 
> Cc: Johan Hovold 
> Cc: Alex Elder 
> Cc: Vaibhav Agarwal 
> Cc: Mark Greer 
> Cc: Viresh Kumar 
> Cc: Rui Miguel Silva 
> Cc: David Lin 
> Cc: "Bryan O'Donoghue" 
> Cc: greybus-...@lists.linaro.org
> Cc: de...@driverdev.osuosl.org
> Signed-off-by: Greg Kroah-Hartman 
> ---

Acked-by: Mark Greer 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/9] staging: greybus: remove license "boilerplate"

[Mark Greer]

On Sun, Aug 25, 2019 at 07:54:22AM +0200, Greg Kroah-Hartman wrote:
> When the greybus drivers were converted to SPDX identifiers for the
> license text, some license boilerplate was not removed.  Clean this up
> by removing this unneeded text now.
> 
> Cc: Johan Hovold 
> Cc: Alex Elder 
> Cc: Vaibhav Agarwal 
> Cc: Mark Greer 
> Cc: Viresh Kumar 
> Cc: "Bryan O'Donoghue" 
> Cc: greybus-...@lists.linaro.org
> Cc: de...@driverdev.osuosl.org
> Signed-off-by: Greg Kroah-Hartman 
> ---

Acked-by: Mark Greer 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: greybus: remove redundant assignment to variable is_empty

[Mark Greer]

On Thu, Jul 04, 2019 at 02:30:31PM +0100, Colin King wrote:
> From: Colin Ian King 
> 
> The variable is_empty is being initialized with a value that is never
> read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King 
> ---
>  drivers/staging/greybus/audio_manager.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager.c 
> b/drivers/staging/greybus/audio_manager.c
> index c2a4af4c1d06..9b19ea9d3fa1 100644
> --- a/drivers/staging/greybus/audio_manager.c
> +++ b/drivers/staging/greybus/audio_manager.c
> @@ -86,7 +86,7 @@ EXPORT_SYMBOL_GPL(gb_audio_manager_remove);
>  void gb_audio_manager_remove_all(void)
>  {
>   struct gb_audio_manager_module *module, *next;
> - int is_empty = 1;
> + int is_empty;
>  
>   down_write(_rwsem);

Reviewed-by: Mark Greer 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get

[Mark Greer]

On Fri, Mar 15, 2019 at 10:49:46AM +0530, Vaibhav Agarwal wrote:
> On Thu, Mar 14, 2019 at 12:15 PM Kangjie Lu  wrote:
> >
> > ida_simple_get could fail. The fix inserts a check for its
> > return value.
> >
> > Signed-off-by: Kangjie Lu 
> > ---
> >  drivers/staging/greybus/audio_manager.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/staging/greybus/audio_manager.c 
> > b/drivers/staging/greybus/audio_manager.c
> > index d44b070d8862..c2a4af4c1d06 100644
> > --- a/drivers/staging/greybus/audio_manager.c
> > +++ b/drivers/staging/greybus/audio_manager.c
> > @@ -45,6 +45,9 @@ int gb_audio_manager_add(struct 
> > gb_audio_manager_module_descriptor *desc)
> > int err;
> >
> > id = ida_simple_get(_id, 0, 0, GFP_KERNEL);
> > +   if (id < 0)
> > +   return id;
> > +
> > err = gb_audio_manager_module_create(, manager_kset,
> >  id, desc);
> > if (err) {
> 
> Reviewed-by: Vaibhav Agarwal 

I am sorry for not responding until now.  For some strange reason, email
from this list are being delayed.  I just got this today (April 30).

Thanks for the patch, Kangjie, and thanks for the review, Vaibhav.

And FWIW,

Reviewed-by: Mark Greer 

Mark
--
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: greybus: fix spelling mistake: "Inavlid" -> "Invalid"

[Mark Greer]

On Tue, May 22, 2018 at 09:33:42AM +0100, Colin King wrote:
> From: Colin Ian King <colin.k...@canonical.com>
> 
> Trivial fix to spelling mistake in dev_err error message
> 
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> ---
>  drivers/staging/greybus/audio_topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_topology.c 
> b/drivers/staging/greybus/audio_topology.c
> index de4b1b2b12f3..15e57f701630 100644
> --- a/drivers/staging/greybus/audio_topology.c
> +++ b/drivers/staging/greybus/audio_topology.c
> @@ -996,7 +996,7 @@ static int gbaudio_tplg_create_widget(struct 
> gbaudio_module_info *module,
>  
>   ret = gbaudio_validate_kcontrol_count(w);
>   if (ret) {
> - dev_err(module->dev, "Inavlid kcontrol count=%d for %s\n",
> + dev_err(module->dev, "Invalid kcontrol count=%d for %s\n",
>   w->ncontrols, w->name);
>   return ret;
>   }

Acked-by: Mark Greer <mgr...@animalcreek.com>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3] staging: greybus: Fix warning to limit chars per line

[Mark Greer]

On Fri, Apr 06, 2018 at 04:39:22PM +0530, Gaurav Dhingra wrote:
> Wrap comment to fix warning "prefer a maximum 75 chars per line"
> 
> Signed-off-by: Gaurav Dhingra <gauravdhingra.g...@gmail.com>
> ---
> Changes in v2:
> - use correct format for multiline comment
> Changes in v3:
> - include commit log
> ---
>  drivers/staging/greybus/audio_codec.h | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_codec.h 
> b/drivers/staging/greybus/audio_codec.h
> index a1d5440..4efd8b3 100644
> --- a/drivers/staging/greybus/audio_codec.h
> +++ b/drivers/staging/greybus/audio_codec.h
> @@ -23,7 +23,10 @@ enum {
>   NUM_CODEC_DAIS,
>  };
>  
> -/* device_type should be same as defined in audio.h (Android media layer) */
> +/*
> + * device_type should be same as defined in audio.h
> + * (Android media layer)
> + */
>  enum {
>   GBAUDIO_DEVICE_NONE = 0x0,
>   /* reserved bits */
> -- 
> 1.9.1

Reviewed-by: Mark Greer <mgr...@animalcreek.com>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 02/11] staging: greybus: Remove redundant license text

[Mark Greer]

On Tue, Nov 07, 2017 at 02:58:42PM +0100, Greg Kroah-Hartman wrote:
> Now that the SPDX tag is in all greybus files, that identifies the
> license in a specific and legally-defined manner.  So the extra GPL text
> wording can be removed as it is no longer needed at all.
> 
> This is done on a quest to remove the 700+ different ways that files in
> the kernel describe the GPL license text.  And there's unneeded stuff
> like the address (sometimes incorrect) for the FSF which is never
> needed.
> 
> No copyright headers or other non-license-description text was removed.
> 
> Cc: Vaibhav Hiremath <hvaibhav.li...@gmail.com>
> Cc: Johan Hovold <jo...@kernel.org>
> Cc: Alex Elder <el...@kernel.org>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Cc: Vaibhav Agarwal <vaibhav...@gmail.com>
> Cc: Mark Greer <mgr...@animalcreek.com>
> Cc: Viresh Kumar <vire...@kernel.org>
> Cc: Rui Miguel Silva <rmf...@gmail.com>
> Cc: David Lin <dtw...@gmail.com>
> Cc: "Bryan O'Donoghue" <pure.lo...@nexus-software.ie>
> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> ---

Acked-by: Mark Greer <mgr...@animalcreek.com>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files

[Mark Greer]

On Tue, Nov 07, 2017 at 02:58:41PM +0100, Greg Kroah-Hartman wrote:
> It's good to have SPDX identifiers in all files to make it easier to
> audit the kernel tree for correct licenses.
> 
> Update the drivers/staging/greybus files files with the correct SPDX
> license identifier based on the license text in the file itself.  The
> SPDX identifier is a legally binding shorthand, which can be used
> instead of the full boiler plate text.
> 
> This work is based on a script and data from Thomas Gleixner, Philippe
> Ombredanne, and Kate Stewart.
> 
> Cc: Johan Hovold <jo...@kernel.org>
> Cc: Alex Elder <el...@kernel.org>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Cc: Vaibhav Hiremath <hvaibhav.li...@gmail.com>
> Cc: Vaibhav Agarwal <vaibhav...@gmail.com>
> Cc: Mark Greer <mgr...@animalcreek.com>
> Cc: Viresh Kumar <vire...@kernel.org>
> Cc: Rui Miguel Silva <rmf...@gmail.com>
> Cc: David Lin <dtw...@gmail.com>
> Cc: "Bryan O'Donoghue" <pure.lo...@nexus-software.ie>
> Cc: Thomas Gleixner <t...@linutronix.de>
> Cc: Kate Stewart <kstew...@linuxfoundation.org>
> Cc: Philippe Ombredanne <pombreda...@nexb.com>
> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

Acked-by: Mark Greer <mgr...@animalcreek.com>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/3] greybus: audio: don't inclide rwlock.h directly.

[Mark Greer]

On Thu, Oct 05, 2017 at 02:56:54PM +0200, Sebastian Andrzej Siewior wrote:
> rwlock.h should not be included directly. Instead linux/splinlock.h
> should be included. One thing it does is to break the RT build.
> 
> Cc: Vaibhav Agarwal <vaibhav...@gmail.com>
> Cc: Mark Greer <mgr...@animalcreek.com>
> Cc: Johan Hovold <jo...@kernel.org>
> Cc: Alex Elder <el...@kernel.org>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Cc: greybus-...@lists.linaro.org
> Cc: de...@driverdev.osuosl.org
> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de>
> ---
>  drivers/staging/greybus/audio_manager.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager.c 
> b/drivers/staging/greybus/audio_manager.c
> index aa6508b44fab..045696ce85c7 100644
> --- a/drivers/staging/greybus/audio_manager.c
> +++ b/drivers/staging/greybus/audio_manager.c
> @@ -10,7 +10,7 @@
>  #include 
>  #include 
>  #include 
> -#include 
> +#include 
>  #include 
>  
>  #include "audio_manager.h"
> -- 
> 2.14.2

Thanks for the patch.

Reviewed-by: Mark Greer <mgr...@animalcreek.com>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: greybus: audio: constify snd_soc_dai_ops structures

[Mark Greer]

On Mon, Aug 21, 2017 at 10:28:24AM +0530, Arvind Yadav wrote:
> snd_soc_dai_ops are not supposed to change at runtime. All functions
> working with snd_soc_dai_ops provided by  work with
> const snd_soc_dai_ops. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
> ---
>  drivers/staging/greybus/audio_codec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_codec.c 
> b/drivers/staging/greybus/audio_codec.c
> index 25c8bb4..a6d01f0 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -674,7 +674,7 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, 
> int mute, int stream)
>   return ret;
>  }
>  
> -static struct snd_soc_dai_ops gbcodec_dai_ops = {
> +static const struct snd_soc_dai_ops gbcodec_dai_ops = {
>   .startup = gbcodec_startup,
>   .shutdown = gbcodec_shutdown,
>   .hw_params = gbcodec_hw_params,

Thanks Arvind.

Acked-by: Mark Greer <mgr...@animalcreek.com>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH -next] staging: greybus: audio_gb.c: Change uint32_t to u32

[Mark Greer]

On Sun, Jan 22, 2017 at 03:49:21PM -0200, Marcos Paulo de Souza wrote:
> Change uint32_t to u32, solved the issue reported by checkpatch.pl:
> 
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> + uint32_t *format, uint32_t *rate, u8 *channels,
> 
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> + uint32_t format, uint32_t rate, u8 channels,
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza@gmail.com>
> ---

Good catch, thanks.

Acked-by: Mark Greer <mgr...@animalcreek.com>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 0/4] Cleanup greybus audio driver

[Mark Greer]

On Wed, Jan 18, 2017 at 10:51:49PM +0530, Vaibhav Agarwal wrote:
> This patch series include following cleanup changes in GB Audio driver.
> - Avoid unnecessary checks for le32 variables
> - Initialize sig_bits before configuring hw_params
> - Remove junk codec register mapping
> - Ensure proper byte ordering
> 
> Next task is to enable build for GB codec driver. However this requires
> pushing some changes in ASoC framework. Possibly in another two weeks
> (based on my freetime), I'll try to submit those changes to ASoC mailing
> list. And once the same are accepted there, I'll share relevant patches
> for GB Audio codec driver as well.
> 
> Changes from v2:
> - patch 1/4
> - Update commit message - Mark Greer
>     - Move le32_to_cpu change to patch 4/4 - Mark Greer
> - patch 3/4
> - Remove junk codec register related definitions in .h file - Mark Greer
> - patch 4/4
> - Ensure byte order for the variable missed out in v1/v2 - Mark Greer
> 
> Changes from v1:
> - Include review comments from Dan

For all four patches:

Acked-by: Mark Greer <mgr...@animalcreek.com>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 4/4] staging: greybus: audio: Ensure proper byte order

[Mark Greer]

On Tue, Jan 17, 2017 at 08:19:30PM +0530, Vaibhav Agarwal wrote:
> From: Vaibhav Agarwal 
> 
> Proper byte order was completely disregarded for multi byte data shared
> between AP and module (and APB1). Fix this.
> 
> Signed-off-by: Vaibhav Agarwal 
> ---

Hi Vaibhav.

I think you got them all except for this one in
audio_topology.c:gbcodec_mixer_dapm_ctl_put():

>>> max = info->value.integer.max;  <<<
mask = (1 << fls(max)) - 1;
val = ucontrol->value.integer.value[0] & mask;
connect = !!val;

Mark
--
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 1/4] staging: greybus: audio: Avoid less than zero check for le32 variable

[Mark Greer]

Hi Vaibhav.

On Tue, Jan 17, 2017 at 08:19:27PM +0530, Vaibhav Agarwal wrote:
> mixer control->info call back function checks for -ve values to rebase
> min and max values. However, le32 variable is used to fetch values from
> GB module FW. Thus -ve value checking is not required. Fix this!!

nit: Please spell out "negative" so it is as easy as possible for the
 casual observer to understand what you're saying.

> Signed-off-by: Vaibhav Agarwal 
> ---
>  drivers/staging/greybus/audio_topology.c | 12 
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/greybus/audio_topology.c 
> b/drivers/staging/greybus/audio_topology.c
> index 3001a4971c06..a8b63a8b2bb0 100644
> --- a/drivers/staging/greybus/audio_topology.c
> +++ b/drivers/staging/greybus/audio_topology.c
> @@ -361,8 +361,8 @@ static int gbcodec_mixer_dapm_ctl_info(struct 
> snd_kcontrol *kcontrol,
>   info = (struct gb_audio_ctl_elem_info *)data->info;
>  
>   /* update uinfo */
> - platform_max = info->value.integer.max;
> - platform_min = info->value.integer.min;
> + platform_max = le32_to_cpu(info->value.integer.max);
> + platform_min = le32_to_cpu(info->value.integer.min);

Should this piece be in patch 4/4?  It seems out of place in this patch.

>   if (platform_max == 1 &&
>   !strnstr(kcontrol->id.name, " Volume", NAME_SIZE))
> @@ -371,12 +371,8 @@ static int gbcodec_mixer_dapm_ctl_info(struct 
> snd_kcontrol *kcontrol,
>   uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
>  
>   uinfo->count = data->vcount;
> - uinfo->value.integer.min = 0;
> - if (info->value.integer.min < 0 &&
> - (uinfo->type == SNDRV_CTL_ELEM_TYPE_INTEGER))
> - uinfo->value.integer.max = platform_max - platform_min;
> - else
> - uinfo->value.integer.max = platform_max;
> + uinfo->value.integer.min = platform_min;
> + uinfo->value.integer.max = platform_max;

This part looks good.

Thanks,

Mark
--
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 2/4] staging: greybus: audio: Initialize sig_bits before configuring hwparams

[Mark Greer]

On Tue, Jan 17, 2017 at 08:19:28PM +0530, Vaibhav Agarwal wrote:
> From: Vaibhav Agarwal <vaibhav.agar...@linaro.org>
> 
> Uninitialized variable sig_bits was used while configuring stream params
> for codec module. These params are used to configure PCM settings for
> APBridgeA.
> 
> Usually, this is dependent on codec capability and thus populated via
> codec dai_driver definition. In our case, it is fixed to 16 based on the
> data format, container supported.
> 
> Signed-off-by: Vaibhav Agarwal <vaibhav.agar...@linaro.org>
> ---

Acked-by: Mark Greer <mgr...@animalcreek.com>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 3/4] staging: greybus: audio: Cleanup junk codec registers

[Mark Greer]

On Tue, Jan 17, 2017 at 08:19:29PM +0530, Vaibhav Agarwal wrote:
> From: Vaibhav Agarwal 
> 
> Dummy codec register were initially added while populating dummy codec
> mixer controls until module topology parser was available. Now, these
> dummy registers are nowhere used and thus can be safely removed.
> 
> Since ASoC framework requires a valid callback for both read & write
> register APIS, currently empty placeholders are kept to avoid panic.
> 
> Later, register mapping logic can be defined:
> 1. Assuming fixed number of maximum modules connected and register bits
> corresponds to basic info of each module OR
> 2. With a logic to dynamically grow register_cache_size based on codec
> modules added/removed.
> 
> Signed-off-by: Vaibhav Agarwal 
> ---
>  drivers/staging/greybus/audio_codec.c | 39 
> ++-
>  1 file changed, 2 insertions(+), 37 deletions(-)
> 
> diff --git a/drivers/staging/greybus/audio_codec.c 
> b/drivers/staging/greybus/audio_codec.c
> index b9d66278ff87..30941f9e380d 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -1026,47 +1026,16 @@ static int gbcodec_remove(struct snd_soc_codec *codec)
>   return 0;
>  }
>  
> -static u8 gbcodec_reg[GBCODEC_REG_COUNT] = {
> - [GBCODEC_CTL_REG] = GBCODEC_CTL_REG_DEFAULT,
> - [GBCODEC_MUTE_REG] = GBCODEC_MUTE_REG_DEFAULT,
> - [GBCODEC_PB_LVOL_REG] = GBCODEC_PB_VOL_REG_DEFAULT,
> - [GBCODEC_PB_RVOL_REG] = GBCODEC_PB_VOL_REG_DEFAULT,
> - [GBCODEC_CAP_LVOL_REG] = GBCODEC_CAP_VOL_REG_DEFAULT,
> - [GBCODEC_CAP_RVOL_REG] = GBCODEC_CAP_VOL_REG_DEFAULT,
> - [GBCODEC_APB1_MUX_REG] = GBCODEC_APB1_MUX_REG_DEFAULT,
> - [GBCODEC_APB2_MUX_REG] = GBCODEC_APB2_MUX_REG_DEFAULT,
> -};
> -

gbcodec_reg_defaults[] and the definitions of 'GBCODEC_CTL_REG_DEFAULT',
etc. can be removed now too, can't they?

The rest looks good.

Mark
--
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel