On Thu, 2018-09-06 at 22:04 -0700, Linus Torvalds wrote:
> On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang
> wrote:
> >
> > put_device will call vme_dev_release to free vdev, kfree is
> > unnecessary here.
>
> That does seem to be the case. I think "unnecessary" is overly kind,
> it does seem to be a
et-variable]
>
> Signed-off-by: Colin Ian King
Reviewed-by: Martyn Welch
> ---
> drivers/vme/bridges/vme_ca91cx42.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/vme/bridges/vme_ca91cx42.c
> b/drivers/vme/bridges/vme_ca91cx42.c
> index 5dd
The PIO2 device is (as far as I know) no longer manufactured. I no longer
have access to the device and this seems unlikely to change. The only
changes to this driver in a long time have been as a result of API changes
else where. Time to remove it...
Signed-off-by: Martyn Welch
---
drivers
From: Martyn Welch
The VME subsystem currently returns -EBUSY when trying to free a DMA
resource that is busy, but returns -EINVAL when trying to free a DMA list
that is in use. Switch to returning -EBUSY when trying to free a DMA list
that is in use for consistency and correctness.
Signed-off
On Sat, 2017-10-14 at 14:08 +0200, Greg Kroah-Hartman wrote:
> On Fri, Oct 13, 2017 at 10:09:19PM +0100, Martyn Welch wrote:
> > The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f:
> >
> > Linux 4.14-rc4 (2017-10-08 20:53:29 -0700)
> >
&
The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f:
Linux 4.14-rc4 (2017-10-08 20:53:29 -0700)
are available in the git repository at:
https://gitlab.collabora.com/martyn/linux.git tags/vme-next-4.14-rc4
for you to fetch changes up to a75dc630086a6b83d780a7b27d03c4c
On 21 September 2017 at 06:52, Janani Sankara Babu wrote:
> This patch is created to solve the following warning shown by the checkpatch
> script Warning: Replace all occurences of (1<
> Signed-off-by: Janani Sankara Babu
> ---
> drivers/staging/vme/devices/vme_pio2.h | 6 +++---
> 1 file change
The following changes since commit 0f9b011d3321ca1079c7a46c18cb1956fbdb7bcb:
driver core: bus: Fix a potential double free (2017-08-31 18:57:30 +0200)
are available in the git repository at:
https://gitlab.collabora.com/martyn/linux.git tags/vme-next-4.13-rc7
for you to fetch changes up to
On 26 August 2017 at 08:00, SF Markus Elfring
wrote:
>>> @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const
>>> struct pci_device_id *id)
>>> master_num--;
>>>
>>> tsi148_device->flush_image =
>>> -kmalloc(sizeof(struct vme_mast
On Fri, Aug 25, 2017 at 05:41:13PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Fri, 25 Aug 2017 13:15:43 +0200
>
> Several update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (14):
> Delete 11 error messages for a failed memory a
On Fri, Aug 25, 2017 at 06:15:08PM +0200, SF Markus Elfring wrote:
> @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const
> struct pci_device_id *id)
> master_num--;
>
> tsi148_device->flush_image =
> - kmalloc(sizeof(struct
cases 'val' happens
> to be 1) rather than a "single bit" (1 << n), so keeping the value as is
> in the code makes it more readable that using a combination of BIT
> macros.
>
> Signed-off-by: Ricardo Silva
Acked-by: Martyn Welch
> ---
> drivers/s
Add kernel-doc comments to the VME driver API and structures. This
documentation will be integrated into the RST documentation in a later
patch.
Signed-off-by: Martyn Welch
---
drivers/vme/vme.c | 469
include/linux/vme.h | 12 +-
2 files
Update VME documentation given that kerneldoc comments are now provided.
Add "VME API" section to VME RST to pull in kerneldoc comments.
Signed-off-by: Martyn Welch
---
Documentation/driver-api/vme.rst | 363 ++-
1 file changed, 93 insertio
eger of different size [-Wpointer-to-int-cast]
> *pci_base = (dma_addr_t)vme_base + pci_offset;
>
> Signed-off-by: Augusto Mecking Caringi
Acked-By: Martyn Welch
> ---
> drivers/vme/bridges/vme_ca91cx42.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> dif
The vme_driver structure currently has a "node" entry. This entry is
never used and it's intended purpose has been lost to the mists of time.
Remove the entry from vme_driver to avoid confusion.
Signed-off-by: Martyn Welch
---
include/linux/vme.h | 1 -
1 file changed, 1 de
and no
in-tree drivers use it (hardly surprising, given it'd never be called).
Remove the entry from vme_driver to avoid confusion.
Signed-off-by: Martyn Welch
---
include/linux/vme.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/vme.h b/include/linux/vme.h
index ea6095d..
On Sun, Nov 13, 2016 at 08:28:34PM -0500, Walt Feasel wrote:
> Make spelling corrections for 'correctly' and
> 'unregister'.
>
> Signed-off-by: Walt Feasel
Acked-by: Martyn Welch
> ---
>
> Removed the previously submitted U.S. spelling for
> &#
From: Martyn Welch
Perform a relatively simple conversion of vme_api.txt to reStructuredText
and move under driver-api, which seems the most logical place for this
documentation.
Signed-off-by: Martyn Welch
---
Documentation/driver-api/index.rst| 1 +
Documentation
The function vme_get_size returns the size of the window to the caller,
however it doesn't check the return value of the call to vme_master_get.
Return 0 on failure rather than anything else.
Suggested-by: Dan Carpenter
Signed-off-by: Martyn Welch
---
drivers/vme/vme.c | 4
1
On Fri, Sep 30, 2016 at 02:37:01PM +0300, Dan Carpenter wrote:
> Hello Martyn Welch,
>
> The patch 658bcdae9c67: "vme: Adding Fake VME driver" from Jul 7,
> 2016, leads to the following static checker warning:
>
> drivers/vme/bridges/vme_fake.c:338 fa
x27;fake_vmewrite32' [-Wmissing-prototypes]
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xi
On Fri, Sep 09, 2016 at 02:41:43PM -0500, Aaron Sierra wrote:
> - Original Message -
> > From: "Martyn Welch"
> > To: "Aaron Sierra"
> > Cc: "Manohar Vanga" , "Greg Kroah-Hartman"
> > , "devel"
> > , &quo
On Fri, Sep 02, 2016 at 04:17:01PM -0500, Aaron Sierra wrote:
> Some bridges support a minimum slave window larger than this driver's
> 128 KB default buffer size. Also bridges typically require the PCI and
> VME bases to be aligned to the size of the window.
>
Which bridge has a minimum slave wi
On Fri, Sep 02, 2016 at 03:59:45PM -0500, Aaron Sierra wrote:
> The driver's bus_num parameter is used to select a VME bus during probe.
> This parameter is used both as a boolean to indicate that probing should
> occur as well as which bus should be probed. However, the first bus in
> the system i
On Fri, Sep 02, 2016 at 04:16:55PM -0500, Aaron Sierra wrote:
> Assign a pointer to the image descriptor once at the beginning of
> the ioctl to help keep code concise.
>
Same with this patch. I'm not sure what's gained by doing this.
> Signed-off-by: Aaron Sierra
> ---
> drivers/staging/vme/d
On Fri, Sep 02, 2016 at 04:16:48PM -0500, Aaron Sierra wrote:
> Update each case to set retval and return that value at the end of the
> function. This also replaces most case statement returns with breaks
> and collapses some whitespace.
>
Sorry if I'm being dense, but is there an advantage to d
make this clearer while fixing the warning, I'm adding
> a set of helper functions for the type conversion.
>
> Signed-off-by: Arnd Bergmann
Acked-by: Martyn Welch
> ---
> drivers/vme/bridges/vme_fake.c | 26 ++
> 1 file changed, 18 insertions(+),
est robot wrote:
Hi,
[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on v4.7-rc6 next-20160707]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Martyn-Welch/vme-
This patch introduces a fake VME bridge driver. This driver currently
emulates a subset of the VME bridge functionality. This allows some VME
subsystem development and even some VME device driver development to be
carried out in the absence of a proper VME bus.
Signed-off-by: Martyn Welch
On 14/06/16 15:36, Alessio Igor Bogani wrote:
These drivers have a PCI device ID table but the PCI module
alias information is not created so module autoloading won't work.
Signed-off-by: Alessio Igor Bogani
Acked-by: Martyn Welch
---
drivers/vme/bridges/vme_ca91cx42.c | 2 ++
dr
, we don't
have any ".suppress_bind_attrs" to be concerned about when we
drop the ".remove" code from this file.
Since module_init was not in use by this code, the init ordering
remains unchanged with this commit.
Cc: Martyn Welch
Cc: Manohar Vanga
Cc: Greg Kroah-Hart
, but the CA91Cx42 changes
have only been compiled.
Signed-off-by: Aaron Sierra
Sorry for the long delay - I've only just found time to write the test
module I wanted to validate this.
Acked-by: Martyn Welch
---
v2 - change new argument name from cookie to data
- add data clean
The vme_register_driver() api changed in commit 5d6abf379d73 ("staging:
vme: make match() driver specific to improve non-VME64x support") but the
documentation wasn't updated. Update the documentation to match the API.
Signed-off-by: Martyn Welch
---
Documentation/vme_api.txt |
Sorry it's taken me so long to get to this, I've wanted to write some
test code to
prove this out to myself and I've been struggling to find the time.
On 29/04/16 22:41, Aaron Sierra wrote:
diff --git a/Documentation/vme_api.txt b/Documentation/vme_api.txt
index ca5b827..4ca63a6 100644
---
On 14/04/16 10:42, Dan Carpenter wrote:
Hello Martyn Welch,
The patch a17a75e2666f: "Staging: VME Framework for the Linux Kernel"
from Jul 31, 2009, leads to the following static checker warning:
drivers/vme/vme.c:161 vme_get_size()
error: uninitialized vari
this:
bridge = vme_init_bridge(&priv->bridge);
Signed-off-by: Aaron Sierra
Acked-by: Martyn Welch
---
drivers/vme/bridges/vme_ca91cx42.c | 9 +
drivers/vme/bridges/vme_tsi148.c | 9 +
drivers/vme/vme.c | 14 ++
driv
Hi Aaron,
On 24/04/16 00:03, Aaron Sierra wrote:
Make the location monitor callback function prototype more useful by
changing the argument from an integer to a void pointer.
All VME bridge drivers were simply passing the location monitor index
(e.g. 0-3) as the argument to these callbacks. It
On 21/04/16 17:18, Aaron Sierra wrote:
Fix a typo in the spurious interrupt warning and consistently capitalize
VME, PCI, and DMA acronyms.
Signed-off-by: Aaron Sierra
Acked-by: Martyn Welch
---
drivers/vme/vme.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
On 31/03/16 23:53, Clifton Barnes wrote:
fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of
'unsigned''
Signed-off-by: Clifton Barnes
Acked-by: Martyn Welch
Greg: Whilst this patch seems valid and compiles fine, I no longer have
access t
This patch introduces a fake VME bridge driver. This driver currently
emulates a subset of the VME bridge functionality. This allows some VME
subsystem development and even some VME device driver development to be
carried out in the absence of a proper VME bus.
Signed-off-by: Martyn Welch
On 27/12/15 10:46, Geliang Tang wrote:
Use to_pci_dev() instead of open-coding it.
Signed-off-by: Geliang Tang
Acked-by: Martyn Welch
---
drivers/vme/bridges/vme_ca91cx42.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/vme/bridges/vme_ca91cx42
On 14/12/15 14:14, Linus Walleij wrote:
On Fri, Dec 11, 2015 at 7:58 AM, Martyn Welch wrote:
On 09/12/15 13:50, Linus Walleij wrote:
This makes the driver use the data pointer added to the gpio_chip
to store a pointer to the state container instead of relying on
container_of().
Cc: Greg
On 09/12/15 13:50, Linus Walleij wrote:
This makes the driver use the data pointer added to the gpio_chip
to store a pointer to the state container instead of relying on
container_of().
Cc: Greg Kroah-Hartman
Cc: Martyn Welch
Cc: Manohar Vanga
Cc: de...@driverdev.osuosl.org
Signed-off-by
On 18/10/15 18:53, Dmitry Kalinkin wrote:
On Sun, Oct 18, 2015 at 10:31 AM, Martyn Welch wrote:
On 11/10/15 01:13, Dmitry Kalinkin wrote:
This introduces a new dma device that provides a single ioctl call that
provides DMA read and write functionality to the user space.
Signed-off-by
On 18/10/15 18:07, Dmitry Kalinkin wrote:
On Sun, Oct 18, 2015 at 9:30 AM, Martyn Welch wrote:
On 10 October 2015 at 23:00, Dmitry Kalinkin wrote:
Fixes an off by one array size.
The Status/ID is an 8-bit value (OK, the standard states it can be a
8, 16 or 32-bit value, however both of
On 11/10/15 01:13, Dmitry Kalinkin wrote:
This introduces a new dma device that provides a single ioctl call that
provides DMA read and write functionality to the user space.
Signed-off-by: Dmitry Kalinkin
Cc: Igor Alekseev
---
On 10 October 2015 at 23:00, Dmitry Kalinkin wrote:
> Fixes an off by one array size.
>
The Status/ID is an 8-bit value (OK, the standard states it can be a
8, 16 or 32-bit value, however both of the chipsets we support at this
point in time support an 8-bit value), why do we need a 256th entry i
On 5 October 2015 at 04:59, Dmitry Kalinkin wrote:
> The warning is a false positive.
>
That seems very likely.
Please could you role this into the original patch (vme: change bus
error handling scheme)?
Martyn
> drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_write':
> drivers/vm
On 18/09/15 00:01, dmitry.kalin...@gmail.com wrote:
From: Dmitry Kalinkin
This will enable error messages for accesses done through mmap.
Signed-off-by: Dmitry Kalinkin
Acked-by: Martyn Welch
---
drivers/vme/vme.c |7 +++
1 file changed, 7 insertions(+)
diff --git a
On 18/09/15 00:01, dmitry.kalin...@gmail.com wrote:
From: Dmitry Kalinkin
The current VME bus error handler adds errors to the bridge error list.
vme_master_{read,write} then traverses that list to look for relevant
errors.
Such scheme didn't work well for accesses going through vme_master_m
On 18/09/15 00:01, dmitry.kalin...@gmail.com wrote:
From: Dmitry Kalinkin
Also changes vme_bus_error_handler to take generic address modifier code
instead of raw contents of a device-specific attribute register.
Signed-off-by: Dmitry Kalinkin
Cc: Igor Alekseev
Acked-by: Martyn Welch
introduces a slight behavior change: vme error message won't be
triggered in a rare case when err_chk=1 and kmalloc fails.
Signed-off-by: Dmitry Kalinkin
Cc: Igor Alekseev
Acked-by: Martyn Welch
---
drivers/vme/bridges/vme_tsi148.c | 93 +++---
driver
I have recently left GE and the email address listed for me in the
maintainers file is no longer valid. Updating email address.
Signed-off-by: Martyn Welch
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7ba7ab7..a77fe5b 100644
l character) */
diff --git a/include/linux/vme.h b/include/linux/vme.h
index c013135..71e4a6d 100644
--- a/include/linux/vme.h
+++ b/include/linux/vme.h
@@ -81,6 +81,9 @@ struct vme_resource {
extern struct bus_type vme_bus_type;
+/* Number of VME interrupt vectors */
+#define VME_NUM_STATUSID
On 08/07/15 16:02, Dmitry Kalinkin wrote:
On 08 Jul 2015, at 16:22, Martyn Welch wrote:
On 06/07/15 18:24, Dmitry Kalinkin wrote:
Some functionality was dropped as it was not good practice
(such as receiving VME interrupts in user space, it's not really doable if
the slave ca
re
dynamically allocated at the time at which an interrupt came in.
Martyn
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E mart
sues with filling available PCI address space.
Admittedly this is more of a problem on 32-bit systems, but...
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748
n top of the existing API. Does that seem workable to you?
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E martyn.we...@g
user and is allocated a window, if vme_user demands 8 windows
(and assuming it doesn't deal with some already having been allocated
gracefully, which it doesn't at the moment) then it doesn't load.
Dynamic allocation would leave "unused" resources available rather than
pro
"Unhandled VME access error at address 0x%llx\n",
+ address);
}
EXPORT_SYMBOL(vme_bus_error_handler);
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642)
On 06/07/15 14:50, Dmitry Kalinkin wrote:
On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch wrote:
Sorry about the *really* late reply, loads of emails some how missed my
periodic search of the mailing list.
I'm happy with the addition of DMA, just not sure whether it's worth addin
lication not just use the control device?
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E martyn.we...@ge.com
On 06/07/15 14:10, Dmitry Kalinkin wrote:
On Mon, Jul 6, 2015 at 3:51 PM, Martyn Welch wrote:
On 26/06/15 21:39, Dmitry Kalinkin wrote:
Signed-off-by: Dmitry Kalinkin
---
drivers/staging/vme/devices/vme_user.c | 47
--
1 file changed, 11 insertions
files changed, 147 insertions(+), 130 deletions(-)
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E martyn.we...@g
ser_read(struct file *file, char __user *buf, size_t
count,
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748 | Manchester, M2 3AB
E martyn.we..
On 25/06/15 13:05, Dmitry Kalinkin wrote:
This is why I think this is not a “we broke userspace” situation.
The vme_user module is also in the staging tree and (almost) by
definition the API shouldn't be considered as stable.
Martyn
--
Martyn Welch (Lead Software Engineer) | Regis
7,7 @@ ssize_t vme_master_read(struct vme_resource *, void *,
size_t, loff_t);
ssize_t vme_master_write(struct vme_resource *, void *, size_t, loff_t);
unsigned int vme_master_rmw(struct vme_resource *, unsigned int, unsigned int,
unsigned int, loff_t);
+int vme_master_mmap(stru
Without knowing much more
about your system (and I don't think you've even told me what SBC you
are using) there's a limit to how much I can help I'm afraid.
Hope that helps,
Martyn
On Wed, Jul 16, 2014 at 12:47 AM, Martyn Welch wrote:
On 14/07/14 19:29, Maurice Moss w
On 23/07/14 17:17, Tom Jorquera wrote:
vme_user.c contained unnecessary breaks after gotos, which increased
code size and caused code style warning. This is now fixed.
Signed-off-by: Tom Jorquera
Acked-by: Martyn Welch
---
drivers/staging/vme/devices/vme_user.c | 4
1 file changed
On 18/07/14 16:33, Masanari Iida wrote:
This patch add missing CR in messages within vme_pio2_core.c
Signed-off-by: Masanari Iida
Acked-by: Martyn Welch
---
drivers/staging/vme/devices/vme_pio2_core.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a
On 18/07/14 16:33, Masanari Iida wrote:
This patch fix spelling typo in printk message.
Signed-off-by: Masanari Iida
Acked-by: Martyn Welch
---
drivers/staging/vme/devices/vme_pio2_gpio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vme
On 18/07/14 16:33, Masanari Iida wrote:
This patch adds missing CR in dev_err message.
Signed-off-by: Masanari Iida
Acked-by: Martyn Welch
---
drivers/staging/vme/devices/vme_pio2_gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vme/devices
ne: BOOT_IMAGE=/vmlinuz-3.14.9
root=UUID=aee6e594-4be8-46d4-abe6-7c054ef239b0 ro
vconsole.font=latarcyrheb-sun16 vme_user.bus=0vme_tsi148.err_chk=1
rhgb quiet
Unless this is a copy and paste issue, you seem to be missing a space
between "vme_user.bus=0" and "vme_tsi148.err_chk
=UUID=aee6e594-4be8-46d4-abe6-7c054ef239b0 ro
vconsole.font=latarcyrheb-sun16 vme_user.bus=0vme_tsi148.err_chk=1
rhgb quiet
Unless this is a copy and paste issue, you seem to be missing a space
between "vme_user.bus=0" and "vme_tsi148.err_chk=1".
Martyn
--
Martyn Welc
hat sounds right.
Martyn
Cheers!
On Wed, Jun 11, 2014 at 10:36 AM, Martyn Welch wrote:
Hi Maurice,
On 04/06/14 22:43, Maurice Moss wrote:
Dear All,
I came across the link here and decided to write to you, as I am
facing a very similar problem:
http://driverdev.linuxdriverproject.org/pi
A24 (1<<16)
#define CA91CX42_LM_CTL_AS_A32(1<<17)
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)1327322748
On 16/06/14 10:56, Dan Carpenter wrote:
On Mon, Jun 16, 2014 at 10:47:25AM +0100, Martyn Welch wrote:
Nick,
Sorry for the delay in responding.
I'm staring at the manual for the ca91c142 and the relevant bits in
the VSIx_CTL registers definitely need to be set to 0 for A16,
likewise wit
1024 (7<<0)/* 1024 us */
+#define TSI148_LCSR_VCTRL_GTO_2048 (8<<0)/* 2048 us (default) */
+#define TSI148_LCSR_VCTRL_GTO_DIS (0xf<<0) /* Disabled */
/*
* VMEbus Status Register CRG + $23C
--
Martyn Welch (Lead Software Engineer)
s actually
happening on the bus?
Thanks for reading this far, and any help is sincerely appreciated!
Hope that helps,
Martyn
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (3828642) at 100 Barbirolli Square
T +44(0)13273227
memcpy_fromio() functions do not provide sufficient control, so instead loop
using ioread functions.
Reported-by: Michael Kenney
Signed-off-by: Martyn Welch
---
drivers/vme/bridges/vme_ca91cx42.c | 29 ++---
drivers/vme/bridges/vme_tsi148.c | 18 +-
2
On 12/02/14 16:43, Greg Kroah-Hartman wrote:
On Wed, Feb 12, 2014 at 01:20:33PM +, Martyn Welch wrote:
Hmm, can't see this patch on the mailing list, though get send-mail cc'ed me
and I got it that way. As you've added a later patch that I wrote and not
this one, can I
Hmm, can't see this patch on the mailing list, though get send-mail
cc'ed me and I got it that way. As you've added a later patch that I
wrote and not this one, can I assume that you didn't get it either Greg?
(This one is needed as well)
Martyn
On 06/02/14 13:35, Mart
On 05/02/14 23:21, Michael Kenney wrote:
On Wed, Feb 5, 2014 at 1:38 PM, Michael Kenney wrote:
On Wed, Feb 5, 2014 at 1:22 PM, Martyn Welch wrote:
On 5 February 2014 17:41, Greg KH wrote:
On Tue, Feb 04, 2014 at 06:34:13PM +, Martyn Welch wrote:
On 04/02/14 16:34, Michael Kenney
On 04/02/14 16:34, Michael Kenney wrote:
Hi Martyn,
On Tue, Feb 4, 2014 at 7:28 AM, Martyn Welch mailto:martyn.we...@ge.com>> wrote:
On 28/12/13 00:34, Michael Kenney wrote:
Hi Martyn,
On Fri, Dec 27, 2013 at 4:23 PM, Martyn Welch
mailto:mar...@welchs
On 28/12/13 00:34, Michael Kenney wrote:
Hi Martyn,
On Fri, Dec 27, 2013 at 4:23 PM, Martyn Welch wrote:
On 27/12/13 20:15, Michael Kenney wrote:
We are using the vme_tsi148 bridge driver along with the vme_user
driver to access the VME boards. The A/D board requires D32 bus cycles
and the
24 and D32.
>
> Does the "attributes" value from the tsi148 provide any further clues?
>
Not really - it gives the status of some of the VME lines when the error
occurred (Address lines, data strobes), it says that there was an error, in
one case it shows an exception ov
On 07/01/14 16:14, Michael Kenney wrote:
> Hi Martyn,
>
> On Fri, Dec 27, 2013 at 4:34 PM, Michael Kenney wrote:
>>
>> Hi Martyn,
>>
>> On Fri, Dec 27, 2013 at 4:23 PM, Martyn Welch wrote:
>>> On 27/12/13 20:15, Michael Kenney wrote:
>>>>
On 27/12/13 20:15, Michael Kenney wrote:
We are using the vme_tsi148 bridge driver along with the vme_user
driver to access the VME boards. The A/D board requires D32 bus cycles
and the VME master window is configured accordingly, however, when
monitoring the bus cycles with a logic analyzer, we
disagree and prevent ioctls from executing (based on ioctl
> signatures from _IOR and _IOW).
>
> Signed-off-by: Aaron Sierra
If Greg's happy with this (he'd suggested re-arranging to avoid the need for
packing):
Acked-by: Martyn Welch
> ---
> drivers/staging/vme/devices/vm
nclude your Signed-off-by
> since you suggested the code change, unless you have an argument against
> me doing so.
>
No problem here.
Martyn
> -Aaron
>
--
Martyn Welch (Lead Software Engineer) | Registered in England and Wales
GE Intelligent Platforms | (38286
ned-off-by: Martyn Welch
---
Documentation/vme_api.txt |2 +-
drivers/staging/vme/devices/vme_user.c |2 +-
drivers/vme/vme.c |6 +++---
include/linux/vme.h|2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Doc
My appologies - the script I had to send patches had got a bit broken and I'd
completely forgotten...
Martyn
On 08/11/13 11:55, y wrote:
> From: Martyn Welch
>
> The match function for vme_user is completely wrong. It will blindly bind
> against the first VME slot on each b
ned-off-by: Martyn Welch
---
Documentation/vme_api.txt |2 +-
drivers/staging/vme/devices/vme_user.c |2 +-
drivers/vme/vme.c |6 +++---
include/linux/vme.h|2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Doc
the slot to which the bridge was attached in the VME
system and to the bus(es) provided via the "bus" module parameter.
To do this cleanly (i.e. without poking arround in the subsystems internal
stuctures) a functionality has been added to provide access to the bus
enumeration.
Signed-off-
On 07/11/13 15:25, Aaron Sierra wrote:
>> From: "Martyn Welch"
>>> This patch removes the bus parameter since its primary function in
>>> practice is to prevent the driver from registering itself with the VME
>>> subsystem entirely unless some (any) val
On 05/11/13 20:58, Aaron Sierra wrote:
> - Original Message -
>> From: "Martyn Welch"
>> Subject: Re: [PATCH 1/3] vme_user: Ensure driver compiles after VME bridges
>>
>> On 05/11/13 17:53, Aaron Sierra wrote:
>>> Martyn,
>>> Can yo
return retval;
>
> err_reg:
> -err_nocard:
> return retval;
> }
>
> @@ -885,10 +866,6 @@ static void __exit vme_user_exit(void)
> vme_unregister_driver(&vme_user_driver);
> }
>
> -
> -MODULE_PARM_DESC(bus, "Enumeration of VMEbus to wh
diff --git a/drivers/vme/Makefile b/drivers/vme/Makefile
>>> index d7bfcb9..7a784ab 100644
>>> --- a/drivers/vme/Makefile
>>> +++ b/drivers/vme/Makefile
>>> @@ -5,3 +5,4 @@ obj-$(CONFIG_VME_BUS) += vme.o
>>>
>>> obj-y
cle; /* Cycle properties */
> +struct __attribute__((__packed__)) vme_slave {
> + u32 enable; /* State of Window */
> + u64 vme_addr; /* Starting Address on the VMEbus */
> + u64 size; /* Window Size */
> + u32 aspace; /* Address Spac
1 - 100 of 101 matches
Mail list logo
