Re: [PATCH 4/4] staging: comedi: Use subdir-ccflags-* to inherit debug flag

CONFIG_COMEDI_DEBUG intends to give the DEBUG flag to all source files under drivers/staging/comedi/. -- Best Regards Masahiro Yamada ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging: most: remove header include path to drivers/staging

There is no need to add "ccflags-y += -I $(srctree)/drivers/staging" just for including . Use the #include "..." directive with the correct relative path. Signed-off-by: Masahiro Yamada --- Changes in v2: - rebase on linux-next drivers/staging/most/Makefile | 1 -

[PATCH v2] staging: vc04_services: remove header include path to vc04_services

Fix up some relative paths in #include "..." directives, and remove the include path to drivers/staging/vc04_services. Signed-off-by: Masahiro Yamada --- Changes in v2: - fix up some relative paths. I tested with/without O= option this time. drivers/staging/vc04_service

Re: [PATCH] staging: vc04_service: remove unused header include path

On Fri, Jan 10, 2020 at 9:24 PM Greg Kroah-Hartman wrote: > > On Sun, Jan 05, 2020 at 01:28:29AM +0900, Masahiro Yamada wrote: > > I can build drivers/staging/vc04_services without this. > > > > Signed-off-by: Masahiro Yamada > > --- > > > > drivers/st

[PATCH] staging: rts5208: remove unneeded header include path

A header include path without $(srctree)/ is suspicous because it does not work with O= builds. I can build drivers/staging/rts5208/ without this include path. Signed-off-by: Masahiro Yamada --- drivers/staging/rts5208/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers

[PATCH] staging: vc04_service: remove unused header include path

I can build drivers/staging/vc04_services without this. Signed-off-by: Masahiro Yamada --- drivers/staging/vc04_services/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/Makefile b/drivers/staging/vc04_services/Makefile index

[PATCH 3/3] staging: rtl8192u: remove unneeded compiler flags

-std=gnu89 is specified by the top Makefile. Adding it in a driver Makefile is redundant. A driver should avoid specifying the optimization flag. -O2, -O3, or -Os is passed by the top Makefile based on the CONFIG_CC_OPTIMIZE_FOR_* option. Signed-off-by: Masahiro Yamada --- drivers/staging

[PATCH 1/3] staging: rtl8192u: remove unused Makefile

drivers/staging/rtl8192u/ieee80211/Makefile is not used at all. All the build rules are described in drivers/staging/rtl8192u/Makefile. Signed-off-by: Masahiro Yamada --- drivers/staging/rtl8192u/ieee80211/Makefile | 27 - 1 file changed, 27 deletions(-) delete mode 100644

[PATCH 2/3] staging: rtl8192u: remove header include path to ieee80211/

There is no need to add "ccflags-y += -I $(srctree)/$(src)/ieee80211" just for including "dot11d.h". Use the correct relative path for the #include "..." directive. Signed-off-by: Masahiro Yamada --- drivers/staging/rtl8192u/Makefile | 1 - drivers/stag

[PATCH] staging: most: remove header include path to drivers/staging

There is no need to add "ccflags-y += -I $(srctree)/drivers/staging" just for including . Use the #include "..." directive with the correct relative path. Signed-off-by: Masahiro Yamada --- drivers/staging/most/Makefile | 1 - drivers/staging/most/cdev/Makefile |

[PATCH] staging: erofs: drop unneeded -Wall addition

The top level Makefile adds -Wall globally: KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \ I see two "-Wall" added for compiling objects in drivers/staging/erofs/. Signed-off-by: Masahiro Yamada --- drivers/staging/erofs/Makefile | 2 +- 1 file

[PATCH] staging: prefix header search paths with $(srctree)/

consistent, and finally get rid of the gross hacks. Having whitespaces after -I does not matter since commit 48f6e3cf5bc6 ("kbuild: do not drop -I without parameter"). [1]: https://patchwork.kernel.org/patch/9632347/ Signed-off-by: Masahiro Yamada --- drivers/staging/erof

Re: [PATCH 05/11] Staging: rtl8192e: kconfig: Remove blank help text

ed > right away). > > Best to remove them, IMO. > > Signed-off-by: Ulf Magnusson <ulfali...@gmail.com> > --- FYI. I picked up this patch to kbuild because I need this to suppress warning messages introduced by 11/11. I am planning to send a PR for this series next wee

Re: [PATCH 04/11] Staging: rtl8192u: kconfig: Remove blank help text

2018-01-31 18:34 GMT+09:00 Ulf Magnusson : > Blank help texts are probably either a typo, a Kconfig misunderstanding, > or some kind of half-committing to adding a help text (in which case a > TODO comment would be clearer, if the help text really can't be added > right away).

Re: [PATCH 1/2] kconfig: use bool instead of boolean for type definition attributes, again

2017-12-16 0:38 GMT+09:00 Masahiro Yamada <yamada.masah...@socionext.com>: > Commit 6341e62b212a ("kconfig: use bool instead of boolean for type > definition attributes") did treewide replacement of 'boolean', and > also mentioned the keyword 'boolean' would be dropped

[PATCH 1/2] kconfig: use bool instead of boolean for type definition attributes, again

ve come up. I am really going to drop this keyword. I need to do the replacement once again. Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> --- drivers/firmware/efi/Kconfig| 2 +- drivers/staging/rtlwifi/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletion

Re: [PATCH 3/5] mtd: nand: force drivers to explicitly send READ/PROG commands

and/atmel/nand-controller.c | 7 ++- > drivers/mtd/nand/bf5xx_nand.c | 6 +- > drivers/mtd/nand/brcmnand/brcmnand.c | 13 +++- > drivers/mtd/nand/cafe_nand.c | 6 +- > drivers/mtd/nand/denali.c | 1 - For denali.c Acked-by: Ma

Re: [PATCH 2/5] mtd: nand: provide several helpers to do common NAND operations

mnand/brcmnand.c |9 +- > drivers/mtd/nand/cafe_nand.c | 14 +- > drivers/mtd/nand/denali.c| 37 +- For denali.c Acked-by: Masahiro Yamada <yamada.masah...@socionext.com> -- Best Regards Masahiro Yamada ___ de

Re: [PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook

E_FAILED; >> >> You forgot to patch single_erase() accordingly. > > Right, sorry about that, I will fix that. > Assuming single_erase() will be fixed, For denali.c Acked-by: Masahiro Yamada <yamada.masah...@socionext.com> -- Best Regards Masahiro Yamada ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()

2016-11-10 22:35 GMT+09:00 Greg Kroah-Hartman <gre...@linuxfoundation.org>: > On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote: >> >> sdhci_alloc_host() returns an error pointer when it fails. >> but mmc_alloc_host() cannot. >> >> This series

[PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()

sdhci_alloc_host() returns an error pointer when it fails. but mmc_alloc_host() cannot. This series allow to propagate a proper error code when host-allocation fails. Masahiro Yamada (2): mmc: allow mmc_alloc_host() to return proper error code mmc: tmio: allow tmio_mmc_host_alloc

[PATCH 1/2] mmc: allow mmc_alloc_host() to return proper error code

callers. Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> --- drivers/mmc/core/host.c | 11 ++- drivers/mmc/host/android-goldfish.c | 4 ++-- drivers/mmc/host/atmel-mci.c| 4 ++-- drivers/mmc/host/au1xmmc.c | 4 ++-- drivers/mmc/host/bfin