[PATCH] staging: sm750fb: replace roundedDiv with DIV_ROUND_CLOSEST

Replace local implementation of rounded division (roundedDiv macro) with the in-kernel implementation (DIV_ROUND_CLOSEST macro) in ddk750_chip.c Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 6 ++ 1 file changed, 2 insertions(+), 4 del

Re: [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c

On Sun, Oct 02, 2016 at 11:47:47AM +0200, Greg KH wrote: > On Sun, Oct 02, 2016 at 08:48:32AM +0300, Moshe Green wrote: > > Rename CamelCased macro roundedDiv to rounded_div. > > > > This issue was found by checkpatch.pl > > > > Signed-off-by

[PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c

Rename CamelCased macro roundedDiv to rounded_div. This issue was found by checkpatch.pl Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chi

[PATCH] staging: sm750fb: rename getChipType to sm750_get_chip_type

Rename CamelCased function getChipType to sm750_get_chip_type (prefex with sm750 in order to make the context of the function clear). This issue was found by checkpatch.pl Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 16 d

Re: [PATCH] staging: sm750fb: rename getChipType to get_chip_type

On Fri, Sep 23, 2016 at 02:13:52PM +0200, Greg KH wrote: > On Thu, Sep 22, 2016 at 09:15:45PM +0300, Moshe Green wrote: > > Rename CamelCased function getChipType to get_chip_type. > > This issue was found by checkpatch.pl > > As this is a global function, can you rename

[PATCH] staging: sm750fb: rename getChipType to get_chip_type

Rename CamelCased function getChipType to get_chip_type. This issue was found by checkpatch.pl Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 16 drivers/staging/sm750fb/ddk750_chip.h | 2 +- drivers/staging/sm750fb/ddk750_

[PATCH 2/2] staging: sm750fb: fix block comment style and spelling issues in ddk750_chip.c

Fix the following warning types: - line length - block comment line * prefix - trailing */ on a separate line found by the checkpatch.pl tool in multiple block comments. Fix a single spelling error in a comment. Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/s

[PATCH 1/2] staging: sm750fb: fix line length coding style issues in ddk750_chip.c

Fix multiple line length warnings found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/staging/s

Re: [PATCH 2/2] staging: sm750fb: fix block comment style and spelling issues in ddk750_chip.c

On Mon, Sep 12, 2016 at 01:17:25PM +0200, Greg KH wrote: > On Sun, Sep 04, 2016 at 09:04:10PM +0300, Moshe Green wrote: > > Fix the following warning types: > > - line length > > - block comment line * prefix > > - trailing */ on a separate line > > found by t

Re: [PATCH 1/2] staging: sm750fb: fix line length coding style issues in ddk750_chip.c

On Mon, Sep 12, 2016 at 01:16:35PM +0200, Greg KH wrote: > On Sun, Sep 04, 2016 at 09:03:27PM +0300, Moshe Green wrote: > > Fix multiple line length warnings found by the checkpatch.pl tool > > in ddk750_chip.c. > > > > Signed-off-by: Moshe Green <mgmos...@gmail.com

[PATCH 2/2] staging: sm750fb: fix block comment style and spelling issues in ddk750_chip.c

Fix the following warning types: - line length - block comment line * prefix - trailing */ on a separate line found by the checkpatch.pl tool in multiple block comments. Fix a single spelling error in a comment. Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/s

[PATCH 1/2] staging: sm750fb: fix line length coding style issues in ddk750_chip.c

Fix multiple line length warnings found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/s

Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

lude quotations after my reply? > > > http://daringfireball.net/2007/07/on_top > > On Fri, Sep 02, 2016 at 11:28:51AM +0300, moshe green wrote: > > There were (mostly) two kinds of warnings that I've handled, "80 > > character line length" and block comments str

Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

at a time? Or should I fix both warnings in the same commit - and place the commit in the most appropriate patch? thanks Moshe Green On 1 September 2016 at 19:04, Greg KH <gre...@linuxfoundation.org> wrote: > On Tue, Aug 30, 2016 at 10:04:02PM +0300, Moshe Green wrote: >> Fix a

Re: [PATCH 7/9] staging: sm750fb: fix block comment style issues in ddk750_chip.c

Will do. Thanks On 30 August 2016 at 22:19, Joe Perches <j...@perches.com> wrote: > On Tue, 2016-08-30 at 22:05 +0300, Moshe Green wrote: >> Fix block comment * prefix and trailing */ warnings found >> by the checkpatch.pl tool in ddk750_chip.c. > [] >> diff -

[PATCH 9/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

Fix a line length warning found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/s

[PATCH 8/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

Fix a line length warning found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/s

[PATCH 7/9] staging: sm750fb: fix block comment style issues in ddk750_chip.c

Fix block comment * prefix and trailing */ warnings found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/s

[PATCH 6/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

Fix a line length warning found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/s

[PATCH 4/9] staging: sm750fb: fix coding style issues in ddk750_chip.c

Fix line length and block comment * prefix warnings found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/s

[PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

Fix a line length warning found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/s

[PATCH 3/9] staging: sm750fb: fix coding style issues in ddk750_chip.c

Fix line length and block comment * prefix warnings found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/s

[PATCH 2/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

Fix a line length warning found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/s

[PATCH] Staging: sm750fb: fix block comment coding style issue in ddk750_chip.c

This is a patch to the ddk750_chip.c file that fixes up two block comment coding style warnings found by the checkpatch.pl tool Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH] Staging: sm750fb: fix line length coding style issue in ddk750_chip.c

This is a patch to the ddk750_chip.c file that fixes up a line length warning found by the checkpatch.pl tool Signed-off-by: Moshe Green <mgmos...@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/s