Re: [PATCH] staging: media: omap4iss: code style - avoid macro argument precedence issues

2021-02-21 Thread Nikolay K.
Hi Laurent, Thank you for the review. I think that if we drop the unneeded parentheses here, we need to drop them everywhere in the file for consistency, even in places checkpatch.pl doesn't warn about. It'll increase patch size without actual usefullness gain, as for me. I am very (very) novice

Re: [PATCH 2/2] staging: media: ipu3: code style fix - missing a blank line after declarations

2021-02-21 Thread Nikolay K.
I can't find any change in struct imgu_fw_info layout after this patch. But warning is strange, because declarations don't actually end here. So I think this warning should be suppressed to reduce noise in checkpatch.pl output. ___ devel mailing list