Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

2018-02-12 Thread Philippe Ombredanne
On Mon, Feb 12, 2018 at 3:37 PM, Himanshu Jha <himanshujha199...@gmail.com> wrote: > On Mon, Feb 12, 2018 at 03:10:56PM +0100, Philippe Ombredanne wrote: >> On Mon, Feb 12, 2018 at 12:54 PM, Himanshu Jha >> <himanshujha199...@gmail.com> wrote: >> > Move

Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

2018-02-12 Thread Philippe Ombredanne
); > +MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS("spi:adis16201"); Your MODULE_LICENSE does not match your SPDX license id. MODULE_LICENSE("GPL v2"); means SPDX GPL-2.0 MODULE_LICENSE("GPL"); means SPDX GPL-2.0+ -- Cordially Philippe Ombredanne __

Re: [PATCH v2 01/27] staging: ccree: SPDXify driver

2018-01-07 Thread Philippe Ombredanne
Gilad, On Sun, Jan 7, 2018 at 11:13 AM, Gilad Ben-Yossef <gi...@benyossef.com> wrote: > On Wed, Jan 3, 2018 at 5:01 PM, Philippe Ombredanne > <pombreda...@nexb.com> wrote: >> Gilad, >> >> On Wed, Jan 3, 2018 at 2:35 PM, Gilad Ben-Yossef <gi...@benyossef.

Re: [PATCH v2 01/27] staging: ccree: SPDXify driver

2018-01-03 Thread Philippe Ombredanne
. This cannot happen any other way or this would defeat the whole purpose to have clear licensing kernel-wide: using the latest and greatest introduces variations and creates a mess that we want to avoid in the first place. CC: Thomas Gleixner <t...@l

Re: [PATCH 01/26] staging: ccree: SPDXify driver

2018-01-01 Thread Philippe Ombredanne
file the style should be C comments as explained in Thomas doc patches. .e.g. > +/* SPDX-License-Identifier: GPL-2.0 */ And then it might makes sense there too: > +/* Copyright (C) 2012-2017 ARM Limited or its affiliates. */ -- Cordially Philippe Ombredanne

Re: [PATCH 04/10] staging: ccree: staging: ccree: replace sysfs by debugfs interface

2017-12-14 Thread Philippe Ombredanne
mments made on the list by Linus. If you could spread the word out in your team too, this would be much welcomed! Thanks! [1] https://lkml.org/lkml/2017/12/4/934 -- Cordially Philippe Ombredanne ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread Philippe Ombredanne
On Fri, Dec 1, 2017 at 9:56 PM, David Daney <dda...@caviumnetworks.com> wrote: > On 12/01/2017 12:41 PM, Philippe Ombredanne wrote: >> >> David, >> >> On Fri, Dec 1, 2017 at 9:01 PM, David Daney <dda...@caviumnetworks.com> >> wrote: >>>

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread Philippe Ombredanne
David, On Fri, Dec 1, 2017 at 9:01 PM, David Daney <dda...@caviumnetworks.com> wrote: > On 12/01/2017 11:49 AM, Philippe Ombredanne wrote: >> >> David, Greg, >> >> On Fri, Dec 1, 2017 at 6:42 PM, David Daney <dda...@caviumnetworks.com> >> wrote: >&g

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread Philippe Ombredanne
David, Greg, On Fri, Dec 1, 2017 at 6:42 PM, David Daney <dda...@caviumnetworks.com> wrote: > On 11/30/2017 11:53 PM, Philippe Ombredanne wrote: [...] >>>> --- /dev/null >>>> +++ b/arch/mips/cavium-octeon/resource-mgr.c >>>> @@ -0,0 +1,371

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-12-01 Thread Philippe Ombredanne
>> + * This file is subject to the terms and conditions of the GNU General >> Public >> + * License. See the file "COPYING" in the main directory of this archive >> + * for more details. >> + * >> + * Copyright (C) 2017 Cavium, I