[PATCH v3 2/4] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-07-24 Thread Roy Pledge
-off-by: Roy Pledge --- MAINTAINERS| 2 +- drivers/crypto/caam/sg_sw_qm2.h| 2 +- drivers/crypto/caam/sg_sw_sec4.h | 2 +- drivers/soc/fsl/Kconfig

[PATCH v3 3/4] drivers/staging: Remove fsl-mc driver from staging

2018-07-24 Thread Roy Pledge
Remove the staging/drivers/fsl-mc directory from the staging area now that all the components have been moved to the main kernel areas. Signed-off-by: Roy Pledge --- drivers/staging/Kconfig | 2 -- drivers/staging/Makefile| 1 - drivers/staging/fsl-mc/Kconfig | 2

[PATCH v3 4/4] drivers/soc/fsl/dpio: Convert DPIO documentation to .rst

2018-07-24 Thread Roy Pledge
Convert the Datapath I/O documentation to .rst format and move to the Documation/networking/dpaa2 directory Signed-off-by: Roy Pledge --- .../networking/dpaa2/dpio-driver.rst | 29 +++--- Documentation/networking/dpaa2/index.rst | 1 + 2 files changed

[PATCH v3 0/4] staging/fsl-mc/bus: Move DPIO from staging to drivers/soc/fsl

2018-07-24 Thread Roy Pledge
the staging directory. Horia Geantă (1): staging: fsl-dpaa2/eth: move generic FD defines to DPIO Roy Pledge (3): staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl drivers/staging: Remove fsl-mc driver from staging drivers/soc/fsl/dpio: Convert DPIO documentation to .rst .../networking

Re: [PATCH v2 4/4] drivers/soc/fsl/dpio: Convert DPIO documentation to .rst

2018-07-24 Thread Roy Pledge
On 7/24/2018 9:52 AM, Horia Geanta wrote: > On 7/23/2018 8:00 PM, Roy Pledge wrote: >> Convert the Datapath I/O documentation to .rst format >> and move to the Documation/networking/dpaa2 directory > typo: ^^^ Documentation > >> Signed-off-by: Roy Pledge

[PATCH v2 4/4] drivers/soc/fsl/dpio: Convert DPIO documentation to .rst

2018-07-23 Thread Roy Pledge
Convert the Datapath I/O documentation to .rst format and move to the Documation/networking/dpaa2 directory Signed-off-by: Roy Pledge --- .../networking/dpaa2/dpio-driver.rst | 30 +++--- Documentation/networking/dpaa2/index.rst | 1 + 2 files changed

[PATCH v2 3/4] drivers/staging: Remove fsl-mc driver from staging

2018-07-23 Thread Roy Pledge
Remove the staging/drivers/fsl-mc directory from the staging area now that all the components have been moved to the main kernel areas. Signed-off-by: Roy Pledge --- drivers/staging/Kconfig | 2 -- drivers/staging/Makefile| 1 - drivers/staging/fsl-mc/Kconfig | 2

[PATCH v2 0/4] staging/fsl-mc/bus: Move DPIO from staging to drivers/soc/fsl

2018-07-23 Thread Roy Pledge
the staging directory. Horia Geantă (1): staging: fsl-dpaa2/eth: move generic FD defines to DPIO Roy Pledge (3): staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl drivers/staging: Remove fsl-mc driver from staging drivers/soc/fsl/dpio: Convert DPIO documentation to .rst

[PATCH v2 1/4] staging: fsl-dpaa2/eth: move generic FD defines to DPIO

2018-07-23 Thread Roy Pledge
From: Horia Geantă Previous commits: commit 6e2387e8f19e ("staging: fsl-dpaa2/eth: Add Freescale DPAA2 Ethernet driver") commit 39163c0ce0f4 ("staging: fsl-dpaa2/eth: Errors checking update") have added bits that are not specific to the WRIOP accelerator. Move these where they belong (in DPIO)

[PATCH v2 2/4] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-07-23 Thread Roy Pledge
-off-by: Roy Pledge --- MAINTAINERS| 2 +- drivers/crypto/caam/sg_sw_qm2.h| 2 +- drivers/crypto/caam/sg_sw_sec4.h | 2 +- drivers/soc/fsl/Kconfig

Re: [PATCH 1/2] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-07-09 Thread Roy Pledge
On 7/9/2018 6:37 AM, Laurentiu Tudor wrote: > Hi Roy, > > Couple of comments inline. > > On 05.07.2018 22:41, Roy Pledge wrote: >> Move the NXP DPIO (Datapath I/O Driver) out of the >> drivers/staging directory and into the drivers/soc/fsl directory. >> >>

Re: [PATCH 0/2] staging/fsl-mc/bus: Move DPIO from staging to drivers/soc/fsl

2018-07-06 Thread Roy Pledge
On 7/6/2018 8:25 AM, Horia Geanta wrote: > On 7/5/2018 10:41 PM, Roy Pledge wrote: >> Move the NXP DPIO (Datapath I/O driver) from the staging/fsl-mc/bus/dpio >> directory to the drivers/soc/fsl directory. >> >> The DPIO driver enables access to the Queue and Buffer Ma

[PATCH 1/2] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-07-05 Thread Roy Pledge
-off-by: Roy Pledge --- MAINTAINERS| 2 +- drivers/crypto/caam/sg_sw_qm2.h| 2 +- drivers/crypto/caam/sg_sw_sec4.h | 2 +- drivers/soc/fsl/Kconfig

[PATCH 2/2] drivers/staging: Remove fsl-mc driver from staging

2018-07-05 Thread Roy Pledge
Remove the staging/drivers/fsl-mc directory from the staging area now that all the components have been moved to the main kernel areas. Signed-off-by: Roy Pledge --- drivers/staging/Kconfig | 2 -- drivers/staging/Makefile| 1 - drivers/staging/fsl-mc/Kconfig | 2

[PATCH 0/2] staging/fsl-mc/bus: Move DPIO from staging to drivers/soc/fsl

2018-07-05 Thread Roy Pledge
the staging directory. Roy Pledge (2): staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl drivers/staging: Remove fsl-mc driver from staging MAINTAINERS | 2 +- drivers/crypto/caam/sg_sw_qm2.h | 2 +- drivers/crypto

[PATCH v4 3/4] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-03-27 Thread Roy Pledge
-off-by: Roy Pledge <roy.ple...@nxp.com> --- MAINTAINERS| 2 +- drivers/crypto/caam/sg_sw_qm2.h| 2 +- drivers/crypto/caam/sg_sw_sec4.h | 2 +- drivers/soc/fsl/K

[PATCH v4 2/4] drivers/staging/fsl-mc: Fix DPIO error path issue

2018-03-27 Thread Roy Pledge
Remove unneeded call to dev_set_drvdata(dev, NULL) since the device will be deallocated in any case. Signed-off-by: Roy Pledge <roy.ple...@nxp.com> --- drivers/staging/fsl-mc/bus/dpio/dpio-driver.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/

[PATCH v4 4/4] drivers/staging: Remove fsl-mc driver from staging

2018-03-27 Thread Roy Pledge
Remove the staging/drivers/fsl-mc directory from the staging area now that all the components have been moved to the main kernel areas. Signed-off-by: Roy Pledge <roy.ple...@nxp.com> --- drivers/staging/Kconfig | 2 -- drivers/staging/Makefile| 1 - drivers/staging/

[PATCH v4 1/4] drivers/staging/fsl-mc: Use devm_memremap/devm_ioremap for DPIO

2018-03-27 Thread Roy Pledge
devm_ioremap() for the cache inhibited area so unmap occurs automatically when the device is released. Signed-off-by: Roy Pledge <roy.ple...@nxp.com> --- drivers/staging/fsl-mc/bus/dpio/dpio-driver.c | 19 +++ drivers/staging/fsl-mc/bus/dpio/qbman-portal.h | 4 ++-- drivers/stagi

[PATCH v4 0/4] drives/soc/fsl: Move DPIO driver out of staging

2018-03-27 Thread Roy Pledge
staging/drivers/fsl-mc directory Changes in v2: - Fix minor conflict in latest linux-next branch - Generate patch using -M Roy Pledge (4): drivers/staging/fsl-mc: Use devm_memremap/devm_ioremap for DPIO drivers/staging/fsl-mc: Fix DPIO error path issue staging:fsl-mc: Move

Re: [PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

2018-03-27 Thread Roy Pledge
On 3/27/2018 7:05 AM, Robin Murphy wrote: > Hi Roy, > > On 26/03/18 20:05, Roy Pledge wrote: >> The error path in the dpaa2_dpio_probe() function was not properly >> unmapping the QBMan device memory on the error path. This was also >> missing from the dpaa2_dpio_rel

[PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

2018-03-26 Thread Roy Pledge
The error path in the dpaa2_dpio_probe() function was not properly unmapping the QBMan device memory on the error path. This was also missing from the dpaa2_dpio_release() function. Also addresses a memory leak of the device private data structure. Signed-off-by: Roy Pledge <roy.ple...@nxp.

[PATCH v3 3/4] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-03-26 Thread Roy Pledge
-off-by: Roy Pledge <roy.ple...@nxp.com> --- MAINTAINERS| 2 +- drivers/crypto/caam/sg_sw_qm2.h| 2 +- drivers/crypto/caam/sg_sw_sec4.h | 2 +- drivers/soc/fsl/K

[PATCH v3 0/4] drives/soc/fsl: Move DPIO driver out of staging

2018-03-26 Thread Roy Pledge
of staging. Changes in v3: - Update caam files that use dpaa2 frame header files - Fix spare errors and memory leak - Remove empty staging/drivers/fsl-mc directory Changes in v2: - Fix minor conflict in latest linux-next branch - Generate patch using -M Roy

[PATCH v3 4/4] drivers/staging: Remove fsl-mc driver from staging

2018-03-26 Thread Roy Pledge
Remove the staging/drivers/fsl-mc directory from the staging area now that all the components have been moved to the main kernel areas. Signed-off-by: Roy Pledge <roy.ple...@nxp.com> --- drivers/staging/Kconfig | 2 -- drivers/staging/Makefile| 1 - drivers/staging/

[PATCH v3 1/4] drivers/staging/fsl-mc: Use memremap for DPIO cache enabled area

2018-03-26 Thread Roy Pledge
Change the mapping of the QBMan cache enabled area from using ioremap_wc() to memremap(). This allows the __iomem attribute to be removed from the pointer (which makes sense as accesses try this as cacheable memory not IO memory). These changes allow sparse checks to pass. Signed-off-by: Roy

[v2] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-03-21 Thread Roy Pledge
-off-by: Roy Pledge <roy.ple...@nxp.com> --- Changes in v2: - Fix minor conflict in latest linux-next branch - Generate patch using -M so patch is smaller --- MAINTAINERS| 2 +- drivers/soc/fsl/Ma

[PATCH] staging: fsl-mc/dpio: Add missing argument identifier

2018-03-07 Thread Roy Pledge
When running checkpatch over the DPIO code the following warning is reported: WARNING: function definition argument 'struct dpaa2_io_notification_ctx *' should also have an identifier name Add the missing identifier. Signed-off-by: Roy Pledge <roy.ple...@nxp.com> --- drivers/staging/

Re: [PATCH 1/2] staging: fsl-mc/dpio: Add dpaa2_io_service_select() API

2018-01-05 Thread Roy Pledge
fsl-mc/include/dpaa2-io.h > @@ -88,6 +88,8 @@ void dpaa2_io_down(struct dpaa2_io *d); > > irqreturn_t dpaa2_io_irq(struct dpaa2_io *obj); > > +struct dpaa2_io *dpaa2_io_service_select(int cpu); > + > /** >* struct dpaa2_io_notification_ctx - The DPIO notifi

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-11-06 Thread Roy Pledge
>> struct dpaa2_io { >> atomic_t refs; >> >> That's a kref, please use it instead of trying to roll your own. >> >> And even for this, your locking is not correct (i.e. you do not have >> any), that needs to be fixed so that teardown works correctly. > > I think we can drop this

[RESEND PATCH v6 5/8] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2

2017-03-13 Thread Roy Pledge
From: Roy Pledge <roy.ple...@nxp.com> Add QBman APIs for frame queue and buffer pool operations. Signed-off-by: Roy Pledge <roy.ple...@nxp.com> Signed-off-by: Haiying Wang <haiying.w...@nxp.com> Signed-off-by: Stuart Yoder <stuart.yo...@nxp.com> --- Notes: -v

[RESEND PATCH v6 6/8] bus: fsl-mc: dpio: add the DPAA2 DPIO service interface

2017-03-13 Thread Roy Pledge
From: Roy Pledge <roy.ple...@nxp.com> The DPIO service interface handles initialization of DPIO objects and exports APIs to be used by other DPAA2 object drivers to perform queuing and buffer management related operations. The service allows registration of callbacks when frames or notific

[RESEND PATCH v6 7/8] bus: fsl-mc: dpio: add the DPAA2 DPIO object driver

2017-03-13 Thread Roy Pledge
The DPIO driver registers with the fsl-mc bus to handle bus-related events for DPIO objects. Key responsibility is mapping I/O regions, setting up interrupt handlers, and calling the DPIO service initialization during probe. Signed-off-by: Roy Pledge <roy.ple...@nxp.com> Signed-off-by: H

[RESEND PATCH v6 8/8] bus: fsl-mc: dpio: add maintainer for DPIO

2017-03-13 Thread Roy Pledge
From: Roy Pledge <roy.ple...@nxp.com> add Roy Pledge as maintainer of DPIO Signed-off-by: Roy Pledge <roy.ple...@nxp.com> Signed-off-by: Stuart Yoder <stuart.yo...@nxp.com> --- Notes: Notes: -v4 -adjust file location to be in drivers/s

[RESEND PATCH v6 2/8] bus: fsl-mc: dpio: add APIs for DPIO objects

2017-03-13 Thread Roy Pledge
From: Ioana Radulescu <ruxandra.radule...@nxp.com> Add the command build/parse APIs for operating on DPIO objects through the DPAA2 Management Complex. Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com> Signed-off-by: Roy Pledge <roy.ple...@nxp.com> Signed-of

[RESEND PATCH v6 4/8] bus: fsl-mc: dpio: add global dpaa2 definitions

2017-03-13 Thread Roy Pledge
From: Roy Pledge <roy.ple...@nxp.com> Create header for global dpaa2 definitions. Add definitions for dequeue results. Signed-off-by: Roy Pledge <roy.ple...@nxp.com> Signed-off-by: Stuart Yoder <stuart.yo...@nxp.com> --- Notes: -v4 -adjust file locatio

[RESEND PATCH v6 3/8] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2017-03-13 Thread Roy Pledge
From: Roy Pledge <roy.ple...@nxp.com> Add global definitions for DPAA2 frame descriptors and scatter gather entries. Signed-off-by: Roy Pledge <roy.ple...@nxp.com> Signed-off-by: Stuart Yoder <stuart.yo...@nxp.com> --- Notes: -v6 -Fix incorrect size of

[RESEND PATCH v6 1/8] bus: fsl-mc: dpio: add DPIO driver overview document

2017-03-13 Thread Roy Pledge
From: Stuart Yoder <stuart.yo...@nxp.com> add document describing the dpio driver and it's role, components and major interfaces Signed-off-by: Stuart Yoder <stuart.yo...@nxp.com> Signed-off-by: Roy Pledge <roy.ple...@nxp.com> --- Notes: -v4 -updated c

[RESEND PATCH v6 0/8] staging: fsl-mc: add dpio driver

2017-03-13 Thread Roy Pledge
location for both fsl-mc bus driver and dpio driver Ioana Radulescu (1): bus: fsl-mc: dpio: add APIs for DPIO objects Roy Pledge (6): bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs bus: fsl-mc: dpio: add global dpaa2 definitions bus: fsl-mc: dpio: add QBMan portal

[v6 1/8] bus: fsl-mc: dpio: add DPIO driver overview document

2017-03-08 Thread Roy Pledge
From: Stuart Yoder add document describing the dpio driver and it's role, components and major interfaces Signed-off-by: Stuart Yoder --- drivers/staging/fsl-mc/bus/dpio/dpio-driver.txt | 135 +++ 1 file changed, 135

[v6 3/8] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2017-03-08 Thread Roy Pledge
From: Roy Pledge <roy.ple...@nxp.com> Add global definitions for DPAA2 frame descriptors and scatter gather entries. Signed-off-by: Roy Pledge <roy.ple...@nxp.com> Signed-off-by: Stuart Yoder <stuart.yo...@nxp.com> --- drivers/staging/fsl-mc/include

[v6 6/8] bus: fsl-mc: dpio: add the DPAA2 DPIO service interface

2017-03-08 Thread Roy Pledge
From: Roy Pledge <roy.ple...@nxp.com> The DPIO service interface handles initialization of DPIO objects and exports APIs to be used by other DPAA2 object drivers to perform queuing and buffer management related operations. The service allows registration of callbacks when frames or notific

[v6 5/8] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2

2017-03-08 Thread Roy Pledge
From: Roy Pledge <roy.ple...@nxp.com> Add QBman APIs for frame queue and buffer pool operations. Signed-off-by: Roy Pledge <roy.ple...@nxp.com> Signed-off-by: Haiying Wang <haiying.w...@nxp.com> Signed-off-by: Stuart Yoder <stuart.yo...@nxp.com> --- drivers/staging/

[v6 8/8] bus: fsl-mc: dpio: add maintainer for DPIO

2017-03-08 Thread Roy Pledge
From: Roy Pledge <roy.ple...@nxp.com> add Roy Pledge as maintainer of DPIO Signed-off-by: Roy Pledge <roy.ple...@nxp.com> Signed-off-by: Stuart Yoder <stuart.yo...@nxp.com> --- MAINTAINERS |6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAI

[v6 2/8] bus: fsl-mc: dpio: add APIs for DPIO objects

2017-03-08 Thread Roy Pledge
From: Ioana Radulescu <ruxandra.radule...@nxp.com> Add the command build/parse APIs for operating on DPIO objects through the DPAA2 Management Complex. Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com> Signed-off-by: Roy Pledge <roy.ple...@nxp.com> Signed-of

[v6 7/8] bus: fsl-mc: dpio: add the DPAA2 DPIO object driver

2017-03-08 Thread Roy Pledge
The DPIO driver registers with the fsl-mc bus to handle bus-related events for DPIO objects. Key responsibility is mapping I/O regions, setting up interrupt handlers, and calling the DPIO service initialization during probe. Signed-off-by: Roy Pledge <roy.ple...@nxp.com> Signed-off-by: H

[v6 4/8] bus: fsl-mc: dpio: add global dpaa2 definitions

2017-03-08 Thread Roy Pledge
From: Roy Pledge <roy.ple...@nxp.com> Create header for global dpaa2 definitions. Add definitions for dequeue results. Signed-off-by: Roy Pledge <roy.ple...@nxp.com> Signed-off-by: Stuart Yoder <stuart.yo...@nxp.com> --- drivers/staging/fsl-mc/include/dpa

[v6 0/8] staging: fsl-mc: add dpio driver

2017-03-08 Thread Roy Pledge
location for both fsl-mc bus driver and dpio driver Ioana Radulescu (1): bus: fsl-mc: dpio: add APIs for DPIO objects Roy Pledge (6): bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs bus: fsl-mc: dpio: add global dpaa2 definitions bus: fsl-mc: dpio: add QBMan portal