Re: [OSSNA] Intro to kernel hacking tutorial

On Mon, Sep 02, 2019 at 10:08:54AM -0400, Valdis Klētnieks wrote: > On Mon, 02 Sep 2019 15:42:19 +0300, Anatoly Pugachev said: > > > is it intentionally that you use > > > > yes "" | make oldconfig > > > > instead of > > > > make olddefconfig > > They do something different. 'olddefconfig' just

Re: [OSSNA] Intro to kernel hacking tutorial

On Sun, Sep 01, 2019 at 05:30:23AM +0530, Amit Kumar wrote: > Hi, > I think now your tutorial should be ready. I do not understand what this means sorry. Is it a request for action? The tutorial was a couple of weeks ago now, here is a link to the material if that is what you were asking

Re: [PATCH 2/2] staging/erofs: Balanced braces around a few conditional statements.

On Wed, Aug 21, 2019 at 10:31:22AM +0800, Gao Xiang wrote: > On Tue, Aug 20, 2019 at 07:26:46PM -0700, Joe Perches wrote: > > On Tue, 2019-08-20 at 20:18 -0400, Caitlyn wrote: > > > Balanced braces to fix some checkpath warnings in inode.c and > > > unzip_vle.c > > [] > > > diff --git

Re: [PATCH 1/2] comedi: remove camelcase

On Wed, Aug 21, 2019 at 02:26:18AM -0700, Greg KH wrote: > On Tue, Aug 20, 2019 at 09:12:51PM -0700, Edmund Huber wrote: > > My apologies. Is it possible that you are replying to a different thread > > than intended? I don't think I have an email addressed to me from the > > patchbot. > > I got a

Re: [OSSNA] Intro to kernel hacking tutorial

On Fri, Jul 19, 2019 at 12:36:58PM +0300, Dan Carpenter wrote: > On Fri, Jul 05, 2019 at 12:50:55PM +1000, Tobin C. Harding wrote: > > Outcome will (hopefully) be a small patch set into drivers/staging/. > > (Don't worry Greg only one group got to this stage last time, you > &

Re: [OSSNA] Intro to kernel hacking tutorial

On Fri, Jul 05, 2019 at 10:40:43AM +0530, Amit Kumar wrote: > On Fri, Jul 5, 2019 at 9:02 AM Amit Kumar wrote: > > > > On Fri, Jul 5, 2019 at 8:21 AM Tobin C. Harding wrote: > > > > > > Hi, > > > > > > I am doing a tutorial at OSSNA in San Di

[OSSNA] Intro to kernel hacking tutorial

Hi, I am doing a tutorial at OSSNA in San Diego on getting into kernel hacking. I'm only a couple of years deep into kernel hacking so I wanted to reach out to those more experienced than myself (and those less experienced). Is there any thing that you would really like to see covered in this

Re: [PATCH 04/11] staging: vchiq_arm: Clear VLA warning

ack. So save stack space and removes the VLA build warning by > making it static. > > [1]: https://lkml.org/lkml/2018/3/7/621 > > CC: Tobin C. Harding <m...@tobin.cc> > Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> > --- > .../vc04_

Re: [PATCH v2] staging: vchiq_arm: Clear VLA warning

On Mon, Mar 12, 2018 at 06:58:04AM +0100, Stefan Wahren wrote: > Hi Tobin, > > > "Tobin C. Harding" <m...@tobin.cc> hat am 12. März 2018 um 06:46 > > geschrieben: > > > > > > On Mon, Mar 12, 2018 at 12:37:53PM +1100, Tobin C. Harding wrot

Re: [PATCH v2] staging: vchiq_arm: Clear VLA warning

On Mon, Mar 12, 2018 at 12:37:53PM +1100, Tobin C. Harding wrote: > The kernel would like to have all stack VLA usage removed[1]. The array > here is fixed (declared with a const variable) but it appears like a VLA > to the compiler. Also, currently we are putting 768 bytes on th

[PATCH v2] staging: vchiq_arm: Clear VLA warning

, let's just allocate the memory instead of using the stack. This saves stack space and removes the VLA build warning. kmalloc a buffer for dumping state instead of using the stack. [1]: https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- v1 of this

Re: [PATCH 4/4] video: Remove stack VLA usage

On Fri, Mar 09, 2018 at 12:16:21AM -0600, Gustavo A. R. Silva wrote: > > I sent a patch for this six hours ago: > > https://patchwork.kernel.org/patch/10268591/ > > -- > Gustavo lol, I knew there would be a race on to fix these :) And you got it right, bonus points. Let's drop this one then.

[PATCH] staging: vchiq_arm: Clear VLA warning

The kernel would like to have all stack VLA usage removed[1]. The array here is fixed (declared with a const variable) but it appears like VLA to the compiler. We can use a pre-processor define to quiet the compiler. [1]: https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Tobin C. Harding &l

Re: [PATCH 4/4] video: Remove stack VLA usage

On Thu, Mar 08, 2018 at 10:01:07PM -0800, Joe Perches wrote: > On Fri, 2018-03-09 at 16:50 +1100, Tobin C. Harding wrote: > > The kernel would like to have all stack VLA usage removed[1]. The > > arrays are fixed here (declared with a const variable) but they appear > > like

[PATCH 4/4] video: Remove stack VLA usage

The kernel would like to have all stack VLA usage removed[1]. The arrays are fixed here (declared with a const variable) but they appear like VLAs to the compiler. We can use a pre-processor define to fix the warning. [1]: https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Tobin C. Harding &l

Re: [PATCH] staging: lustre: Remove VLA usage

On Tue, Mar 06, 2018 at 09:46:08PM -0800, Kees Cook wrote: > The kernel would like to remove all VLA usage. This switches to a > simple kasprintf() instead. > > Signed-off-by: Kees Cook > --- > drivers/staging/lustre/lustre/llite/xattr.c | 19 +-- > 1 file

Re: [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()'.

On Fri, Mar 02, 2018 at 12:05:03PM +0300, Dan Carpenter wrote: > There are so many rules for kernel developers to deal with. Is it worse > to go over the 80 character limit or align the parameters properly? Is > it OK to start the subject with a lower case letter? I get in trouble > for using

Re: [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()'.

On Thu, Mar 01, 2018 at 05:28:26PM -0800, Quytelda Kahja wrote: > Tobin, > I understand your point, and I've read submitting-patches.rst. I made > that wording choice because I was looking at some older commits that > were worded like that. I'm fairly new to the kernel workflow, so I > was just

Re: [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()'.

On Thu, Mar 01, 2018 at 02:15:00PM +0300, Dan Carpenter wrote: > On Thu, Mar 01, 2018 at 05:37:21PM +1100, Tobin C. Harding wrote: > > On Wed, Feb 28, 2018 at 09:19:09PM -0800, Quytelda Kahja wrote: > > > The code that generates a WLAN capability mask is repeated in fi

Re: [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()'.

On Wed, Feb 28, 2018 at 09:19:09PM -0800, Quytelda Kahja wrote: > The code that generates a WLAN capability mask is repeated in five > functions. This change refactors that code into a new function, which is > called now in each of those functions. Perhaps in future something like: Code to

Re: [PATCH 1/5] staging: ks7010: Use constants from ieee80211_eid instead of literal ints.

On Wed, Feb 28, 2018 at 09:19:07PM -0800, Quytelda Kahja wrote: ... I would normally respond to the cover letter but here goes. Reviewed-by: Tobin C. Harding <m...@tobin.cc> thanks, Tobin. ___ devel mailing list de...@linuxdriverproject.or

Re: [PATCH 1/5] staging: ks7010: Use constants from ieee80211_eid instead of literal ints.

On Wed, Feb 28, 2018 at 09:19:07PM -0800, Quytelda Kahja wrote: > The case statement in get_ap_information() should not use literal integers > to parse information element IDs when these values are provided by name > in 'enum ieee80211_eid' in the header 'linux/ieee80211.h'. Nice. Magic number

Re: [PATCH v2] drivers/fbtft: Fix indentation

On Wed, Jan 10, 2018 at 06:30:35PM +0100, Jonny Schaefer wrote: > From: Luis Gerhorst > > This fixes the checkpatch message: > > CHECK: Alignment should match open parenthesis > #1380: FILE: drivers/staging/fbtft/fbtft-core.c:1380: > + dev_warn(dev, >

Re: [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse

On Fri, Nov 24, 2017 at 04:02:09PM +0300, Dan Carpenter wrote: > On Fri, Nov 24, 2017 at 09:20:20AM +1100, Tobin C. Harding wrote: > > My current favourite review of all time was done by you on a what was > > at the time a pretty hard patch for me. It was > > > > No

Re: [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse

On Thu, Nov 23, 2017 at 02:51:38PM +0300, Dan Carpenter wrote: > On Thu, Nov 23, 2017 at 03:59:26PM +1100, Tobin C. Harding wrote: > > On Wed, Nov 22, 2017 at 08:38:27PM +0100, Stefano Manni wrote: > > > Fixed some signedness warnings from sparse on lustre. > > &

Re: [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse

On Wed, Nov 22, 2017 at 08:38:27PM +0100, Stefano Manni wrote: > Fixed some signedness warnings from sparse on lustre. > > Stefano Manni (4): > staging: lustre: fixed signedness of some socklnd params > staging: lustre: fixed signedness of llite > staging: lustre: fixed signedness of lov >

Re: [PATCH] Fix style issues in olpc_dcon

Missing subsystem in subject line. Please use the same git brief description format that has been used previously for files you want to patch. You can view previous commits for a file using git log --pretty=oneline --abbrev --reverse On Mon, Nov 20, 2017 at 03:14:21PM -0600,

Re: [PATCH] Staging: comedi: adl_pci9118: fixed some parentheses coding style issue

You may like to limit the git log brief description to 50 characters (this is going to be hard with such a long pre-fix though :) Brief description should be in imperative mood i.e 'Fix foo' instead of 'fixed foo'. On Tue, Nov 21, 2017 at 05:17:53PM -0200, Guilherme Tadashi Maeoka wrote: > Fixed

Re: [PATCH v2] staging: fsl-mc: fix mc-portal to use u32 type

On Tue, Nov 21, 2017 at 10:35:23AM +0530, Bharat Bhushan wrote: > According to MC APIs, size of mc-portal in 32bit. > Also fsl_create_mc_io() storing 32 bit mc-portal size. >" mc_io->portal_size = mc_portal_size;" >While "mc_io->portal_size" is u16 type and >"mc_portal_size" is u32

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

On Mon, Nov 06, 2017 at 04:56:40PM +0300, Dan Carpenter wrote: > On Mon, Nov 06, 2017 at 07:17:11PM +1100, Tobin C. Harding wrote: > > > > @@ -260,9 +261,10 @@ int visorchannel_signalremove(struct visorchannel > > > > *channel, u32 queue, > > > >

Re: [PATCH 3/3] staging: ccree: simplify ioread/iowrite

On Mon, Nov 06, 2017 at 04:46:54PM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 06, 2017 at 10:59:47AM +0200, Gilad Ben-Yossef wrote: > > On Mon, Nov 6, 2017 at 10:37 AM, Tobin C. Harding <m...@tobin.cc> wrote: > > > On Mon, Nov 06, 2017 at 06:55:52AM +

Re: [PATCH 3/3] staging: ccree: simplify ioread/iowrite

On Mon, Nov 06, 2017 at 06:55:52AM +, Gilad Ben-Yossef wrote: > Registers ioread/iowrite operations were done via macros, > sometime using a "magical" implicit parameter. > > Replace all register access with simple inline macros. > > Signed-off-by: Gilad Ben-Yossef Hi,

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

On Mon, Nov 06, 2017 at 09:02:21AM +0100, gre...@linuxfoundation.org wrote: > On Mon, Nov 06, 2017 at 03:30:48PM +1100, Tobin C. Harding wrote: > > On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@linuxfoundation.org wrote: > > > On Mon, Oct 02, 2017 at 03:41:42PM +, Kersh

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@linuxfoundation.org wrote: > On Mon, Oct 02, 2017 at 03:41:42PM +, Kershner, David A wrote: > > Hey Greg, we think the code for visorbus is ready to be moved out > > of staging, can you review it to see if we have missed anything? > > I think

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

On Tue, Oct 24, 2017 at 11:52:58PM -0700, Stephen Brennan wrote: > Hi Gilad & Tobin, > > > > Perhaps, if Stephen is willing, re-write the code to be more readable > > > by, for example, using a temp > > > variable for the register address, and in doing so both making the > > > code more readable

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

ase do correct me if this is not the correct etiquette, I am still learning also. On Tue, Oct 24, 2017 at 11:49:41AM +0300, Gilad Ben-Yossef wrote: > Hi Tobin, > > On Tue, Oct 24, 2017 at 6:02 AM, Tobin C. Harding <m...@tobin.cc> wrote: > > On Mon, Oct 23, 2017 at 07:53:18AM -

Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

On Mon, Oct 23, 2017 at 07:53:18AM -0700, Stephen Brennan wrote: > Simply break down some long lines and tab-indent them. Hi Stephen, Welcome to the Linux kernel. Great that you have put in a patch, you are, however, unlikely to see success fixing 'line over 80' warnings. There are a bunch of

Re: [PATCH v3] staging: wlan-ng: Remove unnecessary parentheses

On Wed, Oct 18, 2017 at 06:50:52PM -0400, Frank A. Cancio Bello wrote: > On Thu, Oct 19, 2017 at 08:40:08AM +1100, Tobin C. Harding wrote: > > On Wed, Oct 18, 2017 at 11:48:21AM -0400, Frank A. Cancio Bello wrote: > > > --- a/drivers/staging/wlan-ng/p80211req.c > > > ++

Re: [PATCH v3] staging: wlan-ng: Remove unnecessary parentheses

On Wed, Oct 18, 2017 at 11:48:21AM -0400, Frank A. Cancio Bello wrote: > Remove unnecessary parentheses to comply with preferred coding style for > the linux kernel and avoid the following checkpatch's messages: > 'CHECK: Unnecessary parentheses around' > 'CHECK: Logical continuations should be on

Re: [PATCH v3] staging: ccree: fix boolreturn.cocci warning

s_hw_key(struct crypto_tfm *tfm) > { > - return 0; > + return false; > } > > #endif /* CRYPTO_TFM_REQ_HW_KEY */ > -- > 1.9.1 > For what it's worth, Reviewed-by: Tobin C. Harding <m...@tobin.cc> As stated I am being particularly 'nit picky', the commit log is

Re: [PATCH v2] staging: ccree: fix boolreturn.cocci warning

On Wed, Oct 18, 2017 at 07:42:53AM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > Return "false" instead of 0. > > This fixes the following coccinelle warning: > WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. So close! The order of

Re: [PATCH v2] staging: ccree: Fix bool comparison

On Wed, Oct 18, 2017 at 07:40:14AM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > Comparision operator "equal to" not required on a variable > "foo" of type "bool". Bool has only two values, can be used > directly or with logical not. > > This fixes the

Re: [PATCH] staging: ccree: fix boolreturn.cocci warning

On Mon, Oct 16, 2017 at 03:39:57PM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > This fixes the following coccinelle warning: > WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. Perhaps Coccinelle emits WARNING: return of 0/1 in

Re: [PATCH] staging: ccree: Fix bool comparison

On Mon, Oct 16, 2017 at 03:38:11PM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > Bool tests don't need comparisons. This commit log could be a bit longer. You may like to read Documentation/process/submitting-patches.rst (section 2). > This fixes the

Re: [PATCH] stagin: atomisp: Fix oops by unbalanced clk enable/disable call

On Mon, Oct 16, 2017 at 02:34:48PM +0200, Hans de Goede wrote: > The common-clk core expects clk consumers to always call enable/disable > in a balanced manner. The atomisp driver does not call gmin_flisclk_ctrl() > in a balanced manner, so add a clock_on bool and skip redundant calls. > > This

Re: [PATCH] Staging: rtlwifi: Remove NULL pointer dereference

On Wed, Oct 11, 2017 at 06:02:47PM +0530, Shreeya Patel wrote: > On Tue, 2017-10-10 at 11:06 +1100, Tobin C. Harding wrote: > > On Tue, Oct 10, 2017 at 02:48:58AM +0530, Shreeya Patel wrote: > > > > > > Remove NULL pointer dereference as it results in undefined > &

Re: [PATCH v2] Staging: bcm2048 fix bare use of 'unsigned' in radio-bcm2048.c

Hi Branislav, On Tue, Oct 10, 2017 at 03:29:19PM +0200, Branislav Radocaj wrote: > This is a patch to the radio-bcm2048.c file that fixes up > a warning found by the checkpatch.pl tool. > > Signed-off-by: Branislav Radocaj Nice work, a few git log nit picks for you to

Re: [PATCH] Staging: rtlwifi: Remove NULL pointer dereference

On Tue, Oct 10, 2017 at 02:48:58AM +0530, Shreeya Patel wrote: > Remove NULL pointer dereference as it results in undefined > behaviour, and will usually lead to a runtime error. The diff does not show any pointer dereference so it is hard to understand what you are trying to do with this patch.

Re: [PATCH 00/18] use ARRAY_SIZE macro

On Sun, Oct 01, 2017 at 03:30:38PM -0400, Jérémy Lefaure wrote: > Hi everyone, > Using ARRAY_SIZE improves the code readability. I used coccinelle (I > made a change to the array_size.cocci file [1]) to find several places > where ARRAY_SIZE could be used instead of other macros or sizeof >

Re: [PATCH v3] Staging: rtl8723bs: Remove unnecessary comments.

On Sat, Sep 30, 2017 at 07:41:11PM +0530, Shreeya Patel wrote: > Remove unnecessary comments which are there > to explain why call to memset is in comments. Both of the > comments are not needed as they are not very useful. > > > Signed-off-by: Shreeya Patel > ---

Re: [PATCH 0/6] Replace container_of with list_entry

On Sat, Sep 30, 2017 at 12:49:00PM +0530, Srishti Sharma wrote: > Replaces instances of container_of with list_entry to > access current list element. > > Srishti Sharma (6): > Staging: rtl8188eu: core: Use list_entry instead of container_of > Staging: rtl8188eu: core: Use list_entry instead

Re: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments.

Hi Shreeya, We don't usually add a period to the subject line for kernel patches. (reason: we only have about 52 characters for the commit brief description so best not to waste any). On Sat, Sep 30, 2017 at 01:30:34PM +0530, Shreeya Patel wrote: > This patch removes unnecessary comments which

Re: [PATCH v1] staging: rtl8188eu: Fix spelling

hrestha <manishshrestha2...@gmail.com> > Signed-off-by: Valentine Sinitsyn <valentine.sinit...@gmail.com> Reviewed-by: Tobin C. Harding <m...@tobin.cc> > --- > drivers/staging/rtl8188eu/core/rtw_efuse.c| 2 +- > drivers/staging/rtl8188eu/core/rtw_mlme.c

Re: [PATCH 0/3] Spelling fixes for rtl8188eu

On Thu, Sep 14, 2017 at 12:05:17PM -0700, Valentine Sinitsyn wrote: > There are some fixes for typos we discovered in rtl8188eu staging driver > as a part of our Open Source Summit North America 2017 tutorial session. > > Valentine Sinitsyn (3): > staging: rtl8188eu: Fix a typo ("deflaut") >

Re: [PATCH 1/3] staging: rtl8188eu: Fix a typo ("deflaut")

Good work getting this set submitted. On Thu, Sep 14, 2017 at 12:05:18PM -0700, Valentine Sinitsyn wrote: > This improves spelling in the comment line to make things easier to get > for future rtl8188eu developers. > > Fixes: ee5f8a431ea (staging: rtl8188eu: Move all efuse related code to >

Re: [PATCH] staging: rtl8712: Fix unbalanced braces around else statement

On Wed, Sep 13, 2017 at 04:14:29PM +0100, Liam Ryan wrote: > On Wed, Sep 13, 2017 at 08:47:39AM +0200, Frans Klaver wrote: > > On Tue, Sep 12, 2017 at 2:40 AM, Liam Ryan wrote: > > > Fix checkpath-reported unbalanced braces in the following areas > > > > > > 221: FILE:

Re: [PATCH 3/3] staging: rtlwifi: remove unused functions

On Tue, Sep 05, 2017 at 09:46:55AM -0500, Larry Finger wrote: > On 09/05/2017 01:53 AM, Tobin C. Harding wrote: > >Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the > >driver. Both functions call rtl_addr_delay(), this function is unused > >outside of these

[PATCH 3/3] staging: rtlwifi: remove unused functions

Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the driver. Both functions call rtl_addr_delay(), this function is unused outside of these call sites.The driver (and kernel) code base is cleaner if unused functions are removed. Remove unused functions. ---

[PATCH 2/3] staging: rtlwifi: use kcalloc instead of multiply

checkpatch emits multiple warnings of type WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply Replace two calls to kzalloc() with calls to kcalloc(). --- drivers/staging/rtlwifi/efuse.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 0/3] staging: rtlwifi: checkpatch fixes

. Tobin C. Harding (3): staging: rtlwifi: fix parenthesis alignment staging: rtlwifi: use kcalloc instead of multiply staging: rtlwifi: remove unused functions drivers/staging/rtlwifi/core.c | 43 +++-- drivers/staging/rtlwifi/core.h | 4 drivers

[PATCH 1/3] staging: rtlwifi: fix parenthesis alignment

Checkpatch emits multiple warnings of type CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis Fix parenthesis alignment in line with checkpatch suggestion. --- drivers/staging/rtlwifi/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 0/4] staging: ks7010: cfg80211 conversion

On Wed, Jun 14, 2017 at 04:30:34PM +1000, Tobin C. Harding wrote: [snip] Please drop this series. thanks, Tobin. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V2] staging: unisys: visorhba - style fix

On Mon, Jun 19, 2017 at 03:28:19PM +, Kershner, David A wrote: > > > -Original Message- > > From: Derek Robson [mailto:robso...@gmail.com] > > Sent: Friday, June 16, 2017 11:13 PM > > To: Kershner, David A ; > > gre...@linuxfoundation.org; Sell, Timothy C

Re: [PATCH 3/4] staging: ks7010: add initial cfg80211 implementation

On Thu, Jun 15, 2017 at 09:59:06AM +1000, Tobin C. Harding wrote: > On Wed, Jun 14, 2017 at 12:24:21PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Jun 14, 2017 at 04:30:37PM +1000, Tobin C. Harding wrote: > > > Currently we are in the process of replacing

Re: [PATCH 3/4] staging: ks7010: add initial cfg80211 implementation

On Wed, Jun 14, 2017 at 12:24:21PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 14, 2017 at 04:30:37PM +1000, Tobin C. Harding wrote: > > Currently we are in the process of replacing the WEXT interface with > > the cfg80211 API. WEXT code is currently within a sub directory and &

Re: [PATCH 1/4] staging: ks7010: move WEXT files to sub directory

On Wed, Jun 14, 2017 at 12:22:31PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 14, 2017 at 04:30:35PM +1000, Tobin C. Harding wrote: > > Current driver implements the WEXT interface. WEXT is in maintenance > > mode, we need to re-write the driver using the cfg80211 API. The cur

[PATCH 2/4] staging: ks7010: add note regarding patching WEXT

WEXT code has been moved to a sub directory and is no longer included in the module build. We should make a note of this for future developers. Add note to WEXT code TODO file informing developers that code is not included in module build. Signed-off-by: Tobin C. Harding <m...@tobin

[PATCH 0/4] staging: ks7010: cfg80211 conversion

03 adds the new cfg80211 driver code. Patch 04 adds an entry to the MAINTAINERS database. Code is untested. Builds on x86_64 and PowerPC. Code is clear of any warnings from checkpatch.pl, Sparse, and Spatch (kchecker). Tobin C. Harding (4): staging: ks7010: move WEXT files to sub directory

[PATCH 1/4] staging: ks7010: move WEXT files to sub directory

and Kconfig so build completes successfully but does not process any files from the WEXT directory. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- drivers/staging/ks7010/Kconfig| 6 +- drivers/staging/ks7010/Makefile | 5 + drivers/staging/ks7010/{ =

[PATCH 4/4] MAINTAINERS: add maintainer entry for ks7010

Driver ks7010 does not currently have a maintainer. Take ownership of the driver and add an entry for the ks7010 driver to the maintainers database. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAI

Re: [PATCH] staging: ks7010: use little-endian types

in variables > that do not have a specified endianness. > > Signed-off-by: Perry Hooker <perry.hoo...@gmail.com> For what it's worth Reviewed-By: Tobin C. Harding <m...@tobin.cc> > --- > drivers/staging/ks7010/ks_hostif.c | 24 +--- > 1 fi

Re: ks7010 firmware upload fail

On Mon, Jun 05, 2017 at 08:07:40PM -0400, Brian Masney wrote: > On Mon, Jun 05, 2017 at 08:24:44PM +1000, Tobin C. Harding wrote: > > On Mon, Jun 05, 2017 at 09:22:12AM +0200, Wolfram Sang wrote: > > > Tobin, > > > > > > > My question is should I be diggin

Re: ks7010 firmware upload fail

On Mon, Jun 05, 2017 at 09:22:12AM +0200, Wolfram Sang wrote: > Tobin, > > > My question is should I be digging further into the MMC code or be doing > > something else with the driver code? > > So, you haven't found any branch that worked? No plain v4.9 or the > gen3-sdio branch from my tree?

ks7010 firmware upload fail

Hi, I am attempting to test the ks7010 SIDO Wi-Fi driver (drivers/staging/ks7010/). Currently probing the driver fails because of a firmware upload error. I am seeking ideas on where to continue troubleshooting this issue. Test setup: - Spectec SDW-823 WIFI card (micro SD). - Raspberry Pi B 1

Re: [RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

On Thu, Jun 01, 2017 at 12:46:30PM +0900, Greg KH wrote: > On Thu, Jun 01, 2017 at 01:27:08PM +1000, Tobin C. Harding wrote: > > Driver ks7010 does not currently have a maintainer. > > > > Add maintainers entry for ks7010. > > > > Signed-off-by

Re: [RFC 1/3] staging: ks7010: move WEXT files to sub directory

On Thu, Jun 01, 2017 at 12:45:37PM +0900, Greg KH wrote: > On Thu, Jun 01, 2017 at 01:27:06PM +1000, Tobin C. Harding wrote: > > Current driver implements the WEXT interface. WEXT is in maintenance > > mode, we need to re-write the driver using cfg80211. The current >

[RFC 2/3] staging: ks7010: add cfg80211 files

for most of the rest of the driver at the same time. Add cfg80211 driver skeleton. Implement FIL. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- drivers/staging/ks7010/Makefile|6 + drivers/staging/ks7010/README.rst | 73 ++ drivers/staging/ks7010/TODO.rst| 17 + d

[RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

Driver ks7010 does not currently have a maintainer. Add maintainers entry for ks7010. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9e98464..75250ee 100644 --- a/MAINTAINERS

[RFC 0/3] staging: ks7010: cfg80211 conversion, add FIL

for taking the time to read this and thank you in advance for any time that you spend on this RFC. All feedback very much appreciated. Regards, Tobin. Tobin C. Harding (3): staging: ks7010: move WEXT files to sub directory staging: ks7010: Add cfg80211 files MAINTAINERS: add maintainer entry

Re: [PATCH V2 00/27] Drivers: ccree - align block comments

On Tue, May 30, 2017 at 08:49:41AM +0200, Antoine Tenart wrote: > Hello Derek, > > On Tue, May 30, 2017 at 06:09:37PM +1200, Derek Robson wrote: > > Fixed block comments across whole ccree driver > > Since all these commits are doing the same logical change across a > single driver, you could

Re: [PATCH] fix multiple blank lines coding style problem

On Thu, May 25, 2017 at 12:22:15PM +0300, Aliza Minkov wrote: > Signed-off-by: Aliza Minkov > --- > drivers/staging/dgnc/dgnc_driver.c | 2 -- > 1 file changed, 2 deletions(-) Hi Aliza, Well done getting your patch together. I think you might get an automated message from

drivers/staging/ks7010 hardware test

Hi Wolfram, I began testing the card you sent today. I'm getting a firmware load error like you mentioned. I checked out code from when you originally merged into staging, however I built the module in a 4.9 kernel. To help me track down the issue could you please tell me what testing you

Re: [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue.

On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote: This driver is not in Greg KH's staging tree. You may like to work off of that tree when doing staging patches. https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ To aid you future patches here are a couple of

Re: [PATCH] staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

On Wed, May 24, 2017 at 10:38:57PM +0800, Jamie Huang wrote: Comment on your patch subject line. Patches to staging typically include the driver in the subject. You can view previous commits to get an idea using $ git log --pretty=oneline drivers/staging/rtl8723bs/core/rtw_security.c And from

Re: staging: sm750fb: removed hungarian prfx and replace CamelCase variables

On Wed, May 24, 2017 at 01:24:14PM +0530, Richa Jha wrote: [snip] Nice work so far. I'm having trouble with your patches. Here are a few nitpicks to help you on your way. There are 4 emails in the last few days with similar subjects but they are not linked together. Also your email subject does

Re: [PATCH 01/27] Drivers: ccree: ssi_sysfs.h - align block comments

On Wed, May 24, 2017 at 04:40:32PM +1200, Derek Robson wrote: > Fixed block comment alignment, Style fix only > Found using checkpatch It's 'one thing per patch', this whole set does one thing. You may like to submit it as a single patch. You won't need the file name in the commit summary then

Re: staging: sm750fb: removed hungarian prfx and replace CamelCase variables

On Tue, May 23, 2017 at 06:37:39PM +0530, Richa Jha wrote: > Replace CamelCase variable names with underscores and remove > hungarian prefixes to comply with the standard kernel coding style Hi Richa, Nice work. You may like to do all the camel case at the same time. You could limit yourself to

[PATCH 2/3] staging: ks7010: hostif, u16 data types to __le16

these data. Change all u16 data types in host interface structures to be __le16. Update all code that touches modified data types. Check using Sparse. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- drivers/staging/ks7010/ks_hostif.c | 14 ++-- drivers/staging/ks7010/ks_hostif.h

[PATCH 3/3] staging: ks7010: hostif, u32 data types to __le32

-off-by: Tobin C. Harding <m...@tobin.cc> --- drivers/staging/ks7010/ks_hostif.h | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h index 35d51fe..45e3a01 100644 --- a/d

[PATCH 1/3] staging: ks7010: eap, change unsigned short to __be16

Sparse emits warning: cast to restricted __be16. EAP header uses network byte order. The structures used to describe it should use __beXX data types. Change data type unsigned short -> __be16. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- drivers/staging/ks7010/eap_packet.h |

[PATCH 0/3] staging: ks7010: fix endian issues

is untested. Builds on x86_64 and PowerPC. Tobin C. Harding (3): staging: ks7010: eap, change unsigned short to __be16 staging: ks7010: hostif, u16 data types to __le16 staging: ks7010: hostif, u32 data types to __le32 drivers/staging/ks7010/eap_packet.h | 4 +- drivers/staging/ks7010

Re: [PATCH v2 1/5] staging: wilc1000: Last line is empty

On Tue, May 02, 2017 at 04:18:39PM +0200, Vincent Siles wrote: > Removing empty line at the end of the file Hi Vincent, Small comment on your patch series. You may have more success if your summary phrase is in imperative mood i.e sounds like you are commanding changes to be made to the code

Re: [PATCH] staging/ks7010: Fix type assignment for struct hostif_hdr

On Mon, May 01, 2017 at 04:11:30PM +0200, gapalinux wrote: > On Mon, 1 May 2017 19:59:44 +1000 > "Tobin C. Harding" <m...@tobin.cc> wrote: > > > On Sat, Apr 29, 2017 at 07:54:30PM +0200, Cezary Gapinski wrote: > > > Sparse spits out a warnings about __

Re: [PATCH] staging/ks7010: Fix type assignment for struct hostif_hdr

. If I am wrong, I'll be here to fix it up :) Reviewed-by: Tobin C. Harding <m...@tobin.cc> Good work Cezsary, apologies for the wish-washy replies. I'm learning also ;) Good luck, Tobin. > --- > drivers/staging/ks7010/ks7010_sdio.c | 10 ++ > drivers/staging/ks7010/ks_hostif

Re: [PATCH v4] staging: ks7010: fix block comment style

On Fri, Apr 28, 2017 at 03:01:32PM +0200, Ilia Sergachev wrote: > On Fri, 28 Apr 2017 14:20:21 +0200 > Greg Kroah-Hartman wrote: > > > > > Nope, the whole thing still doesn't apply: > > > > checking file drivers/staging/ks7010/ks_wlan_net.c > > Hunk #1 FAILED at

Re: [PATCH] staging: ks7010: remove line continuations in quoted strings

On Fri, Apr 28, 2017 at 05:26:17PM +0300, Dan Carpenter wrote: > On Fri, Apr 28, 2017 at 04:19:28PM +0200, Ilia Sergachev wrote: > > Checkpatch emits WARNING: Avoid line continuations in quoted strings. > > > > Remove line continuations - split strings using quotes. > > > > Signed-off-by: Ilia

Re: [PATCH 0/8] Avoid CamelCases in ks7010 driver

On Sat, Apr 29, 2017 at 10:58:40PM +0200, Janusz Lisiecki wrote: > This patchset fix CamelCases in ks7010 driver except michael_mic > which will be replaced by kernel implementation in the future. Series looks good to me. For what its worth; Reviewed-by: Tobin C. Harding <m...

Re: [PATCH 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields

On Sat, Apr 29, 2017 at 10:58:44PM +0200, Janusz Lisiecki wrote: > Replace CamelCase struct field names with underscores to comply > with the standard kernel coding style. > Changed: > - FhParms_t > - DsParms_t > - CfParms_t > - IbssParms_t > - ErpParams_t > > Signed-off-by: Janusz Lisiecki

Re: [bug report] staging: ks7010: add driver from Nanonote extra-repository

On Fri, Apr 28, 2017 at 04:27:29PM +0200, Wolfram Sang wrote: > On Fri, Apr 28, 2017 at 04:41:33PM +0300, Dan Carpenter wrote: > > Adding Tobin to CC, he is way more into the driver than I am these > days... I've mocked up a patch set to address this issue (along with some further refactoring of

Re: [PATCH] staging/ks7010: Fix type assignment for struct hostif_hdr

On Sat, Apr 29, 2017 at 07:54:30PM +0200, Cezary Gapinski wrote: > Sparse spits out a warnings about __le16 and unsigned short assignment. > Change the type of size and event members of struct hostif_hdr > to __le16 and correct conversion to the proper cpu type. I believe that this patch is

  1   2   3   4   5   6   >