Re: [PATCH RESEND v3] staging: erofs: remove unsupported ->datamode check in fill_inline_data()

On Thu, 4 Jul 2019 07:26:49 +0200 Greg KH wrote: > On Thu, Jul 04, 2019 at 09:59:03AM +0800, Yue Hu wrote: > > On Wed, 3 Jul 2019 18:20:38 +0200 > > Greg KH wrote: > > > > > On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote: > > > > Fr

Re: [PATCH RESEND v3] staging: erofs: remove unsupported ->datamode check in fill_inline_data()

On Wed, 3 Jul 2019 18:20:38 +0200 Greg KH wrote: > On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote: > > From: Yue Hu > > > > Already check if ->datamode is supported in read_inode(), no need to check > > again in the next fill_inline_data() only called by

[PATCH RESEND v3] staging: erofs: remove unsupported ->datamode check in fill_inline_data()

From: Yue Hu Already check if ->datamode is supported in read_inode(), no need to check again in the next fill_inline_data() only called by fill_inode(). Signed-off-by: Yue Hu Reviewed-by: Gao Xiang Reviewed-by: Chao Yu --- no change drivers/staging/erofs/inode.c | 2 -- 1 file changed

Re: [PATCH] staging: erofs: don't check special inode layout

On Fri, 28 Jun 2019 11:50:21 +0800 Gao Xiang wrote: > Hi Yue, > > On 2019/6/28 11:42, Yue Hu wrote: > > From: Yue Hu > > > > Currently, we will check if inode layout is compression or inline if > > the inode is special in fill_inode(). Also set ->i_mapping-

[PATCH] staging: erofs: don't check special inode layout

From: Yue Hu Currently, we will check if inode layout is compression or inline if the inode is special in fill_inode(). Also set ->i_mapping->a_ops for it. That is pointless since the both modes won't be set for special inode when creating EROFS filesystem image. So, let's avoid it. Sign

[PATCH RESEND v2] staging: erofs: return the error value if fill_inline_data() fails

From: Yue Hu We should consider the error returned by fill_inline_data() when filling last page in fill_inode(). If not getting inode will be successful even though last page is bad. That is illogical. Also change -EAGAIN to 0 in fill_inline_data() to stand for successful filling. Signed-off

[PATCH RESEND v2] staging: erofs: remove unsupported ->datamode check in fill_inline_data()

From: Yue Hu Already check if ->datamode is supported in read_inode(), no need to check again in the next fill_inline_data() only called by fill_inode(). Signed-off-by: Yue Hu Reviewed-by: Gao Xiang Reviewed-by: Chao Yu --- v2: add tags. drivers/staging/erofs/inode.c | 2 -- 1 file chan

[PATCH RESEND] staging: erofs: remove unsupported ->datamode check in fill_inline_data()

From: Yue Hu Already check if ->datamode is supported in read_inode(), no need to check again in the next fill_inline_data() only called by fill_inode(). Signed-off-by: Yue Hu Reviewed-by: Gao Xiang Reviewed-by: Chao Yu --- drivers/staging/erofs/inode.c | 2 -- 1 file changed, 2 deleti

[PATCH RESEND] staging: erofs: return the error value if fill_inline_data() fails

From: Yue Hu We should consider the error returned by fill_inline_data() when filling last page in fill_inode(). If not getting inode will be successful even though last page is bad. That is illogical. Also change -EAGAIN to 0 in fill_inline_data() to stand for successful filling. Signed-off

[PATCH RESEND] staging: erofs: remove unsupported ->datamode check in fill_inline_data()

From: Yue Hu Already check if ->datamode is supported in read_inode(), no need to check again in the next fill_inline_data() only called by fill_inode(). Signed-off-by: Yue Hu --- drivers/staging/erofs/inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/erofs/inod