Re: [V2 PATCH 03/10] added media agnostic (MA) data structures and handling

2014-11-11 Thread steph
On Wed, Nov 12, 2014 at 10:14:38AM +0900, Greg KH wrote: On Tue, Nov 11, 2014 at 02:42:22PM -0800, Sean O. Stalley wrote: On Tue, Nov 11, 2014 at 01:38:21PM +0900, Greg KH wrote: On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote: Yes, I am holding you to a higher standard

Re: [PATCH 01/10] added media agnostic (MA) USB HCD driver

2014-11-03 Thread steph
On Mon, Nov 03, 2014 at 01:18:16PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote: +#define DEBUG I doubt you want this in the driver enabled by default :( Thank you for catching, will remove in the next patch version.

Re: [PATCH 01/10] added media agnostic (MA) USB HCD driver

2014-11-03 Thread steph
On Mon, Nov 03, 2014 at 01:21:39PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote: +EXPORT_SYMBOL(mausb_register_ms_driver); EXPORT_SYMBOL_GPL()? I have to ask... The source is dual-licenced under BSD and GPL. It was our understanding that

Re: [PATCH 01/10] added media agnostic (MA) USB HCD driver

2014-11-03 Thread steph
On Mon, Nov 03, 2014 at 04:13:55PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 04:04:42PM -0800, steph wrote: On Mon, Nov 03, 2014 at 01:21:39PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote: +EXPORT_SYMBOL(mausb_register_ms_driver