Re: [PATCH 1/5] Staging: rtl8192u: ieee80211: Fix coding style warning

[Dan Carpenter]

On Tue, May 14, 2019 at 01:08:11AM +0530, Puranjay Mohan wrote:
> Remove braces around a single if statement to fix following
> checkpatch.pl warning.
> WARNING: braces {} are not necessary for single statement blocks
> 
> Signed-off-by: Puranjay Mohan 
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c 
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 0e762e559675..bd97531a254f 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
>   spin_unlock_irqrestore(>lock, flags);
>   if 
> (is_beacon(beacon->header.frame_ctl)&_same_network(>current_network, 
> network, ieee)&&\
>   (ieee->state == IEEE80211_LINKED)) {
> - if (ieee->handle_beacon != NULL) {
> + if (ieee->handle_beacon != NULL)
>   
> ieee->handle_beacon(ieee->dev,beacon,>current_network);
> - }
> +
>   }

We don't want the blank line.  Just delete the '}'

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/5] Staging: rtl8192u: ieee80211: Fix coding style warning

[Puranjay Mohan]

Remove braces around a single if statement to fix following
checkpatch.pl warning.
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Puranjay Mohan 
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c 
b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
index 0e762e559675..bd97531a254f 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
@@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
spin_unlock_irqrestore(>lock, flags);
if 
(is_beacon(beacon->header.frame_ctl)&_same_network(>current_network, 
network, ieee)&&\
(ieee->state == IEEE80211_LINKED)) {
-   if (ieee->handle_beacon != NULL) {
+   if (ieee->handle_beacon != NULL)

ieee->handle_beacon(ieee->dev,beacon,>current_network);
-   }
+
}
 
 out:
-- 
2.21.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel