Re: [PATCH 10/24] staging: unisys: refactor VISORCHIPSET_SWITCH_INFO

2014-11-03 Thread Greg KH 
On Fri, Oct 31, 2014 at 09:57:29AM -0400, Benjamin Romer wrote:
 Remove the typedef and use struct visorchipset_switch_info instead. Fix all
 CamelCase member names:
 
 switchNo = switch_no
 switchTypeGuid = switch_type_uuid
 authService1 = authservice1
 authService2 = authservice2
 authService3 = authservice3
 securityContext = security_context
 Reserved = reserved
 Reserved2 = reserved2
 pendingMsgHdr = pending_msg_hdr
 
 Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
 ---
  drivers/staging/unisys/visorchipset/visorchipset.h | 25 
 +++---
  1 file changed, 12 insertions(+), 13 deletions(-)
 
 diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h 
 b/drivers/staging/unisys/visorchipset/visorchipset.h
 index a578d0a..762bc13 100644
 --- a/drivers/staging/unisys/visorchipset/visorchipset.h
 +++ b/drivers/staging/unisys/visorchipset/visorchipset.h
 @@ -160,21 +160,20 @@ findbus(struct list_head *list, u32 bus_no)
  
  /** Attributes for a particular Supervisor switch.
   */
 -typedef struct {
 - u32 switchNo;
 +struct visorchipset_switch_info {
 + u32 switch_no;
   struct visorchipset_state state;
 - uuid_le switchTypeGuid;
 - u8 *authService1;
 - u8 *authService2;
 - u8 *authService3;
 - u8 *securityContext;
 - u64 Reserved;
 - u32 Reserved2;  /* control_vm_id */
 + uuid_le switch_type_uuid;
 + u8 *authservice1;
 + u8 *authservice2;
 + u8 *authservice3;
 + u8 *security_context;
 + u64 reserved;
 + u32 reserved2;  /* control_vm_id */
   struct device dev;
   BOOL dev_exists;
 - struct controlvm_message_header pendingMsgHdr;
 -
 -} VISORCHIPSET_SWITCH_INFO;
 + struct controlvm_message_header pending_msg_hdr;
 +};
  
  /** Attributes for a particular Supervisor external port, which is connected
   *  to a specific switch.
 @@ -277,7 +276,7 @@ BOOL visorchipset_get_bus_info(ulong busNo,
  BOOL visorchipset_get_device_info(ulong busNo, ulong devNo,
 struct visorchipset_device_info *devInfo);
  BOOL visorchipset_get_switch_info(ulong switchNo,
 -   VISORCHIPSET_SWITCH_INFO *switchInfo);
 +   struct visorchipset_switch_info *switchInfo);
  BOOL visorchipset_get_externalport_info(ulong switchNo, ulong externalPortNo,
   VISORCHIPSET_EXTERNALPORT_INFO
   *externalPortInfo);

Does no one do anythign with this structure?  If so, why not just delete
it?

In future patches, don't worry about it in this series.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 10/24] staging: unisys: refactor VISORCHIPSET_SWITCH_INFO

2014-10-31 Thread Benjamin Romer 
Remove the typedef and use struct visorchipset_switch_info instead. Fix all
CamelCase member names:

switchNo = switch_no
switchTypeGuid = switch_type_uuid
authService1 = authservice1
authService2 = authservice2
authService3 = authservice3
securityContext = security_context
Reserved = reserved
Reserved2 = reserved2
pendingMsgHdr = pending_msg_hdr

Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
 drivers/staging/unisys/visorchipset/visorchipset.h | 25 +++---
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h 
b/drivers/staging/unisys/visorchipset/visorchipset.h
index a578d0a..762bc13 100644
--- a/drivers/staging/unisys/visorchipset/visorchipset.h
+++ b/drivers/staging/unisys/visorchipset/visorchipset.h
@@ -160,21 +160,20 @@ findbus(struct list_head *list, u32 bus_no)
 
 /** Attributes for a particular Supervisor switch.
  */
-typedef struct {
-   u32 switchNo;
+struct visorchipset_switch_info {
+   u32 switch_no;
struct visorchipset_state state;
-   uuid_le switchTypeGuid;
-   u8 *authService1;
-   u8 *authService2;
-   u8 *authService3;
-   u8 *securityContext;
-   u64 Reserved;
-   u32 Reserved2;  /* control_vm_id */
+   uuid_le switch_type_uuid;
+   u8 *authservice1;
+   u8 *authservice2;
+   u8 *authservice3;
+   u8 *security_context;
+   u64 reserved;
+   u32 reserved2;  /* control_vm_id */
struct device dev;
BOOL dev_exists;
-   struct controlvm_message_header pendingMsgHdr;
-
-} VISORCHIPSET_SWITCH_INFO;
+   struct controlvm_message_header pending_msg_hdr;
+};
 
 /** Attributes for a particular Supervisor external port, which is connected
  *  to a specific switch.
@@ -277,7 +276,7 @@ BOOL visorchipset_get_bus_info(ulong busNo,
 BOOL visorchipset_get_device_info(ulong busNo, ulong devNo,
  struct visorchipset_device_info *devInfo);
 BOOL visorchipset_get_switch_info(ulong switchNo,
- VISORCHIPSET_SWITCH_INFO *switchInfo);
+ struct visorchipset_switch_info *switchInfo);
 BOOL visorchipset_get_externalport_info(ulong switchNo, ulong externalPortNo,
VISORCHIPSET_EXTERNALPORT_INFO
*externalPortInfo);
-- 
2.1.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel