Re: [PATCH v2] staging:iio:meter: Add name to function definition arguments

[Dan Carpenter]

On Tue, Feb 20, 2018 at 09:21:56AM -0300, Rodrigo Siqueira wrote:
> On 02/20, Dan Carpenter wrote:
> > > On Mon, Feb 19, 2018 at 01:28:32PM -0300, rodrigosiqueira wrote:
> > ^^^
> > This looks good, but you need to fix your from email header.
> 
> Thanks for the review, and the feedback related to the email header.
> I already fixed it. Is it necessary to resend the patch?
>  

I don't know?  Sometimes mainainters will cleanup patches themselves...

Probably it's simplest to just resend, yes.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2] staging:iio:meter: Add name to function definition arguments

[Rodrigo Siqueira]

On 02/20, Dan Carpenter wrote:
> > On Mon, Feb 19, 2018 at 01:28:32PM -0300, rodrigosiqueira wrote:
> ^^^
> This looks good, but you need to fix your from email header.

Thanks for the review, and the feedback related to the email header.
I already fixed it. Is it necessary to resend the patch?
 
> regards,
> dan carpenter
> 
> 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2] staging:iio:meter: Add name to function definition arguments

[Dan Carpenter]

> On Mon, Feb 19, 2018 at 01:28:32PM -0300, rodrigosiqueira wrote:
^^^
This looks good, but you need to fix your from email header.

regards,
dan carpenter


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging:iio:meter: Add name to function definition arguments

[rodrigosiqueira]

This patch fixes the checkpatch.pl warning:

drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition
argument 'struct device *' should also have an identifier name...

This commit adds arguments names to the signature declared in the
ade7854_state struct. For consistency reason, It also renames all
arguments in function definitions.

Signed-off-by: Rodrigo Siqueira 
---
Changes in v2:
  - Make the commit message clearer.
  - Use the same arguments name across signatures and definitions.

 drivers/staging/iio/meter/ade7754.c |  6 +++---
 drivers/staging/iio/meter/ade7854-i2c.c | 28 ++--
 drivers/staging/iio/meter/ade7854-spi.c | 28 ++--
 drivers/staging/iio/meter/ade7854.h | 28 ++--
 4 files changed, 45 insertions(+), 45 deletions(-)

diff --git a/drivers/staging/iio/meter/ade7754.c 
b/drivers/staging/iio/meter/ade7754.c
index 3a1e342d75fb..9aa067736715 100644
--- a/drivers/staging/iio/meter/ade7754.c
+++ b/drivers/staging/iio/meter/ade7754.c
@@ -132,7 +132,7 @@ static int ade7754_spi_write_reg_8(struct device *dev, u8 
reg_address, u8 val)
 }
 
 static int ade7754_spi_write_reg_16(struct device *dev,
-   u8 reg_address, u16 value)
+   u8 reg_address, u16 val)
 {
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -140,8 +140,8 @@ static int ade7754_spi_write_reg_16(struct device *dev,
 
mutex_lock(>buf_lock);
st->tx[0] = ADE7754_WRITE_REG(reg_address);
-   st->tx[1] = (value >> 8) & 0xFF;
-   st->tx[2] = value & 0xFF;
+   st->tx[1] = (val >> 8) & 0xFF;
+   st->tx[2] = val & 0xFF;
ret = spi_write(st->us, st->tx, 3);
mutex_unlock(>buf_lock);
 
diff --git a/drivers/staging/iio/meter/ade7854-i2c.c 
b/drivers/staging/iio/meter/ade7854-i2c.c
index 8106f8cceeab..317e4f0d8176 100644
--- a/drivers/staging/iio/meter/ade7854-i2c.c
+++ b/drivers/staging/iio/meter/ade7854-i2c.c
@@ -17,7 +17,7 @@
 
 static int ade7854_i2c_write_reg_8(struct device *dev,
   u16 reg_address,
-  u8 value)
+  u8 val)
 {
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -26,7 +26,7 @@ static int ade7854_i2c_write_reg_8(struct device *dev,
mutex_lock(>buf_lock);
st->tx[0] = (reg_address >> 8) & 0xFF;
st->tx[1] = reg_address & 0xFF;
-   st->tx[2] = value;
+   st->tx[2] = val;
 
ret = i2c_master_send(st->i2c, st->tx, 3);
mutex_unlock(>buf_lock);
@@ -36,7 +36,7 @@ static int ade7854_i2c_write_reg_8(struct device *dev,
 
 static int ade7854_i2c_write_reg_16(struct device *dev,
u16 reg_address,
-   u16 value)
+   u16 val)
 {
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -45,8 +45,8 @@ static int ade7854_i2c_write_reg_16(struct device *dev,
mutex_lock(>buf_lock);
st->tx[0] = (reg_address >> 8) & 0xFF;
st->tx[1] = reg_address & 0xFF;
-   st->tx[2] = (value >> 8) & 0xFF;
-   st->tx[3] = value & 0xFF;
+   st->tx[2] = (val >> 8) & 0xFF;
+   st->tx[3] = val & 0xFF;
 
ret = i2c_master_send(st->i2c, st->tx, 4);
mutex_unlock(>buf_lock);
@@ -56,7 +56,7 @@ static int ade7854_i2c_write_reg_16(struct device *dev,
 
 static int ade7854_i2c_write_reg_24(struct device *dev,
u16 reg_address,
-   u32 value)
+   u32 val)
 {
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -65,9 +65,9 @@ static int ade7854_i2c_write_reg_24(struct device *dev,
mutex_lock(>buf_lock);
st->tx[0] = (reg_address >> 8) & 0xFF;
st->tx[1] = reg_address & 0xFF;
-   st->tx[2] = (value >> 16) & 0xFF;
-   st->tx[3] = (value >> 8) & 0xFF;
-   st->tx[4] = value & 0xFF;
+   st->tx[2] = (val >> 16) & 0xFF;
+   st->tx[3] = (val >> 8) & 0xFF;
+   st->tx[4] = val & 0xFF;
 
ret = i2c_master_send(st->i2c, st->tx, 5);
mutex_unlock(>buf_lock);
@@ -77,7 +77,7 @@ static int ade7854_i2c_write_reg_24(struct device *dev,
 
 static int ade7854_i2c_write_reg_32(struct device *dev,
u16 reg_address,
-   u32 value)
+   u32 val)
 {
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -86,10 +86,10 @@ static int ade7854_i2c_write_reg_32(struct device *dev,
mutex_lock(>buf_lock);
st->tx[0] = (reg_address >> 8) & 0xFF;
st->tx[1] = reg_address & 0xFF;
-   st->tx[2] = (value >> 24) & 0xFF;
-   st->tx[3] = (value >> 16) & 0xFF;
-   st->tx[4] = (value >> 8) & 0xFF;
-