Re: [PATCH] Staging: wilc1000: fixed the wrong error code

2016-12-06 Thread Greg KH 
On Sat, Dec 03, 2016 at 12:26:06AM +0530, Atul Raj wrote:
> in case of memory failure -ENOMEM should be returned.
> 
> Signed-off-by: Atul Raj 
> ---
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This patch doesn't apply at all :(

Please fix up and resend.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wilc1000: fixed the wrong error code

2016-12-01 Thread Dan Carpenter 
This doesn't apply.  Here is a howto on sending a v2 patch.

https://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wilc1000: fixed the wrong error code

2016-12-01 Thread Atul Raj 
On Thu, Dec 1, 2016 at 1:03 AM, Dan Carpenter  wrote:
> On Thu, Dec 01, 2016 at 12:58:45AM +0530, Atul Raj wrote:
>> ENOENT is error code for 
>> ENOMEM should be used for 
>>
>> Signed-off-by: Atul Raj 

> Changelog doesn't match the patch.

Sorry for the mistake. Please check the corrected version.

EFAULT is error code for 
ENOMEM should be used for 


Signed-off-by: Atul Raj 
---
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index 60d8b05..971956f 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -1642,7 +1642,7 @@ static int mgmt_tx(struct wiphy *wiphy,
if (ieee80211_is_mgmt(mgmt->frame_control)) {
mgmt_tx = kmalloc(sizeof(struct p2p_mgmt_data), GFP_KERNEL);
if (!mgmt_tx)
-   return -EFAULT;
+   return -ENOMEM;

mgmt_tx->buff = kmalloc(buf_len, GFP_KERNEL);
if (!mgmt_tx->buff) {
--
2.10.2.windows.1

Regards
Atul Raj
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wilc1000: fixed the wrong error code

2016-11-30 Thread Dan Carpenter 
On Thu, Dec 01, 2016 at 12:58:45AM +0530, Atul Raj wrote:
> ENOENT is error code for 
> ENOMEM should be used for 
> 
> Signed-off-by: Atul Raj 
> ---
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index 60d8b05..971956f 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -1642,7 +1642,7 @@ static int mgmt_tx(struct wiphy *wiphy,
> if (ieee80211_is_mgmt(mgmt->frame_control)) {
> mgmt_tx = kmalloc(sizeof(struct p2p_mgmt_data), GFP_KERNEL);
> if (!mgmt_tx)
> -   return -EFAULT;
> +   return -ENOMEM;

Changelog doesn't match the patch.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel