Re: [PATCH] [media] : Removing warnings caught by checkpatch.pl

2016-10-04 Thread Laurent Pinchart
Hi Andrey, On Monday 03 Oct 2016 22:52:11 Andrey Utkin wrote: > On Sun, Oct 02, 2016 at 02:30:45AM +0530, Harman Kalra wrote: > > static int iss_video_queue_setup(struct vb2_queue *vq, > > > > -unsigned int *count, unsigned int *num_planes, > > -

Re: [PATCH] [media] : Removing warnings caught by checkpatch.pl

2016-10-03 Thread Andrey Utkin
On Sun, Oct 02, 2016 at 02:30:45AM +0530, Harman Kalra wrote: > static int iss_video_queue_setup(struct vb2_queue *vq, > - unsigned int *count, unsigned int *num_planes, > - unsigned int sizes[], struct device > *alloc_devs[]) > +

Re: [PATCH] [media] : Removing warnings caught by checkpatch.pl

2016-10-03 Thread Laurent Pinchart
Hello Harman, Thank you for the patch. The subject of your commit message should at least contain the name of the driver. Furthermore, you can mention that the patch originates from warnings output by checkpatch.pl, but the subject should describe what you fix (in this case what type of

[PATCH] [media] : Removing warnings caught by checkpatch.pl

2016-10-01 Thread Harman Kalra
Removing warnings caught by checkpatch.pl Signed-off-by: Harman Kalra --- drivers/staging/media/omap4iss/iss_video.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss_video.c