Kfree on NULL pointer is a no-op and therefore checking is redundant.

Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com>
---
 .../staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c    | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git 
a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c 
b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
index 6358216..451c76e 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
@@ -295,10 +295,8 @@ void sh_css_unload_firmware(void)
        }
 
        memset(&sh_css_sp_fw, 0, sizeof(sh_css_sp_fw));
-       if (sh_css_blob_info) {
-               kfree(sh_css_blob_info);
-               sh_css_blob_info = NULL;
-       }
+       kfree(sh_css_blob_info);
+       sh_css_blob_info = NULL;
        sh_css_num_binaries = 0;
 }
 
-- 
2.7.4

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to