Re: [PATCH] [v2] staging: iio: ad5933: avoid uninitialized variable in error case

2016-10-25 Thread Jonathan Cameron
On 25/10/16 18:00, Lars-Peter Clausen wrote: > On 10/25/2016 06:57 PM, Jonathan Cameron wrote: >> On 24/10/16 16:22, Arnd Bergmann wrote: >>> The ad5933_i2c_read function returns an error code to indicate >>> whether it could read data or not. However ad5933_work() ignores >>> this return code and

Re: [PATCH] [v2] staging: iio: ad5933: avoid uninitialized variable in error case

2016-10-25 Thread Lars-Peter Clausen
On 10/25/2016 06:57 PM, Jonathan Cameron wrote: > On 24/10/16 16:22, Arnd Bergmann wrote: >> The ad5933_i2c_read function returns an error code to indicate >> whether it could read data or not. However ad5933_work() ignores >> this return code and just accesses the data unconditionally, >> which

Re: [PATCH] [v2] staging: iio: ad5933: avoid uninitialized variable in error case

2016-10-25 Thread Jonathan Cameron
On 24/10/16 16:22, Arnd Bergmann wrote: > The ad5933_i2c_read function returns an error code to indicate > whether it could read data or not. However ad5933_work() ignores > this return code and just accesses the data unconditionally, > which gets detected by gcc as a possible bug: > >

[PATCH] [v2] staging: iio: ad5933: avoid uninitialized variable in error case

2016-10-24 Thread Arnd Bergmann
The ad5933_i2c_read function returns an error code to indicate whether it could read data or not. However ad5933_work() ignores this return code and just accesses the data unconditionally, which gets detected by gcc as a possible bug: drivers/staging/iio/impedance-analyzer/ad5933.c: In function