[PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-12-05 Thread Athira Lekshmi 
Fixed the checkpatch warning:
Missing a blank line after declarations

Signed-off-by: Athira Lekshmi andnlnb...@gmail.com
---
 drivers/staging/octeon/ethernet-rx.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/octeon/ethernet-rx.c 
b/drivers/staging/octeon/ethernet-rx.c
index 44e372f..220106e 100644
--- a/drivers/staging/octeon/ethernet-rx.c
+++ b/drivers/staging/octeon/ethernet-rx.c
@@ -84,6 +84,7 @@ static int cvm_irq_cpu;
 static void cvm_oct_enable_napi(void *_)
 {
int cpu = smp_processor_id();
+
napi_schedule(cvm_oct_napi[cpu].napi);
 }
 
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-12-05 Thread Sudip Mukherjee 
On Fri, Dec 05, 2014 at 04:25:22PM +0530, Athira Lekshmi wrote:
 Fixed the checkpatch warning:
 Missing a blank line after declarations

this is not applying to next-20141204.

sudip

 
 Signed-off-by: Athira Lekshmi andnlnb...@gmail.com
 ---
  drivers/staging/octeon/ethernet-rx.c |1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/staging/octeon/ethernet-rx.c 
 b/drivers/staging/octeon/ethernet-rx.c
 index 44e372f..220106e 100644
 --- a/drivers/staging/octeon/ethernet-rx.c
 +++ b/drivers/staging/octeon/ethernet-rx.c
 @@ -84,6 +84,7 @@ static int cvm_irq_cpu;
  static void cvm_oct_enable_napi(void *_)
  {
   int cpu = smp_processor_id();
 +
   napi_schedule(cvm_oct_napi[cpu].napi);
  }
  
 -- 
 1.7.9.5
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-kernel in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 Please read the FAQ at  http://www.tux.org/lkml/
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-12-02 Thread Greg KH 
On Sat, Nov 29, 2014 at 11:04:00AM +0530, Athira Lekshmi wrote:
 Fixed the checkpatch warning:
 Missing a blank line after declarations
 
 Signed-off-by: Athira Lekshmi andnlnb...@gmail.com
 ---
  drivers/staging/octeon/ethernet-rx.c |1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/staging/octeon/ethernet-rx.c 
 b/drivers/staging/octeon/ethernet-rx.c
 index 44e372f..220106e 100644
 --- a/drivers/staging/octeon/ethernet-rx.c
 +++ b/drivers/staging/octeon/ethernet-rx.c
 @@ -84,6 +84,7 @@ static int cvm_irq_cpu;
  static void cvm_oct_enable_napi(void *_)
  {
   int cpu = smp_processor_id();
 +
   napi_schedule(cvm_oct_napi[cpu].napi);
  }
  
 -- 
 1.7.9.5

Why did you resend this, with no obvious reason why it was different
from the previous version?

I don't know what to apply, so I'm dropping both.  Please resend the
patch properly, and only once.

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-11-28 Thread Dan Carpenter 
On Thu, Nov 27, 2014 at 05:42:06PM +0530, Athira Lekshmi C V wrote:
 C V is my initals . Can I just go with the name Athira Lekshmi ?
 

Sign it like you would sign a legal document.

In American, that's normally Firstname Lastname but if you normally sign a legal
document with C V on the end in India then probably C V is ok, it's just not
normal in America so we have to ask.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-11-28 Thread Athira Lekshmi C V 
Hello

I sign the documents as Athira Lekshmi.

Thanking You
Athira Lekshmi
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-11-28 Thread Athira Lekshmi C V 
   Hello

   I have resend the patch signing off as Athira Lekshmi.

   Thanking You
  Athira Lekshmi
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-11-28 Thread Athira Lekshmi 
Fixed the checkpatch warning:
Missing a blank line after declarations

Signed-off-by: Athira Lekshmi andnlnb...@gmail.com
---
 drivers/staging/octeon/ethernet-rx.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/octeon/ethernet-rx.c 
b/drivers/staging/octeon/ethernet-rx.c
index 44e372f..220106e 100644
--- a/drivers/staging/octeon/ethernet-rx.c
+++ b/drivers/staging/octeon/ethernet-rx.c
@@ -84,6 +84,7 @@ static int cvm_irq_cpu;
 static void cvm_oct_enable_napi(void *_)
 {
int cpu = smp_processor_id();
+
napi_schedule(cvm_oct_napi[cpu].napi);
 }
 
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-11-27 Thread Athira Lekshmi C V 
C V is my initals . Can I just go with the name Athira Lekshmi ?

Thanking You
Athira Lekshmi C V

On Thu, Nov 27, 2014 at 3:14 AM, Greg KH gre...@linuxfoundation.org wrote:
 On Wed, Nov 26, 2014 at 05:58:37PM +0530, Athira Lekshmi C V wrote:
 Fixed the checkpatch warning:
 WARNING: Missing a blank line after declarations

 Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com

 What is the C V at the end of the name here?  Is that your full
 name?  I need a real name, not initials.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-11-26 Thread Athira Lekshmi C V 
Fixed the checkpatch warning:
WARNING: Missing a blank line after declarations

Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com
---
 drivers/staging/octeon/ethernet-rx.c |5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/staging/octeon/ethernet-rx.c 
b/drivers/staging/octeon/ethernet-rx.c
index 44e372f..f80d509 100644
--- a/drivers/staging/octeon/ethernet-rx.c
+++ b/drivers/staging/octeon/ethernet-rx.c
@@ -84,6 +84,7 @@ static int cvm_irq_cpu;
 static void cvm_oct_enable_napi(void *_)
 {
int cpu = smp_processor_id();
+
napi_schedule(cvm_oct_napi[cpu].napi);
 }
 
@@ -169,6 +170,7 @@ static inline int cvm_oct_check_rcv_error(cvmx_wqe_t *work)
int interface = cvmx_helper_get_interface_num(work-ipprt);
int index = cvmx_helper_get_interface_index_num(work-ipprt);
union cvmx_gmxx_rxx_frm_ctl gmxx_rxx_frm_ctl;
+
gmxx_rxx_frm_ctl.u64 =
cvmx_read_csr(CVMX_GMXX_RXX_FRM_CTL(index, interface));
if (gmxx_rxx_frm_ctl.s.pre_chk == 0) {
@@ -272,6 +274,7 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int 
budget)
did_work_request = 0;
if (work == NULL) {
union cvmx_pow_wq_int wq_int;
+
wq_int.u64 = 0;
wq_int.s.iq_dis = 1  pow_receive_group;
wq_int.s.wq_int = 1  pow_receive_group;
@@ -294,8 +297,10 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int 
budget)
 * CPU.
 */
union cvmx_pow_wq_int_cntx counts;
+
int backlog;
int cores_in_use = core_state.baseline_cores - 
atomic_read(core_state.available_cores);
+
counts.u64 = 
cvmx_read_csr(CVMX_POW_WQ_INT_CNTX(pow_receive_group));
backlog = counts.s.iq_cnt + counts.s.ds_cnt;
if (backlog  budget * cores_in_use  napi != NULL)
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-11-26 Thread Dan Carpenter 
On Wed, Nov 26, 2014 at 05:17:48PM +0530, Athira Lekshmi C V wrote:
 @@ -294,8 +297,10 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, 
 int budget)
* CPU.
*/
   union cvmx_pow_wq_int_cntx counts;
 +

Don't put a blank here.

   int backlog;
   int cores_in_use = core_state.baseline_cores - 
 atomic_read(core_state.available_cores);
 +
   counts.u64 = 
 cvmx_read_csr(CVMX_POW_WQ_INT_CNTX(pow_receive_group));
   backlog = counts.s.iq_cnt + counts.s.ds_cnt;

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-11-26 Thread Athira Lekshmi C V 
Fixed the checkpatch warning:
WARNING: Missing a blank line after declarations

Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com
---
 drivers/staging/octeon/ethernet-rx.c |2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/octeon/ethernet-rx.c 
b/drivers/staging/octeon/ethernet-rx.c
index 44e372f..a7ff01c 100644
--- a/drivers/staging/octeon/ethernet-rx.c
+++ b/drivers/staging/octeon/ethernet-rx.c
@@ -84,6 +84,7 @@ static int cvm_irq_cpu;
 static void cvm_oct_enable_napi(void *_)
 {
int cpu = smp_processor_id();
+
napi_schedule(cvm_oct_napi[cpu].napi);
 }
 
@@ -296,6 +297,7 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int 
budget)
union cvmx_pow_wq_int_cntx counts;
int backlog;
int cores_in_use = core_state.baseline_cores - 
atomic_read(core_state.available_cores);
+
counts.u64 = 
cvmx_read_csr(CVMX_POW_WQ_INT_CNTX(pow_receive_group));
backlog = counts.s.iq_cnt + counts.s.ds_cnt;
if (backlog  budget * cores_in_use  napi != NULL)
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-11-26 Thread Greg KH 
On Wed, Nov 26, 2014 at 05:58:37PM +0530, Athira Lekshmi C V wrote:
 Fixed the checkpatch warning:
 WARNING: Missing a blank line after declarations
 
 Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com

What is the C V at the end of the name here?  Is that your full
name?  I need a real name, not initials.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel