Re: [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get

2019-04-30 Thread Mark Greer
On Fri, Mar 15, 2019 at 10:49:46AM +0530, Vaibhav Agarwal wrote: > On Thu, Mar 14, 2019 at 12:15 PM Kangjie Lu wrote: > > > > ida_simple_get could fail. The fix inserts a check for its > > return value. > > > > Signed-off-by: Kangjie Lu > > --- > > drivers/staging/greybus/audio_manager.c | 3

Re: [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get

2019-03-14 Thread Vaibhav Agarwal
On Thu, Mar 14, 2019 at 12:15 PM Kangjie Lu wrote: > > ida_simple_get could fail. The fix inserts a check for its > return value. > > Signed-off-by: Kangjie Lu > --- > drivers/staging/greybus/audio_manager.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [greybus-dev] [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get

2019-03-14 Thread Viresh Kumar
On 14-03-19, 01:45, Kangjie Lu wrote: > ida_simple_get could fail. The fix inserts a check for its > return value. > > Signed-off-by: Kangjie Lu > --- > drivers/staging/greybus/audio_manager.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/greybus/audio_manager.c

[PATCH] greybus: audio_manager: fix a missing check of ida_simple_get

2019-03-14 Thread Kangjie Lu
ida_simple_get could fail. The fix inserts a check for its return value. Signed-off-by: Kangjie Lu --- drivers/staging/greybus/audio_manager.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c index