Re: [PATCH] ion: hisilicon: check the right value after ion_heap_create

2017-05-05 Thread Laura Abbott
On 05/04/2017 08:32 PM, Yisheng Xie wrote: > Hi Laura, > > On 2017/5/5 1:47, Laura Abbott wrote: >> On 05/04/2017 07:45 AM, Yisheng Xie wrote: >>> From: Yisheng Xie >>> >>> It should check ipdev->heaps[i] whether it is error or null instead of >>> ipdev->heaps, after

Re: [PATCH] ion: hisilicon: check the right value after ion_heap_create

2017-05-04 Thread Yisheng Xie
Hi Laura, On 2017/5/5 1:47, Laura Abbott wrote: > On 05/04/2017 07:45 AM, Yisheng Xie wrote: >> From: Yisheng Xie >> >> It should check ipdev->heaps[i] whether it is error or null instead of >> ipdev->heaps, after ion_heap_create() for ipdev->heaps[i]. >> >>

Re: [PATCH] ion: hisilicon: check the right value after ion_heap_create

2017-05-04 Thread Laura Abbott
On 05/04/2017 07:45 AM, Yisheng Xie wrote: > From: Yisheng Xie > > It should check ipdev->heaps[i] whether it is error or null instead of > ipdev->heaps, after ion_heap_create() for ipdev->heaps[i]. > > Signed-off-by: Yisheng Xie > --- >

[PATCH] ion: hisilicon: check the right value after ion_heap_create

2017-05-04 Thread Yisheng Xie
From: Yisheng Xie It should check ipdev->heaps[i] whether it is error or null instead of ipdev->heaps, after ion_heap_create() for ipdev->heaps[i]. Signed-off-by: Yisheng Xie --- drivers/staging/android/ion/hisilicon/hi6220_ion.c | 2 +- 1 file