RE: [PATCH] media: staging: ipu3: Fix stale list entries on parameter queue failure

2020-04-12 Thread Cao, Bingbu
Greg Kroah-Hartman ; Qiu, > Tian Shu ; Cao, Bingbu ; > de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; Laurent Pinchart > ; jacopo mondi ; > Tomasz Figa > Subject: [PATCH] media: staging: ipu3: Fix stale list entries on parameter > queue failure > > When queuin

Re: [PATCH] media: staging: ipu3: Fix stale list entries on parameter queue failure

2020-04-12 Thread Laurent Pinchart
Hi Tomasz, Thank you for the patch. On Sat, Apr 11, 2020 at 05:37:10PM +, Tomasz Figa wrote: > When queuing parameters fails, current code bails out without deleting > the corresponding vb2 buffer from the driver buffer list, but the buffer > is returned to vb2. This leads to stale list

[PATCH] media: staging: ipu3: Fix stale list entries on parameter queue failure

2020-04-11 Thread Tomasz Figa
When queuing parameters fails, current code bails out without deleting the corresponding vb2 buffer from the driver buffer list, but the buffer is returned to vb2. This leads to stale list entries and a crash when the driver stops streaming: [ 224.935561] ipu3-imgu :00:05.0: set parameters