Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-12-06 Thread Stephen Hemminger
> Cc: KY Srinivasan <k...@microsoft.com>; Haiyang Zhang > > <haiya...@microsoft.com>; Bjorn Helgaas <bhelg...@google.com>; > > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; linux- > > p...@vger.kernel.org > > Subject: Re: [PATCH] pci-hyperv: use k

RE: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-12-05 Thread Long Li
Helgaas <bhelg...@google.com>; > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; linux- > p...@vger.kernel.org > Subject: Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params > buffer > > On Tue, 8 Nov 2016 14:04:38 -0800 > Long Li <

RE: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-12-05 Thread Long Li
To: Bjorn Helgaas <helg...@kernel.org>; Long Li <lon...@microsoft.com> > > Cc: de...@linuxdriverproject.org > > Subject: Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall > > params buffer > > > > Hi, > > > > Is the double semicolon a typo? &g

RE: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-12-05 Thread KY Srinivasan
ject.org > Subject: Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params > buffer > > Hi, > > Is the double semicolon a typo? Yes; it is a typo. K. Y > > Thanks, > > Cathy > > diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyp

Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-12-05 Thread Stephen Hemminger
On Tue, 8 Nov 2016 14:04:38 -0800 Long Li wrote: > + spin_lock_irqsave(>retarget_msi_interrupt_lock, flags); > + > + params = >retarget_msi_interrupt_params; > + memset(params, 0, sizeof(*params)); > + params->partition_id = HV_PARTITION_ID_SELF; >

Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-12-05 Thread Cathy Avery
Hi, Is the double semicolon a typo? Thanks, Cathy diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c index 763ff87..ca553df 100644 --- a/drivers/pci/host/pci-hyperv.c +++ b/drivers/pci/host/pci-hyperv.c @@ -378,6 +378,8 @@ struct hv_pcibus_device { struct

Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-29 Thread Bjorn Helgaas
On Tue, Nov 08, 2016 at 02:04:38PM -0800, Long Li wrote: > From: Long Li > > hv_do_hypercall assumes that we pass a segment from a physically > continuous buffer. Buffer allocated on the stack may not work if > CONFIG_VMAP_STACK=y is set. > > Change to use kmalloc to

RE: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-23 Thread KY Srinivasan
Helgaas <bhelg...@google.com>; > de...@linuxdriverproject.org; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; Long Li <lon...@microsoft.com> > Subject: Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params > buffer > > On Tue, Nov 08, 2016 at 02:04:

Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-23 Thread Bjorn Helgaas
On Tue, Nov 08, 2016 at 02:04:38PM -0800, Long Li wrote: > From: Long Li > > hv_do_hypercall assumes that we pass a segment from a physically > continuous buffer. Buffer allocated on the stack may not work if > CONFIG_VMAP_STACK=y is set. > > Change to use kmalloc to

RE: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-08 Thread Long Li
microsoft.com>; > linux-ker...@vger.kernel.org; Bjorn Helgaas <bhelg...@google.com>; > de...@linuxdriverproject.org > Subject: RE: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall > params buffer > > This sender failed our fraud detection checks and may not be

[PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-08 Thread Long Li
From: Long Li hv_do_hypercall assumes that we pass a segment from a physically continuous buffer. Buffer allocated on the stack may not work if CONFIG_VMAP_STACK=y is set. Change to use kmalloc to allocate this buffer. The v2 patch adds locking to access the pre-allocated

RE: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-08 Thread KY Srinivasan
> de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; linux- > p...@vger.kernel.org > Subject: RE: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall > params buffer > > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfound

RE: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-08 Thread Long Li
Helgaas <bhelg...@google.com>; > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; linux- > p...@vger.kernel.org > Subject: Re: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall > params buffer > > On Tue, Nov 08, 2016 at 12:14:14AM -0800, Long Li wrote: >

Re: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-07 Thread Greg KH
On Tue, Nov 08, 2016 at 12:14:14AM -0800, Long Li wrote: > From: Long Li > > hv_do_hypercall assumes that we pass a segment from a physically continuous > buffer. Buffer allocated on the stack may not work if CONFIG_VMAP_STACK=y is > set. Use kmalloc to allocate this

[Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

2016-11-07 Thread Long Li
From: Long Li hv_do_hypercall assumes that we pass a segment from a physically continuous buffer. Buffer allocated on the stack may not work if CONFIG_VMAP_STACK=y is set. Use kmalloc to allocate this buffer. Signed-off-by: Long Li Reported-by: