Re: [PATCH] staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c

2014-10-08 Thread Greg KH 
On Tue, Sep 30, 2014 at 10:56:17PM +0530, Karthik Nayak wrote:
 1. WARNING: else is not generally useful after a break or return
 
 2. WARNING: quoted string split across lines
 
 3. WARNING: break quoted strings at a space character
 
 Signed-off-by: Karthik Nayak karthik@gmail.com
 ---
  drivers/staging/bcm/InterfaceIdleMode.c | 11 +--
  1 file changed, 5 insertions(+), 6 deletions(-)

Doesn't apply to my tree :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c

2014-09-30 Thread Karthik Nayak 
1. WARNING: else is not generally useful after a break or return

2. WARNING: quoted string split across lines

3. WARNING: break quoted strings at a space character

Signed-off-by: Karthik Nayak karthik@gmail.com
---
 drivers/staging/bcm/InterfaceIdleMode.c | 11 +--
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/bcm/InterfaceIdleMode.c 
b/drivers/staging/bcm/InterfaceIdleMode.c
index c84ee49..9a77a98 100644
--- a/drivers/staging/bcm/InterfaceIdleMode.c
+++ b/drivers/staging/bcm/InterfaceIdleMode.c
@@ -188,10 +188,9 @@ static int InterfaceAbortIdlemode(struct bcm_mini_adapter 
*Adapter,
5000);
if (status)
return status;
-   else
-   BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS,
-   IDLE_MODE, DBG_LVL_ALL,
-   NOB Sent down :%d, lenwritten);
+   BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS,
+   IDLE_MODE, DBG_LVL_ALL,
+   NOB Sent down :%d, lenwritten);
 
/* mdelay(25); */
 
@@ -211,8 +210,8 @@ static int InterfaceAbortIdlemode(struct bcm_mini_adapter 
*Adapter,
else
BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS,
IDLE_MODE, DBG_LVL_ALL,
-   Number of completed iteration to
-   read chip-id :%lu, itr);
+   Number of completed iteration to read chip-id 
:%lu,
+   itr);
 
status = wrmalt(Adapter, SW_ABORT_IDLEMODE_LOC,
Pattern, sizeof(status));
-- 
2.1.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c

2014-09-30 Thread Mark Einon 
On Tue, Sep 30, 2014 at 10:56:17PM +0530, Karthik Nayak wrote:
 1. WARNING: else is not generally useful after a break or return
 
 2. WARNING: quoted string split across lines
 
 3. WARNING: break quoted strings at a space character
 
 Signed-off-by: Karthik Nayak karthik@gmail.com
 ---

Hi again,

You probably wanted to send this patch to the maintainer of this driver,
instead of me. I suggest you re-run scripts/getmaintainer.pl on the patch.

Cheers,

Mark
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel