Re: [PATCH] staging: bcm2835: fix vchiq_mmal dependencies

2020-12-04 Thread Jacopo Mondi
Hi Arnd, On Fri, Dec 04, 2020 at 01:49:39PM +0100, Arnd Bergmann wrote: > On Fri, Dec 4, 2020 at 11:44 AM Jacopo Mondi wrote: > > > > Hi Arnd, > > > > On Thu, Dec 03, 2020 at 11:38:30PM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > When the MMAL code is built-in but the

Re: [PATCH] staging: bcm2835: fix vchiq_mmal dependencies

2020-12-04 Thread Arnd Bergmann
On Fri, Dec 4, 2020 at 11:44 AM Jacopo Mondi wrote: > > Hi Arnd, > > On Thu, Dec 03, 2020 at 11:38:30PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When the MMAL code is built-in but the vchiq core config is > > set to =m, the mmal code never gets built, which in turn can > >

Re: [PATCH] staging: bcm2835: fix vchiq_mmal dependencies

2020-12-04 Thread Jacopo Mondi
Hi Arnd, On Thu, Dec 03, 2020 at 11:38:30PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When the MMAL code is built-in but the vchiq core config is > set to =m, the mmal code never gets built, which in turn can > lead to link errors: My bad, I repetedly ignored the error report

[PATCH] staging: bcm2835: fix vchiq_mmal dependencies

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann When the MMAL code is built-in but the vchiq core config is set to =m, the mmal code never gets built, which in turn can lead to link errors: ERROR: modpost: "vchiq_mmal_port_set_format" [drivers/staging/vc04_services/bcm2835-camera/bcm2835-v4l2.ko] undefined! ERROR: