Re: [PATCH] staging: bcm2835-camera: Restore return behavior of ctrl_set_bitrate()

2019-06-27 Thread Peter Robinson
> Dave > > PS Is linux-rpi-kernel actually behaving for other people? I didn't > see this patch when it was submitted, and it isn't showing in the list > archive either. No, but it never really has for me, it's always been weird in what it allows through by default and the admin has to approve

Re: [PATCH] staging: bcm2835-camera: Restore return behavior of ctrl_set_bitrate()

2019-06-26 Thread Dave Stevenson
Hi Stefan. On Tue, 25 Jun 2019 at 17:30, Stefan Wahren wrote: > > Hi Dan, > hi Dave, > > Am 25.06.19 um 09:55 schrieb Dan Carpenter: > > On Tue, Jun 25, 2019 at 12:13:15AM +0200, Stefan Wahren wrote: > >> The commit 52c4dfcead49 ("Staging: vc04_services: Cleanup in > >> ctrl_set_bitrate()")

Re: [PATCH] staging: bcm2835-camera: Restore return behavior of ctrl_set_bitrate()

2019-06-25 Thread Stefan Wahren
Hi Dan, hi Dave, Am 25.06.19 um 09:55 schrieb Dan Carpenter: > On Tue, Jun 25, 2019 at 12:13:15AM +0200, Stefan Wahren wrote: >> The commit 52c4dfcead49 ("Staging: vc04_services: Cleanup in >> ctrl_set_bitrate()") changed the return behavior of ctrl_set_bitrate(). >> This breaks probing of

Re: [PATCH] staging: bcm2835-camera: Restore return behavior of ctrl_set_bitrate()

2019-06-25 Thread Dan Carpenter
On Tue, Jun 25, 2019 at 12:13:15AM +0200, Stefan Wahren wrote: > The commit 52c4dfcead49 ("Staging: vc04_services: Cleanup in > ctrl_set_bitrate()") changed the return behavior of ctrl_set_bitrate(). > This breaks probing of bcm2835-camera: > > bcm2835-v4l2: mmal_init: failed to set all

Re: [PATCH] staging: bcm2835-camera: Restore return behavior of ctrl_set_bitrate()

2019-06-25 Thread Peter Robinson
On Mon, Jun 24, 2019 at 11:13 PM Stefan Wahren wrote: > > The commit 52c4dfcead49 ("Staging: vc04_services: Cleanup in > ctrl_set_bitrate()") changed the return behavior of ctrl_set_bitrate(). > This breaks probing of bcm2835-camera: > > bcm2835-v4l2: mmal_init: failed to set all camera

[PATCH] staging: bcm2835-camera: Restore return behavior of ctrl_set_bitrate()

2019-06-24 Thread Stefan Wahren
The commit 52c4dfcead49 ("Staging: vc04_services: Cleanup in ctrl_set_bitrate()") changed the return behavior of ctrl_set_bitrate(). This breaks probing of bcm2835-camera: bcm2835-v4l2: mmal_init: failed to set all camera controls: -3 Cleanup: Destroy video encoder Cleanup: Destroy