Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-21 Thread Mark Hounschell
On 10/14/2014 08:01 AM, Mark Hounschell wrote: On 10/13/2014 10:04 PM, Greg KH wrote: On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote: On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: Hi, 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Mon, Oct 13, 2014

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-14 Thread DaeSeok Youn
Hi, 2014-10-14 11:19 GMT+09:00 Joe Perches j...@perches.com: On Tue, 2014-10-14 at 04:04 +0200, Greg KH wrote: On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote: On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org:

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-14 Thread Mark Hounschell
On 10/13/2014 10:04 PM, Greg KH wrote: On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote: On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: Hi, 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-14 Thread Dan Carpenter
On Mon, Oct 13, 2014 at 07:19:38PM -0700, Joe Perches wrote: I don't know of a way to compare objects when functions are rearranged in the source file. Anyone else? I have a perl script that I use to review function movement. It barfed on the DaeSeok's original patch so I re-wrote it, but

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-13 Thread DaeSeok Youn
Hi, 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: Re-arrange the functions for removing forward declarations. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- This patch has too many changes for

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-13 Thread Joe Perches
On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: Hi, 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: Re-arrange the functions for removing forward declarations. Signed-off-by: Daeseok Youn

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-13 Thread DaeSeok Youn
Hi, 2014-10-13 23:56 GMT+09:00 Joe Perches j...@perches.com: On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: Hi, 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: Re-arrange the functions for removing

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-13 Thread Greg KH
On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote: On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: Hi, 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: Re-arrange the functions for removing

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-13 Thread Joe Perches
On Tue, 2014-10-14 at 04:04 +0200, Greg KH wrote: On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote: On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-12 Thread Greg KH
On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: Re-arrange the functions for removing forward declarations. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- This patch has too many changes for re-arranging the functions. So I wonder that I should break this up into