Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

2019-05-23 Thread Greg KH
On Thu, May 23, 2019 at 09:02:11AM -0400, Sven Van Asbroeck wrote: > On Thu, May 23, 2019 at 5:09 AM Dan Carpenter > wrote: > > > > Sven, you should add yourself to the MAINTAINERS file. > > Greg, what do you think? Yes! ___ devel mailing list

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

2019-05-23 Thread Sven Van Asbroeck
On Thu, May 23, 2019 at 5:09 AM Dan Carpenter wrote: > > Sven, you should add yourself to the MAINTAINERS file. Greg, what do you think? ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

2019-05-23 Thread Dan Carpenter
On Thu, May 23, 2019 at 09:27:02AM +0100, Jeremy Sowden wrote: > On 2019-05-23, at 13:51:18 +0530, Nishka Dasgupta wrote: > > On 23/05/19 12:52 PM, Greg KH wrote: > > > On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote: > > > Also, you forgot to cc: Sven on this patch, please always

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

2019-05-23 Thread Nishka Dasgupta
On 23/05/19 1:57 PM, Jeremy Sowden wrote: On 2019-05-23, at 13:51:18 +0530, Nishka Dasgupta wrote: On 23/05/19 12:52 PM, Greg KH wrote: On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote: In the functions export_reset_0 and export_reset_1 in arcx-anybus.c, the only operation

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

2019-05-23 Thread Greg KH
On Thu, May 23, 2019 at 01:51:18PM +0530, Nishka Dasgupta wrote: > > > On 23/05/19 12:52 PM, Greg KH wrote: > > On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote: > > > In the functions export_reset_0 and export_reset_1 in arcx-anybus.c, > > > the only operation performed before

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

2019-05-23 Thread Jeremy Sowden
On 2019-05-23, at 13:51:18 +0530, Nishka Dasgupta wrote: > On 23/05/19 12:52 PM, Greg KH wrote: > > On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote: > > > In the functions export_reset_0 and export_reset_1 in > > > arcx-anybus.c, the only operation performed before return is > > >

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

2019-05-23 Thread Nishka Dasgupta
On 23/05/19 12:52 PM, Greg KH wrote: On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote: In the functions export_reset_0 and export_reset_1 in arcx-anybus.c, the only operation performed before return is passing the variable cd (which takes the value of a function call on one of

Re: [PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

2019-05-23 Thread Greg KH
On Thu, May 23, 2019 at 12:05:01PM +0530, Nishka Dasgupta wrote: > In the functions export_reset_0 and export_reset_1 in arcx-anybus.c, > the only operation performed before return is passing the variable cd > (which takes the value of a function call on one of the parameters) as > argument to

[PATCH] staging: fieldbus: anybuss: Remove unnecessary variables

2019-05-23 Thread Nishka Dasgupta
In the functions export_reset_0 and export_reset_1 in arcx-anybus.c, the only operation performed before return is passing the variable cd (which takes the value of a function call on one of the parameters) as argument to another function. Hence the variable cd can be removed. Issue found using