On Sat, Jan 17, 2015 at 03:29:01PM -0800, Greg KH wrote:
On Sat, Dec 13, 2014 at 03:58:46PM +0100, Loïc Pefferkorn wrote:
Don't hide implementation of locks in functions like this, it only
causes problems. This code has layers of layers of layers of
abstractions due to it wanting to
On Sat, Dec 13, 2014 at 03:58:46PM +0100, Loïc Pefferkorn wrote:
Don't hide implementation of locks in functions like this, it only
causes problems. This code has layers of layers of layers of
abstractions due to it wanting to be originally ported to other
operating systems and lots
Don't hide implementation of locks in functions like this, it only
causes problems. This code has layers of layers of layers of
abstractions due to it wanting to be originally ported to other
operating systems and lots of different kernel versions of Linux itself.
Unwinding and removing
On Tue, Dec 02, 2014 at 02:11:33PM -0700, Andreas Dilger wrote:
On Nov 28, 2014, at 11:50 AM, Greg KH gre...@linuxfoundation.org wrote:
On Thu, Nov 27, 2014 at 07:34:10PM +0100, Loïc Pefferkorn wrote:
Hello Greg,
After some investigation, I think that removing these wrappers is not
On Dec 7, 2014, at 4:57 AM, Loïc Pefferkorn l...@loicp.eu wrote:
On Tue, Dec 02, 2014 at 02:11:33PM -0700, Andreas Dilger wrote:
On Nov 28, 2014, at 11:50 AM, Greg KH gre...@linuxfoundation.org wrote:
On Thu, Nov 27, 2014 at 07:34:10PM +0100, Loïc Pefferkorn wrote:
Hello Greg,
After some
On Nov 28, 2014, at 11:50 AM, Greg KH gre...@linuxfoundation.org wrote:
On Thu, Nov 27, 2014 at 07:34:10PM +0100, Loïc Pefferkorn wrote:
Hello Greg,
After some investigation, I think that removing these wrappers is not going
to improve the code readability:
On Wed, Nov 26, 2014 at
: [HPDD-discuss] [PATCH] staging: lustre: fix sparse warnings
related to lock context imbalance
On Thu, Nov 27, 2014 at 07:34:10PM +0100, Loïc Pefferkorn wrote:
1827 if (valid != 0) {
1828 cl_object_attr_lock(obj);
1829 cl_object_attr_set(env, obj, attr, valid);
1830
On Fri, Nov 28, 2014 at 03:45:24PM +, Patrick Farrell wrote:
Dan,
I disagree about the change suggested here. In this particular code,
'object_attr' is distinct from 'attr', as in a 'setattr' call on an
inode. 'cl_object' is a distinct thing from an inode/file on disk,
and specifying
On Thu, Nov 27, 2014 at 07:34:10PM +0100, Loïc Pefferkorn wrote:
Hello Greg,
After some investigation, I think that removing these wrappers is not going
to improve the code readability:
On Wed, Nov 26, 2014 at 12:54:43PM -0800, Greg KH wrote:
On Wed, Nov 26, 2014 at 05:15:48PM +0100,
Add __acquires() and __releases() function annotations, to fix sparse warnings
related to lock context imbalance.
This fixes the following warnings:
drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c:153:5: warning:
context imbalance in 'cfs_trace_lock_tcd' - wrong count at exit
On Wed, Nov 26, 2014 at 05:15:48PM +0100, Loic Pefferkorn wrote:
Add __acquires() and __releases() function annotations, to fix sparse
warnings related to lock context imbalance.
This fixes the following warnings:
drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c:153:5:
On Wed, Nov 26, 2014 at 12:54:43PM -0800, Greg KH wrote:
Ugh, how horrid, please just delete these functions and push down the
spin_lock/unlock calls down into the places these are called.
Same for these.
Same thing here.
Hello Greg,
Thanks for your comments, I will write a v2.
--
12 matches
Mail list logo
